Skip to content

fix(design-v2): keep the Text step editor usable at mobile widths - #1146

Open
saurav-shakya wants to merge 1 commit into
accordproject:mainfrom
saurav-shakya:ccr-c0802b54-6z5oem
Open

saurav-shakya wants to merge 1 commit into
accordproject:mainfrom
saurav-shakya:ccr-c0802b54-6z5oem

Conversation

@saurav-shakya

Copy link
Copy Markdown

Closes #1145

At phone widths the Text step editor shrank to about 5px, so the template could not be read or edited. This gives the Text step the same stacked-layout treatment the Logic step got in #1104.

Changes

  • DesignV2Layout.css: inside the existing @media (max-width: 960px) block, let the body scroll on the Text step and give its editor a height of its own (clamp(260px, 45vh, 380px)). Scoped to .nd-view-text. Nothing changes above 960px.
  • e2e/design-v2-mobile.spec.ts: opens the Text step at 390×844 and checks that the editor is at least 200px tall. It fails without the CSS change (received 5px) and passes with it.
Viewport Before After
390×844 5px 379px
844×390 (landscape) n/a 260px
768×1024 313px 380px
1366×850 459px 459px (unchanged)

Flags

  • The Data step is also cramped at mobile widths. I left it out to keep this PR to one bug, and will open a separate issue for it.
  • In landscape on a phone the editor (260px) takes most of the visible area. The help rail is still reachable by scrolling the page, the same as on the Logic step.

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Under 960px the editor column and the help rail stack, and the Text
step's editor card shrank to about 5px on a 390px-wide phone, so the
template could not be read or edited. Give it the same treatment the
Logic step got in accordproject#1104: let the body scroll and give the editor a
height of its own (clamp(260px, 45vh, 380px)).

Add an e2e test that opens the Text step at 390x844 and checks the
editor height; it fails without this change.

Signed-off-by: Saurav Shakya <sauravshakya1221244072@gmail.com>
@saurav-shakya
saurav-shakya requested review from a team and TheCelestial25 as code owners November 22, 2026 06:46
Copilot AI balanced review requested due to automatic review settings November 22, 2026 06:46
@netlify

netlify Bot commented Nov 22, 2026

Copy link
Copy Markdown

👷 Deploy request for ap-template-playground pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b911af8

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@mira-accord-project

Copy link
Copy Markdown

Thank you for your first contribution to Template Playground, and for the clear before and after measurements in the description. The change is small and well scoped, and the new e2e test makes the regression easy to see. The PR is now with the playground maintainers for review, and we will reply on this thread once the review is done. The CI checks for this fork's first run are being approved so they can start. If you have questions in the meantime, please ask here.


Posted automatically by Mira, an Accord Project agent. A maintainer will follow up; they make the decisions on this.

@mira-accord-project mira-accord-project Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, saurav-shakya, and for the clear before and after measurements. The CSS is small and scoped to .nd-view-text inside the existing max-width: 960px block, so nothing changes on wider screens. It follows the same approach as the Logic step. The new Playwright spec opens the Text step at 390×844 and checks the editor height, so it would catch this regression again. The class names the CSS targets all exist in TextView.tsx. CI is green. I found nothing that needs changing, so this is ready once a maintainer approves it.

No problems found.


Automated review by Mira, an Accord Project agent, at b911af8. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design V2] Text step editor collapses to a few pixels at mobile widths

2 participants