Enable windows changes for arm 9

Author: Vignesh-qcom

.github/workflows/cmake-windows.yml

@@ -1,14 +1,17 @@
-name: CMake Windows
+name: CMake
 
-on:
-  - push
-  - pull_request
+on: [push, pull_request]
 
 env:
+  # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
   BUILD_TYPE: Release
 
 jobs:
   build:
+    # The CMake configure and build commands are platform agnostic and should work equally
+    # well on Windows or Mac.  You can convert this to a matrix build if you need
+    # cross-platform coverage.
+    # See: https://docs.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow#configuring-a-build-matrix
     strategy:
       matrix:
         include:
@@ -25,31 +28,27 @@ jobs:
     runs-on: ${{ matrix.runner }}
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v2
 
       - name: Run vcpkg for ${{ matrix.arch }}
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgArguments: >
-            getopt:${{ matrix.vcpkg_triplet }}
-            libiconv:${{ matrix.vcpkg_triplet }}
-            libpng:${{ matrix.vcpkg_triplet }}
-            zlib:${{ matrix.vcpkg_triplet }}
-          vcpkgGitCommitId: 'cd61e1e26a038e82d6550a3ebbe0fbbfe7da78e3'
-
-      - name: Show vcpkg environment
-        shell: bash
-        run: |
-          echo "VCPKG_ROOT=$VCPKG_ROOT"
-          "$VCPKG_ROOT/vcpkg" list
+          vcpkgGitCommitId: cd61e1e26a038e82d6550a3ebbe0fbbfe7da78e3
+          vcpkgJsonGlob: '**/vcpkg.json'
 
       - name: Create Build Environment
+      # Some projects don't allow in-source building, so create a separate build directory
+      # We'll use this as our working directory for all subsequent commands
         run: cmake -E make_directory ${{ runner.workspace }}/build-${{ matrix.arch }}
 
       - name: Configure CMake for ${{ matrix.arch }}
+      # Use a bash shell so we can use the same syntax for environment variable
+      # access regardless of the host operating system
         shell: bash
         working-directory: ${{ runner.workspace }}/build-${{ matrix.arch }}
+      # Note the current convention is to use the -S and -B options here to specify source 
+      # and build directories, but this is only available with CMake 3.13 and higher.  
+      # The CMake binaries on the Github Actions machines are (as of this writing) 3.12
         run: |
           cmake "$GITHUB_WORKSPACE" \
             -A ${{ matrix.cmake_platform }} \
@@ -62,11 +61,12 @@ jobs:
       - name: Build for ${{ matrix.arch }}
         shell: bash
         working-directory: ${{ runner.workspace }}/build-${{ matrix.arch }}
-        run: |
-          cmake --build . --config $BUILD_TYPE
+      # Execute the build.  You can specify a specific target with "--target <NAME>"
+        run: cmake --build . --config $BUILD_TYPE
 
       - name: Test for ${{ matrix.arch }}
         shell: bash
         working-directory: ${{ runner.workspace }}/build-${{ matrix.arch }}
-        run: |
-          ctest -C $BUILD_TYPE --output-on-failure
+      # Execute tests defined by the CMake configuration.  
+      # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
+        run: ctest -C $BUILD_TYPE --output-on-failure