Skip to content

Commit 6dcdf80

Browse files
chore(PLT-3524): remove orphaned SonarCloud coverage plumbing
Removes coverage steps left behind after PR #165 removed the `sonarcloud` job that consumed them: - Dropped `--coverage` flags from test runs - Removed "Merge coverage reports and generate lcov.info" step - Removed "Upload coverage file" step (artifact had zero consumers) - Cleaned up stale "coverage file uploaded" comment The coverage merge/upload steps existed solely to feed the SonarCloud scan, which #165 correctly removed. With nothing consuming the coverage-report artifact, the plumbing is dead weight. Part of the PLT-3524 SonarCloud decommission. Generated by Glean Code Writer
1 parent 1139e80 commit 6dcdf80

1 file changed

Lines changed: 3 additions & 16 deletions

File tree

‎.github/workflows/pr.yml‎

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
matrix:
1313
node_version:
14-
- 24 # end of life 2028-04-30 # coverage file uploaded from this version
14+
- 24 # end of life 2028-04-30
1515
name: build-lint-test - node ${{ matrix.node_version }}
1616
steps:
1717
- name: Check out Git repository
@@ -43,21 +43,8 @@ jobs:
4343
run: yarn lint
4444

4545
- name: Unit tests
46-
run: yarn test:unit --coverage
46+
run: yarn test:unit
4747

4848
- name: Integration tests
49-
run: (yarn server &) && sleep 1 && yarn test:integration --coverage
50-
51-
- name: Merge coverage reports and generate lcov.info
52-
run: |
53-
mkdir -p .nyc_output
54-
npx nyc merge ./coverage
55-
npx nyc report --reporter=lcov --temp-dir ./coverage
56-
57-
- name: Upload coverage file
58-
uses: actions/upload-artifact@v7
59-
with:
60-
name: coverage-report
61-
path: ./coverage/lcov.info
62-
retention-days: 1
49+
run: (yarn server &) && sleep 1 && yarn test:integration
6350

0 commit comments

Comments
 (0)