express: small perf (#10594)

Author: nigrosimone

frameworks/JavaScript/express/helper.js

@@ -1,20 +1,10 @@
 module.exports = {
 
     sanititizeTotal : (total) => {
-        let totalIterations;
-        if (!total || typeof(total) != 'number') {
-            totalIterations = 1;
-        } else if(total < 501 && total > 0) {
-            totalIterations = total;
-        } else if (total > 500) {
-            totalIterations = 500;
-        } else {
-            totalIterations = 1;
-        }
-        return totalIterations;
+        return total > 500 ? 500 : (i | 0) || 1;
     },
 
     randomizeNum : () => {
-        return Math.floor(Math.random() * 10000) + 1
+        return ((Math.random() * 10000) | 0) + 1;
     }
 }

frameworks/JavaScript/express/mongodb-app.js

@@ -103,10 +103,10 @@ if (cluster.isPrimary) {
 
   app.get('/mongoose-update', async (req, res) => {
     const queryCount = Math.min(parseInt(req.query.queries, 10) || 1, 500);
-    const promises = [];
+    const promises = new Array(queryCount);
 
     for (let i = 1; i <= queryCount; i++) {
-      promises.push(getUpdateRandomWorld());
+      promises[i - 1] = getUpdateRandomWorld();
     }
 
     res.setHeader("Server", "Express");

frameworks/JavaScript/express/mysql-app.js

@@ -64,8 +64,9 @@ if (cluster.isPrimary) {
 
   // Routes
   app.get('/mysql-orm-query', async (req, res) => {
-    const results = [],
-      queries = Math.min(parseInt(req.query.queries) || 1, 500);
+   
+    const queries = Math.min(parseInt(req.query.queries) || 1, 500);
+    const results = new Array(queries);
 
     for (let i = 1; i <= queries; i++) {
       const world = await World.findOne({
@@ -74,7 +75,7 @@ if (cluster.isPrimary) {
         }
       }
       );
-      results.push(world);
+      results[i - 1] = world;
     }
 
     res.setHeader("Content-Type", "application/json");
@@ -95,20 +96,19 @@ if (cluster.isPrimary) {
     res.send(world)
   });
 
-  app.get('/mysql-orm-fortune', (req, res) => {
-    Fortune.findAll().then((fortunes) => {
-      const newFortune = { id: 0, message: "Additional fortune added at request time." };
-      fortunes.push(newFortune);
-      fortunes.sort((a, b) => (a.message < b.message) ? -1 : 1);
+  app.get('/mysql-orm-fortune', async(req, res) => {
+    const fortunes = await Fortune.findAll()
+    const newFortune = { id: 0, message: "Additional fortune added at request time." };
+    fortunes.push(newFortune);
+    fortunes.sort((a, b) => (a.message < b.message) ? -1 : 1);
 
-      res.setHeader("Server", "Express");
-      res.render('fortunes/index', { fortunes: fortunes });
-    });
+    res.setHeader("Server", "Express");
+    res.render('fortunes/index', { fortunes: fortunes });
   });
 
   app.get('/mysql-orm-update', async (req, res) => {
-    const results = [],
-      queries = Math.min(parseInt(req.query.queries) || 1, 500);
+    const queries = Math.min(parseInt(req.query.queries) || 1, 500);
+    const results = new Array(queries);
 
     for (let i = 1; i <= queries; i++) {
       const world = await World.findOne({
@@ -119,7 +119,7 @@ if (cluster.isPrimary) {
       );
       world.randomNumber = ~~(Math.random() * 10000) + 1;
       await world.save();
-      results.push(world);
+      results[i - 1] = world;
     }
 
     res.setHeader("Server", "Express");

frameworks/JavaScript/express/resolver-mongo.js

@@ -33,10 +33,10 @@ async function getRandomWorld() {
 
 function arrayOfRandomWorlds(totalWorldsToReturn) {
   const totalIterations = helper.sanititizeTotal(totalWorldsToReturn);
-  const promises = [];
+  const promises = new Array(totalIterations);
 
   for (let i = 1; i <= totalIterations; i++) {
-    promises.push(getRandomWorld());
+    promises[i - 1] = getRandomWorld();
   }
 
   return Promise.all(promises);
@@ -58,10 +58,10 @@ async function getAndUpdateRandomWorld() {
 
 function updateRandomWorlds(totalToUpdate) {
   const totalIterations = helper.sanititizeTotal(totalToUpdate);
-  const promises = [];
+  const promises = new Array(totalIterations);
 
   for (let i = 1; i <= totalIterations; i++) {
-    promises.push(getAndUpdateRandomWorld());
+    promises[i - 1] = getAndUpdateRandomWorld();
   }
 
   return Promise.all(promises);

frameworks/JavaScript/express/resolver-postgres.js

@@ -16,10 +16,10 @@ const db = pgp(`postgres://${connection.username}:${connection.password}@${conne
 function arrayOfRandomWorlds(totalWorldsToReturn) {
 
     const totalIterations = helper.sanititizeTotal(totalWorldsToReturn);
-    const arr = [];
+    const arr = new Array(totalIterations);
 
     for(let i = 0; i < totalIterations; i++) {
-        arr.push(getRandomWorld());
+        arr[i] = getRandomWorld();
     }
 
     return Promise.all(arr);
@@ -28,10 +28,10 @@ function arrayOfRandomWorlds(totalWorldsToReturn) {
 function updateRandomWorlds(totalToUpdate) {
 
     const total = helper.sanititizeTotal(totalToUpdate);
-    const arr = [];
+    const arr = new Array(total);
 
     for(let i = 0; i < total; i++) {
-        arr.push(updateRandomWorld());
+        arr[i] = updateRandomWorld();
     }
 
     return Promise.all(arr);

frameworks/JavaScript/express/resolver.js

@@ -51,10 +51,10 @@ const Fortune = sequelize.define('fortune', {
 function arrayOfRandomWorlds(totalWorldToReturn) {
 
     const totalIterations = helper.sanititizeTotal(totalWorldToReturn);
-    const arr = [];
+    const arr = new Array();
 
     for(let i = 0; i < totalIterations; i++) {
-        arr.push(World.findByPk(helper.randomizeNum()));
+        arr[i] = World.findByPk(helper.randomizeNum());
     }
 
     return Promise.all(arr);
@@ -63,19 +63,20 @@ function arrayOfRandomWorlds(totalWorldToReturn) {
 async function updateRandomWorlds(totalToUpdate) {
 
     const total = helper.sanititizeTotal(totalToUpdate);
-    const arr = [];
+    const arr = new Array(total);
 
     for(let i = 0; i < total; i++) {
-        arr.push(World.findByPk(helper.randomizeNum()));
+        arr[i] = World.findByPk(helper.randomizeNum());
     }
 
     const results = await Promise.all(arr);
 
-    const updates = [];
-    for(const world of results){
-        updates.push(world.updateAttributes({
+    const updates = new Array(total);
+    for (let index = 0; index < results.length; index++) {
+        const element = results[index];
+        updates[index] = element.updateAttributes({
             randomNumber: helper.randomizeNum()
-        }));
+        });
     }
 
     await Promise.all(updates);