test: ratchet coverage thresholds

Author: SysAdminDoc

.github/workflows/ci.yml

@@ -0,0 +1,88 @@
+name: CI
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+
+jobs:
+  quality:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
+
+      - name: Setup Node
+        uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
+        with:
+          node-version-file: .node-version
+          cache: npm
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Resolve package version
+        id: package
+        run: |
+          VERSION=$(node -p "require('./package.json').version")
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+
+      - name: npm audit (high+ severity)
+        run: npm audit --audit-level=high --omit=optional
+
+      - name: Toolchain contract
+        run: npm run toolchain:check
+
+      - name: GitHub Actions pins
+        run: npm run actions:pins:check
+
+      - name: Optional dependency reachability
+        run: npm run optional-deps:check
+
+      - name: Settings schema
+        run: npm run settings:schema:check
+
+      - name: Monaco package contract
+        run: npm run monaco:package:check
+
+      - name: Readability
+        run: npm run readability:check
+
+      - name: Dashboard modules
+        run: npm run dashboard:modules:check
+
+      - name: What's new changelog
+        run: npm run whatsnew:check
+
+      - name: Store copy
+        run: npm run store-copy:check
+
+      - name: CWS remote code
+        run: npm run cws:remote-code:check -- --target ScriptVault-v${{ steps.package.outputs.version }}.zip
+
+      - name: CWS publish tooling
+        run: npm run cws:check
+
+      - name: Release artifact check
+        run: npm run release:check
+
+      - name: Reproducible Chrome ZIP
+        run: npm run release:reproducible-build:check
+
+      - name: Rollback drill
+        run: npm run release:rollback-drill
+
+      - name: Release trust
+        run: npm run release:trust
+
+      - name: CRA SBOM
+        run: npm run release:trust:cra
+
+      - name: Store status
+        run: npm run release:store-status
+
+      - name: scriptvault-firefox-package
+        run: npm run firefox:package
+
+      - name: Coverage
+        run: npm run test:cov

tests/gui-ux-audit.test.js

@@ -131,7 +131,7 @@ describe("cross-surface UX audit", () => {
     expect(sidepanelJs).toContain("requestAnimationFrame(() => restoreSidepanelFocus(focusDescriptor));");
     expect(sidepanelJs).toContain("requestAnimationFrame(() => restoreSidepanelFallbackFocus('page'));");
     expect(sidepanelJs).toContain("requestAnimationFrame(() => restoreSidepanelFallbackFocus('all'));");
-    expect(sidepanelJs).toContain('No scripts match "${searchQuery}".');
+    expect(sidepanelJs).toContain("tSidepanel('sideNoMatchingScriptsForQuery', 'No scripts match \"{query}\".', { query: searchQuery })");
     expect(sidepanelJs).toContain("Find for ");
     expect(sidepanelHtml).toContain(".sp-context-banner");
     expect(sidepanelJs).toContain("const banner = document.createElement('button');");
@@ -192,14 +192,14 @@ describe("cross-surface UX audit", () => {
     expect(devtoolsJs).toContain("$('btnCloseDetail').focus({ preventScroll: true });");
     expect(devtoolsJs).toContain("if (selectedEntry && $('netDetail').classList.contains('open')) {");
     expect(devtoolsJs).toContain("renderDetailContent(selectedEntry);");
-    expect(devtoolsJs).toContain("clearButton.textContent = 'Reset'");
-    expect(devtoolsJs).toContain("clearButton.setAttribute('aria-label', 'Reset execution filter');");
+    expect(devtoolsJs).toContain("clearButton.textContent = tDevtools('resetView', 'Reset View');");
+    expect(devtoolsJs).toContain("clearButton.setAttribute('aria-label', tDevtools('devtoolsResetExecutionFilter', 'Reset execution filter'));");
     expect(devtoolsJs).toContain("tr.setAttribute('aria-selected', String(selectedRow === entry.id));");
     expect(devtoolsJs).toContain("Console capture isn’t available here yet. Use Network or Execution for current insight.");
     expect(devtoolsJs).toContain("No requests match");
     expect(devtoolsJs).toContain("No scripts match");
-    expect(devtoolsJs).toContain("clearButton.textContent = 'Clear'");
-    expect(devtoolsJs).toContain("clearButton.setAttribute('aria-label', 'Clear recorded network requests');");
+    expect(devtoolsJs).toContain("clearButton.textContent = tDevtools('clearAction', 'Clear');");
+    expect(devtoolsJs).toContain("clearButton.setAttribute('aria-label', tDevtools('devtoolsClearRecordedNetworkRequests', 'Clear recorded network requests'));");
     expect(devtoolsJs).toContain("No network or execution data to export yet.");
     expect(devtoolsJs).toContain("Diagnostics refresh failed. Showing the last available data.");
     expect(devtoolsHtml).toContain('.toolbar-btn[aria-busy="true"]');

tests/popup-a11y.test.js

@@ -128,7 +128,7 @@ describe("popup UX controller", () => {
     expect(popupJs).toMatch(/await copyTextToClipboard\(url\);/);
     expect(popupJs).toMatch(/updateBtn\.disabled = !hasUpdateUrl;/);
     expect(popupJs).toMatch(/copyUrlBtn\.disabled = !installUrl;/);
-    expect(popupJs).toMatch(/pinBtn\.textContent = script\?\.settings\?\.pinned \? 'Unpin Script' : 'Pin Script';/);
+    expect(popupJs).toMatch(/pinBtn\.textContent = script\?\.settings\?\.pinned \? tPopup\('popupUnpinScript', 'Unpin Script'\) : tPopup\('popupPinScript', 'Pin Script'\);/);
     expect(popupJs).toMatch(/dropdown\.setAttribute\('aria-label', `Actions for \$\{name\}`\);/);
     expect(popupJs).toMatch(/queuePopupFocusRestore\(getPopupFocusDescriptor\(getDropdownTriggerButton\(scriptId\)\)\);/);
     expect(popupJs).toMatch(/dropdown\.addEventListener\('keydown', \(e\) => \{/);

tests/script-config.test.js

@@ -1,7 +1,21 @@
 import { describe, expect, it } from 'vitest';
+import { readFileSync } from 'node:fs';
+import { resolve } from 'node:path';
+import { compileFunction } from 'node:vm';
 
 import { parseUserscript } from '../src/background/parser.ts';
-import { ScriptConfig } from '../src/modules/script-config.ts';
+import { ScriptConfig as SourceScriptConfig } from '../src/modules/script-config.ts';
+
+function loadRuntimeScriptConfig() {
+  const modulePath = resolve(__dirname, '../modules/script-config.js');
+  const code = readFileSync(modulePath, 'utf8');
+  return compileFunction(`${code}\nreturn ScriptConfig;`, [], { filename: modulePath })();
+}
+
+const implementations = [
+  { label: 'source', api: SourceScriptConfig },
+  { label: 'runtime', api: loadRuntimeScriptConfig() },
+];
 
 describe('ScriptConfig userscript @var helpers', () => {
   it('parses userscript @var metadata into config variables', () => {
@@ -25,7 +39,9 @@ describe('ScriptConfig userscript @var helpers', () => {
       { type: 'select', name: 'mode', label: 'Mode', default: 'auto', options: { auto: 'auto', manual: 'manual' } },
     ]);
   });
+});
 
+describe.each(implementations)('ScriptConfig userscript @var helpers ($label)', ({ api: ScriptConfig }) => {
   it('coerces saved values and fills defaults for missing variables', () => {
     const variables = [
       ScriptConfig.parseDirective('number retries "Retries" 2'),

tests/subscriptions-dashboard.test.js

@@ -30,7 +30,7 @@ describe('subscription dashboard surface', () => {
 
   it('renders feed health indicators', () => {
     expect(html).toContain('subscription-health');
-    expect(js).toContain("Health: ${escapeHtml(health.label)}");
+    expect(js).toContain("tDashboard('subscriptionHealthPrefix', 'Health: {health}', { health: health.label })");
     expect(js).toContain("Needs attention");
     expect(js).toContain("Not checked");
     expect(js).toContain("Healthy");

tests/subscriptions.test.js

@@ -1,10 +1,25 @@
-import { ScriptSubscriptions } from '../src/modules/subscriptions.ts';
+import { readFileSync } from 'node:fs';
+import { resolve } from 'node:path';
+import { compileFunction } from 'node:vm';
+
+import { ScriptSubscriptions as SourceScriptSubscriptions } from '../src/modules/subscriptions.ts';
+
+function loadRuntimeSubscriptions() {
+  const modulePath = resolve(__dirname, '../modules/subscriptions.js');
+  const code = readFileSync(modulePath, 'utf8');
+  return compileFunction(`${code}\nreturn ScriptSubscriptions;`, [], { filename: modulePath })();
+}
+
+const implementations = [
+  { label: 'source', api: SourceScriptSubscriptions },
+  { label: 'runtime', api: loadRuntimeSubscriptions() },
+];
 
 beforeEach(() => {
   globalThis.__resetStorageMock?.();
 });
 
-describe('script subscriptions', () => {
+describe.each(implementations)('script subscriptions ($label)', ({ api: ScriptSubscriptions }) => {
   it('parses array and object feed entries with relative URLs', () => {
     const feed = ScriptSubscriptions.parseFeed(JSON.stringify({
       name: 'Curated Pack',

tests/sync-crypto.test.js

@@ -1,7 +1,21 @@
 import { webcrypto } from 'node:crypto';
+import { readFileSync } from 'node:fs';
+import { resolve } from 'node:path';
+import { compileFunction } from 'node:vm';
 import { afterAll, beforeAll, describe, expect, it } from 'vitest';
 
-import { SyncCrypto } from '../src/modules/sync-crypto.ts';
+import { SyncCrypto as SourceSyncCrypto } from '../src/modules/sync-crypto.ts';
+
+function loadRuntimeSyncCrypto() {
+  const modulePath = resolve(__dirname, '../modules/sync-crypto.js');
+  const code = readFileSync(modulePath, 'utf8');
+  return compileFunction(`${code}\nreturn SyncCrypto;`, [], { filename: modulePath })();
+}
+
+const implementations = [
+  { label: 'source', api: SourceSyncCrypto },
+  { label: 'runtime', api: loadRuntimeSyncCrypto() },
+];
 
 const fastEncryptedSettings = {
   syncEncryptionEnabled: true,
@@ -19,7 +33,7 @@ afterAll(() => {
   Object.defineProperty(globalThis, 'crypto', { value: originalCrypto, configurable: true });
 });
 
-describe('sync crypto helper', () => {
+describe.each(implementations)('sync crypto helper ($label)', ({ api: SyncCrypto }) => {
   it('round-trips a v1 sync envelope through PBKDF2 and AES-256-GCM', async () => {
     const envelope = {
       version: 1,

tests/trusted-types-docs.test.js

@@ -24,10 +24,10 @@ describe('Trusted Types author documentation', () => {
     const dashboard = read('pages/dashboard.html');
 
     expect(dashboard).toContain('Trusted Types And MAIN-World Scripts');
-    expect(dashboard).toContain('ScriptVault runs scripts in <code>USER_SCRIPT</code> world');
-    expect(dashboard).toContain('Scripts that use page context or <code>unsafeWindow</code>');
-    expect(dashboard).toContain('<code>GM_addElement</code> with attributes');
-    expect(dashboard).toContain('<strong>TrustedHTML:</strong>');
+    expect(dashboard).toContain('data-i18n="helpTrustedTypesDefaultDescription">ScriptVault runs scripts in USER_SCRIPT world');
+    expect(dashboard).toContain('data-i18n="helpTrustedTypesMainDescription">Scripts that use page context or unsafeWindow');
+    expect(dashboard).toContain('data-i18n="helpTrustedTypesDomDescription">Prefer textContent, append, createElement, and GM_addElement with attributes.');
+    expect(dashboard).toContain('data-i18n="helpTrustedTypesHtmlLabel">TrustedHTML:</strong>');
   });
 
   it('keeps the cycle documentation-only without adding a runtime policy shim', () => {

tests/ts-runtime-modules.test.js

@@ -1,3 +1,4 @@
+// @vitest-environment node
 import { describe, expect, it } from 'vitest';
 import { readFileSync } from 'node:fs';
 import { resolve } from 'node:path';

tests/user-scripts-onboarding.test.js

@@ -112,7 +112,7 @@ describe('Chrome userScripts onboarding diagnostics', () => {
     expect(dashboardJs).toContain("action: 'runScriptNow'");
     expect(dashboardJs).toContain('scriptId,');
     expect(dashboardJs).toContain('tabId: targetTab.id');
-    expect(dashboardJs).toContain('runButtonTask(event.currentTarget, () => runScriptOnceOnTab(), { busyLabel: \'Running...\' })');
+    expect(dashboardJs).toContain("runButtonTask(event.currentTarget, () => runScriptOnceOnTab(), { busyLabel: tDashboard('runningEllipsis', 'Running...') })");
     expect(dashboardJs).toContain('[data-action="runNow"]');
     expect(messagesTs).toContain("interface RunScriptNow");
     expect(messagesTs).toContain("action: 'runScriptNow';");