feat: a gun that tracks a target and knows whose side it is on

- follow an entity, not only a point, and lose it when it dies
- spare a target carrying the installation's access code
- declare what a build needs delivered, gas included and reserved
- add manual control as a mode through the same launch path
- read mount telemetry off the guns for the console readout
- pin the ship-frame case: a gun in the shipyard fires into the world

Author: StannisMod

src/main/java/zmaster587/advancedRocketry/AdvancedRocketry.java

@@ -742,7 +742,8 @@ public void registerBlocks(RegistryEvent.Register<Block> evt) {
                 .setUnlocalizedName("gunBarrel").setCreativeTab(tabAdvRocketry);
         AdvancedRocketryBlocks.blockGunAmmoFeed = new zmaster587.advancedRocketry.block.weapon.BlockGunPart(
                 builder -> builder.speedUpFireIntervalBy(3).addImpactEnergy(6).addEnergyPerShot(75)
-                        .addHeatPerShot(2))
+                        .addHeatPerShot(2)
+                        .declareInput(zmaster587.advancedRocketry.api.weapon.GunInput.FORGE_ENERGY))
                 .setUnlocalizedName("gunAmmoFeed").setCreativeTab(tabAdvRocketry);
         AdvancedRocketryBlocks.blockGunCooling = new zmaster587.advancedRocketry.block.weapon.BlockGunPart(
                 builder -> builder.addHeatCapacity(40).addCoolingPerTick(2).addTraverseDegreesPerTick(0.5D))

src/main/java/zmaster587/advancedRocketry/api/weapon/GunInput.java

@@ -0,0 +1,26 @@
+package zmaster587.advancedRocketry.api.weapon;
+
+/**
+ * What a gun needs delivered to it in order to fire.
+ *
+ * <h3>Declared by the build, so nothing has to guess</h3>
+ * <p>A gun states its inputs rather than being asked to justify a failure to fire: a player looking
+ * at a silent weapon can be told "it wants gas and has none" instead of being left to work out which
+ * of six conditions is unmet. An addon's part declares its own input the same way, which is what
+ * lets a supply system serve weapons it was not written knowing about.</p>
+ *
+ * <h3>One of these is implemented</h3>
+ * <p>{@link #FORGE_ENERGY} is real: guns hold a buffer, draw from any FE source, and the weapons
+ * network distributes it. {@link #GAS} is declared and reserved — the fabric that would carry it
+ * exists for other purposes, and the plasma weapons that would want it are a later wave. A build
+ * that declares it today is not refused and is not charged; the declaration is what makes adding the
+ * supply later a change to one place rather than to every gun.</p>
+ */
+public enum GunInput {
+
+    /** Forge Energy, drawn from the gun's own buffer. Implemented. */
+    FORGE_ENERGY,
+
+    /** A gas feed from the ship's fabric. Declared only — nothing consumes it yet. */
+    GAS
+}

src/main/java/zmaster587/advancedRocketry/api/weapon/GunSpec.java

@@ -40,6 +40,7 @@ public final class GunSpec {
     private final double projectileMass;
     private final ImpactKind kind;
     private final int partCount;
+    private final java.util.EnumSet<GunInput> inputs;
 
     private GunSpec(Builder builder) {
         this.muzzleSpeed = builder.muzzleSpeed;
@@ -56,6 +57,8 @@ private GunSpec(Builder builder) {
         this.projectileMass = builder.projectileMass;
         this.kind = builder.kind;
         this.partCount = builder.partCount;
+        this.inputs = java.util.EnumSet.copyOf(builder.inputs.isEmpty()
+                ? java.util.EnumSet.of(GunInput.FORGE_ENERGY) : builder.inputs);
     }
 
     /**
@@ -127,6 +130,14 @@ public ImpactKind getKind() {
         return kind;
     }
 
+    /**
+     * What this build needs delivered to it. Never empty: a gun that declared nothing would be a gun
+     * nothing could be said about, so the floor is Forge Energy — which every build draws anyway.
+     */
+    public java.util.Set<GunInput> getDeclaredInputs() {
+        return java.util.Collections.unmodifiableSet(inputs);
+    }
+
     /** How many parts were counted. Diagnostics, and the "is this thing built" test's raw material. */
     public int getPartCount() {
         return partCount;
@@ -157,6 +168,7 @@ public static final class Builder {
         private double projectileMass = 1.0D;
         private ImpactKind kind = ImpactKind.KINETIC;
         private int partCount;
+        private final java.util.EnumSet<GunInput> inputs = java.util.EnumSet.noneOf(GunInput.class);
 
         public Builder addMuzzleSpeed(double blocksPerTick) {
             this.muzzleSpeed += Math.max(0.0D, blocksPerTick);
@@ -227,6 +239,17 @@ public Builder setKind(ImpactKind kind) {
             return this;
         }
 
+        /**
+         * State that this part needs something delivered. Additive like everything else: a build with
+         * one gas-fed component declares gas, whatever the rest of it wants.
+         */
+        public Builder declareInput(GunInput input) {
+            if (input != null) {
+                this.inputs.add(input);
+            }
+            return this;
+        }
+
         /** Called once per part counted, by the assembly walk rather than by the parts themselves. */
         public Builder countPart() {
             this.partCount++;

src/main/java/zmaster587/advancedRocketry/command/test/TestProbeCommand.java

@@ -399,6 +399,7 @@ private void handleTurret(MinecraftServer server, ICommandSender sender, String[
         }
         if ("cleartarget".equals(sub)) {
             turret.setTarget(null);
+            turret.setTargetEntity(null);
             send(sender, "{\"ok\":true}");
             return;
         }
@@ -413,6 +414,36 @@ private void handleTurret(MinecraftServer server, ICommandSender sender, String[
             send(sender, "{\"ok\":true,\"drive\":\"" + turret.getMechanism().getDriveState().name() + "\"}");
             return;
         }
+        if ("target-player".equals(sub) && args.length >= 6) {
+            net.minecraft.entity.player.EntityPlayerMP player =
+                    server.getPlayerList().getPlayerByUsername(args[5]);
+            if (player == null) {
+                send(sender, jsonError("no such player"));
+                return;
+            }
+            turret.setTargetEntity(player.getUniqueID());
+            send(sender, "{\"ok\":true}");
+            return;
+        }
+        if ("code".equals(sub)) {
+            turret.setAccessCode(args.length >= 6 ? args[5] : "");
+            send(sender, "{\"ok\":true,\"code\":\"" + escapeJson(turret.getEffectiveAccessCode()) + "\"}");
+            return;
+        }
+        if ("manual".equals(sub) && args.length >= 6) {
+            turret.setManualControl(Boolean.parseBoolean(args[5]));
+            send(sender, "{\"ok\":true,\"manual\":" + turret.isManuallyControlled() + "}");
+            return;
+        }
+        if ("bearing".equals(sub) && args.length >= 7) {
+            turret.commandManualBearing(parseDoubleOr(args[5], 0), parseDoubleOr(args[6], 0));
+            send(sender, "{\"ok\":true}");
+            return;
+        }
+        if ("fire".equals(sub)) {
+            send(sender, "{\"ok\":true,\"fired\":" + turret.fireOnce() + "}");
+            return;
+        }
         if ("read".equals(sub)) {
             zmaster587.advancedRocketry.api.weapon.GunSpec spec = turret.getSpec();
             zmaster587.advancedRocketry.weapon.TurretMechanism mount = turret.getMechanism();
@@ -436,6 +467,10 @@ private void handleTurret(MinecraftServer server, ICommandSender sender, String[
                     + ",\"drive\":\"" + mount.getDriveState().name() + "\""
                     + ",\"shots\":" + turret.getShotsFired()
                     + ",\"lastShot\":" + turret.getLastShotId()
+                    + ",\"trackingEntity\":" + (turret.getTargetEntity() != null)
+                    + ",\"code\":\"" + escapeJson(turret.getEffectiveAccessCode()) + "\""
+                    + ",\"manual\":" + turret.isManuallyControlled()
+                    + ",\"inputs\":\"" + escapeJson(spec.getDeclaredInputs().toString()) + "\""
                     + ",\"hasTarget\":" + (target != null)
                     + (target == null ? "" : ",\"targetX\":" + target.x + ",\"targetY\":" + target.y
                             + ",\"targetZ\":" + target.z)
@@ -496,13 +531,34 @@ private void handleWeaponConsole(MinecraftServer server, ICommandSender sender,
                     + console.isHoldFire() + "}");
             return;
         }
+        if ("target-player".equals(sub) && args.length >= 6) {
+            net.minecraft.entity.player.EntityPlayerMP player =
+                    server.getPlayerList().getPlayerByUsername(args[5]);
+            if (player == null) {
+                send(sender, jsonError("no such player"));
+                return;
+            }
+            send(sender, "{\"ok\":true,\"applied\":"
+                    + console.assignTargetEntity(player.getUniqueID()) + "}");
+            return;
+        }
+        if ("code".equals(sub)) {
+            boolean applied = console.setAccessCode(args.length >= 6 ? args[5] : "");
+            send(sender, "{\"ok\":true,\"applied\":" + applied + ",\"code\":\""
+                    + escapeJson(console.getAccessCode()) + "\"}");
+            return;
+        }
         if ("read".equals(sub)) {
             net.minecraft.util.math.Vec3d target = console.getTarget();
             send(sender, "{\"ok\":true"
                     + ",\"network\":" + (console.network() != null)
                     + ",\"status\":\"" + escapeJson(console.getNetworkStatusText()) + "\""
                     + ",\"guns\":" + console.getGunCount()
+                    + ",\"onTarget\":" + console.getMountTelemetry()[0]
+                    + ",\"saturated\":" + console.getMountTelemetry()[1]
                     + ",\"holdFire\":" + console.isHoldFire()
+                    + ",\"code\":\"" + escapeJson(console.getAccessCode()) + "\""
+                    + ",\"trackingEntity\":" + (console.getTargetEntity() != null)
                     + ",\"hasTarget\":" + (target != null)
                     + (target == null ? "" : ",\"targetX\":" + target.x + ",\"targetY\":" + target.y
                             + ",\"targetZ\":" + target.z)
@@ -512,6 +568,11 @@ private void handleWeaponConsole(MinecraftServer server, ICommandSender sender,
         send(sender, "{\"error\":\"unknown weaponconsole subcommand\",\"sub\":\"" + escapeJson(sub) + "\"}");
     }
 
+    /** One-line error payload, so a new verb does not hand-build JSON and get a quote wrong. */
+    private static String jsonError(String message) {
+        return "{\"error\":\"" + escapeJson(message) + "\"}";
+    }
+
     private static String shotJson(zmaster587.advancedRocketry.projectile.Shot shot) {
         return "{\"id\":" + shot.getId()
                 + ",\"x\":" + shot.getPosition().x