fix: 사용자 광고에서 설치·가입 캠페인 제외 (#463)

사용자 광고 API와 공개 광고 랜딩에서 애드픽 동기화 설치·가입형 캠페인을 제외합니다. 쇼핑·핫딜 상품과 쿠팡 및 수동 등록
광고는 기존 조건으로 제공하고, 쇼핑 재고가 부족해도 설치형 캠페인으로 채우지 않습니다. 기존 소재와 성과 기록은 보존합니다.

검증: 광고 조회·동기화 테스트 통과. 설치/가입형 제외, 재고 부족 시 빈 목록, 공개 랜딩 제외 회귀 테스트를 추가했습니다.

Author: Roy-wonji

src/main/java/com/swyp/picke/domain/ad/service/AdQueryService.java

@@ -3,6 +3,8 @@
 import com.swyp.picke.domain.ad.dto.response.AdResponse;
 import com.swyp.picke.domain.ad.entity.AdCreative;
 import com.swyp.picke.domain.ad.enums.AdSlotCode;
+import com.swyp.picke.domain.ad.enums.AdNetwork;
+import com.swyp.picke.domain.ad.enums.AdSource;
 import com.swyp.picke.domain.ad.enums.AdStatus;
 import com.swyp.picke.domain.ad.enums.AdTargetOs;
 import com.swyp.picke.domain.ad.repository.AdCreativeRepository;
@@ -46,6 +48,7 @@ public List<AdResponse> findServableAds(AdSlotCode slot, AdTargetOs os, int size
 
         List<AdCreative> candidates = adCreativeRepository.findAllBySlotAndStatus(slot, AdStatus.ACTIVE).stream()
                 .filter(creative -> creative.isServable(now))
+                .filter(this::isShoppingOrManualAd)
                 .filter(creative -> creative.getTargetOs().matches(requested))
                 .toList();
 
@@ -64,6 +67,7 @@ public List<AdResponse> findLandingAds() {
 
         return adCreativeRepository.findAllByStatusOrderByIdDesc(AdStatus.ACTIVE).stream()
                 .filter(creative -> creative.isServable(now))
+                .filter(this::isShoppingOrManualAd)
                 .map(creative -> AdResponse.of(creative, buildClickUrl(creative)))
                 .toList();
     }
@@ -101,6 +105,14 @@ private void increaseImpression(ImpressionTarget target, LocalDate today) {
         }
     }
 
+    /** 동기화된 애드픽 설치·가입 캠페인은 제외한다. 쇼핑 식별자는 수집 시 생성한 sh + 해시다. */
+    private boolean isShoppingOrManualAd(AdCreative creative) {
+        if (creative.getNetwork() != AdNetwork.ADPICK || creative.getSource() != AdSource.ADPICK_API) {
+            return true;
+        }
+        return creative.getExternalId() != null && creative.getExternalId().matches("sh[0-9a-f]{10}");
+    }
+
     private String buildClickUrl(AdCreative creative) {
         return adBaseUrl + "/c/" + creative.getCode();
     }

src/test/java/com/swyp/picke/domain/ad/service/AdQueryServiceTest.java

@@ -5,6 +5,7 @@
 import com.swyp.picke.domain.ad.enums.AdNetwork;
 import com.swyp.picke.domain.ad.enums.AdSlotCode;
 import com.swyp.picke.domain.ad.enums.AdStatus;
+import com.swyp.picke.domain.ad.enums.AdSource;
 import com.swyp.picke.domain.ad.enums.AdTargetOs;
 import com.swyp.picke.domain.ad.repository.AdCreativeRepository;
 import java.time.LocalDate;
@@ -147,6 +148,44 @@ void findServableAds_filtersByTargetOs() {
         assertThat(result).extracting(AdResponse::code).containsExactlyInAnyOrder("ios00001", "all00001");
     }
 
+    private AdCreative syncedAdpick(String code, String externalId) {
+        AdCreative ad = creative(code, AdStatus.ACTIVE, 100, null, null);
+        ReflectionTestUtils.setField(ad, "network", AdNetwork.ADPICK);
+        ReflectionTestUtils.setField(ad, "source", AdSource.ADPICK_API);
+        ReflectionTestUtils.setField(ad, "externalId", externalId);
+        return ad;
+    }
+
+    @Test
+    void excludesInstallCampaignsEvenWhenShoppingCannotFillRequestedSize() {
+        var shopping = syncedAdpick("shop0001", "sh012345abcd");
+        var install = syncedAdpick("app00001", "ukjd9nru");
+        var signup = syncedAdpick("join0001", "hmvdx3t3");
+        var coupang = creative("coup0001", AdStatus.ACTIVE, 1, null, null);
+        when(adCreativeRepository.findAllBySlotAndStatus(AdSlotCode.HOME_FEED, AdStatus.ACTIVE))
+                .thenReturn(List.of(shopping, install, signup, coupang));
+
+        assertThat(adQueryService.findServableAds(AdSlotCode.HOME_FEED, AdTargetOs.ALL, 10))
+                .extracting(AdResponse::code).containsExactlyInAnyOrder("shop0001", "coup0001");
+    }
+
+    @Test
+    void doesNotFallbackToInstallAdsWhenThereAreNoShoppingProducts() {
+        when(adCreativeRepository.findAllBySlotAndStatus(AdSlotCode.HOME_FEED, AdStatus.ACTIVE))
+                .thenReturn(List.of(syncedAdpick("app00001", "ukjd9nru"),
+                        syncedAdpick("bad00001", null)));
+        assertThat(adQueryService.findServableAds(AdSlotCode.HOME_FEED, AdTargetOs.ANDROID, 10)).isEmpty();
+    }
+
+    @Test
+    void landingAlsoExcludesInstallCampaigns() {
+        when(adCreativeRepository.findAllByStatusOrderByIdDesc(AdStatus.ACTIVE))
+                .thenReturn(List.of(syncedAdpick("shop0001", "sh012345abcd"),
+                        syncedAdpick("app00001", "ukjd9nru")));
+        assertThat(adQueryService.findLandingAds()).extracting(AdResponse::code)
+                .containsExactly("shop0001");
+    }
+
     @Test
     @DisplayName("노출 집계는 같은 날 반복 호출하면 기존 행을 누적한다")
     void recordImpressions_incrementsExistingRow() {