Skip to content

fix(cli): keep /model switches session-scoped #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qqqys wants to merge 20 commits into
base: main
Choose a base branch
from
Open

fix(cli): keep /model switches session-scoped #4332

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a101ca8
fix(cli): keep model switches session-scoped
qqqys May 19, 2026
412c8d6
fix(cli): add model command locale coverage
qqqys May 19, 2026
ef5e575
test(cli): cover model default review paths
qqqys May 19, 2026
0779951
fix(cli): harden model default shortcut
qqqys May 19, 2026
eab2ece
fix(cli): address model default review feedback
qqqys May 19, 2026
fd46f47
fix(cli): harden model default persistence
qqqys May 20, 2026
f832609
fix(cli): polish model default review feedback
qqqys May 20, 2026
1faa612
fix(cli): clarify model session default feedback
qqqys May 20, 2026
346da6e
fix(cli): handle model default persistence errors
qqqys May 20, 2026
ce79a71
fix(cli): complete model flag suggestions
qqqys May 20, 2026
0b5a1ff
fix(cli): serialize model default switching
qqqys May 20, 2026
063fef6
fix(cli): handle fast model persistence failures
qqqys May 20, 2026
4b33f7c
fix(cli): stabilize model dialog keypress handler
qqqys May 23, 2026
f2a49b6
fix(cli): handle model default race cases
qqqys May 23, 2026
648b127
fix(cli): reject conflicting model flags
qqqys May 24, 2026
1c93b39
fix(cli): address model switch review
qqqys May 24, 2026
517a81d
fix(cli): align model command selectors
qqqys May 24, 2026
bc33192
fix(cli): guard model command telemetry and oauth fast models
qqqys May 24, 2026
1ff2020
fix(cli): harden model command edge cases
qqqys May 24, 2026
a17caf0
fix(cli): avoid duplicate default model history
qqqys May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/cli/src/i18n/locales/ca.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1858,6 +1858,15 @@ export default {
'Manage extension settings': 'Gestionar la configuració de les extensions',
'Desc:': 'Descripció:',
'Ref:': 'Referència:',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
"Canvia el model d'aquesta sessió (--default per persistir, --fast per al model de suggeriments).",
'Default model': 'Model predeterminat',
'session only': 'només aquesta sessió',
'Persist the selected model as the default':
'Persistir el model seleccionat com a predeterminat',
'Usage: /model --default <model-id>': 'Ús: /model --default <id-del-model>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'Model actual: {{model}}\nUseu "/model <model-id>" per canviar de model (només aquesta sessió), "/model --default <model-id>" per persistir-lo, o "/model --fast <model-id>" per definir el model ràpid.',
'中国 (China)': 'Xina',
'中国 (China) - 阿里云百炼': 'Xina - 阿里云百炼',
};
10 changes: 10 additions & 0 deletions packages/cli/src/i18n/locales/de.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,6 +1902,16 @@ export default {
'Ref:': 'Referenz:',
'Skills:': 'Fähigkeiten:',
remote: 'entfernt',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'Modell für diese Sitzung wechseln (--default zum Speichern, --fast für das Vorschlagsmodell).',
'Default model': 'Standardmodell',
'session only': 'nur diese Sitzung',
'Persist the selected model as the default':
'Ausgewähltes Modell als Standard speichern',
'Usage: /model --default <model-id>':
'Verwendung: /model --default <modell-id>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'Aktuelles Modell: {{model}}\nVerwenden Sie "/model <model-id>", um das Modell zu wechseln (nur diese Sitzung), "/model --default <model-id>" zum Speichern oder "/model --fast <model-id>" zum Festlegen des schnellen Modells.',
'中国 (China)': 'China',
'中国 (China) - 阿里云百炼': 'China - 阿里云百炼',
};
11 changes: 11 additions & 0 deletions packages/cli/src/i18n/locales/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ export default {
'Esc to close': 'Esc to close',
'Enter to select, ↑↓ to navigate, Esc to close':
'Enter to select, ↑↓ to navigate, Esc to close',
'Enter to select, d to set default, ↑↓ to navigate, Esc to close':
Copy link
Copy Markdown
Collaborator

@wenshao wenshao May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] The i18n key 'Enter to select, d to set default, ↑↓ to navigate, Esc to close' was added to en.js, zh.js, and zh-TW.js but is missing from 6 other locales: ca.js, de.js, fr.js, ja.js, pt.js, ru.js. All other new keys from this PR (Default model, session only, Persist the selected model..., Usage: /model --default..., Current model: {{model}}...) are present in all locales.

Non-CJK users will see the English fallback text in the dialog footer instead of a translated version.

— qwen-latest-series-invite-beta-v34 via Qwen Code /review

'Enter to select, d to set default, ↑↓ to navigate, Esc to close',
'Esc to go back': 'Esc to go back',
'Enter to confirm, Esc to cancel': 'Enter to confirm, Esc to cancel',
'Enter to select, ↑↓ to navigate, Esc to go back':
Expand Down Expand Up @@ -1040,6 +1042,15 @@ export default {
// ============================================================================
'Switch the model for this session (--fast for suggestion model, [model-id] to switch immediately).':
'Switch the model for this session (--fast for suggestion model, [model-id] to switch immediately).',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'Switch the model for this session (--default to persist, --fast for suggestion model).',
'Default model': 'Default model',
'session only': 'session only',
'Persist the selected model as the default':
'Persist the selected model as the default',
'Usage: /model --default <model-id>': 'Usage: /model --default <model-id>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.',
'Set a lighter model for prompt suggestions and speculative execution':
'Set a lighter model for prompt suggestions and speculative execution',
'Content generator configuration not available.':
Expand Down
10 changes: 10 additions & 0 deletions packages/cli/src/i18n/locales/fr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1896,5 +1896,15 @@ export default {
Auto: 'Automatique',
Tokens: 'Jetons',
tokens: 'jetons',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'Changer le modèle pour cette session (--default pour persister, --fast pour le modèle de suggestion).',
'Default model': 'Modèle par défaut',
'session only': 'session uniquement',
'Persist the selected model as the default':
'Persister le modèle sélectionné comme modèle par défaut',
'Usage: /model --default <model-id>':
'Utilisation : /model --default <id-modèle>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'Modèle actuel : {{model}}\nUtilisez "/model <model-id>" pour changer de modèle (session uniquement), "/model --default <model-id>" pour le persister, ou "/model --fast <model-id>" pour définir le modèle rapide.',
'中国 (China)': 'Chine',
};
9 changes: 9 additions & 0 deletions packages/cli/src/i18n/locales/ja.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1667,6 +1667,15 @@ export default {
// === Same-as-English optimization ===
' (not in model registry)': '（モデルレジストリにありません）',
'Attribution: commit': 'コミットの帰属表示',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'このセッションのモデルを切り替えます（--default で永続化、--fast で提案モデルを設定）。',
'Default model': 'デフォルトモデル',
'session only': 'このセッションのみ',
'Persist the selected model as the default':
'選択したモデルをデフォルトとして保存',
'Usage: /model --default <model-id>': '使い方: /model --default <model-id>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'現在のモデル: {{model}}\n"/model <model-id>" でモデルを切り替え（このセッションのみ）、"/model --default <model-id>" で保存、"/model --fast <model-id>" で高速モデルを設定します。',
'中国 (China)': '中国',
'中国 (China) - 阿里云百炼': '中国 - 阿里云百炼',
};
9 changes: 9 additions & 0 deletions packages/cli/src/i18n/locales/pt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1889,6 +1889,15 @@ export default {
Status: 'Estado',
'Status:': 'Estado:',
Use: 'Uso',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'Trocar o modelo desta sessão (--default para persistir, --fast para o modelo de sugestões).',
'Default model': 'Modelo padrão',
'session only': 'somente nesta sessão',
'Persist the selected model as the default':
'Persistir o modelo selecionado como padrão',
'Usage: /model --default <model-id>': 'Uso: /model --default <id-do-modelo>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'Modelo atual: {{model}}\nUse "/model <model-id>" para trocar de modelo (somente nesta sessão), "/model --default <model-id>" para persistir, ou "/model --fast <model-id>" para definir o modelo rápido.',
'中国 (China)': 'China',
'中国 (China) - 阿里云百炼': 'China - 阿里云百炼',
};
10 changes: 10 additions & 0 deletions packages/cli/src/i18n/locales/ru.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1878,6 +1878,16 @@ export default {
// === Same-as-English optimization ===
' (not in model registry)': ' (не в реестре моделей)',
'start server': 'запустить сервер',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'Переключить модель для этой сессии (--default для сохранения, --fast для модели подсказок).',
'Default model': 'Модель по умолчанию',
'session only': 'только эта сессия',
'Persist the selected model as the default':
'Сохранить выбранную модель как модель по умолчанию',
'Usage: /model --default <model-id>':
'Использование: /model --default <model-id>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'Текущая модель: {{model}}\nИспользуйте "/model <model-id>" для переключения модели (только эта сессия), "/model --default <model-id>" для сохранения или "/model --fast <model-id>" для быстрой модели.',
'中国 (China)': 'Китай',
'中国 (China) - 阿里云百炼': 'Китай - 阿里云百炼',
};
10 changes: 10 additions & 0 deletions packages/cli/src/i18n/locales/zh-TW.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ export default {
'Esc to close': '按 Esc 關閉',
'Enter to select, ↑↓ to navigate, Esc to close':
'Enter 選擇，↑↓ 導航，Esc 關閉',
'Enter to select, d to set default, ↑↓ to navigate, Esc to close':
'Enter 選擇，d 設為預設，↑↓ 導航，Esc 關閉',
'Esc to go back': '按 Esc 返回',
'Enter to confirm, Esc to cancel': 'Enter 確認，Esc 取消',
'Enter to select, ↑↓ to navigate, Esc to go back':
Expand Down Expand Up @@ -884,6 +886,14 @@ export default {
'生成摘要失敗 - 未從 LLM 響應中接收到文本內容',
'Switch the model for this session (--fast for suggestion model, [model-id] to switch immediately).':
'切換此會話的模型（--fast 可設置建議模型）',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'切換此會話的模型（--default 可持久化，--fast 可設置建議模型）',
'Default model': '預設模型',
'session only': '僅此會話',
'Persist the selected model as the default': '將所選模型持久化為預設模型',
'Usage: /model --default <model-id>': '用法：/model --default <模型 ID>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'目前模型：{{model}}\n使用 "/model <model-id>" 切換模型（僅此會話），使用 "/model --default <model-id>" 持久化，或使用 "/model --fast <model-id>" 設定快速模型。',
'Set a lighter model for prompt suggestions and speculative execution':
'設置用於輸入建議和推測執行的輕量模型',
'Content generator configuration not available.': '內容生成器配置不可用',
Expand Down
10 changes: 10 additions & 0 deletions packages/cli/src/i18n/locales/zh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ export default {
'Esc to close': '按 Esc 关闭',
'Enter to select, ↑↓ to navigate, Esc to close':
'Enter 选择，↑↓ 导航，Esc 关闭',
'Enter to select, d to set default, ↑↓ to navigate, Esc to close':
'Enter 选择，d 设为默认，↑↓ 导航，Esc 关闭',
'Esc to go back': '按 Esc 返回',
'Enter to confirm, Esc to cancel': 'Enter 确认，Esc 取消',
'Enter to select, ↑↓ to navigate, Esc to go back':
Expand Down Expand Up @@ -991,6 +993,14 @@ export default {
// ============================================================================
'Switch the model for this session (--fast for suggestion model, [model-id] to switch immediately).':
'切换此会话的模型（--fast 可设置建议模型）',
'Switch the model for this session (--default to persist, --fast for suggestion model).':
'切换此会话的模型（--default 可持久化，--fast 可设置建议模型）',
'Default model': '默认模型',
'session only': '仅本会话',
'Persist the selected model as the default': '将所选模型持久化为默认模型',
'Usage: /model --default <model-id>': '用法：/model --default <模型 ID>',
'Current model: {{model}}\nUse "/model <model-id>" to switch models (session only), "/model --default <model-id>" to persist, or "/model --fast <model-id>" to set the fast model.':
'当前模型：{{model}}\n使用 "/model <model-id>" 切换模型（仅本会话），使用 "/model --default <model-id>" 持久化，或使用 "/model --fast <model-id>" 设置快速模型。',
'Set a lighter model for prompt suggestions and speculative execution':
'设置用于输入建议和推测执行的轻量模型',
'Content generator configuration not available.': '内容生成器配置不可用',
Expand Down
Loading
Loading