From 12fc0d0158bf97649fdb7e2169342978e45ad736 Mon Sep 17 00:00:00 2001 From: Marlo Longley Date: Thu, 2 Oct 2025 16:31:12 -0400 Subject: [PATCH] Remove un-dispatched action types --- __tests__/src/reducers/catalog.test.js | 2 +- __tests__/src/reducers/windows.test.js | 62 -------------------------- src/state/actions/action-types.js | 8 ---- src/state/reducers/windows.js | 20 --------- 4 files changed, 1 insertion(+), 91 deletions(-) diff --git a/__tests__/src/reducers/catalog.test.js b/__tests__/src/reducers/catalog.test.js index b232590e94..3030b9048f 100644 --- a/__tests__/src/reducers/catalog.test.js +++ b/__tests__/src/reducers/catalog.test.js @@ -2,7 +2,7 @@ import { catalogReducer } from '../../../src/state/reducers/catalog'; import ActionTypes from '../../../src/state/actions/action-types'; describe('catalog reducer', () => { - describe('ADD_MANIFEST', () => { + describe('ADD_RESOURCE', () => { it('adds new manifests to the state', () => { expect(catalogReducer([], { manifestId: '1', diff --git a/__tests__/src/reducers/windows.test.js b/__tests__/src/reducers/windows.test.js index 181fcc3701..59f9d8cc56 100644 --- a/__tests__/src/reducers/windows.test.js +++ b/__tests__/src/reducers/windows.test.js @@ -152,68 +152,6 @@ describe('windows reducer', () => { }); }); - it('should handle SET_WINDOW_SIZE', () => { - expect(windowsReducer({ - abc123: { - id: 'abc123', - }, - def456: { - id: 'def456', - }, - }, { - payload: { - size: { - height: 200, - width: 200, - x: 20, - y: 20, - }, - windowId: 'abc123', - }, - type: ActionTypes.SET_WINDOW_SIZE, - })).toEqual({ - abc123: { - height: 200, - id: 'abc123', - width: 200, - x: 20, - y: 20, - }, - def456: { - id: 'def456', - }, - }); - }); - - it('should handle UPDATE_WINDOW_POSITION', () => { - expect(windowsReducer({ - abc123: { - id: 'abc123', - }, - def456: { - id: 'def456', - }, - }, { - payload: { - position: { - x: 20, - y: 20, - }, - windowId: 'abc123', - }, - type: ActionTypes.UPDATE_WINDOW_POSITION, - })).toEqual({ - abc123: { - id: 'abc123', - x: 20, - y: 20, - }, - def456: { - id: 'def456', - }, - }); - }); - it('should handle ADD_COMPANION_WINDOW', () => { // on the right, just tacks the new id on expect(windowsReducer({ diff --git a/src/state/actions/action-types.js b/src/state/actions/action-types.js index c1f1244727..c36611b647 100644 --- a/src/state/actions/action-types.js +++ b/src/state/actions/action-types.js @@ -15,9 +15,7 @@ const ActionTypes = { TOGGLE_ANNOTATION_DISPLAY: 'mirador/TOGGLE_ANNOTATION_DISPLAY', FOCUS_WINDOW: 'mirador/FOCUS_WINDOW', - SET_WORKSPACE_FULLSCREEN: 'mirador/SET_WORKSPACE_FULLSCREEN', SET_WORKSPACE_VIEWPORT_POSITION: 'mirador/SET_WORKSPACE_VIEWPORT_POSITION', - ADD_MANIFEST: 'mirador/ADD_MANIFEST', ADD_WINDOW: 'mirador/ADD_WINDOW', ADD_ERROR: 'mirador/ADD_ERROR', IMPORT_CONFIG: 'mirador/IMPORT_CONFIG', @@ -25,17 +23,13 @@ const ActionTypes = { SET_CANVAS: 'mirador/SET_CANVAS', MAXIMIZE_WINDOW: 'mirador/MAXIMIZE_WINDOW', MINIMIZE_WINDOW: 'mirador/MINIMIZE_WINDOW', - UPDATE_WINDOW_POSITION: 'mirador/UPDATE_WINDOW_POSITION', - SET_WINDOW_SIZE: 'mirador/SET_WINDOW_SIZE', REMOVE_WINDOW: 'mirador/REMOVE_WINDOW', - PICK_WINDOWING_SYSTEM: 'mirador/PICK_WINDOWING_SYSTEM', REQUEST_MANIFEST: 'mirador/REQUEST_MANIFEST', RECEIVE_MANIFEST: 'mirador/RECEIVE_MANIFEST', RECEIVE_MANIFEST_FAILURE: 'mirador/RECEIVE_MANIFEST_FAILURE', REMOVE_ERROR: 'mirador/REMOVE_ERROR', SET_CONFIG: 'mirador/SET_CONFIG', UPDATE_WORKSPACE: 'mirador/UPDATE_WORKSPACE', - SET_WINDOW_THUMBNAIL_POSITION: 'mirador/SET_WINDOW_THUMBNAIL_POSITION', SET_WINDOW_VIEW_TYPE: 'mirador/SET_WINDOW_VIEW_TYPE', SET_WORKSPACE_ADD_VISIBILITY: 'mirador/SET_WORKSPACE_ADD_VISIBILITY', TOGGLE_WINDOW_SIDE_BAR: 'mirador/TOGGLE_WINDOW_SIDE_BAR', @@ -58,8 +52,6 @@ const ActionTypes = { RECEIVE_ACCESS_TOKEN: 'mirador/RECEIVE_ACCESS_TOKEN', RECEIVE_ACCESS_TOKEN_FAILURE: 'mirador/RECEIVE_ACCESS_TOKEN_FAILURE', RESET_AUTHENTICATION_STATE: 'mirador/RESET_AUTHENTICATION_STATE', - CLEAR_ACCESS_TOKEN_QUEUE: 'mirador/CLEAR_ACCESS_TOKEN_QUEUE', - REQUEST_SEARCH: 'mirador/REQUEST_SEARCH', RECEIVE_SEARCH: 'mirador/RECEIVE_SEARCH', RECEIVE_SEARCH_FAILURE: 'mirador/RECEIVE_SEARCH_FAILURE', diff --git a/src/state/reducers/windows.js b/src/state/reducers/windows.js index 16b705c117..5eedb62f7d 100644 --- a/src/state/reducers/windows.js +++ b/src/state/reducers/windows.js @@ -48,26 +48,6 @@ export const windowsReducer = (state = {}, action) => { view: action.viewType, }, }; - case ActionTypes.UPDATE_WINDOW_POSITION: - return { - ...state, - [action.payload.windowId]: { - ...state[action.payload.windowId], - x: action.payload.position.x, - y: action.payload.position.y, - }, - }; - case ActionTypes.SET_WINDOW_SIZE: - return { - ...state, - [action.payload.windowId]: { - ...state[action.payload.windowId], - height: action.payload.size.height, - width: action.payload.size.width, - x: action.payload.size.x, - y: action.payload.size.y, - }, - }; case ActionTypes.SET_CANVAS: if (!state[action.windowId]) return state;