set default values on new registration

Author: Sajaki

CHANGELOG.md

@@ -1,6 +1,9 @@
-
 ### Changelog
 
+
+- 2.2.8 (10/06/2018)
+  - [FIX] #82 RT FIX
+
 - 2.2.7 (25/02/2018) 
   - [NEW] #82 recent topics is now available on a special page http://url/app.php/rt
   - [CHG] now uses phpbb 3.2 language class

README.md

@@ -8,8 +8,6 @@ Based on NV Recent Topics for phpBB 3.0, by Joas Schilling ([nickvergessen](http
 v2.2.7 (25/02/2018)
 [![Build Status](https://api.travis-ci.org/Sajaki/RecentTopics.svg)](https://travis-ci.org/Sajaki/RecentTopics)
 
-- [download](https://www.avathar.be/bbdkp/app.php/dlext/?view=detail&df_id=35)
-
 #### Support
 - [Support forum](https://www.avathar.be/bbdkp/viewforum.php?f=65)
 

config/services.yml

@@ -52,5 +52,6 @@ services:
             - '@template'
             - '@user'
             - '@language'
+            - '@dbal.conn'
         tags:
             - { name: event.listener }

event/ucp_listener.php

@@ -56,6 +56,9 @@ class ucp_listener implements EventSubscriberInterface
 	 */
 	protected $language;
 
+	/* @var \phpbb\db\driver\driver_interface */
+	protected $db;
+
 	/**
 	 * ucp_listener constructor.
 	 *
@@ -65,20 +68,24 @@ class ucp_listener implements EventSubscriberInterface
 	 * @param \phpbb\template\template $template
 	 * @param \phpbb\user              $user
 	 * @param \phpbb\language\language $language
+	 * @param \phpbb\db\driver\driver_interface $db
 	 */
 	public function __construct(\phpbb\auth\auth $auth,
 		\phpbb\config\config $config,
 		\phpbb\request\request $request,
 		\phpbb\template\template $template,
 		\phpbb\user $user,
-		\phpbb\language\language $language)
+		\phpbb\language\language $language,
+		\phpbb\db\driver\driver_interface $db
+	)
 	{
 		$this->auth = $auth;
 		$this->config = $config;
 		$this->request = $request;
 		$this->template = $template;
 		$this->user = $user;
 		$this->language = $language;
+		$this->db = $db;
 	}
 
 	/**
@@ -89,6 +96,7 @@ static public function getSubscribedEvents()
 		return array(
 		'core.ucp_prefs_view_data'        => 'ucp_prefs_get_data',
 		'core.ucp_prefs_view_update_data' => 'ucp_prefs_set_data',
+		'core.ucp_register_data_after'		  => 'ucp_register_set_data'
 		);
 	}
 
@@ -115,6 +123,7 @@ public function ucp_prefs_get_data($event)
 
 			$template_vars = array();
 
+			// if authorised for one of these then set ucp master template variable to true
 			if ($this->auth->acl_get('u_rt_enable') || $this->auth->acl_get('u_rt_location') || $this->auth->acl_get('u_rt_sort_start_time') || $this->auth->acl_get('u_rt_unread_only'))
 			{
 				$template_vars += array(
@@ -199,4 +208,24 @@ public function ucp_prefs_set_data($event)
 			)
 		);
 	}
+
+	/**
+	 * After new user registration, set rt user parameters to default;
+	 * @param $event
+	 */
+	public function ucp_register_set_data($event)
+	{
+		$sql = ' UPDATE ' . USERS_TABLE . ' SET ';
+		$sql .= " user_rt_enable = '" . $this->config['rt_index'] . "' ";
+		$sql .= ", user_rt_sort_start_time = '" . $this->config['rt_sort_start_time'] . "' ";
+		$sql .= ", user_rt_unread_only = '" . $this->config['rt_unread_only'] . "' ";
+		$sql .= ", user_rt_location = '" . $this->config['rt_location'] . "' ";
+		$sql .= ', user_rt_number = ' . ((int) $this->config['rt_number'] > 0 ? (int) $this->config['rt_number'] : 5 ) . ' ';
+		$sql .= ' WHERE 1=1 ';
+		$sql .= ' AND user_id = ' . $this->user->data['user_id'];
+
+		$this->db->sql_query($sql);
+	}
+
+
 }

migrations/release_2_2_7.php

@@ -64,4 +64,4 @@ public function revert_schema()
 			),
 		);
 	}
-}
+}

migrations/release_2_2_8.php

@@ -29,31 +29,18 @@ public function update_data()
 	{
 		return array(
 			array('config.update', array('rt_version', '2.2.8')),
-
+			array('custom', array(array($this, 'fix_rt_number')))
 		);
-	}
-
-	public function update_schema()
-	{
-		return array(
-			'drop_columns'    => array(
-				$this->table_prefix . 'users' => array(
-					'user_rt_number',
-				),
-			),
-
-			'add_columns'    => array(
-				$this->table_prefix . 'users' => array(
-					'user_rt_number'      => array('UINT', $this->config['rt_number']),
-				),
-			),
 
-		);
 	}
 
-	public function revert_schema()
+	/**
+	 * in 2.7 the column was created with a wrong default value so we need to reset it.
+	 */
+	public function fix_rt_number()
 	{
-		//no action needed on uninstall
+		$sql = 'UPDATE ' . $this->table_prefix . 'users' . " SET user_rt_number = '" . ((int) $this->config['rt_number'] > 0 ? (int) $this->config['rt_number'] : 5 ) . "' ";
+		$this->db->sql_query($sql);
 	}
 
 }