Fix failing tests

Author: IhateTrains

ImperatorToCK3.UnitTests/CK3/Characters/CharacterCollectionTests.cs

@@ -273,6 +273,14 @@ public void ImperatorCountriesGoldCanBeDistributedAmongRulerAndVassals() {
 			ruler_term={ character=1000 start_date=440.10.1 }
 		");
 		var country = Country.Parse(countryReader, 589);
+		
+		imperatorWorld.Provinces[1].OwnerCountry = country;
+		imperatorWorld.Provinces[2].OwnerCountry = country;
+		imperatorWorld.Provinces[3].OwnerCountry = country;
+		imperatorWorld.Provinces[4].OwnerCountry = country;
+		imperatorWorld.Provinces[5].OwnerCountry = country;
+		imperatorWorld.Provinces[6].OwnerCountry = country;
+		
 		Assert.Equal(200, country.Currencies.Gold);
 		imperatorWorld.Countries.Add(country);
 		imperatorWorld.Characters.LinkCountries(imperatorWorld.Countries);

ImperatorToCK3.UnitTests/CK3/Titles/LandedTitlesTests.cs

@@ -235,22 +235,33 @@ public void GovernorshipsCanBeRecognizedAsCountyLevel() {
 		var config = new Configuration { ImperatorPath = "TestFiles/LandedTitlesTests/Imperator" };
 		var imperatorWorld = new TestImperatorWorld(config);
 
-		imperatorWorld.Provinces.Add(new Province(1));
-		imperatorWorld.Provinces.Add(new Province(2));
-		imperatorWorld.Provinces.Add(new Province(3));
+		var irProv1 = new Province(1);
+		var irProv2 = new Province(2);
+		var irProv3 = new Province(3);
+		imperatorWorld.Provinces.Add(irProv1);
+		imperatorWorld.Provinces.Add(irProv2);
+		imperatorWorld.Provinces.Add(irProv3);
 
 		var governor = new ImperatorToCK3.Imperator.Characters.Character(25212);
 		imperatorWorld.Characters.Add(governor);
 
 		var countryReader = new BufferedReader("tag=PRY capital=1");
 		var country = Country.Parse(countryReader, 589);
+		irProv1.OwnerCountry = country;
+		irProv2.OwnerCountry = country;
+		irProv3.OwnerCountry = country;
+		country.RegisterProvince(irProv1);
+		country.RegisterProvince(irProv2);
+		country.RegisterProvince(irProv3);
 		imperatorWorld.Countries.Add(country);
 
 		imperatorWorld.Areas.LoadAreas(imperatorWorld.ModFS, imperatorWorld.Provinces);
 		var irRegionMapper = new ImperatorRegionMapper(imperatorWorld.Areas, irMapData);
 		irRegionMapper.LoadRegions(imperatorWorld.ModFS, new ColorFactory());
 		Assert.True(irRegionMapper.RegionNameIsValid("galatia_area"));
 		Assert.True(irRegionMapper.RegionNameIsValid("galatia_region"));
+		Assert.True(irRegionMapper.ProvinceIsInRegion(2, "galatia_region"));
+		Assert.True(irRegionMapper.ProvinceIsInRegion(3, "galatia_region"));
 		var ck3RegionMapper = new CK3RegionMapper();
 
 		var reader = new BufferedReader(
@@ -335,14 +346,14 @@ public void GovernorshipsCanBeRecognizedAsCountyLevel() {
 			title => Assert.Equal("d_IRTOCK3_PRY", title.Id)
 		);
 
-		var provinces = new ProvinceCollection(ck3ModFS);
+		var ck3Provinces = new ProvinceCollection(ck3ModFS);
 		var ck3MapData = new MapData(ck3ModFS);
 		ck3MapData.ProvinceDefinitions.Add(new(1));
 		ck3MapData.ProvinceDefinitions.Add(new(2));
 		ck3MapData.ProvinceDefinitions.Add(new(3));
-		provinces.ImportImperatorProvinces(imperatorWorld, ck3MapData, titles, cultureMapper, religionMapper, provinceMapper, conversionDate, config);
+		ck3Provinces.ImportImperatorProvinces(imperatorWorld, ck3MapData, titles, cultureMapper, religionMapper, provinceMapper, conversionDate, config);
 		// Country 589 is imported as duchy-level title, so its governorship of galatia_region will be county level.
-		titles.ImportImperatorGovernorships(imperatorWorld, provinces, tagTitleMapper, irLocDB, ck3LocDB, config, provinceMapper, definiteFormMapper, irRegionMapper, coaMapper, countyLevelGovernorships);
+		titles.ImportImperatorGovernorships(imperatorWorld, ck3Provinces, tagTitleMapper, irLocDB, ck3LocDB, config, provinceMapper, definiteFormMapper, irRegionMapper, coaMapper, countyLevelGovernorships);
 
 		Assert.Collection(titles,
 			title => Assert.Equal("c_county1", title.Id),

ImperatorToCK3/Configuration.cs

@@ -6,7 +6,6 @@
 using ImperatorToCK3.CommonUtils;
 using System;
 using System.Collections.Generic;
-using System.Globalization;
 using System.IO;
 using System.Linq;
 

ImperatorToCK3/Imperator/Jobs/Governorship.cs

@@ -48,7 +48,7 @@ public int GetIRProvinceCount(ProvinceCollection irProvinces) {
 		int provinceCount = 0;
 		foreach (var province in irProvinces) {
 			if (province.OwnerCountry == Country && Region.ContainsProvince(province.Id)) {
-				provinceCount++;
+				++provinceCount;
 			}
 		}