Compatch for WtWSMS 0.1.8.5 #4588
Annotations
11 warnings
|
Test:
ImperatorToCK3/Outputter/MenAtArmsOutputter.cs#L86
TODO use on_finish instead of on_start, on_start may execute twice according to a CK3 mod coop (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Test:
ImperatorToCK3/Outputter/MenAtArmsOutputter.cs#L85
TODO Use ExecuteConsoleCommands instead of using ExecuteConsoleCommand in a loop (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Test:
ImperatorToCK3/Mappers/Technology/InnovationMapper.cs#L76
TODO ALSO LOG UNMAPPED CK3 MARTIAL AND CIVIC INNOVATIONS (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Test:
ImperatorToCK3/Imperator/Diplomacy/Dependency.cs#L12
TODO use Imperator subject type definitions to determine how the subject should be treated in CK3 (contracts and obligations) (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Test:
ImperatorToCK3/Imperator/Diplomacy/Dependency.cs#L11
TODO don't convert tributaries as vassals (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Test:
ImperatorToCK3/CK3/Titles/LandedTitles.cs#L971
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Test:
ImperatorToCK3/CK3/Titles/LandedTitles.cs#L917
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Test:
ImperatorToCK3/CK3/Localization/CK3LocBlock.cs#L8
TODO add ILocBlock interface that both this and commonItems' LocBlock would implement. (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
|
|
Test:
ImperatorToCK3/CK3/CK3LocDB.cs#L104
TODO add unit test for combining loc from all the sources into one locblock (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
|
|
Setup Dotnet for use with actions
Failed to install dotnet runtime + cli, exit code: 1. cp: cannot create directory '/usr/share/dotnet/host/fxr/10.0.5/': Permission denied
cp: cannot create directory '/usr/share/dotnet/shared/Microsoft.NETCore.App/10.0.5/': Permission denied
dotnet_install: Error: Failed to verify the version of installed `.NET Core Runtime`.
Installation source: https://builds.dotnet.microsoft.com/dotnet/Runtime/10.0.5/dotnet-runtime-10.0.5-linux-x64.tar.gz.
Installation location: /usr/share/dotnet.
Report the bug at https://github.com/dotnet/install-scripts/issues.
dotnet_install: Error: `.NET Core Runtime` with version = 10.0.5 failed to install with an error.
|
Loading