Skip to content

Commit 2fde0aa

Browse files
committed
Fix P-256 curves (Issue #188)
1 parent ef1b571 commit 2fde0aa

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎cups/jwt.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ cupsJWTLoadCredentials(
908908

909909
switch (EC_GROUP_get_curve_name(group))
910910
{
911-
case NID_secp256k1 :
911+
case NID_X9_62_prime256v1 :
912912
crv = "P-256";
913913
break;
914914
case NID_secp384r1 :
@@ -1163,7 +1163,7 @@ cupsJWTMakePrivateKey(cups_jwa_t alg) // I - Signing/encryption algorithm
11631163
BIGNUM *bx, *by; // Public key coordinates
11641164

11651165
if (alg == CUPS_JWA_ES256)
1166-
ec = EC_KEY_new_by_curve_name(NID_secp256k1);
1166+
ec = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
11671167
else if (alg == CUPS_JWA_ES384)
11681168
ec = EC_KEY_new_by_curve_name(NID_secp384r1);
11691169
else
@@ -1817,7 +1817,7 @@ make_ec_key(cups_json_t *jwk, // I - JSON web key
18171817
goto ec_done;
18181818

18191819
if (!strcmp(crv, "P-256"))
1820-
ec = EC_KEY_new_by_curve_name(NID_secp256k1);
1820+
ec = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
18211821
else if (!strcmp(crv, "P-384"))
18221822
ec = EC_KEY_new_by_curve_name(NID_secp384r1);
18231823
else if (!strcmp(crv, "P-521"))

‎cups/tls-openssl.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2305,7 +2305,7 @@ openssl_create_key(
23052305
{
23062306
case CUPS_CREDTYPE_ECDSA_P256_SHA256 :
23072307
algid = EVP_PKEY_EC;
2308-
curveid = NID_secp256k1;
2308+
curveid = NID_X9_62_prime256v1;
23092309
break;
23102310

23112311
case CUPS_CREDTYPE_ECDSA_P384_SHA256 :

0 commit comments

Comments
 (0)