Metadata push fails, still returns 200

[baszoetekouw]

When the exception below occurs on metadata push, the call nontheless returns a status 200 instead of 400-ish. This causes the error to be invisible.

Error

Unable to assemble the pushed metadata: Duplicate SP entity ids are not allowed in MFA list: surf_access_test

Exception chain

BadApiRequestHttpException (code 0)
ConnectionsController.php:129

Unable to assemble the pushed metadata: Duplicate SP entity ids are not allowed in MFA list: surf_access_test

↳ caused by InvalidArgumentException (code 216)
Assert/Assertion.php:2728

Duplicate SP entity ids are not allowed in MFA list: surf_access_test

Stack trace

#0 Assert\Assertion::createException() Assertion.php:1310
#1 Assert\Assertion::keyNotExists() MfaEntityCollection.php:45
#2 MfaEntityCollection::fromMetadataPush() PushMetadataAssembler.php:638
#3 PushMetadataAssembler->assembleMfaEntities() PushMetadataAssembler.php:270
#4 PushMetadataAssembler->assembleIdp() PushMetadataAssembler.php:210
#5 PushMetadataAssembler->assembleConnection() PushMetadataAssembler.php:95
#6 PushMetadataAssembler->assemble() ConnectionsController.php:127
#7 ConnectionsController->pushConnectionsAction() HttpKernel.php:163
#8 HttpKernel->handleRaw() HttpKernel.php:75
#9 HttpKernel->handle() Kernel.php:202
#10 Kernel->handle() index.php:37
#11 {main}