diff --git a/src/libstore/include/nix/store/ssh.hh b/src/libstore/include/nix/store/ssh.hh index df3e4e77cf5..3fed05dba49 100644 --- a/src/libstore/include/nix/store/ssh.hh +++ b/src/libstore/include/nix/store/ssh.hh @@ -40,7 +40,7 @@ private: void addCommonSSHOpts(OsStrings & args); bool isMasterRunning(); -#ifndef _WIN32 // TODO re-enable on Windows, once we can fork. +#ifndef _WIN32 // TODO re-enable on Windows; needs startProcess(), which forks to run a child callback. std::filesystem::path startMaster(); #endif diff --git a/src/libstore/ssh.cc b/src/libstore/ssh.cc index b19d05100a2..624698f6639 100644 --- a/src/libstore/ssh.cc +++ b/src/libstore/ssh.cc @@ -150,8 +150,9 @@ Strings createSSHEnv() std::unique_ptr SSHMaster::startCommand(OsStrings && command, OsStrings && extraSshArgs) { -#ifdef _WIN32 // TODO re-enable on Windows, once we can fork. - throw UnimplementedError("cannot yet SSH on windows because spawning processes is not yet implemented"); +#ifdef _WIN32 // TODO re-enable on Windows; needs startProcess(), which forks to run a child callback. + throw UnimplementedError( + "cannot yet SSH on Windows: this needs startProcess(), which forks to run a child callback"); #else std::filesystem::path socketPath = startMaster(); @@ -229,7 +230,7 @@ std::unique_ptr SSHMaster::startCommand(OsStrings && comm #endif } -#ifndef _WIN32 // TODO re-enable on Windows, once we can fork. +#ifndef _WIN32 // TODO re-enable on Windows; needs startProcess(), which forks to run a child callback. std::filesystem::path SSHMaster::startMaster() {