From e60cf8a4f4b1568b208bd24f2ac6e094c13d08d4 Mon Sep 17 00:00:00 2001 From: Roy Marples Date: Wed, 5 Aug 2026 13:13:20 +0100 Subject: [PATCH 1/3] Add disable build privsep to the build matrix --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 83fee113a..050c8e0a1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -24,6 +24,7 @@ jobs: - --disable-ipv4ll - --disable-ipv6 - --disable-dhcp6 + - --disable-privsep cppflags: - - -DSMALL From 924c17a23f276256857305b3908049c66ea11aac Mon Sep 17 00:00:00 2001 From: Roy Marples Date: Wed, 5 Aug 2026 13:16:37 +0100 Subject: [PATCH 2/3] control: Fix non privsep builds Fixes #688 --- src/control.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/control.c b/src/control.c index 6ed7dd165..8da64533e 100644 --- a/src/control.c +++ b/src/control.c @@ -381,11 +381,12 @@ control_new(struct dhcpcd_ctx *ctx, int fd, unsigned int flags) { struct fd_list *l; size_t cnt; -#ifdef PRIVSEP struct fd_list *n; +#ifdef PRIVSEP unsigned int id; #endif + l = control_find(ctx, fd); if (l != NULL) { l->flags = flags; From d44af1a58286bd7db7fe4f2d9de0dfd3386885d8 Mon Sep 17 00:00:00 2001 From: Roy Marples Date: Wed, 5 Aug 2026 13:18:30 +0100 Subject: [PATCH 3/3] Format --- src/control.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/control.c b/src/control.c index 8da64533e..114435e3e 100644 --- a/src/control.c +++ b/src/control.c @@ -386,7 +386,6 @@ control_new(struct dhcpcd_ctx *ctx, int fd, unsigned int flags) unsigned int id; #endif - l = control_find(ctx, fd); if (l != NULL) { l->flags = flags;