Skip to content

Commit 84ffbc3

Browse files
autumnustLei Sun
andauthored
Ask for compiler baselines in custom GPU kernel reviews (#1255)
Co-authored-by: Lei Sun <leisun@4u8g-tur-0037.aselab.nvidia.com> Signed-off-by: Lei Sun <leisun@4u8g-tur-0037.aselab.nvidia.com>
1 parent a7e57e2 commit 84ffbc3

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

‎.coderabbit.yaml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,16 @@ reviews:
4646
dependencies optional). In `__init__.py`, imports and `__all__`
4747
are intentionally ordered by dependency, not alphabetically — do
4848
not suggest alphabetical sorting there.
49+
- path: 'sdm/_kernels/**'
50+
instructions: >-
51+
For changes introducing or expanding a custom GPU kernel, check
52+
whether the performance evidence includes a practical
53+
compiler-generated or existing-library alternative. If absent,
54+
request a comparison or a concrete explanation of incompatibility.
55+
Check that comparisons preserve workload and numerical requirements
56+
and distinguish startup from prediction latency. Treat this as a
57+
justification question; do not infer performance from source code
58+
alone.
4959
- path: 'test/**/*.py'
5060
instructions: >-
5161
Pytest-based tests. Check that behavior changes in sdm/ have

0 commit comments

Comments
 (0)