Skip to content

Commit d498f68

Browse files
authored
fix: update LLMHtmlExtractCompareV3 response type (#389)
* fix: update LLMHtmlExtractCompareV3 response type * update ut
1 parent 6ebd21f commit d498f68

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

dingo/model/llm/compare/llm_html_extract_compare_v3.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def process_response(cls, response: str) -> EvalDetail:
215215
tmp_type = "EXTRACTION_EQUAL"
216216

217217
result.status = response_model.score != 1
218-
result.label = [f"{tmp_type}.{response_model.name}"]
218+
result.label = [f"{tmp_type}"]
219219
result.reason = [json.dumps(response_json, ensure_ascii=False)]
220220

221221
return result

test/scripts/model/llm/test_llm_html_extract_compare_v3.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def test_score_1_prompt_better(self):
7575
)
7676
result = LLMHtmlExtractCompareV3.process_response(raw)
7777
assert result.metric == "LLMHtmlExtractCompareV3"
78-
assert result.label == ["PROMPT_BETTER.Error_Content_Coverage"]
78+
assert result.label == ["PROMPT_BETTER"]
7979
assert result.status is False
8080
parsed = json.loads(result.reason[0])
8181
assert parsed["score"] == 1
@@ -86,7 +86,7 @@ def test_score_2_content_better(self):
8686
ensure_ascii=False,
8787
)
8888
result = LLMHtmlExtractCompareV3.process_response(raw)
89-
assert result.label == ["CONTENT_BETTER.Error_Formula"]
89+
assert result.label == ["CONTENT_BETTER"]
9090
assert result.status is True
9191

9292
def test_score_0_extraction_equal(self):
@@ -95,7 +95,7 @@ def test_score_0_extraction_equal(self):
9595
ensure_ascii=False,
9696
)
9797
result = LLMHtmlExtractCompareV3.process_response(raw)
98-
assert result.label == ["EXTRACTION_EQUAL.None"]
98+
assert result.label == ["EXTRACTION_EQUAL"]
9999
assert result.status is True
100100

101101
def test_json_fenced_with_markdown(self):
@@ -111,7 +111,7 @@ def test_redacted_thinking_appended_to_reason(self):
111111
'{"score": 2, "name": "Error_Table", "reason": "Brief."}'
112112
)
113113
result = LLMHtmlExtractCompareV3.process_response(body)
114-
assert "CONTENT_BETTER.Error_Table" == result.label[0]
114+
assert "CONTENT_BETTER" == result.label[0]
115115
parsed = json.loads(result.reason[0])
116116
assert "internal" in parsed["reason"]
117117

0 commit comments

Comments
 (0)