chore(6938): migrate settings-search InputAdornment from MUI v4 → v5#41957
Closed
Copilot wants to merge 16 commits into
Closed
chore(6938): migrate settings-search InputAdornment from MUI v4 → v5#41957Copilot wants to merge 16 commits into
Copilot wants to merge 16 commits into
Conversation
Agent-Logs-Url: https://github.com/MetaMask/metamask-extension/sessions/497fc9c3-dfc1-4709-97f9-b58f5063d703 Co-authored-by: MajorLift <34228073+MajorLift@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate settings search InputAdornment from MUI v4 to v5
feat: migrate settings-search InputAdornment from MUI v4 → v5
Apr 20, 2026
Contributor
|
@metamaskbot update-policies |
Collaborator
|
No policy changes |
DDDDDanica
changed the title
…ngs-search-inputadornment-v4-v5
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
github-actions
Bot
added
the
retry-ci
Contributor
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/browserify/beta/policy.json changes differ from lavamoat/browserify/main/policy.json changes |
…ngs-search-inputadornment-v4-v5
Contributor
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (14 files, +277 -277)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Contributor
Builds ready [a033f4c]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
DDDDDanica
added
team-extension-platform
…ngs-search-inputadornment-v4-v5
…webpack MV2 policy
Contributor
Builds ready [f4f7782]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 10 warn · 🔴 0 fail)
Bundle size diffs
|
Contributor
Builds ready [f4f7782]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 10 warn · 🔴 0 fail)
Bundle size diffs
|
Contributor
Builds ready [d42d6ef]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 10 warn · 🔴 0 fail)
Bundle size diffs
|
itsyoboieltr
requested changes
May 12, 2026
| # all @types/* packages are imported implicitly by TypeScript | ||
| - '@types/*' | ||
| # safety fallback for npm lifecycle scripts, not used normally | ||
| - '@lavamoat/preinstall-always-fail' |
Contributor
There was a problem hiding this comment.
Seems to have unrelated changes?
DDDDDanica
force-pushed
the
copilot/migrate-settings-search-inputadornment-v4-v5
branch
from
c445e91 to
a12f73a
Compare
|
Contributor
Builds ready [a12f73a]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
@SocketSecurity ignore-all |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the broader MUI v4 → v5 migration. Updates the single
@material-ui/core/InputAdornmentusage in the settings search component to@mui/material/InputAdornment. TheInputAdornmentAPI is unchanged between versions.Changes
settings-search.js— swap import path:package.json— add@mui/material: "^5.14.0"as a direct dependency (@mui/materialv5.18.0 was already present as a transitive dep; this makes the direct usage explicit)yarn.lock— one-line update to register@mui/materialunder the root workspace metadata (no new resolution required)Note
Medium Risk
Touches multiple generated LavaMoat
policy.jsonfiles, so an incorrect permission mapping could break bundling/runtime module access across browserify/webpack builds. However, changes are narrow and appear limited to dependency path renames forsafe-buffer/content-dispositionplus a singlepackage.jsonresolution tweak.Overview
Updates LavaMoat policies across browserify/webpack (MV2/MV3; beta/experimental/flask/main) to repoint
safe-bufferallowances frommockttp>express>safe-buffertokoa>content-disposition>safe-buffer, including renaming the trackedcontent-dispositionnode in the webpack build policy.Adds a root
package.jsonresolutionsentry forip-address(^10.1.1).Reviewed by Cursor Bugbot for commit a12f73a. Bugbot is set up for automated code reviews on this repo. Configure here.