diff --git a/client/mysqldump.cc b/client/mysqldump.cc index 86cab38d02ead..2faf1073f7498 100644 --- a/client/mysqldump.cc +++ b/client/mysqldump.cc @@ -888,10 +888,10 @@ static void write_footer(FILE *sql_file) } /* write_footer */ -const uchar *get_table_key(const void *entry, size_t *length, my_bool) +const void *get_table_key(const void *entry, size_t *length, my_bool) { *length= strlen(static_cast(entry)); - return static_cast(entry); + return entry; } diff --git a/client/mysqltest.cc b/client/mysqltest.cc index b44d0536ac2fc..257f98e79a6d0 100644 --- a/client/mysqltest.cc +++ b/client/mysqltest.cc @@ -2787,12 +2787,10 @@ static void strip_parentheses(struct st_command *command) C_MODE_START -static const uchar *get_var_key(const void *var, size_t *len, my_bool) +static const void *get_var_key(const void *var, size_t *len, my_bool) { - char* key; - key= (static_cast(var))->name; *len= (static_cast(var))->name_len; - return reinterpret_cast(key); + return (static_cast(var))->name; } diff --git a/extra/mariabackup/xbstream.cc b/extra/mariabackup/xbstream.cc index 23200c19465d3..d8028215779ad 100644 --- a/extra/mariabackup/xbstream.cc +++ b/extra/mariabackup/xbstream.cc @@ -353,12 +353,12 @@ file_entry_new(extract_ctxt_t *ctxt, const char *path, uint pathlen, } static -const uchar * +const void * get_file_entry_key(const void *entry_, size_t *length, my_bool) { const file_entry_t *entry= static_cast(entry_); *length= entry->pathlen; - return reinterpret_cast(entry->path); + return entry->path; } static diff --git a/include/hash.h b/include/hash.h index faea1b4538e7a..7c9a97d22c01f 100644 --- a/include/hash.h +++ b/include/hash.h @@ -42,7 +42,7 @@ extern "C" { #define HASH_THREAD_SPECIFIC 2 /* Mark allocated memory THREAD_SPECIFIC */ typedef uint32 my_hash_value_type; -typedef const uchar *(*my_hash_get_key)(const void *, size_t *, my_bool); +typedef const void *(*my_hash_get_key)(const void *, size_t *, my_bool); typedef my_hash_value_type (*my_hash_function)(CHARSET_INFO *, const uchar *, size_t); typedef void (*my_hash_free_key)(void *); @@ -71,28 +71,28 @@ my_bool my_hash_init2(PSI_memory_key psi_key, HASH *hash, size_t growth_size, void (*free_element)(void*), uint flags); void my_hash_free(HASH *tree); void my_hash_reset(HASH *hash); -uchar *my_hash_element(const HASH *hash, size_t idx); -uchar *my_hash_search(const HASH *info, const uchar *key, size_t length); -uchar *my_hash_search_using_hash_value(const HASH *info, - my_hash_value_type hash_value, - const uchar *key, size_t length); +void *my_hash_element(const HASH *hash, size_t idx); +void *my_hash_search(const HASH *info, const uchar *key, size_t length); +void *my_hash_search_using_hash_value(const HASH *info, + my_hash_value_type hash_value, + const uchar *key, size_t length); my_hash_value_type my_hash_sort(CHARSET_INFO *cs, const uchar *key, size_t length); #define my_calc_hash(A, B, C) my_hash_sort((A)->charset, B, C) -uchar *my_hash_first(const HASH *info, const uchar *key, size_t length, - HASH_SEARCH_STATE *state); -uchar *my_hash_first_from_hash_value(const HASH *info, - my_hash_value_type hash_value, - const uchar *key, - size_t length, - HASH_SEARCH_STATE *state); -uchar *my_hash_next(const HASH *info, const uchar *key, size_t length, +void *my_hash_first(const HASH *info, const uchar *key, size_t length, HASH_SEARCH_STATE *state); -my_bool my_hash_insert(HASH *info, const uchar *data); -my_bool my_hash_delete(HASH *hash, uchar *record); -my_bool my_hash_update(HASH *hash, uchar *record, uchar *old_key, +void *my_hash_first_from_hash_value(const HASH *info, + my_hash_value_type hash_value, + const uchar *key, + size_t length, + HASH_SEARCH_STATE *state); +void *my_hash_next(const HASH *info, const uchar *key, size_t length, + HASH_SEARCH_STATE *state); +my_bool my_hash_insert(HASH *info, const void *data); +my_bool my_hash_delete(HASH *hash, void *record); +my_bool my_hash_update(HASH *hash, void *record, uchar *old_key, size_t old_key_length); -void my_hash_replace(HASH *hash, HASH_SEARCH_STATE *state, uchar *new_row); +void my_hash_replace(HASH *hash, HASH_SEARCH_STATE *state, void *new_row); my_bool my_hash_check(HASH *hash); /* Only in debug library */ my_bool my_hash_iterate(HASH *hash, my_hash_walk_action action, void *argument); diff --git a/mysys/charset.c b/mysys/charset.c index 44aac5666725e..23c899fd2c9ea 100644 --- a/mysys/charset.c +++ b/mysys/charset.c @@ -685,20 +685,20 @@ const char *my_collation_get_tailoring(uint id) } -static const uchar *get_charset_key(const void *object, size_t *size, - my_bool not_used __attribute__((unused))) +static const void *get_charset_key(const void *object, size_t *size, + my_bool not_used __attribute__((unused))) { CHARSET_INFO *cs= object; *size= cs->cs_name.length; - return (const uchar*) cs->cs_name.str; + return cs->cs_name.str; } -static const uchar *get_collation_key(const void *object, size_t *length, - my_bool not_used __attribute__((unused))) +static const void *get_collation_key(const void *object, size_t *length, + my_bool not_used __attribute__((unused))) { CHARSET_INFO *cs= (CHARSET_INFO*) object; *length= cs->coll_name.length; - return (const uchar*) cs->coll_name.str; + return cs->coll_name.str; } static void init_available_charsets(void) diff --git a/mysys/hash.c b/mysys/hash.c index b79580c6b5aba..27dbfd4e35f74 100644 --- a/mysys/hash.c +++ b/mysys/hash.c @@ -32,7 +32,7 @@ typedef struct st_hash_info { uint32 next; /* index to next key */ my_hash_value_type hash_nr; - uchar *data; /* data for current entry */ + void *data; /* data for current entry */ } HASH_LINK; static uint my_hash_mask(my_hash_value_type hashnr, @@ -190,7 +190,7 @@ void my_hash_reset(HASH *hash) */ static inline char* -my_hash_key(const HASH *hash, const uchar *record, size_t *length, +my_hash_key(const HASH *hash, const void *record, size_t *length, my_bool first) { if (hash->get_key) @@ -222,7 +222,7 @@ static #if !defined(__USLC__) && !defined(__sgi) inline #endif -my_hash_value_type rec_hashnr(HASH *hash,const uchar *record) +my_hash_value_type rec_hashnr(HASH *hash, const void *record) { size_t length; uchar *key= (uchar*) my_hash_key(hash, record, &length, 0); @@ -230,16 +230,16 @@ my_hash_value_type rec_hashnr(HASH *hash,const uchar *record) } -uchar* my_hash_search(const HASH *hash, const uchar *key, size_t length) +void* my_hash_search(const HASH *hash, const uchar *key, size_t length) { HASH_SEARCH_STATE state; return my_hash_first(hash, key, length, &state); } -uchar* my_hash_search_using_hash_value(const HASH *hash, - my_hash_value_type hash_value, - const uchar *key, - size_t length) +void* my_hash_search_using_hash_value(const HASH *hash, + my_hash_value_type hash_value, + const uchar *key, + size_t length) { HASH_SEARCH_STATE state; return my_hash_first_from_hash_value(hash, hash_value, @@ -254,10 +254,10 @@ uchar* my_hash_search_using_hash_value(const HASH *hash, Assigns the number of the found record to HASH_SEARCH_STATE state */ -uchar* my_hash_first(const HASH *hash, const uchar *key, size_t length, - HASH_SEARCH_STATE *current_record) +void* my_hash_first(const HASH *hash, const uchar *key, size_t length, + HASH_SEARCH_STATE *current_record) { - uchar *res; + void *res; DBUG_ASSERT(my_hash_inited(hash)); res= my_hash_first_from_hash_value(hash, @@ -269,11 +269,11 @@ uchar* my_hash_first(const HASH *hash, const uchar *key, size_t length, } -uchar* my_hash_first_from_hash_value(const HASH *hash, - my_hash_value_type hash_value, - const uchar *key, - size_t length, - HASH_SEARCH_STATE *current_record) +void* my_hash_first_from_hash_value(const HASH *hash, + my_hash_value_type hash_value, + const uchar *key, + size_t length, + HASH_SEARCH_STATE *current_record) { HASH_LINK *pos; DBUG_ENTER("my_hash_first_from_hash_value"); @@ -310,8 +310,8 @@ uchar* my_hash_first_from_hash_value(const HASH *hash, /* Get next record with identical key */ /* Can only be called if previous calls was my_hash_search */ -uchar* my_hash_next(const HASH *hash, const uchar *key, size_t length, - HASH_SEARCH_STATE *current_record) +void* my_hash_next(const HASH *hash, const uchar *key, size_t length, + HASH_SEARCH_STATE *current_record) { HASH_LINK *pos; uint idx; @@ -391,7 +391,7 @@ static int hashcmp(const HASH *hash, HASH_LINK *pos, const uchar *key, @retval 1 Duplicate key or out of memory */ -my_bool my_hash_insert(HASH *info, const uchar *record) +my_bool my_hash_insert(HASH *info, const void *record) { int flag; size_t idx, halfbuff, first_index; @@ -531,7 +531,7 @@ my_bool my_hash_insert(HASH *info, const uchar *record) movelink(data,(uint) (pos-data),(uint) (gpos-data),(uint) (empty-data)); } } - pos->data= (uchar*) record; + pos->data= (void*) record; pos->hash_nr= current_hash_nr; if (++info->records == info->blength) info->blength+= info->blength; @@ -558,7 +558,7 @@ my_bool my_hash_insert(HASH *info, const uchar *record) @retval 1 Record not found */ -my_bool my_hash_delete(HASH *hash, uchar *record) +my_bool my_hash_delete(HASH *hash, void *record) { uint pos2,idx,empty_index; my_hash_value_type pos_hashnr, lastpos_hashnr; @@ -637,7 +637,7 @@ my_bool my_hash_delete(HASH *hash, uchar *record) exit: (void) pop_dynamic(&hash->array); if (hash->free) - (*hash->free)((uchar*) record); + (*hash->free)(record); DBUG_RETURN(0); } @@ -647,7 +647,7 @@ my_bool my_hash_delete(HASH *hash, uchar *record) This is much more efficient than using a delete & insert. */ -my_bool my_hash_update(HASH *hash, uchar *record, uchar *old_key, +my_bool my_hash_update(HASH *hash, void *record, uchar *old_key, size_t old_key_length) { uint new_index, new_pos_index, org_index, records, idx; @@ -659,11 +659,11 @@ my_bool my_hash_update(HASH *hash, uchar *record, uchar *old_key, new_key= (uchar*) my_hash_key(hash, record, &length, 1); hash_nr= hash->hash_function(hash->charset, new_key, length); - + if (HASH_UNIQUE & hash->flags) { HASH_SEARCH_STATE state; - uchar *found; + void *found; if ((found= my_hash_first_from_hash_value(hash, hash_nr, new_key, length, &state))) @@ -762,7 +762,7 @@ my_bool my_hash_update(HASH *hash, uchar *record, uchar *old_key, } -uchar *my_hash_element(const HASH *hash, size_t idx) +void *my_hash_element(const HASH *hash, size_t idx) { if (idx < hash->records) return dynamic_element(&hash->array,idx,HASH_LINK*)->data; @@ -776,7 +776,7 @@ uchar *my_hash_element(const HASH *hash, size_t idx) */ void my_hash_replace(HASH *hash, HASH_SEARCH_STATE *current_record, - uchar *new_row) + void *new_row) { if (*current_record != NO_RECORD) /* Safety */ dynamic_element(&hash->array, *current_record, HASH_LINK*)->data= new_row; @@ -885,8 +885,8 @@ my_bool my_hash_check(HASH *hash) #define RECORDS 1000 -const uchar *test_get_key(const void *data, size_t *length, - my_bool not_used __attribute__((unused))) +const void *test_get_key(const void *data, size_t *length, + my_bool not_used __attribute__((unused))) { *length= 2; return data; diff --git a/mysys/lf_hash.cc b/mysys/lf_hash.cc index d2f8d9b471a0a..1ac948b0e4423 100644 --- a/mysys/lf_hash.cc +++ b/mysys/lf_hash.cc @@ -309,7 +309,7 @@ static inline const uchar* hash_key(const LF_HASH *hash, const uchar *record, size_t *length) { if (hash->get_key) - return (*hash->get_key)(record, length, 0); + return (const uchar*) (*hash->get_key)(record, length, 0); *length= hash->key_length; return record + hash->key_offset; } diff --git a/mysys/my_likely.c b/mysys/my_likely.c index 0d5463f64b09b..2172542b9b279 100644 --- a/mysys/my_likely.c +++ b/mysys/my_likely.c @@ -35,12 +35,12 @@ typedef struct st_likely_entry ulonglong ok,fail; } LIKELY_ENTRY; -static const uchar *get_likely_key(const void *part_, size_t *length, - my_bool not_used __attribute__((unused))) +static const void *get_likely_key(const void *part_, size_t *length, + my_bool not_used __attribute__((unused))) { const LIKELY_ENTRY *part= (const LIKELY_ENTRY *) part_; *length= part->key_length; - return (const uchar *) part->key; + return part->key; } pthread_mutex_t likely_mutex; diff --git a/mysys/my_safehash.c b/mysys/my_safehash.c index 70ed450e03722..938beb95328e5 100644 --- a/mysys/my_safehash.c +++ b/mysys/my_safehash.c @@ -71,9 +71,9 @@ static void safe_hash_entry_free(void *entry_) # reference on the key */ -static const uchar *safe_hash_entry_get(const void *entry_, size_t *length, - my_bool not_used - __attribute__((unused))) +static const void *safe_hash_entry_get(const void *entry_, size_t *length, + my_bool not_used + __attribute__((unused))) { const SAFE_HASH_ENTRY *entry= entry_; *length= entry->length; diff --git a/plugin/qc_info/qc_info.cc b/plugin/qc_info/qc_info.cc index 52cfaa7a9cacd..48b8a4320f202 100644 --- a/plugin/qc_info/qc_info.cc +++ b/plugin/qc_info/qc_info.cc @@ -137,7 +137,7 @@ static int qc_info_fill_table(THD *thd, TABLE_LIST *tables, /* loop through all queries in the query cache */ for (uint i= 0; i < queries->records; i++) { - const uchar *query_cache_block_raw; + const void *query_cache_block_raw; Query_cache_block* query_cache_block; Query_cache_query* query_cache_query; Query_cache_query_flags flags; diff --git a/sql-common/client.c b/sql-common/client.c index 469bfdc8ae920..e670e3959fe7a 100644 --- a/sql-common/client.c +++ b/sql-common/client.c @@ -3963,13 +3963,13 @@ mysql_options(MYSQL *mysql,enum mysql_option option, const void *arg) /** A function to return the key from a connection attribute */ -const uchar * +const void * get_attr_key(const void *part_, size_t *length, my_bool not_used __attribute__((unused))) { const LEX_STRING *part= part_; *length= part[0].length; - return (const uchar *) part[0].str; + return part[0].str; } int STDCALL diff --git a/sql/debug_sync.cc b/sql/debug_sync.cc index 7345e3cc03d1a..c40c17c39506c 100644 --- a/sql/debug_sync.cc +++ b/sql/debug_sync.cc @@ -103,11 +103,11 @@ struct st_debug_sync_globals } /* Hash key function for ds_signal_set. */ - static const uchar *signal_key(const void *str_, size_t *klen, my_bool) + static const void *signal_key(const void *str_, size_t *klen, my_bool) { const LEX_CSTRING *str= static_cast(str_); *klen= str->length; - return reinterpret_cast(str->str); + return str->str; } /** diff --git a/sql/ha_partition.cc b/sql/ha_partition.cc index 9cc10b16fda5c..26783832e903b 100644 --- a/sql/ha_partition.cc +++ b/sql/ha_partition.cc @@ -3460,7 +3460,7 @@ bool ha_partition::re_create_par_file(const char *name) @return Partition name */ -static const uchar *get_part_name(const void *part_, size_t *length, my_bool) +static const void *get_part_name(const void *part_, size_t *length, my_bool) { auto part= reinterpret_cast(part_); *length= part->length; diff --git a/sql/handler.h b/sql/handler.h index 354e5d6192d6a..93fe5bbecaed8 100644 --- a/sql/handler.h +++ b/sql/handler.h @@ -6137,7 +6137,7 @@ class handler_binlog_xid_info { enum binlog_xid_state xid_state; /* The key function to use for the HASH. */ - static const uchar *get_key(const void *p, size_t *out_len, my_bool) + static const void *get_key(const void *p, size_t *out_len, my_bool) { const XID *xid= &(reinterpret_cast(p)->xid); diff --git a/sql/item_create.cc b/sql/item_create.cc index f2716e643668a..db37c8df56369 100644 --- a/sql/item_create.cc +++ b/sql/item_create.cc @@ -41,12 +41,12 @@ #include -extern "C" const uchar *get_native_fct_hash_key(const void *buff, - size_t *length, my_bool) +extern "C" const void *get_native_fct_hash_key(const void *buff, + size_t *length, my_bool) { auto func= static_cast(buff); *length= func->name.length; - return reinterpret_cast(func->name.str); + return func->name.str; } diff --git a/sql/item_func.cc b/sql/item_func.cc index 594a98b3e3138..027a5acb563da 100644 --- a/sql/item_func.cc +++ b/sql/item_func.cc @@ -4205,7 +4205,7 @@ class User_level_lock /** Extract a hash key from User_level_lock. */ -const uchar *ull_get_key(const void *ptr, size_t *length, my_bool) +const void *ull_get_key(const void *ptr, size_t *length, my_bool) { User_level_lock *ull = (User_level_lock*) ptr; const MDL_key *key = ull->lock->get_key(); diff --git a/sql/item_jsonfunc.cc b/sql/item_jsonfunc.cc index b4ba0bd215c87..212853064f4a9 100644 --- a/sql/item_jsonfunc.cc +++ b/sql/item_jsonfunc.cc @@ -5809,7 +5809,7 @@ bool Item_func_json_array_intersect:: that value to str. At the same time, update the number of times the value appears in the hash table. */ - uchar * found= NULL; + void *found= NULL; if ((found= my_hash_search(items, (const uchar *) new_entry, strlen(new_entry)))) @@ -5817,7 +5817,7 @@ bool Item_func_json_array_intersect:: has_value= true; temp_str.append( (const char*) value_start, value_len); temp_str.append(','); - if (my_hash_delete(items, found) || my_hash_insert(seen, (const uchar *)found)) + if (my_hash_delete(items, found) || my_hash_insert(seen, found)) { free(new_entry); goto error; diff --git a/sql/json_schema.cc b/sql/json_schema.cc index 9aa052ca26185..76f48ee1bc1b3 100644 --- a/sql/json_schema.cc +++ b/sql/json_schema.cc @@ -3018,22 +3018,22 @@ bool create_object_and_handle_keyword(THD *thd, MEM_ROOT *current_mem_root, return je->s.error ? true : false; } -const uchar *get_key_name_for_property(const void *key_name, size_t *length, - my_bool) +const void *get_key_name_for_property(const void *key_name, size_t *length, + my_bool) { auto curr_property= static_cast(key_name); *length= strlen(curr_property->key_name); - return reinterpret_cast(curr_property->key_name); + return curr_property->key_name; } -const uchar *get_key_name_for_func(const void *key_name, size_t *length, - my_bool) +const void *get_key_name_for_func(const void *key_name, size_t *length, + my_bool) { auto curr_keyword= static_cast(key_name); *length= curr_keyword->func_name.length; - return reinterpret_cast(curr_keyword->func_name.str); + return curr_keyword->func_name.str; } bool setup_json_schema_keyword_hash() diff --git a/sql/json_schema.h b/sql/json_schema.h index d3bc1e7c13e43..9c89da96234a6 100644 --- a/sql/json_schema.h +++ b/sql/json_schema.h @@ -880,10 +880,10 @@ bool create_object_and_handle_keyword(THD *thd, MEM_ROOT *current_mem_root, json_engine_t *je, List *keyword_list, List *all_keywords); -const uchar *get_key_name_for_property(const void *key_name, size_t *length, - my_bool); -const uchar *get_key_name_for_func(const void *key_name, size_t *length, - my_bool); +const void *get_key_name_for_property(const void *key_name, size_t *length, + my_bool); +const void *get_key_name_for_func(const void *key_name, size_t *length, + my_bool); enum keyword_flag { diff --git a/sql/json_schema_helper.cc b/sql/json_schema_helper.cc index 2884e2464c4e7..75d8582bbf3a2 100644 --- a/sql/json_schema_helper.cc +++ b/sql/json_schema_helper.cc @@ -51,11 +51,11 @@ bool json_assign_type(uint *curr_type, json_engine_t *je) return false; } -const uchar *get_key_name(const void *key_name_, size_t *length, my_bool) +const void *get_key_name(const void *key_name_, size_t *length, my_bool) { auto key_name= static_cast(key_name_); *length= strlen(key_name); - return reinterpret_cast(key_name); + return key_name; } void json_get_normalized_string(json_engine_t *je, String *res, diff --git a/sql/json_schema_helper.h b/sql/json_schema_helper.h index 50f334a875135..be4d376866f3a 100644 --- a/sql/json_schema_helper.h +++ b/sql/json_schema_helper.h @@ -23,7 +23,7 @@ bool json_key_equals(const char* key, LEX_CSTRING val, int key_len); bool json_assign_type(uint *curr_type, json_engine_t *je); -const uchar *get_key_name(const void *key_name, size_t *length, my_bool); +const void *get_key_name(const void *key_name, size_t *length, my_bool); void json_get_normalized_string(json_engine_t *je, String *res, int *error, MEM_ROOT *current_mem_root, json_engine_t *temp_je, diff --git a/sql/log.cc b/sql/log.cc index f0684d37a3d24..e4fe21fad3c33 100644 --- a/sql/log.cc +++ b/sql/log.cc @@ -12969,7 +12969,7 @@ binlog_recover_hash_free(void *p) } -static const uchar * +static const void * binlog_recover_hash_key(const void *p, size_t *out_len, my_bool) { const XID *xid= &(reinterpret_cast(p)->xid); diff --git a/sql/mdl.cc b/sql/mdl.cc index 2330357f8ad2b..722334c3376b5 100644 --- a/sql/mdl.cc +++ b/sql/mdl.cc @@ -1123,8 +1123,8 @@ class MDL_lock lock->m_strategy= &m_object_lock_strategy; } - static const uchar *mdl_locks_key(const void *record, size_t *length, - my_bool) + static const void *mdl_locks_key(const void *record, size_t *length, + my_bool) { const MDL_lock *lock= static_cast(record); *length= lock->key.length(); diff --git a/sql/opt_trace_ddl_info.cc b/sql/opt_trace_ddl_info.cc index 0151a9929805e..26d915dd81d88 100644 --- a/sql/opt_trace_ddl_info.cc +++ b/sql/opt_trace_ddl_info.cc @@ -43,12 +43,12 @@ struct DDL_Key helper function to know the key portion of the record that is stored in hash. */ -static const uchar *get_rec_key(const void *entry_, size_t *length, - my_bool flags) +static const void *get_rec_key(const void *entry_, size_t *length, + my_bool flags) { auto entry= static_cast(entry_); *length= entry->name_len; - return reinterpret_cast(entry->name); + return entry->name; } /* diff --git a/sql/partition_info.cc b/sql/partition_info.cc index 7666997dc5eca..ee9a16b41f49e 100644 --- a/sql/partition_info.cc +++ b/sql/partition_info.cc @@ -672,11 +672,11 @@ partition_info::get_part_elem(const Lex_ident_partition &partition_name, Helper function to find_duplicate_name. */ -static const uchar *get_part_name_from_elem(const void *name, size_t *length, - my_bool) +static const void *get_part_name_from_elem(const void *name, size_t *length, + my_bool) { *length= strlen(static_cast(name)); - return static_cast(name); + return name; } /* diff --git a/sql/rpl_filter.cc b/sql/rpl_filter.cc index 7186b505e57e5..22ecc83c3fe81 100644 --- a/sql/rpl_filter.cc +++ b/sql/rpl_filter.cc @@ -652,14 +652,14 @@ Rpl_filter::set_ignore_db(const char* db_spec) } -extern "C" const uchar *get_table_key(const void *, size_t *, my_bool); +extern "C" const void *get_table_key(const void *, size_t *, my_bool); extern "C" void free_table_ent(void* a); -const uchar *get_table_key(const void *a, size_t *len, my_bool) +const void *get_table_key(const void *a, size_t *len, my_bool) { auto e= static_cast(a); *len= e->key_len; - return reinterpret_cast(e->db); + return e->db; } diff --git a/sql/rpl_gtid.cc b/sql/rpl_gtid.cc index 0eb48e4b0c2a3..7903f6b636f0f 100644 --- a/sql/rpl_gtid.cc +++ b/sql/rpl_gtid.cc @@ -1140,7 +1140,7 @@ rpl_slave_state::iterate(int (*cb)(rpl_gtid *, void *), void *data, { uint32 i; HASH gtid_hash; - uchar *rec; + void *rec; rpl_gtid *gtid; int res= 1; bool locked= false; @@ -2504,8 +2504,8 @@ int slave_connection_state::update(const rpl_gtid *in_gtid) { entry *e; - uchar *rec= my_hash_search(&hash, (const uchar *)(&in_gtid->domain_id), - sizeof(in_gtid->domain_id)); + void *rec= my_hash_search(&hash, (const uchar *)(&in_gtid->domain_id), + sizeof(in_gtid->domain_id)); if (rec) { e= (entry *)rec; @@ -2530,8 +2530,8 @@ slave_connection_state::update(const rpl_gtid *in_gtid) void slave_connection_state::remove(const rpl_gtid *in_gtid) { - uchar *rec= my_hash_search(&hash, (const uchar *)(&in_gtid->domain_id), - sizeof(in_gtid->domain_id)); + void *rec= my_hash_search(&hash, (const uchar *)(&in_gtid->domain_id), + sizeof(in_gtid->domain_id)); #ifdef DBUG_ASSERT_EXISTS bool err; rpl_gtid *slave_gtid= &((entry *)rec)->gtid; @@ -2548,8 +2548,8 @@ slave_connection_state::remove(const rpl_gtid *in_gtid) void slave_connection_state::remove_if_present(const rpl_gtid *in_gtid) { - uchar *rec= my_hash_search(&hash, (const uchar *)(&in_gtid->domain_id), - sizeof(in_gtid->domain_id)); + void *rec= my_hash_search(&hash, (const uchar *)(&in_gtid->domain_id), + sizeof(in_gtid->domain_id)); if (rec) my_hash_delete(&hash, rec); } diff --git a/sql/rpl_mi.cc b/sql/rpl_mi.cc index ecc666c6ddd30..3e6f55c1f3e35 100644 --- a/sql/rpl_mi.cc +++ b/sql/rpl_mi.cc @@ -495,12 +495,12 @@ void end_master_info(Master_info* mi) } /* Multi-Master By P.Linux */ -const uchar *get_key_master_info(const void *mi_, size_t *length, my_bool) +const void *get_key_master_info(const void *mi_, size_t *length, my_bool) { auto mi= static_cast(mi_); /* Return lower case name */ *length= mi->cmp_connection_name.length; - return reinterpret_cast(mi->cmp_connection_name.str); + return mi->cmp_connection_name.str; } /* diff --git a/sql/rpl_mi.h b/sql/rpl_mi.h index a3e9c553fe83c..1c13cb85b0910 100644 --- a/sql/rpl_mi.h +++ b/sql/rpl_mi.h @@ -455,8 +455,8 @@ void create_logfile_name_with_suffix(char *res_file_name, size_t length, bool append, LEX_CSTRING *suffix); -uchar *get_key_master_info(Master_info *mi, size_t *length, - my_bool not_used __attribute__((unused))); +const void *get_key_master_info(const void *mi, size_t *length, + my_bool not_used __attribute__((unused))); void free_key_master_info(Master_info *mi); uint any_slave_sql_running(bool already_locked); bool give_error_if_slave_running(bool already_lock); diff --git a/sql/rpl_rli.cc b/sql/rpl_rli.cc index e03357acbb12f..38c9f9107c896 100644 --- a/sql/rpl_rli.cc +++ b/sql/rpl_rli.cc @@ -1540,7 +1540,7 @@ scan_one_gtid_slave_pos_table(THD *thd, HASH *hash, DYNAMIC_ARRAY *array, { uint32 domain_id, server_id; uint64 sub_id, seq_no; - uchar *rec; + void *rec; if ((err= table->file->ha_rnd_next(table->record[0]))) { diff --git a/sql/session_tracker.cc b/sql/session_tracker.cc index ac1b91f22edd5..908084a68273f 100644 --- a/sql/session_tracker.cc +++ b/sql/session_tracker.cc @@ -588,13 +588,13 @@ void Session_sysvars_tracker::mark_all_as_changed(THD *thd) @return Pointer to the key buffer. */ -const uchar *Session_sysvars_tracker::sysvars_get_key(const void *entry, - size_t *length, my_bool) +const void *Session_sysvars_tracker::sysvars_get_key(const void *entry, + size_t *length, my_bool) { ptrdiff_t *key= &((static_cast(entry))->m_svar->offset); *length= sizeof(*key); - return reinterpret_cast(key); + return key; } diff --git a/sql/session_tracker.h b/sql/session_tracker.h index 1f0aa9908dee1..efdeac4fa5d7c 100644 --- a/sql/session_tracker.h +++ b/sql/session_tracker.h @@ -214,8 +214,8 @@ class Session_sysvars_tracker: public State_tracker void mark_all_as_changed(THD *thd); void deinit() { orig_list.deinit(); } /* callback */ - static const uchar *sysvars_get_key(const void *entry, size_t *length, - my_bool); + static const void *sysvars_get_key(const void *entry, size_t *length, + my_bool); friend bool sysvartrack_global_update(THD *thd, char *str, size_t len); }; diff --git a/sql/set_var.cc b/sql/set_var.cc index 0f89cf5e1d2ab..f5f16df44dbff 100644 --- a/sql/set_var.cc +++ b/sql/set_var.cc @@ -48,12 +48,12 @@ static ulonglong system_variable_hash_version= 0; Return variable name and length for hashing of variables. */ -static const uchar *get_sys_var_length(const void *var_, size_t *length, - my_bool) +static const void *get_sys_var_length(const void *var_, size_t *length, + my_bool) { auto var= static_cast(var_); *length= var->name.length; - return reinterpret_cast(var->name.str); + return var->name.str; } sys_var_chain all_sys_vars = { NULL, NULL }; diff --git a/sql/sp.cc b/sql/sp.cc index cbaf72b939814..29f041abab2ae 100644 --- a/sql/sp.cc +++ b/sql/sp.cc @@ -2430,7 +2430,7 @@ Sp_handler::sp_exist_routines(THD *thd, TABLE_LIST *routines) const } -extern "C" const uchar *sp_sroutine_key(const void *ptr, size_t *plen, my_bool) +extern "C" const void *sp_sroutine_key(const void *ptr, size_t *plen, my_bool) { auto rn= static_cast(ptr); *plen= rn->mdl_request.key.length(); diff --git a/sql/sp.h b/sql/sp.h index 47f2495db3e26..c4cd5a38c38ee 100644 --- a/sql/sp.h +++ b/sql/sp.h @@ -696,8 +696,8 @@ void sp_update_stmt_used_routines(THD *thd, Query_tables_list *prelocking_ctx, SQL_I_List *src, TABLE_LIST *belong_to_view); -extern "C" const uchar *sp_sroutine_key(const void *ptr, size_t *plen, - my_bool); +extern "C" const void *sp_sroutine_key(const void *ptr, size_t *plen, + my_bool); /* Routines which allow open/lock and close mysql.proc table even when diff --git a/sql/sp_cache.cc b/sql/sp_cache.cc index d802141a2d590..6640f84c6e6ba 100644 --- a/sql/sp_cache.cc +++ b/sql/sp_cache.cc @@ -264,15 +264,15 @@ sp_cache_enforce_limit(sp_cache *c, ulong upper_limit_for_elements) Internal functions *************************************************************************/ -extern "C" const uchar *hash_get_key_for_sp_head(const void *ptr, size_t *plen, - my_bool); +extern "C" const void *hash_get_key_for_sp_head(const void *ptr, size_t *plen, + my_bool); extern "C" void hash_free_sp_head(void *p); -const uchar *hash_get_key_for_sp_head(const void *ptr, size_t *plen, my_bool) +const void *hash_get_key_for_sp_head(const void *ptr, size_t *plen, my_bool) { auto sp= static_cast(ptr); *plen= sp->m_qname.length; - return reinterpret_cast(sp->m_qname.str); + return sp->m_qname.str; } diff --git a/sql/sp_head.cc b/sql/sp_head.cc index 5d52b7f109dac..c1117cb0ba600 100644 --- a/sql/sp_head.cc +++ b/sql/sp_head.cc @@ -97,7 +97,7 @@ void init_sp_psi_keys() #define MYSQL_RUN_SP(SP, CODE) do { CODE; } while(0) #endif -extern "C" const uchar *sp_table_key(const void *ptr, size_t *plen, my_bool); +extern "C" const void *sp_table_key(const void *ptr, size_t *plen, my_bool); /** Helper function which operates on a THD object to set the query start_time to @@ -3537,11 +3537,11 @@ typedef struct st_sp_table } SP_TABLE; -const uchar *sp_table_key(const void *ptr, size_t *plen, my_bool) +const void *sp_table_key(const void *ptr, size_t *plen, my_bool) { auto tab= static_cast(ptr); *plen= tab->qname.length; - return reinterpret_cast(tab->qname.str); + return tab->qname.str; } diff --git a/sql/sql_acl.cc b/sql/sql_acl.cc index 0a271dab40efb..50ac1a22ee91a 100644 --- a/sql/sql_acl.cc +++ b/sql/sql_acl.cc @@ -581,20 +581,20 @@ class acl_entry :public hash_filo_element }; -static const uchar *acl_entry_get_key(const void *entry_, size_t *length, - my_bool) +static const void *acl_entry_get_key(const void *entry_, size_t *length, + my_bool) { auto entry= static_cast(entry_); *length=(uint) entry->length; - return reinterpret_cast(entry->key); + return entry->key; } -static const uchar *acl_role_get_key(const void *entry_, size_t *length, - my_bool) +static const void *acl_role_get_key(const void *entry_, size_t *length, + my_bool) { auto entry= static_cast(entry_); *length=(uint) entry->user.length; - return reinterpret_cast(entry->user.str); + return entry->user.str; } struct ROLE_GRANT_PAIR : public Sql_alloc @@ -612,12 +612,12 @@ struct ROLE_GRANT_PAIR : public Sql_alloc bool with_admin_option); }; -static const uchar *acl_role_map_get_key(const void *entry_, size_t *length, - my_bool) +static const void *acl_role_map_get_key(const void *entry_, size_t *length, + my_bool) { auto entry= static_cast(entry_); *length=(uint) entry->hashkey.length; - return reinterpret_cast(entry->hashkey.str); + return entry->hashkey.str; } bool ROLE_GRANT_PAIR::init(MEM_ROOT *mem, @@ -3591,11 +3591,11 @@ int acl_setrole(THD *thd, const LEX_CSTRING &rolename, privilege_t access) return 0; } -static const uchar *check_get_key(const void *buff_, size_t *length, my_bool) +static const void *check_get_key(const void *buff_, size_t *length, my_bool) { auto buff= static_cast(buff_); *length=buff->hostname_length; - return reinterpret_cast(buff->host.hostname); + return buff->host.hostname; } @@ -5566,12 +5566,12 @@ class GRANT_COLUMN :public Sql_alloc }; -static const uchar *get_key_column(const void *buff_, size_t *length, my_bool) +static const void *get_key_column(const void *buff_, size_t *length, my_bool) { auto buff= static_cast(buff_); *length=buff->key_length; - return reinterpret_cast(buff->column); + return buff->column; } class GRANT_NAME :public Sql_alloc @@ -5809,11 +5809,11 @@ GRANT_TABLE::~GRANT_TABLE() } -static const uchar *get_grant_table(const void *buff_, size_t *length, my_bool) +static const void *get_grant_table(const void *buff_, size_t *length, my_bool) { auto buff= static_cast(buff_); *length=buff->key_length; - return reinterpret_cast(buff->hash_key); + return buff->hash_key; } @@ -6739,11 +6739,11 @@ static int traverse_role_graph_down(ACL_USER_BASE *user, void *context, entries using the role hash. We put all these "interesting" entries in a (suposedly small) dynamic array and them use it for merging. */ -static const uchar *role_key(const void *role_, size_t *klen, my_bool) +static const void *role_key(const void *role_, size_t *klen, my_bool) { auto role= static_cast(role_); *klen= role->user.length; - return reinterpret_cast(role->user.str); + return role->user.str; } typedef Hash_set role_hash_t; diff --git a/sql/sql_cache.cc b/sql/sql_cache.cc index 9d36606009d62..6e6c12fc5f0a7 100644 --- a/sql/sql_cache.cc +++ b/sql/sql_cache.cc @@ -892,14 +892,13 @@ Query_cache_block_table * Query_cache_block::table(TABLE_COUNTER_TYPE n) extern "C" { -const uchar *query_cache_table_get_key(const void *record, size_t *length, - my_bool) +const void *query_cache_table_get_key(const void *record, size_t *length, + my_bool) { auto table_block= static_cast(record); *length= (table_block->used - table_block->headers_len() - ALIGN_SIZE(sizeof(Query_cache_table))); - return reinterpret_cast( - ((table_block->data()) + ALIGN_SIZE(sizeof(Query_cache_table)))); + return (table_block->data()) + ALIGN_SIZE(sizeof(Query_cache_table)); } } @@ -990,14 +989,13 @@ void Query_cache_query::unlock_n_destroy() extern "C" { -const uchar *query_cache_query_get_key(const void *record, size_t *length, - my_bool) +const void *query_cache_query_get_key(const void *record, size_t *length, + my_bool) { auto query_block= static_cast(record); *length= (query_block->used - query_block->headers_len() - ALIGN_SIZE(sizeof(Query_cache_query))); - return reinterpret_cast - (((query_block->data()) + ALIGN_SIZE(sizeof(Query_cache_query)))); + return (query_block->data()) + ALIGN_SIZE(sizeof(Query_cache_query)); } } @@ -4331,9 +4329,9 @@ my_bool Query_cache::move_by_type(uchar **border, *new_block =(Query_cache_block *) *border; size_t tablename_offset = block->table()->table() - block->table()->db(); char *data = (char*) block->data(); - const uchar *key; size_t key_length; - key=query_cache_table_get_key( block, &key_length, 0); + const uchar *key= (const uchar *) + query_cache_table_get_key( block, &key_length, 0); my_hash_first(&tables, key, key_length, &record_idx); block->destroy(); @@ -4392,9 +4390,9 @@ my_bool Query_cache::move_by_type(uchar **border, char *data = (char*) block->data(); Query_cache_block *first_result_block = ((Query_cache_query *) block->data())->result(); - const uchar *key; size_t key_length; - key=query_cache_query_get_key( block, &key_length, 0); + const uchar *key= (const uchar *) + query_cache_query_get_key( block, &key_length, 0); my_hash_first(&queries, key, key_length, &record_idx); block->query()->unlock_n_destroy(); block->destroy(); @@ -5066,9 +5064,9 @@ my_bool Query_cache::check_integrity(bool locked) DBUG_PRINT("qcache", ("block %p, type %u...", block, (uint) block->type)); size_t length; - const uchar *key= query_cache_query_get_key(block, &length, 0); - uchar* val = my_hash_search(&queries, key, length); - if ((reinterpret_cast(block)) != val) + const uchar *key= (const uchar*) query_cache_query_get_key(block, &length, 0); + void* val = my_hash_search(&queries, key, length); + if ((reinterpret_cast(block)) != val) { DBUG_PRINT("error", ("block %p found in queries hash like %p", block, val)); @@ -5101,9 +5099,9 @@ my_bool Query_cache::check_integrity(bool locked) DBUG_PRINT("qcache", ("block %p, type %u...", block, (uint) block->type)); size_t length; - const uchar *key= query_cache_table_get_key(block, &length, 0); - uchar* val = my_hash_search(&tables, key, length); - if (reinterpret_cast(block) != val) + const uchar *key= (const uchar*) query_cache_table_get_key(block, &length, 0); + void* val = my_hash_search(&tables, key, length); + if (reinterpret_cast(block) != val) { DBUG_PRINT("error", ("block %p found in tables hash like %p", block, val)); diff --git a/sql/sql_cache.h b/sql/sql_cache.h index 822a6e5ed25f7..f7935e8945be5 100644 --- a/sql/sql_cache.h +++ b/sql/sql_cache.h @@ -256,10 +256,10 @@ struct Query_cache_result extern "C" { - const uchar *query_cache_query_get_key(const void *record, size_t *length, - my_bool); - const uchar *query_cache_table_get_key(const void *record, size_t *length, - my_bool); + const void *query_cache_query_get_key(const void *record, size_t *length, + my_bool); + const void *query_cache_table_get_key(const void *record, size_t *length, + my_bool); } extern "C" void query_cache_invalidate_by_MyISAM_filename(const char* filename); diff --git a/sql/sql_class.cc b/sql/sql_class.cc index 3856a1d4ed736..1a663ca338db5 100644 --- a/sql/sql_class.cc +++ b/sql/sql_class.cc @@ -85,12 +85,12 @@ char empty_c_string[1]= {0}; /* used for not defined db */ ** User variables ****************************************************************************/ -extern "C" const uchar *get_var_key(const void *entry_, size_t *length, - my_bool) +extern "C" const void *get_var_key(const void *entry_, size_t *length, + my_bool) { const user_var_entry *entry= static_cast(entry_); *length= entry->name.length; - return reinterpret_cast(entry->name.str); + return entry->name.str; } extern "C" void free_user_var(void *entry_) @@ -104,8 +104,8 @@ extern "C" void free_user_var(void *entry_) /* Functions for last-value-from-sequence hash */ -extern "C" const uchar *get_sequence_last_key(const void *entry_, - size_t *length, my_bool) +extern "C" const void *get_sequence_last_key(const void *entry_, + size_t *length, my_bool) { const SEQUENCE_LAST_VALUE *entry= static_cast(entry_); *length= entry->length; @@ -4508,12 +4508,12 @@ Statement::~Statement() = default; C_MODE_START -static const uchar *get_statement_id_as_hash_key(const void *record, - size_t *key_length, my_bool) +static const void *get_statement_id_as_hash_key(const void *record, + size_t *key_length, my_bool) { const Statement *statement= static_cast(record); *key_length= sizeof(statement->id); - return reinterpret_cast(&(statement)->id); + return &(statement)->id; } static void delete_statement_as_hash_key(void *key) @@ -4521,12 +4521,12 @@ static void delete_statement_as_hash_key(void *key) delete (Statement *) key; } -static const uchar *get_stmt_name_hash_key(const void *entry_, size_t *length, - my_bool) +static const void *get_stmt_name_hash_key(const void *entry_, size_t *length, + my_bool) { const Statement *entry= static_cast(entry_); *length= entry->name.length; - return reinterpret_cast(entry->name.str); + return entry->name.str; } C_MODE_END diff --git a/sql/sql_connect.cc b/sql/sql_connect.cc index 2617c7de40b3b..fc0a6680827fc 100644 --- a/sql/sql_connect.cc +++ b/sql/sql_connect.cc @@ -305,12 +305,12 @@ bool check_mqh(THD *thd, uint check_command) started with corresponding variable that is greater then 0. */ -extern "C" const uchar *get_key_conn(const void *buff_, size_t *length, - my_bool) +extern "C" const void *get_key_conn(const void *buff_, size_t *length, + my_bool) { auto buff= static_cast(buff_); *length= buff->len; - return reinterpret_cast(buff->user); + return buff->user; } @@ -398,12 +398,12 @@ static const char *get_client_host(THD *client) client->security_ctx->host ? client->security_ctx->host : ""; } -extern "C" const uchar *get_key_user_stats(const void *user_stats_, - size_t *length, my_bool) +extern "C" const void *get_key_user_stats(const void *user_stats_, + size_t *length, my_bool) { auto user_stats= static_cast(user_stats_); *length= user_stats->user_name_length; - return reinterpret_cast(user_stats->user); + return user_stats->user; } void init_user_stats(USER_STATS *user_stats, @@ -481,12 +481,12 @@ void init_global_client_stats(void) 0, 0, get_key_user_stats, my_free, 0); } -extern "C" const uchar *get_key_table_stats(const void *table_stats_, - size_t *length, my_bool) +extern "C" const void *get_key_table_stats(const void *table_stats_, + size_t *length, my_bool) { auto table_stats= static_cast(table_stats_); *length= table_stats->table_name_length; - return reinterpret_cast(table_stats->table); + return table_stats->table; } void init_global_table_stats(void) @@ -496,12 +496,12 @@ void init_global_table_stats(void) get_key_table_stats, my_free, 0); } -extern "C" const uchar *get_key_index_stats(const void *index_stats_, - size_t *length, my_bool) +extern "C" const void *get_key_index_stats(const void *index_stats_, + size_t *length, my_bool) { auto index_stats= static_cast(index_stats_); *length= index_stats->index_name_length; - return reinterpret_cast(index_stats->index); + return index_stats->index; } void init_global_index_stats(void) diff --git a/sql/sql_db.cc b/sql/sql_db.cc index a1b7d093d6db5..093a5e618ed00 100644 --- a/sql/sql_db.cc +++ b/sql/sql_db.cc @@ -142,11 +142,11 @@ struct dbname_cache_t Hash_set m_set; mysql_rwlock_t m_lock; - static const uchar *get_key(const void *ls_, size_t *sz, my_bool) + static const void *get_key(const void *ls_, size_t *sz, my_bool) { const LEX_STRING *ls= static_cast(ls_); *sz= ls->length; - return reinterpret_cast(ls->str); + return ls->str; } public: @@ -236,14 +236,14 @@ static int my_rmdir(const char *dir) Function we use in the creation of our hash to get key. */ -extern "C" const uchar *dboptions_get_key(const void *opt, size_t *length, - my_bool); +extern "C" const void *dboptions_get_key(const void *opt, size_t *length, + my_bool); -const uchar *dboptions_get_key(const void *opt_, size_t *length, my_bool) +const void *dboptions_get_key(const void *opt_, size_t *length, my_bool) { auto opt= static_cast(opt_); *length= opt->name_length; - return reinterpret_cast(opt->name); + return opt->name; } diff --git a/sql/sql_handler.cc b/sql/sql_handler.cc index c5131e529f9e9..6737460d0435c 100644 --- a/sql/sql_handler.cc +++ b/sql/sql_handler.cc @@ -108,12 +108,12 @@ SQL_HANDLER::~SQL_HANDLER() Pointer to the TABLE_LIST struct. */ -static const uchar *mysql_ha_hash_get_key(const void *table_, size_t *key_len, - my_bool) +static const void *mysql_ha_hash_get_key(const void *table_, size_t *key_len, + my_bool) { auto table= static_cast(table_); *key_len= table->handler_name.length + 1 ; /* include '\0' in comparisons */ - return reinterpret_cast(table->handler_name.str); + return table->handler_name.str; } diff --git a/sql/sql_hset.h b/sql/sql_hset.h index b9a6f2d13c4c5..763c8cc3d3809 100644 --- a/sql/sql_hset.h +++ b/sql/sql_hset.h @@ -32,7 +32,7 @@ class Hash_set Constructs an empty unique hash. */ Hash_set(PSI_memory_key psi_key, - const uchar *(*K)(const void *, size_t *, my_bool), + const void *(*K)(const void *, size_t *, my_bool), CHARSET_INFO *cs= &my_charset_bin) { my_hash_init(psi_key, &m_hash, cs, START_SIZE, 0, 0, K, 0, HASH_UNIQUE); @@ -80,8 +80,7 @@ class Hash_set { DBUG_ASSERT(m_hash.get_key); size_t klen; - const uchar *key= m_hash.get_key(reinterpret_cast(other), - &klen, false); + const void *key= m_hash.get_key(other, &klen, false); return find(key, klen); } /** Is this hash set empty? */ diff --git a/sql/sql_plugin.cc b/sql/sql_plugin.cc index 2d04676cad754..82f4904b8d661 100644 --- a/sql/sql_plugin.cc +++ b/sql/sql_plugin.cc @@ -1520,23 +1520,23 @@ static int plugin_initialize(MEM_ROOT *tmp_root, struct st_plugin_int *plugin, } -extern "C" const uchar *get_plugin_hash_key(const void *, size_t *, my_bool); -extern "C" const uchar *get_bookmark_hash_key(const void *, size_t *, my_bool); +extern "C" const void *get_plugin_hash_key(const void *, size_t *, my_bool); +extern "C" const void *get_bookmark_hash_key(const void *, size_t *, my_bool); -const uchar *get_plugin_hash_key(const void *buff, size_t *length, my_bool) +const void *get_plugin_hash_key(const void *buff, size_t *length, my_bool) { auto plugin= static_cast(buff); *length= plugin->name.length; - return reinterpret_cast(plugin->name.str); + return plugin->name.str; } -const uchar *get_bookmark_hash_key(const void *buff, size_t *length, my_bool) +const void *get_bookmark_hash_key(const void *buff, size_t *length, my_bool) { auto var= static_cast(buff); *length= var->name_len + 1; - return reinterpret_cast(var->key); + return var->key; } #ifdef HAVE_PSI_INTERFACE diff --git a/sql/sql_servers.cc b/sql/sql_servers.cc index 2d40208c3f1df..8532e6c1195f1 100644 --- a/sql/sql_servers.cc +++ b/sql/sql_servers.cc @@ -87,8 +87,8 @@ static int update_server_record_in_cache(FOREIGN_SERVER *existing, /* utility functions */ static void merge_server_struct(FOREIGN_SERVER *from, FOREIGN_SERVER *to); -static const uchar *servers_cache_get_key(const void *server_, size_t *length, - my_bool) +static const void *servers_cache_get_key(const void *server_, size_t *length, + my_bool) { auto server= static_cast(server_); DBUG_ENTER("servers_cache_get_key"); @@ -97,7 +97,7 @@ static const uchar *servers_cache_get_key(const void *server_, size_t *length, server->server_name)); *length= server->server_name_length; - DBUG_RETURN(reinterpret_cast(server->server_name)); + DBUG_RETURN(server->server_name); } static PSI_memory_key key_memory_servers; diff --git a/sql/sql_show.cc b/sql/sql_show.cc index b85156a0f06f3..d4fbd413af34f 100644 --- a/sql/sql_show.cc +++ b/sql/sql_show.cc @@ -677,13 +677,13 @@ ignore_db_dirs_init() @return a pointer to the key */ -static const uchar *db_dirs_hash_get_key(const void *data, size_t *len_ret, - my_bool) +static const void *db_dirs_hash_get_key(const void *data, size_t *len_ret, + my_bool) { auto e= static_cast(data); *len_ret= e->length; - return reinterpret_cast(e->str); + return e->str; } diff --git a/sql/sql_udf.cc b/sql/sql_udf.cc index 70951d456ddfe..0b76a85ba786e 100644 --- a/sql/sql_udf.cc +++ b/sql/sql_udf.cc @@ -100,11 +100,11 @@ static const char *init_syms(udf_func *tmp, char *nm) } -extern "C" const uchar *get_hash_key(const void *buff, size_t *length, my_bool) +extern "C" const void *get_hash_key(const void *buff, size_t *length, my_bool) { auto udf= static_cast(buff); *length= udf->name.length; - return reinterpret_cast(udf->name.str); + return udf->name.str; } static PSI_memory_key key_memory_udf_mem; diff --git a/sql/table.cc b/sql/table.cc index e150bd238392c..46f3e403febdc 100644 --- a/sql/table.cc +++ b/sql/table.cc @@ -264,11 +264,11 @@ View_creation_ctx * View_creation_ctx::create(THD *thd, /* Get column name from column hash */ -static const uchar *get_field_name(const void *buff_, size_t *length, my_bool) +static const void *get_field_name(const void *buff_, size_t *length, my_bool) { auto buff= static_cast(buff_); *length= (*buff)->field_name.length; - return reinterpret_cast((*buff)->field_name.str); + return (*buff)->field_name.str; } diff --git a/sql/table_cache.cc b/sql/table_cache.cc index d2a95d90178d9..705d22b8aa098 100644 --- a/sql/table_cache.cc +++ b/sql/table_cache.cc @@ -588,11 +588,11 @@ static void tdc_hash_initializer(LF_HASH *, } -static const uchar *tdc_hash_key(const void *element_, size_t *length, my_bool) +static const void *tdc_hash_key(const void *element_, size_t *length, my_bool) { auto element= static_cast(element_); *length= element->m_key_length; - return reinterpret_cast(element->m_key); + return element->m_key; } @@ -1142,12 +1142,12 @@ struct eliminate_duplicates_arg }; -static const uchar *eliminate_duplicates_get_key(const void *element, - size_t *length, my_bool) +static const void *eliminate_duplicates_get_key(const void *element, + size_t *length, my_bool) { auto key= static_cast(element); *length= key->length; - return reinterpret_cast(key->str); + return key->str; } diff --git a/sql/tztime.cc b/sql/tztime.cc index e8a60f92c54df..2259514c3a9ce 100644 --- a/sql/tztime.cc +++ b/sql/tztime.cc @@ -1529,20 +1529,20 @@ class Tz_names_entry: public Sql_alloc they should obey C calling conventions. */ -static const uchar *my_tz_names_get_key(const void *entry_, size_t *length, - my_bool) +static const void *my_tz_names_get_key(const void *entry_, size_t *length, + my_bool) { auto entry= static_cast(entry_); *length= entry->name.length(); - return reinterpret_cast(entry->name.ptr()); + return entry->name.ptr(); } -static const uchar *my_offset_tzs_get_key(const void *entry_, - size_t *length, my_bool) +static const void *my_offset_tzs_get_key(const void *entry_, + size_t *length, my_bool) { auto entry= static_cast(entry_); *length= sizeof(long); - return reinterpret_cast(&entry->offset); + return &entry->offset; } diff --git a/sql/vector_mhnsw.cc b/sql/vector_mhnsw.cc index c480c36c7e7ad..4c1ae294383bf 100644 --- a/sql/vector_mhnsw.cc +++ b/sql/vector_mhnsw.cc @@ -456,7 +456,7 @@ class FVectorNode uchar *tref() const; void push_neighbor(size_t layer, FVectorNode *v); - static const uchar *get_key(const void *elem, size_t *key_len, my_bool); + static const void *get_key(const void *elem, size_t *key_len, my_bool); }; #pragma pack(pop) @@ -1052,7 +1052,7 @@ size_t FVectorNode::gref_len() const { return ctx->gref_len; } uchar *FVectorNode::gref() const { return (uchar*)(this+1); } uchar *FVectorNode::tref() const { return gref() + gref_len(); } -const uchar *FVectorNode::get_key(const void *elem, size_t *key_len, my_bool) +const void *FVectorNode::get_key(const void *elem, size_t *key_len, my_bool) { *key_len= static_cast(elem)->gref_len(); return static_cast(elem)->gref(); diff --git a/sql/xa.cc b/sql/xa.cc index 2712516f1462d..98431f5420d12 100644 --- a/sql/xa.cc +++ b/sql/xa.cc @@ -148,7 +148,7 @@ class XID_cache_element DBUG_ASSERT(!reinterpret_cast(ptr + LF_HASH_OVERHEAD) ->is_set(ACQUIRED)); } - static const uchar *key(const void *el, size_t *length, my_bool) + static const void *key(const void *el, size_t *length, my_bool) { const XID &xid= reinterpret_cast(el)->xid; *length= xid.key_length(); diff --git a/storage/blackhole/ha_blackhole.cc b/storage/blackhole/ha_blackhole.cc index f2191e48f35c7..a948c8d60e34f 100644 --- a/storage/blackhole/ha_blackhole.cc +++ b/storage/blackhole/ha_blackhole.cc @@ -354,12 +354,12 @@ static void blackhole_free_key(void *share) my_free(share); } -static const uchar *blackhole_get_key(const void *share_, size_t *length, - my_bool) +static const void *blackhole_get_key(const void *share_, size_t *length, + my_bool) { auto share= static_cast(share_); *length= share->table_name_length; - return reinterpret_cast(share->table_name); + return share->table_name; } #ifdef HAVE_PSI_INTERFACE diff --git a/storage/csv/ha_tina.cc b/storage/csv/ha_tina.cc index 221fbe3f6fd1f..aeb3e12a013ae 100644 --- a/storage/csv/ha_tina.cc +++ b/storage/csv/ha_tina.cc @@ -107,11 +107,11 @@ int sort_set (const void *a_, const void *b_) return ( a->begin > b->begin ? 1 : ( a->begin < b->begin ? -1 : 0 ) ); } -static const uchar *tina_get_key(const void *share_, size_t *length, my_bool) +static const void *tina_get_key(const void *share_, size_t *length, my_bool) { const TINA_SHARE *share= static_cast(share_); *length=share->table_name_length; - return reinterpret_cast(share->table_name); + return share->table_name; } static PSI_memory_key csv_key_memory_tina_share; diff --git a/storage/federated/ha_federated.cc b/storage/federated/ha_federated.cc index d199397c3b4e1..7fba4a3503165 100644 --- a/storage/federated/ha_federated.cc +++ b/storage/federated/ha_federated.cc @@ -428,12 +428,12 @@ static handler *federated_create_handler(handlerton *hton, /* Function we use in the creation of our hash to get key */ -static const uchar *federated_get_key(const void *share_, size_t *length, - my_bool) +static const void *federated_get_key(const void *share_, size_t *length, + my_bool) { auto share= static_cast(share_); *length= share->share_key_length; - return reinterpret_cast(share->share_key); + return share->share_key; } #ifdef HAVE_PSI_INTERFACE diff --git a/storage/federatedx/ha_federatedx.cc b/storage/federatedx/ha_federatedx.cc index ff0ca86abb733..e142d13228354 100644 --- a/storage/federatedx/ha_federatedx.cc +++ b/storage/federatedx/ha_federatedx.cc @@ -359,20 +359,20 @@ static handler *federatedx_create_handler(handlerton *hton, /* Function we use in the creation of our hash to get key */ -static const uchar *federatedx_share_get_key(const void *share_, - size_t *length, my_bool) +static const void *federatedx_share_get_key(const void *share_, + size_t *length, my_bool) { auto share= static_cast(share_); *length= share->share_key_length; - return reinterpret_cast(share->share_key); + return share->share_key; } -static const uchar *federatedx_server_get_key(const void *server_, - size_t *length, my_bool) +static const void *federatedx_server_get_key(const void *server_, + size_t *length, my_bool) { auto server= static_cast(server_); *length= server->key_length; - return reinterpret_cast(server->key); + return server->key; } #ifdef HAVE_PSI_INTERFACE diff --git a/storage/innobase/handler/innodb_binlog.cc b/storage/innobase/handler/innodb_binlog.cc index 667768941a022..b994300afaecf 100644 --- a/storage/innobase/handler/innodb_binlog.cc +++ b/storage/innobase/handler/innodb_binlog.cc @@ -2558,8 +2558,8 @@ ibb_recv_record_update(HASH *hash, ibb_binlog_xid_info *info, uint64_t file_no) { /* Delete any existing entry for this XID before inserting the newer one. */ size_t key_len= 0; - const uchar *key_ptr= info->get_key(info, &key_len, 1); - uchar *rec= my_hash_search(hash, key_ptr, key_len); + const uchar *key_ptr= (const uchar *) info->get_key(info, &key_len, 1); + void *rec= my_hash_search(hash, key_ptr, key_len); if (rec != nullptr) my_hash_delete(hash, rec); if (my_hash_insert(hash, (const uchar *)info)) @@ -4258,9 +4258,9 @@ pending_lsn_fifo::add_to_fifo(uint64_t lsn, uint64_t file_no, uint64_t offset) } -static const uchar *get_xid_hash_key(const void *p, size_t *out_len, my_bool) +static const void *get_xid_hash_key(const void *p, size_t *out_len, my_bool) { - const XID *xid= &(reinterpret_cast(p)->xid); + const XID *xid= &(static_cast(p)->xid); *out_len= xid->key_length(); return xid->key(); } @@ -4347,14 +4347,14 @@ template bool ibb_xid_hash::run_on_xid(const XID *xid, F callback) { size_t key_len= 0; - const uchar *key_ptr= get_xid_hash_key(xid, &key_len, 1); + const uchar *key_ptr= (const uchar*) get_xid_hash_key(xid, &key_len, 1); bool err; mysql_mutex_lock(&xid_mutex); - uchar *rec= my_hash_search(&xid_hash, key_ptr, key_len); + void *rec= my_hash_search(&xid_hash, key_ptr, key_len); if (UNIV_LIKELY(rec != nullptr)) { - err= callback(reinterpret_cast(rec)); + err= callback(static_cast(rec)); } else err= true; @@ -4372,12 +4372,12 @@ ibb_xid_hash::grab_xid(const XID *xid) { xid_elem *e= nullptr; size_t key_len= 0; - const uchar *key_ptr= get_xid_hash_key(xid, &key_len, 1); + const uchar *key_ptr= (const uchar*) get_xid_hash_key(xid, &key_len, 1); mysql_mutex_lock(&xid_mutex); - uchar *rec= my_hash_search(&xid_hash, key_ptr, key_len); + void *rec= my_hash_search(&xid_hash, key_ptr, key_len); if (UNIV_LIKELY(rec != nullptr)) { - e= reinterpret_cast(rec); + e= static_cast(rec); my_hash_delete(&xid_hash, rec); } mysql_mutex_unlock(&xid_mutex); diff --git a/storage/maria/aria_read_log.c b/storage/maria/aria_read_log.c index 7a0849b54b4ae..b8469782adcdd 100644 --- a/storage/maria/aria_read_log.c +++ b/storage/maria/aria_read_log.c @@ -341,8 +341,8 @@ static void usage(void) } -static const uchar *my_hash_get_string(const void *record_, size_t *length, - my_bool first __attribute__((unused))) +static const void *my_hash_get_string(const void *record_, size_t *length, + my_bool first __attribute__((unused))) { const char *record= record_; *length= (strcend(record, ',') - record); diff --git a/storage/maria/trnman.c b/storage/maria/trnman.c index e0509f4544f77..f5d33dc44cb61 100644 --- a/storage/maria/trnman.c +++ b/storage/maria/trnman.c @@ -126,12 +126,12 @@ default_trnman_end_trans_hook(TRN *trn __attribute__ ((unused)), } -static const uchar *trn_get_hash_key(const void *trn_, size_t *len, - my_bool unused __attribute__((unused))) +static const void *trn_get_hash_key(const void *trn_, size_t *len, + my_bool unused __attribute__((unused))) { const TRN *const *trn= trn_; *len= sizeof(TrID); - return (const uchar *) &((*trn)->trid); + return &((*trn)->trid); } diff --git a/storage/mroonga/ha_mroonga.cpp b/storage/mroonga/ha_mroonga.cpp index c992ef0dcf62a..6db7a1bcf1b3c 100644 --- a/storage/mroonga/ha_mroonga.cpp +++ b/storage/mroonga/ha_mroonga.cpp @@ -610,22 +610,22 @@ static const char *mrn_inspect_extra_function(enum ha_extra_function operation) } #endif -static const uchar *mrn_open_tables_get_key(const void *record, size_t *length, - my_bool) +static const void *mrn_open_tables_get_key(const void *record, size_t *length, + my_bool) { MRN_DBUG_ENTER_FUNCTION(); auto share = static_cast(record); *length = share->table_name_length; - DBUG_RETURN(reinterpret_cast(share->table_name)); + DBUG_RETURN(share->table_name); } -static const uchar *mrn_long_term_share_get_key(const void *record, - size_t *length, my_bool) +static const void *mrn_long_term_share_get_key(const void *record, + size_t *length, my_bool) { MRN_DBUG_ENTER_FUNCTION(); auto long_term_share= static_cast(record); *length = long_term_share->table_name_length; - DBUG_RETURN(reinterpret_cast(long_term_share->table_name)); + DBUG_RETURN(long_term_share->table_name); } /* status */ @@ -699,12 +699,12 @@ static grn_logger mrn_logger = { NULL }; -static const uchar *mrn_allocated_thds_get_key(const void *record, - size_t *length, my_bool) +static const void *mrn_allocated_thds_get_key(const void *record, + size_t *length, my_bool) { MRN_DBUG_ENTER_FUNCTION(); *length = sizeof(THD *); - DBUG_RETURN(static_cast(record)); + DBUG_RETURN(record); } /* system functions */ diff --git a/storage/perfschema/pfs_account.cc b/storage/perfschema/pfs_account.cc index 2a87783664908..f378cc9c4043e 100644 --- a/storage/perfschema/pfs_account.cc +++ b/storage/perfschema/pfs_account.cc @@ -67,8 +67,8 @@ void cleanup_account(void) } C_MODE_START -static const uchar *account_hash_get_key(const void *entry, size_t *length, - my_bool) +static const void *account_hash_get_key(const void *entry, size_t *length, + my_bool) { const PFS_account * const *typed_entry; const PFS_account *account; @@ -79,7 +79,7 @@ static const uchar *account_hash_get_key(const void *entry, size_t *length, assert(account != NULL); *length= account->m_key.m_key_length; result= account->m_key.m_hash_key; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_digest.cc b/storage/perfschema/pfs_digest.cc index f160325c94c32..304915c860b6c 100644 --- a/storage/perfschema/pfs_digest.cc +++ b/storage/perfschema/pfs_digest.cc @@ -146,8 +146,8 @@ void cleanup_digest(void) } C_MODE_START -static const uchar *digest_hash_get_key(const void *entry, size_t *length, - my_bool) +static const void *digest_hash_get_key(const void *entry, size_t *length, + my_bool) { const PFS_statements_digest_stat * const *typed_entry; const PFS_statements_digest_stat *digest; @@ -158,7 +158,7 @@ static const uchar *digest_hash_get_key(const void *entry, size_t *length, assert(digest != NULL); *length= sizeof (PFS_digest_key); result= & digest->m_digest_key; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_host.cc b/storage/perfschema/pfs_host.cc index bf8421909bab9..757e243e38a8f 100644 --- a/storage/perfschema/pfs_host.cc +++ b/storage/perfschema/pfs_host.cc @@ -65,8 +65,8 @@ void cleanup_host(void) } C_MODE_START -static const uchar *host_hash_get_key(const void *entry, size_t *length, - my_bool) +static const void *host_hash_get_key(const void *entry, size_t *length, + my_bool) { const PFS_host * const *typed_entry; const PFS_host *host; @@ -77,7 +77,7 @@ static const uchar *host_hash_get_key(const void *entry, size_t *length, assert(host != NULL); *length= host->m_key.m_key_length; result= host->m_key.m_hash_key; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_instr.cc b/storage/perfschema/pfs_instr.cc index c9fb7ca7a3aa6..8a65c83ed02c6 100644 --- a/storage/perfschema/pfs_instr.cc +++ b/storage/perfschema/pfs_instr.cc @@ -253,8 +253,8 @@ void cleanup_instruments(void) C_MODE_START /** Get hash table key for instrumented files. */ -static const uchar *filename_hash_get_key(const void *entry, size_t *length, - my_bool) +static const void *filename_hash_get_key(const void *entry, size_t *length, + my_bool) { const PFS_file * const *typed_entry; const PFS_file *file; @@ -265,7 +265,7 @@ static const uchar *filename_hash_get_key(const void *entry, size_t *length, assert(file != NULL); *length= file->m_filename_length; result= file->m_filename; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_instr_class.cc b/storage/perfschema/pfs_instr_class.cc index c3a68793ad642..383d1e84c4516 100644 --- a/storage/perfschema/pfs_instr_class.cc +++ b/storage/perfschema/pfs_instr_class.cc @@ -384,8 +384,8 @@ void cleanup_table_share(void) C_MODE_START /** get_key function for @c table_share_hash. */ -static const uchar *table_share_hash_get_key(const void *entry, size_t *length, - my_bool) +static const void *table_share_hash_get_key(const void *entry, size_t *length, + my_bool) { const PFS_table_share * const *typed_entry; const PFS_table_share *share; @@ -396,7 +396,7 @@ static const uchar *table_share_hash_get_key(const void *entry, size_t *length, assert(share != NULL); *length= share->m_key.m_key_length; result= &share->m_key.m_hash_key[0]; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_program.cc b/storage/perfschema/pfs_program.cc index ee4e23a59b0ec..02adc8e8f470a 100644 --- a/storage/perfschema/pfs_program.cc +++ b/storage/perfschema/pfs_program.cc @@ -63,8 +63,8 @@ void cleanup_program(void) } C_MODE_START -static const uchar *program_hash_get_key(const void *entry, size_t *length, - my_bool) +static const void *program_hash_get_key(const void *entry, size_t *length, + my_bool) { const PFS_program * const *typed_entry; const PFS_program *program; @@ -75,7 +75,7 @@ static const uchar *program_hash_get_key(const void *entry, size_t *length, assert(program != NULL); *length= program->m_key.m_key_length; result= program->m_key.m_hash_key; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_setup_actor.cc b/storage/perfschema/pfs_setup_actor.cc index 638b2e5648d92..bda9f47c2d879 100644 --- a/storage/perfschema/pfs_setup_actor.cc +++ b/storage/perfschema/pfs_setup_actor.cc @@ -63,7 +63,7 @@ void cleanup_setup_actor(void) } C_MODE_START -static const uchar *setup_actor_hash_get_key(const void *entry, size_t *length, +static const void *setup_actor_hash_get_key(const void *entry, size_t *length, my_bool) { const PFS_setup_actor * const *typed_entry; @@ -75,7 +75,7 @@ static const uchar *setup_actor_hash_get_key(const void *entry, size_t *length, assert(setup_actor != NULL); *length= setup_actor->m_key.m_key_length; result= setup_actor->m_key.m_hash_key; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_setup_object.cc b/storage/perfschema/pfs_setup_object.cc index a961c51d0e9df..fd84d2b8523cd 100644 --- a/storage/perfschema/pfs_setup_object.cc +++ b/storage/perfschema/pfs_setup_object.cc @@ -63,8 +63,8 @@ void cleanup_setup_object(void) } C_MODE_START -static const uchar *setup_object_hash_get_key(const void *entry, - size_t *length, my_bool) +static const void *setup_object_hash_get_key(const void *entry, + size_t *length, my_bool) { const PFS_setup_object * const *typed_entry; const PFS_setup_object *setup_object; @@ -75,7 +75,7 @@ static const uchar *setup_object_hash_get_key(const void *entry, assert(setup_object != NULL); *length= setup_object->m_key.m_key_length; result= setup_object->m_key.m_hash_key; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/perfschema/pfs_user.cc b/storage/perfschema/pfs_user.cc index d83ee52a77dec..aeb2c9edb7f1c 100644 --- a/storage/perfschema/pfs_user.cc +++ b/storage/perfschema/pfs_user.cc @@ -64,8 +64,8 @@ void cleanup_user(void) } C_MODE_START -static const uchar *user_hash_get_key(const void *entry, size_t *length, - my_bool) +static const void *user_hash_get_key(const void *entry, size_t *length, + my_bool) { const PFS_user * const *typed_entry; const PFS_user *user; @@ -76,7 +76,7 @@ static const uchar *user_hash_get_key(const void *entry, size_t *length, assert(user != NULL); *length= user->m_key.m_key_length; result= user->m_key.m_hash_key; - return reinterpret_cast(result); + return result; } C_MODE_END diff --git a/storage/sphinx/ha_sphinx.cc b/storage/sphinx/ha_sphinx.cc index 1d9ff1ca373df..1954996e25efd 100644 --- a/storage/sphinx/ha_sphinx.cc +++ b/storage/sphinx/ha_sphinx.cc @@ -653,12 +653,12 @@ static HASH sphinx_open_tables; // hash used to track open tables // hashing function typedef size_t GetKeyLength_t; -static const uchar *sphinx_get_key(const void *pSharePtr, - GetKeyLength_t *pLength, my_bool) +static const void *sphinx_get_key(const void *pSharePtr, + GetKeyLength_t *pLength, my_bool) { const CSphSEShare *pShare= static_cast(pSharePtr); *pLength= pShare->m_iTableNameLen; - return reinterpret_cast(pShare->m_sTable); + return pShare->m_sTable; } static int sphinx_init_func ( void * p ) diff --git a/storage/spider/spd_conn.cc b/storage/spider/spd_conn.cc index df38d2b7f0f2f..8546b3307eb8f 100644 --- a/storage/spider/spd_conn.cc +++ b/storage/spider/spd_conn.cc @@ -100,7 +100,7 @@ ulong spider_open_connections_line_no; pthread_mutex_t spider_conn_mutex; /* for spider_open_connections and trx_conn_hash */ -const uchar *spider_conn_get_key( +const void *spider_conn_get_key( const void *conn_, size_t *length, my_bool @@ -111,10 +111,10 @@ const uchar *spider_conn_get_key( #ifdef DBUG_TRACE spider_print_keys(conn->conn_key, conn->conn_key_length); #endif - DBUG_RETURN(reinterpret_cast(conn->conn_key)); + DBUG_RETURN(conn->conn_key); } -const uchar *spider_ipport_conn_get_key( +const void *spider_ipport_conn_get_key( const void *ip_port_, size_t *length, my_bool @@ -123,10 +123,10 @@ const uchar *spider_ipport_conn_get_key( auto ip_port= static_cast(ip_port_); DBUG_ENTER("spider_ipport_conn_get_key"); *length = ip_port->key_len; - DBUG_RETURN(reinterpret_cast(ip_port->key)); + DBUG_RETURN(ip_port->key); } -static const uchar *spider_loop_check_full_get_key( +static const void *spider_loop_check_full_get_key( const void *ptr_, size_t *length, my_bool @@ -134,10 +134,10 @@ static const uchar *spider_loop_check_full_get_key( auto ptr= static_cast(ptr_); DBUG_ENTER("spider_loop_check_full_get_key"); *length = ptr->full_name.length; - DBUG_RETURN(reinterpret_cast(ptr->full_name.str)); + DBUG_RETURN(ptr->full_name.str); } -static const uchar *spider_loop_check_to_get_key( +static const void *spider_loop_check_to_get_key( const void *ptr_, size_t *length, my_bool @@ -145,7 +145,7 @@ static const uchar *spider_loop_check_to_get_key( auto ptr= static_cast(ptr_); DBUG_ENTER("spider_loop_check_to_get_key"); *length = ptr->to_name.length; - DBUG_RETURN(reinterpret_cast(ptr->to_name.str)); + DBUG_RETURN(ptr->to_name.str); } int spider_conn_init( diff --git a/storage/spider/spd_conn.h b/storage/spider/spd_conn.h index b50c306999343..2aa2a26c3519a 100644 --- a/storage/spider/spd_conn.h +++ b/storage/spider/spd_conn.h @@ -82,13 +82,13 @@ typedef struct st_spider_conn_loop_check LEX_CSTRING merged_value; } SPIDER_CONN_LOOP_CHECK; -const uchar *spider_conn_get_key( +const void *spider_conn_get_key( const void *conn, size_t *length, my_bool ); -const uchar *spider_ipport_conn_get_key( +const void *spider_ipport_conn_get_key( const void *ip_port, size_t *length, my_bool diff --git a/storage/spider/spd_table.cc b/storage/spider/spd_table.cc index 6f7c8204ed95f..8f7e0585674ea 100644 --- a/storage/spider/spd_table.cc +++ b/storage/spider/spd_table.cc @@ -451,7 +451,7 @@ static char spider_unique_id_buf[1 + 12 + 1 + (16 * 2) + 1 + 1]; LEX_CSTRING spider_unique_id; // for spider_open_tables -const uchar *spider_tbl_get_key( +const void *spider_tbl_get_key( const void *share_, size_t *length, my_bool @@ -459,10 +459,10 @@ const uchar *spider_tbl_get_key( auto share= static_cast(share_); DBUG_ENTER("spider_tbl_get_key"); *length = share->table_name_length; - DBUG_RETURN(reinterpret_cast(share->table_name)); + DBUG_RETURN(share->table_name); } -const uchar *spider_wide_share_get_key( +const void *spider_wide_share_get_key( const void *share_, size_t *length, my_bool @@ -470,10 +470,10 @@ const uchar *spider_wide_share_get_key( auto share= static_cast(share_); DBUG_ENTER("spider_wide_share_get_key"); *length = share->table_name_length; - DBUG_RETURN(reinterpret_cast(share->table_name)); + DBUG_RETURN(share->table_name); } -const uchar *spider_lgtm_tblhnd_share_hash_get_key( +const void *spider_lgtm_tblhnd_share_hash_get_key( const void *share_, size_t *length, my_bool @@ -481,10 +481,10 @@ const uchar *spider_lgtm_tblhnd_share_hash_get_key( auto share= static_cast(share_); DBUG_ENTER("spider_lgtm_tblhnd_share_hash_get_key"); *length = share->table_name_length; - DBUG_RETURN(reinterpret_cast(share->table_name)); + DBUG_RETURN(share->table_name); } -const uchar *spider_link_get_key( +const void *spider_link_get_key( const void *link_for_hash_, size_t *length, my_bool @@ -493,10 +493,10 @@ const uchar *spider_link_get_key( static_cast(link_for_hash_); DBUG_ENTER("spider_link_get_key"); *length = link_for_hash->db_table_str->length(); - DBUG_RETURN(reinterpret_cast(link_for_hash->db_table_str->ptr())); + DBUG_RETURN(link_for_hash->db_table_str->ptr()); } -const uchar *spider_udf_tbl_mon_list_key( +const void *spider_udf_tbl_mon_list_key( const void *table_mon_list_, size_t *length, my_bool @@ -507,17 +507,17 @@ const uchar *spider_udf_tbl_mon_list_key( DBUG_PRINT("info",("spider hash key=%s", table_mon_list->key)); DBUG_PRINT("info",("spider hash key length=%u", table_mon_list->key_length)); *length = table_mon_list->key_length; - DBUG_RETURN(reinterpret_cast(table_mon_list->key)); + DBUG_RETURN(table_mon_list->key); } -const uchar *spider_allocated_thds_get_key( +const void *spider_allocated_thds_get_key( const void *thd, size_t *length, my_bool ) { DBUG_ENTER("spider_allocated_thds_get_key"); *length = sizeof(THD *); - DBUG_RETURN(reinterpret_cast(thd)); + DBUG_RETURN(thd); } #ifdef HAVE_PSI_INTERFACE diff --git a/storage/spider/spd_table.h b/storage/spider/spd_table.h index b48d8ada5882d..dd4fdb87f17d2 100644 --- a/storage/spider/spd_table.h +++ b/storage/spider/spd_table.h @@ -47,19 +47,19 @@ typedef struct st_spider_param_string_parse bool locate_param_def(char*& start_param); } SPIDER_PARAM_STRING_PARSE; -const uchar *spider_tbl_get_key( +const void *spider_tbl_get_key( const void *share, size_t *length, my_bool ); -const uchar *spider_wide_share_get_key( +const void *spider_wide_share_get_key( const void *share, size_t *length, my_bool ); -const uchar *spider_link_get_key( +const void *spider_link_get_key( const void *link_for_hash, size_t *length, my_bool diff --git a/storage/spider/spd_trx.cc b/storage/spider/spd_trx.cc index 64db1af1be237..c238bff25d182 100644 --- a/storage/spider/spd_trx.cc +++ b/storage/spider/spd_trx.cc @@ -58,7 +58,7 @@ extern ulong spider_allocated_thds_line_no; extern pthread_mutex_t spider_allocated_thds_mutex; // for spider_alter_tables -const uchar *spider_alter_tbl_get_key( +const void *spider_alter_tbl_get_key( const void *alter_table_, size_t *length, my_bool @@ -68,11 +68,11 @@ const uchar *spider_alter_tbl_get_key( *length = alter_table->table_name_length; DBUG_PRINT("info",("spider table_name_length=%zu", *length)); DBUG_PRINT("info",("spider table_name=%s", alter_table->table_name)); - DBUG_RETURN(reinterpret_cast(alter_table->table_name)); + DBUG_RETURN(alter_table->table_name); } // for SPIDER_TRX_HA -const uchar *spider_trx_ha_get_key( +const void *spider_trx_ha_get_key( const void *trx_ha_, size_t *length, my_bool @@ -82,7 +82,7 @@ const uchar *spider_trx_ha_get_key( *length = trx_ha->table_name_length; DBUG_PRINT("info",("spider table_name_length=%zu", *length)); DBUG_PRINT("info",("spider table_name=%s", trx_ha->table_name)); - DBUG_RETURN(reinterpret_cast(trx_ha->table_name)); + DBUG_RETURN(trx_ha->table_name); } /*