Commit 23de8c4
committed
Add integrity hashes for remote scripts and stylesheets
Why these changes are being introduced:
It's good practice to validate checksums for external libraries.
We've done this in individual apps, but it makes sense to make
the change in the theme gem.
Relevant ticket(s):
* [ENGX-290](https://mitlibraries.atlassian.net/browse/ENGX-290)
How this addresses that need:
This adds `integrity`, `crossorigin`, and `referrerpolicy`
attributes for remotely hosted scripts and stylesheets.
Side effects of this change:
I'm not totally sure how to exhaustively test these changes. I've
confirmed that the scripts/stylesheets load as expected, and
checked the changes locally in a few of our apps. That feels like
enough, but just signaling the uncertainty here in case the
reviewer has additional insight.1 parent ba5bdc9 commit 23de8c4
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
| 10 | + | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments