Power spectrum responses for SSC by RyoTerasawa · Pull Request #1134 · LSSTDESC/CCL

RyoTerasawa · 2023-11-06T00:23:10Z

In pyccl/pkresponse.py, I implemented the functions to calculate power spectrum responses to the super-survey modes which are responsible for super-sample covariance (SSC), based on arXiv:2310.13330.
We approximate the power spectrum growth response to the super-survey modes by its growth response to the Hubble parameter.

For the galaxy-matter and galaxy-auto power spectra, the halo statistics (halo-matter/halo-auto power spectrum, mass function) are calculated by DarkEmulator.

Update to master

coveralls · 2023-12-04T08:34:58Z

Pull Request Test Coverage Report for Build 16628354402

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

304 of 323 (94.12%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 97.306%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pyccl/pk_response.py	303	322	94.1%

Totals
Change from base Build 14732172638:	-0.2%
Covered Lines:	6863
Relevant Lines:	7053

💛 - Coveralls

damonge · 2024-02-21T08:35:24Z

@RyoTerasawa can I check what the status of this PR is?

RyoTerasawa · 2024-02-21T11:17:50Z

I am waiting for someone to review the code. I haven't asked for a specific person yet, but maybe I should ask a member of the MCPCov group to review it. I am happy to explain the details if needed. I am also working on writing the unit test and benchmark test to be included in this PR.

Update to v3.0.1

carlosggarcia · 2024-04-08T14:47:11Z

@RyoTerasawa @YueNan-c, maybe you want to also implement the DarkEmulator here: https://github.com/LSSTDESC/CCL/blob/master/pyccl/emulators/cosmicemu_pk.py.

Are the unit tests and benchmark ready?

Unit test updates

damonge · 2024-06-18T08:51:18Z

@RyoTerasawa @carlosggarcia can I check what the status of this is?

RyoTerasawa · 2024-06-22T12:57:20Z

@carlosggarcia @damonge
Sorry for the late reply. I just added the unit tests and benchmark, and this pull request is ready to be reviewed.

RyoTerasawa · 2025-03-12T14:45:10Z

All looks good to me. Can you merge the master branch into this branch to see if that solves the issue with the unit tests? Once the unit test pass, I will approve.

I've left some questions for @damonge regarding the integrals.

Thank you for the through review. Now this SSC branch is up to date with the master branch, and 33 commits ahead of the master branch.
As the unit tests still fail at the point other than my modifications, I will wait for that issue to be resolved.

merge from master branch

Merge changes in master

carlosggarcia

I would re-add the lk_arr and a_arr options. @damonge can you check the comments above for the integrals?

carlosggarcia

Almost there

carlosggarcia · 2025-06-19T09:53:28Z

-        raise ValueError("you must provide arrays")
+    # Set k and a sampling from CCL parameters
+    if a_arr is None:
+        a_arr = get_pk_spline_a()


Thanks! I would use the same code that was there before, just in case there is a subtle difference that we are missing

if lk_arr is None: status = 0 nk = lib.get_pk_spline_nk(cosmo.cosmo) lk_arr, status = lib.get_pk_spline_lk(cosmo.cosmo, nk, status) check(status, cosmo=cosmo) if a_arr is None: status = 0 na = lib.get_pk_spline_na(cosmo.cosmo) a_arr, status = lib.get_pk_spline_a(cosmo.cosmo, na, status) check(status, cosmo=cosmo)

I modified so that the spline uses the same code that was there before.

carlosggarcia

LGTM! I'd wait for @damonge to check whether some of the integrals are duplicating some existing functionality before merging.

damonge

I trust the functional contents of this PR are fine since they've been reviewed by @carlosggarcia . I don't mind that the halo model integrals are carried out outside of the current halo model (we could incorporate this later if this module becomes more embedded in the pipeline). However, I have a few requests about the structure of the new module itself:

First, change the name of the module to pk_response rather than pkresponse, for clarity.
Second, we need better names for all the new functions, so they are easily identifiable. My suggestion is as follows:
- Use a structure of the form resp_<pk_kind>_<method>, where <pk_kind> is Pmm, Pgm etc., and <method> is the method used to calculate the response.
- With this in mind, the new functions you have added should read resp_Pmm_hresponse (for example), resp_Pgm_darkemu etc.

I also have an overarching comment: presumably we would like to use the contents of this PR to improve the way we compute the SSC covariances. However, right now the methods you have implemented are completely orphan, and cannot be used for this. The way things currently stand, the SSC contribution computed here automatically assumes the PT approach to the power spectrum response.

Before we move forward, can I ask what the plans are for embedding the new responses in the existing SSC infrastructure? I'm asking because the structure of the code added by this PR should be influenced by how we will use this code later on.

damonge · 2025-06-23T07:27:14Z

+    return dpk12
+
+
+def darkemu_Pgm_resp(


This function needs to be properly documented (include a description of all arguments). It would also be good if its name matched the structure of the previous function (i.e. Pgm_resp instead of darkemu_Pgm_resp, since the previous function is Pmm_resp).

If you want to specify that the response is calculated with darkemu, I would do this at the end of the name, not at the start. I'll propose a naming scheme at the end of this review.

damonge · 2025-06-23T07:29:04Z

+        nP = nth_mat * np.array(Pth)
+
+        # Eq. A7
+        Pgm = integrate.romb(dprof_dlogM * nP, dx=dlogM, axis=0) / ng


I'm ok leaving this outside of the halo model framework for now, since these methods are all quite specific. If we ever wanted to generalise this, I would indeed suggest that we incorporate this fully within the existing halo model module.

damonge · 2025-06-23T07:29:32Z

+    return dpk12
+
+
+def darkemu_Pgg_resp(


As before, this needs proper documentation and homogenise the function names.

damonge · 2025-06-23T07:29:48Z

+        Pgg_2h_int = np.array(Pgg_2h_int)
+
+        # Eq. A12
+        _Pgg_2h = integrate.romb(


damonge · 2025-06-23T07:29:55Z

+        G_prof = (
+            +2.0
+            / 3.0
+            * integrate.romb(


RyoTerasawa · 2025-07-03T12:00:51Z

@carlosggarcia @damonge Thank you for the through review.

I changed the name of the module to pk_response.
I renamed the new functions as resp_Pmm_hresponse, resp_Pgm_darkemu, and resp_Pgg_darkemu.
I added the documentation for resp_Pgm_darkemu, and resp_Pgg_darkemu.
Regarding the last point, the outputs of the pk_response module can be passed to pyccl.tk3d.Tk3D to make a tk3d object, and then using the tk3d object as an input of pyccl.cosmology.angular_cl_cov_SSC, we can compute the SSC. I will write this interface in TJPCov and possibly in CCL too.

carlosggarcia

Two missing arguments in the documentation.

Also, @damonge, we will need your approval

carlosggarcia · 2025-07-30T13:14:16Z

+            which the response is calculated.
+        a_arr (array): an array holding values of the scale factor
+            at which the response is calculated.
+


missing khmin

carlosggarcia · 2025-12-10T14:49:49Z

@damonge can you check if you are happy with this now?

RyoTerasawa added 4 commits November 6, 2023 07:19

add darkemulator.py

867e33c

add darkemulator mass function

0df32e9

Linting

a37dcca

delete darkemulator.py

efcdc7f

RyoTerasawa requested a review from carlosggarcia November 6, 2023 00:23

RyoTerasawa and others added 3 commits November 6, 2023 21:47

add dependency on dark_emulator

2ee5ba5

Update environment.yml

ad83f2a

Merge pull request #1141 from LSSTDESC/master

a691491

Update to master

This was referenced Dec 4, 2023

Ssc terasawa #991

Closed

SSC for g-g lensing and galaxy clustering using DarkEmulator #1079

Closed

RyoTerasawa and others added 2 commits March 10, 2024 18:41

Merge remote-tracking branch 'origin/master' into SSC

9b7450d

Merge pull request #1166 from LSSTDESC/master

e43186e

Update to v3.0.1

YueNan-c added 5 commits June 3, 2024 21:44

Local updates

5f131cb

Local updates

273c214

Unit test updates

Update test_pkresponse.py

dcc98c6

Add files via upload

26b4aa8

Delete benchmarks/test_ssc_terasawa_accuracy.py

43d5eb5

RyoTerasawa force-pushed the SSC branch from 43d5eb5 to 9b7450d Compare June 4, 2024 05:27

damonge and others added 6 commits June 18, 2024 09:51

Merge branch 'master' into SSC

f76b69f

try bumping python

4b5f3a6

try george in conda

a382551

Merge branch 'master' into SSC

5f8d35d

add unit test and benchmark test

ca3dcd9

lint

0341150

add comments in benchmark

4a9e8bb

Merge pull request #1239 from LSSTDESC/master

45d8c0f

merge from master branch

RyoTerasawa added a commit that referenced this pull request Apr 29, 2025

PR #1134 with freshly made branch

6dc8779

RyoTerasawa mentioned this pull request Apr 29, 2025

PR #1134 with freshly made branch #1243

Closed

RyoTerasawa and others added 11 commits April 29, 2025 20:13

update pkresponse.py

9f1d1d7

Merge remote-tracking branch 'origin/SSC' into SSC

83b42c1

dealt with coveralls

1bb5f5c

update test_pkresponse.py

8ae5708

update pkresponse.py

9a919cf

update CCLWarning import

44d6c4f

update pkresponse.py

6345bd0

Make wanings into ValueError

6580ccb

Merge pull request #1245 from LSSTDESC/master

053a807

Merge changes in master

lint

3ad0df1

Merge remote-tracking branch 'origin/SSC' into SSC

2f8fbba

carlosggarcia reviewed Jun 17, 2025

View reviewed changes

Comment thread pyccl/pkresponse.py Outdated

carlosggarcia requested changes Jun 18, 2025

View reviewed changes

Comment thread pyccl/pkresponse.py Outdated

re-add lk_arr and a_arr options

ff8152d

carlosggarcia requested changes Jun 19, 2025

View reviewed changes

update spline

fd24b45

carlosggarcia approved these changes Jun 19, 2025

View reviewed changes

damonge requested changes Jun 23, 2025

View reviewed changes

renamed module and functions

9a22ba4

fix typo

dc930fa

carlosggarcia reviewed Jul 30, 2025

View reviewed changes

add docs for khmin

3d8f651

Merge branch 'SSC' of https://github.com/LSSTDESC/CCL into SSC

c06ec05

Conversation

RyoTerasawa commented Nov 6, 2023

Uh oh!

coveralls commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 16628354402

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

damonge commented Feb 21, 2024

Uh oh!

RyoTerasawa commented Feb 21, 2024

Uh oh!

carlosggarcia commented Apr 8, 2024

Uh oh!

damonge commented Jun 18, 2024

Uh oh!

RyoTerasawa commented Jun 22, 2024

Uh oh!

RyoTerasawa commented Mar 12, 2025

Uh oh!

Uh oh!

carlosggarcia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carlosggarcia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlosggarcia left a comment

Choose a reason for hiding this comment

Uh oh!

damonge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RyoTerasawa commented Jul 3, 2025

Uh oh!

carlosggarcia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carlosggarcia commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Dec 4, 2023 •

edited

Loading