-
Notifications
You must be signed in to change notification settings - Fork 365
Expand file tree
/
Copy pathgraph-settings.test.tsx
More file actions
698 lines (602 loc) · 21 KB
/
graph-settings.test.tsx
File metadata and controls
698 lines (602 loc) · 21 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
import {Dependencies, Util} from "@khanacademy/perseus";
import {render, screen, waitFor, fireEvent} from "@testing-library/react";
import {userEvent as userEventLib} from "@testing-library/user-event";
import * as React from "react";
import {testDependencies} from "../../testing/test-dependencies";
import GraphSettings from "../graph-settings";
import type {UserEvent} from "@testing-library/user-event";
import "@testing-library/jest-dom"; // Imports custom matchers
/**
* userEvent vs. userEventLib - which to use?
*
* This file contains tests that use real timers (by default, the Perseus Jest
* tests are set to use fake timers).
*
* By default, the @testing-library/user-event library only knows how to
* advance real timers. It does, however, contain a setup() function that we
* can use to tell it how to advance Jest's fake timers (see the beforeEach()
* in this file).
*
* So, if your test calls `jest.useRealTimers()` you should use the
* `userEventLib` import. If it does not, you should use the configured
* `userEvent` variable.
*
* The failure mode for running tests with fake timers is that they'll fail by
* timing out. If you get that error, you most likely need to switch to using
* the configured `userEvent` instance.
*/
describe("GraphSettings", () => {
let userEvent: UserEvent;
beforeEach(() => {
userEvent = userEventLib.setup({
advanceTimers: jest.advanceTimersByTime,
});
jest.spyOn(Dependencies, "getDependencies").mockReturnValue(
testDependencies,
);
});
test("displays canvas settings", () => {
// Arrange
// Act
render(
<GraphSettings editableSettings={["canvas"]} onChange={() => {}} />,
);
// Assert
expect(
screen.getByText("Canvas size (x,y pixels)"),
).toBeInTheDocument();
});
test("displays graph settings", () => {
// Arrange
// Act
render(
<GraphSettings editableSettings={["graph"]} onChange={() => {}} />,
);
// Assert
expect(screen.getByText("x Label")).toBeInTheDocument();
expect(screen.getByText("y Label")).toBeInTheDocument();
expect(screen.getByText("Markings:")).toBeInTheDocument();
});
test("displays nothing if snap is by itself", () => {
// Arrange
// Act
render(
<GraphSettings editableSettings={["snap"]} onChange={() => {}} />,
);
// Assert
expect(screen.queryByText("Snap Step")).not.toBeInTheDocument();
});
test("displays snap settings", () => {
// Arrange
// Act
render(
<GraphSettings
editableSettings={["graph", "snap"]}
onChange={() => {}}
/>,
);
// Assert
expect(screen.getByText("Snap Step")).toBeInTheDocument();
});
test("displays image settings", () => {
// Arrange
// Act
render(
<GraphSettings editableSettings={["image"]} onChange={() => {}} />,
);
// Assert
expect(screen.getByText("Background image:")).toBeInTheDocument();
});
test("displays measure settings", () => {
// Arrange
// Act
render(
<GraphSettings
editableSettings={["measure"]}
onChange={() => {}}
/>,
);
// Assert
expect(screen.getByText("Show ruler")).toBeInTheDocument();
expect(screen.getByText("Show protractor")).toBeInTheDocument();
});
test("displays all settings", () => {
// Arrange
// Act
render(
<GraphSettings
editableSettings={[
"canvas",
"graph",
"snap",
"image",
"measure",
]}
onChange={() => {}}
/>,
);
// Assert
expect(
screen.getByText("Canvas size (x,y pixels)"),
).toBeInTheDocument();
expect(screen.getByText("x Label")).toBeInTheDocument();
expect(screen.getByText("y Label")).toBeInTheDocument();
expect(screen.getByText("Markings:")).toBeInTheDocument();
expect(screen.getByText("Snap Step")).toBeInTheDocument();
expect(screen.getByText("Background image:")).toBeInTheDocument();
expect(screen.getByText("Show ruler")).toBeInTheDocument();
expect(screen.getByText("Show protractor")).toBeInTheDocument();
});
test("calls onChange when markings are changed", async () => {
// Arrange
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const button = screen.getByRole("button", {name: "Grid"});
await userEvent.click(button);
// Assert
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({markings: "grid"}),
);
});
test("calls onChange when ruler label is changed", async () => {
// Arrange
const onChange = jest.fn();
render(
<GraphSettings
editableSettings={["measure"]}
showRuler={true}
onChange={onChange}
/>,
);
// Act
const select = screen.getByRole("combobox", {name: "Ruler label:"});
await userEvent.selectOptions(select, ["cm"]);
// Assert
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({rulerLabel: "cm"}),
);
});
test("calls onChange when rulerTicks is changed", async () => {
// Arrange
const onChange = jest.fn();
render(
<GraphSettings
editableSettings={["measure"]}
showRuler={true}
onChange={onChange}
/>,
);
// Act
const select = screen.getByRole("combobox", {name: "Ruler ticks:"});
await userEvent.selectOptions(select, ["4"]);
// Assert
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({rulerTicks: 4}),
);
});
test("calls onChange when background image is changed", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
const mockGetImageSize = (url, cb: (width, height) => void) => {
cb(100, 100);
};
jest.spyOn(Util, "getImageSize").mockImplementation(mockGetImageSize);
render(
<GraphSettings editableSettings={["image"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox");
await userEventLib.type(input, "https://example.com/image.png");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
backgroundImage: expect.objectContaining({
url: "https://example.com/image.png",
}),
}),
),
);
});
test("validates background image size", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
const mockGetImageSize = (url, cb: (width, height) => void) => {
// Large image should be invalid
cb(1000, 1000);
};
jest.spyOn(Util, "getImageSize").mockImplementation(mockGetImageSize);
render(
<GraphSettings editableSettings={["image"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox");
await userEventLib.type(input, "https://example.com/image.png");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
valid: "Image must be smaller than 450px x 450px.",
}),
),
);
});
test("calls onChange with null background image if background image input is empty", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
const mockGetImageSize = (url, cb: (width, height) => void) => {};
jest.spyOn(Util, "getImageSize").mockImplementation(mockGetImageSize);
render(
<GraphSettings editableSettings={["image"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox") as HTMLInputElement;
await userEventLib.clear(input);
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
backgroundImage: expect.objectContaining({
url: null,
}),
}),
),
);
});
test("does not update background image until input is blurred", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["image"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox");
input.focus();
// Disabling this because we need to test keypress events that are
// unfortunately being used in legacy code.
// eslint-disable-next-line testing-library/prefer-user-event
fireEvent.keyPress(input, {key: "a", code: "KeyA", charCode: 97});
// Assert
expect(onChange).not.toHaveBeenCalled();
});
test("calls onChange when protractor label is changed", async () => {
// Arrange
const onChange = jest.fn();
render(
<GraphSettings
editableSettings={["measure"]}
showProtractor={true}
onChange={onChange}
/>,
);
// Act
const checkbox = screen.getByRole("checkbox", {
name: "Show protractor",
});
await userEvent.click(checkbox);
// Assert
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({showProtractor: false}),
);
});
test("Calls onChange when x range is changed and valid", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "x Range"});
await userEventLib.clear(input);
await userEventLib.type(input, "0");
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
range: [
[0, 10],
[-10, 10],
],
valid: true,
}),
),
);
});
test("Calls onChange when y range is changed and valid", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "y Range"});
await userEventLib.clear(input);
await userEventLib.type(input, "0");
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
range: [
[-10, 10],
[0, 10],
],
valid: true,
}),
),
);
});
test("validates range input when left is bigger than right", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "x Range"});
await userEventLib.clear(input);
await userEventLib.type(input, "20");
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
valid: "Range must have a higher number on the right",
}),
),
);
});
test("Calls onChange when step value is changed and valid", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "Tick Step"});
await userEventLib.clear(input);
await userEventLib.type(input, "2");
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
step: [2, 1],
valid: true,
}),
),
);
});
test("validates step value when tick step is too large", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "Tick Step"});
await userEventLib.clear(input);
await userEventLib.type(input, "20");
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
valid: "Step is too large, there must be at least 3 ticks.",
}),
),
);
});
test("validates step value when tick step is too small", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings
editableSettings={["graph"]}
range={[
[-100, 100],
[-100, 100],
]}
onChange={onChange}
/>,
);
// Act
const input = screen.getByRole("textbox", {name: "Tick Step"});
await userEventLib.clear(input);
await userEventLib.type(input, "2");
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
valid: "Step is too small, there can be at most 20 ticks.",
}),
),
);
});
test("Calls onChange when snap step is changed and valid", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings
editableSettings={["graph", "snap"]}
onChange={onChange}
/>,
);
// Act
const input = screen.getByRole("textbox", {name: "Snap Step"});
await userEventLib.clear(input);
await userEventLib.type(input, "2");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
snapStep: [2, 1],
valid: true,
}),
),
);
});
test("validates when the snap step is too large", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings
editableSettings={["graph", "snap"]}
onChange={onChange}
/>,
);
// Act
const input = screen.getByRole("textbox", {name: "Snap Step"});
await userEventLib.clear(input);
await userEventLib.type(input, "100");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
valid: "Snap step is too large, there must be at least 5 ticks.",
}),
),
);
});
test("Calls onChange when grid step is changed and valid", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "Grid Step"});
await userEventLib.clear(input);
await userEventLib.type(input, "2");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
gridStep: [2, 1],
valid: true,
}),
),
);
});
test("validates when the grid step is too large", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "Grid Step"});
await userEventLib.clear(input);
await userEventLib.type(input, "100");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
valid: "Grid step is too large, there must be at least 3 ticks.",
}),
),
);
});
test("Calls onChange when the x label is changed", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "x Label"});
await userEventLib.clear(input);
await userEventLib.type(input, "time");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
labels: ["time", "y"],
}),
),
);
});
test("Calls onChange when the y label is changed", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["graph"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {name: "y Label"});
await userEventLib.clear(input);
await userEventLib.type(input, "count");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
labels: ["x", "count"],
}),
),
);
});
test("Calls onChange when the canvas size is changed and valid", async () => {
// Arrange
// TODO(nisha): Figure out how to use fake timers for this.
jest.useRealTimers();
const onChange = jest.fn();
render(
<GraphSettings editableSettings={["canvas"]} onChange={onChange} />,
);
// Act
const input = screen.getByRole("textbox", {
name: "Canvas size (x,y pixels)",
});
await userEventLib.clear(input);
await userEventLib.paste("300");
await userEventLib.tab();
// Assert
await waitFor(() =>
expect(onChange).toHaveBeenCalledWith(
expect.objectContaining({
box: [300, 288],
}),
),
);
});
});