Get rid of the preprocessord,

prefix s1 namespaces with S1

Author: omar-akermi

S1API/Products/CocaineDefinition.cs

@@ -1,11 +1,11 @@
 #if (IL2CPPMELON)
 using Il2CppScheduleOne.Product;
 using S1CocaineDefinition = Il2CppScheduleOne.Product.CocaineDefinition;
-using Properties = Il2CppScheduleOne.Properties;
+using S1Properties = Il2CppScheduleOne.Properties;
 #elif (MONOMELON || MONOBEPINEX || IL2CPPBEPINEX)
 using ScheduleOne.Product;
 using S1CocaineDefinition = ScheduleOne.Product.CocaineDefinition;
-using Properties = ScheduleOne.Properties;
+using S1Properties = ScheduleOne.Properties;
 #endif
 
 using System.Collections.Generic;
@@ -15,58 +15,47 @@
 namespace S1API.Products
 {
     /// <summary>
-    /// Represents the definition of a cocaine product within the system.
+    /// Defines the characteristics and behaviors of a cocaine product within the system.
     /// </summary>
     public class CocaineDefinition : ProductDefinition
     {
         /// <summary>
-        /// INTERNAL: Strongly typed access to the CocaineDefinition within the Schedule One framework.
+        /// Provides internal access to the CocaineDefinition type within the Schedule One system.
         /// </summary>
         internal S1CocaineDefinition S1CocaineDefinition =>
             CrossType.As<S1CocaineDefinition>(S1ItemDefinition);
 
         /// <summary>
-        /// Represents the definition of a Cocaine product.
+        /// Represents the definition of a cocaine product within the system.
         /// </summary>
         internal CocaineDefinition(S1CocaineDefinition definition)
             : base(definition)
         {
         }
 
         /// <summary>
-        /// Creates an instance of this cocaine product with the specified quantity.
+        /// Creates an instance of this product definition with the specified quantity.
         /// </summary>
-        /// <param name="quantity">The quantity of the product to create. Defaults to 1.</param>
-        /// <returns>An instance of the cocaine product with the specified quantity.</returns>
+        /// <param name="quantity">The quantity of the product to instantiate. Defaults to 1 if not specified.</param>
+        /// <returns>An <see cref="ItemInstance"/> representing the instantiated product with the specified quantity.</returns>
         public override ItemInstance CreateInstance(int quantity = 1) =>
             new ProductInstance(CrossType.As<ProductItemInstance>(
                 S1CocaineDefinition.GetDefaultInstance(quantity)));
 
         /// <summary>
-        /// Retrieves a list of properties associated with the current cocaine product definition.
+        /// Retrieves a list of properties associated with this product definition.
         /// </summary>
-        /// <returns>A list of properties specific to the cocaine product definition.</returns>
-#if   IL2CPPMELON
-        public List<Properties.Property> GetProperties()
-#else
-        public List<Properties.Property> GetProperties()
-#endif
+        /// <returns>A list of properties for the product.</returns>
+        public List<S1Properties.Property> GetProperties()
         {
-#if IL2CPPMELON
-            var result = new List<Properties.Property>();
-#else
-            var result = new List<Properties.Property>();
-#endif
+            var result = new List<S1Properties.Property>();
             var list = S1CocaineDefinition?.Properties;
             if (list != null)
             {
                 for (int i = 0; i < list.Count; i++)
-                {
                     result.Add(list[i]);
-                }
             }
             return result;
         }
     }
-
 }

S1API/Products/MethDefinition.cs

@@ -1,74 +1,59 @@
 #if (IL2CPPMELON)
 using Il2CppScheduleOne.Product;
 using S1MethDefinition = Il2CppScheduleOne.Product.MethDefinition;
-    using Properties = Il2CppScheduleOne.Properties;
+using S1Properties = Il2CppScheduleOne.Properties;
 #elif (MONOMELON || MONOBEPINEX || IL2CPPBEPINEX)
 using ScheduleOne.Product;
 using S1MethDefinition = ScheduleOne.Product.MethDefinition;
-using Properties = ScheduleOne.Properties;
+using S1Properties = ScheduleOne.Properties;
 #endif
 
 using System.Collections.Generic;
 using S1API.Internal.Utils;
 using S1API.Items;
-
 namespace S1API.Products
 {
     /// <summary>
-    /// Represents the definition of a Meth product in the product framework.
+    /// Represents the definition of a meth product within the ScheduleOne product framework.
     /// </summary>
-    /// <remarks>
-    /// Provides methods for retrieving properties and creating instances of meth products. This class extends the base functionality provided by <see cref="ProductDefinition"/>.
-    /// </remarks>
     public class MethDefinition : ProductDefinition
     {
         /// <summary>
-        /// INTERNAL: Strongly typed access to S1MethDefinition, representing the Il2CppScheduleOne.Product.MethDefinition entity.
+        /// INTERNAL: Strongly typed access to S1MethDefinition.
         /// </summary>
         internal S1MethDefinition S1MethDefinition =>
             CrossType.As<S1MethDefinition>(S1ItemDefinition);
 
         /// <summary>
-        /// Represents the definition of a Meth product.
+        /// Represents the definition of a Meth product in the product framework.
         /// </summary>
         internal MethDefinition(S1MethDefinition definition)
             : base(definition)
         {
         }
 
         /// <summary>
-        /// Creates an instance of this meth product with a specified quantity.
+        /// Creates an instance of this meth product with the specified quantity.
         /// </summary>
-        /// <param name="quantity">The quantity of the meth product to instantiate. Defaults to 1 if not provided.</param>
-        /// <returns>An instance of the meth product as a <see cref="ItemInstance"/>.</returns>
+        /// <param name="quantity">The quantity of the product instance to create. Defaults to 1 if not specified.</param>
+        /// <returns>An instance of <see cref="ItemInstance"/> representing the created meth product.</returns>
         public override ItemInstance CreateInstance(int quantity = 1) =>
             new ProductInstance(CrossType.As<ProductItemInstance>(
                 S1MethDefinition.GetDefaultInstance(quantity)));
 
         /// <summary>
         /// Retrieves the list of properties associated with the meth product definition.
         /// </summary>
-        /// <returns>A list of properties that belong to the meth product definition.</returns>
-#if IL2CPPMELON
-        public List<Properties.Property> GetProperties()
-#else
-        public List<Properties.Property> GetProperties()
-#endif
+        /// <returns>A list of properties defined for the meth product.</returns>
+        public List<S1Properties.Property> GetProperties()
         {
-#if IL2CPPMELON
-            var result = new List<Properties.Property>();
-#else
-            var result = new List<Properties.Property>();
-#endif
+            var result = new List<S1Properties.Property>();
             var list = S1MethDefinition?.Properties;
             if (list != null)
             {
                 for (int i = 0; i < list.Count; i++)
-                {
                     result.Add(list[i]);
-                }
             }
-
             return result;
         }
     }

S1API/Products/ProductInstance.cs

@@ -1,73 +1,72 @@
 #if (IL2CPPMELON )
 using S1Product = Il2CppScheduleOne.Product;
-using Properties = Il2CppScheduleOne.Properties;
+using S1Properties = Il2CppScheduleOne.Properties;
 #elif (MONOMELON || MONOBEPINEX || IL2CPPBEPINEX)
 using S1Product = ScheduleOne.Product;
 using Properties = ScheduleOne.Properties;
 #endif
 using System.Collections.Generic;
 using S1API.Internal.Utils;
-using ItemInstance = S1API.Items.ItemInstance;
-
+using S1ItemInstance = S1API.Items.ItemInstance;
 namespace S1API.Products
 {
     /// <summary>
     /// Represents an instance of a product in the game.
     /// </summary>
-    public class ProductInstance : ItemInstance
+    /// <remarks>
+    /// This class defines specific properties and behaviors for a product instance,
+    /// such as quality, packaging, and definition, derived from the S1API's item instance structure.
+    /// </remarks>
+    public class ProductInstance : S1ItemInstance
     {
         /// <summary>
-        /// INTERNAL: Reference to the in-game product item instance.
+        /// INTERNAL: Provides access to the underlying in-game product item instance.
         /// </summary>
         internal S1Product.ProductItemInstance S1ProductInstance =>
             CrossType.As<S1Product.ProductItemInstance>(S1ItemInstance);
 
         /// <summary>
-        /// Represents an instance of a product derived from an in-game product item instance.
+        /// Represents an instance of a product, derived from a specific in-game product item instance,
+        /// with additional properties for packaging, quality, and product definition.
         /// </summary>
-        internal ProductInstance(S1Product.ProductItemInstance productInstance) : base(productInstance)
+        internal ProductInstance(S1Product.ProductItemInstance productInstance)
+            : base(productInstance)
         {
         }
 
         /// <summary>
         /// Indicates whether the product instance has applied packaging.
         /// </summary>
-        public bool IsPackaged =>
-            S1ProductInstance.AppliedPackaging;
+        public bool IsPackaged => S1ProductInstance.AppliedPackaging;
 
         /// <summary>
-        /// Represents the packaging details currently applied to the product instance, if any.
+        /// Provides access to the packaging information applied to the product,
+        /// represented as a specific packaging definition instance.
         /// </summary>
         public PackagingDefinition AppliedPackaging =>
             new PackagingDefinition(S1ProductInstance.AppliedPackaging);
 
         /// <summary>
-        /// Represents the quality tier of the product instance.
+        /// Represents the quality level of the product instance.
         /// </summary>
         /// <remarks>
-        /// The quality indicates the standard or grade of the product, ranging through predefined levels such as Trash, Poor, Standard, Premium, and Heavenly.
+        /// Quality levels provide a measure of the product's grading, ranging from "Trash" to "Heavenly".
         /// </remarks>
         public Quality Quality => S1ProductInstance.Quality.ToAPI();
 
-        // Expose the underlying definition's properties (if S1ProductInstance.Definition is available)
-
-        // Add Definition property if you don't have one yet
-
-#if IL2CPPMELON
-        public IReadOnlyList<Properties.Property> Properties => Definition.Properties;
-        public ProductDefinition Definition => new ProductDefinition(S1ProductInstance.Definition);
-#else
         /// <summary>
-        /// Represents the collection of properties associated with the product.
+        /// Gets the definition of the product associated with this instance.
         /// </summary>
-        public IReadOnlyList<Properties.Property> Properties => Definition.Properties;
+        public ProductDefinition Definition => new ProductDefinition(S1ProductInstance.Definition);
 
         /// <summary>
-        /// Represents the definition of a product in the game, including its core properties.
+        /// Gets the list of properties associated with the product definition.
         /// </summary>
-        public ProductDefinition Definition => new ProductDefinition(S1ProductInstance.Definition);
-
-#endif
-
+        /// <remarks>
+        /// This property provides an unmodifiable list of properties associated
+        /// with the underlying product definition. Each property represents
+        /// a specific characteristic or behavior of the corresponding product.
+        /// </remarks>
+        public IReadOnlyList<S1Properties.Property> Properties => Definition.Properties;
     }
 }

S1API/Products/WeedDefinition.cs

@@ -1,11 +1,11 @@
 #if (IL2CPPMELON)
 using Il2CppScheduleOne.Product;
 using S1WeedDefinition = Il2CppScheduleOne.Product.WeedDefinition;
-using Properties = Il2CppScheduleOne.Properties;
+using S1Properties = Il2CppScheduleOne.Properties;
 #elif (MONOMELON || MONOBEPINEX || IL2CPPBEPINEX)
 using ScheduleOne.Product;
 using S1WeedDefinition = ScheduleOne.Product.WeedDefinition;
-using Properties = ScheduleOne.Properties;
+using S1Properties = ScheduleOne.Properties;
 #endif
 
 using S1API.Internal.Utils;
@@ -15,29 +15,19 @@
 namespace S1API.Products
 {
     /// <summary>
-    /// Represents a specific type of weed product definition. This class extends the functionality of
-    /// <see cref="ProductDefinition"/> to include details specific to weed products.
+    /// Represents a specific type of weed product definition.
     /// </summary>
-    /// <remarks>
-    /// This class provides methods and properties to work with weed-related product definitions,
-    /// including creating product instances and accessing weed-specific properties.
-    /// </remarks>
     public class WeedDefinition : ProductDefinition
     {
         /// <summary>
-        /// Represents the definition of a weed product in the ScheduleOne API.
-        /// Provides access to underlying data and functionalities specific to weed products.
+        /// INTERNAL: Strongly typed reference to Schedule One's WeedDefinition.
         /// </summary>
         internal S1WeedDefinition S1WeedDefinition =>
             CrossType.As<S1WeedDefinition>(S1ItemDefinition);
 
         /// <summary>
-        /// Represents a specific type of product definition for weed products in the API.
+        /// Represents a specific type of weed product definition.
         /// </summary>
-        /// <remarks>
-        /// This class acts as a wrapper for `Il2CppScheduleOne.Product.WeedDefinition`,
-        /// providing additional functionality and a specific type for handling weed items.
-        /// </remarks>
         internal WeedDefinition(S1WeedDefinition definition)
             : base(definition)
         {
@@ -47,37 +37,24 @@ internal WeedDefinition(S1WeedDefinition definition)
         /// Creates an instance of the product with the specified quantity.
         /// </summary>
         /// <param name="quantity">The quantity of the product to create. Defaults to 1 if not specified.</param>
-        /// <returns>An instance of <see cref="ItemInstance"/> representing the created product.</returns>
+        /// <returns>An <see cref="ItemInstance"/> representing the created product instance with the specified quantity.</returns>
         public override ItemInstance CreateInstance(int quantity = 1) =>
             new ProductInstance(CrossType.As<ProductItemInstance>(
                 S1WeedDefinition.GetDefaultInstance(quantity)));
 
         /// <summary>
-        /// Gets a list of properties associated with the current weed definition.
+        /// Retrieves a list of properties associated with this weed definition.
         /// </summary>
-        /// <returns>
-        /// A list of properties of type Il2CppScheduleOne.Properties.Property
-        /// associated with the weed definition. If no properties are found,
-        /// an empty list is returned.
-        /// </returns>
-#if IL2CPPMELON
-        public List<Properties.Property> GetProperties()
-#else
-        public List<Properties.Property> GetProperties()
-#endif
+        /// <returns>A list of properties of type <c>S1Properties.Property</c> that are linked with the current weed definition, or an empty list if none are found.</returns>
+        public List<S1Properties.Property> GetProperties()
         {
-#if  IL2CPPMELON
-            var result = new List<Properties.Property>();
-#else
-            var result = new List<Properties.Property>();
-            #endif
+            var result = new List<S1Properties.Property>();
             var list = S1WeedDefinition?.Properties;
+
             if (list != null)
             {
                 for (int i = 0; i < list.Count; i++)
-                {
                     result.Add(list[i]);
-                }
             }
 
             return result;