Merge branch 'master' into ci

Author: ViralBShah

.github/workflows/CI.yml

@@ -1,10 +1,24 @@
 name: CI
+
 on:
   pull_request:
+    paths:
+      - '.github/workflows/CI.yml'
+      - 'ext/**'
+      - 'src/**'
+      - 'test/**'
+      - 'Project.toml'
   push:
     branches:
       - master
     tags: '*'
+    paths:
+      - '.github/workflows/CI.yml'
+      - 'ext/**'
+      - 'src/**'
+      - 'test/**'
+      - 'Project.toml'
+
 jobs:
   test:
     name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ github.event_name }}
@@ -26,7 +40,7 @@ jobs:
           - os: macos-latest # Apple Silicon
             version: '1'
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.version }}

.github/workflows/Documenter.yml

@@ -1,9 +1,20 @@
 name: Documenter
+
 on:
   push:
     branches: [master]
     tags: [v*]
+    paths:
+      - '.github/workflows/Documenter.yml'
+      - 'docs/**'
+      - 'src/**'
+      - 'Project.toml'
   pull_request:
+    paths:
+      - '.github/workflows/Documenter.yml'
+      - 'docs/**'
+      - 'src/**'
+      - 'Project.toml'
 
 concurrency:
   # Skip intermediate builds: always.
@@ -22,7 +33,7 @@ jobs:
       # needed to allow the workflow to create a status with a link to the docs preview
       statuses: write
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@v2
         with:
           version: '1'
@@ -31,9 +42,8 @@ jobs:
         shell: julia --project=docs --color=yes {0}
         run: |
           using Pkg
-          Pkg.develop(PackageSpec(path=pwd()))
           Pkg.instantiate()
       - uses: julia-actions/julia-buildpkg@v1
-      - run: julia --project=docs docs/make.jl
+      - run: julia --project=docs --color=yes docs/make.jl
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/IntegrationTest.yml

@@ -2,10 +2,20 @@ name: IntegrationTest
 
 on:
   pull_request:
+    paths:
+      - '.github/workflows/IntegrationTest.yml'
+      - 'ext/**'
+      - 'src/**'
+      - 'Project.toml'
   push:
     branches:
       - master
     tags: '*'
+    paths:
+      - '.github/workflows/IntegrationTest.yml'
+      - 'ext/**'
+      - 'src/**'
+      - 'Project.toml'
 
 jobs:
   test:
@@ -20,19 +30,20 @@ jobs:
           - {user: JuliaMath, repo: FFTW.jl}
           - {user: JuliaApproximation, repo: FastTransforms.jl}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.julia-version }}
           arch: x64
+      - uses: julia-actions/cache@v2
       - uses: julia-actions/julia-buildpkg@v1
       - name: Clone Downstream
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
           path: downstream
       - name: Load this and run the downstream tests
-        shell: julia --project=downstream {0}
+        shell: julia --color=yes --project=downstream {0}
         run: |
           using Pkg
           try

.github/workflows/Invalidations.yml

@@ -2,6 +2,11 @@ name: Invalidations
 
 on:
   pull_request:
+    paths:
+      - '.github/workflows/Invalidations.yml'
+      - 'ext/**'
+      - 'src/**'
+      - 'Project.toml'
 
 concurrency:
   # Skip intermediate builds: always.
@@ -19,12 +24,13 @@ jobs:
     - uses: julia-actions/setup-julia@v2
       with:
         version: '1'
-    - uses: actions/checkout@v4
+    - uses: julia-actions/cache@v2
+    - uses: actions/checkout@v6
     - uses: julia-actions/julia-buildpkg@v1
     - uses: julia-actions/julia-invalidations@v1
       id: invs_pr
 
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v6
       with:
         ref: ${{ github.event.repository.default_branch }}
     - uses: julia-actions/julia-buildpkg@v1

docs/Project.toml

@@ -2,5 +2,8 @@
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"
 Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
 
+[sources]
+AbstractFFTs = { path = ".." }
+
 [compat]
-Documenter = "~0.25"
+Documenter = "^1"

src/definitions.jl

@@ -649,6 +649,9 @@ struct AdjointPlan{T,P<:Plan} <: Plan{T}
     AdjointPlan{T,P}(p) where {T,P} = new(p)
 end
 
+# We eagerly form the plan inverse in the adjoint(p) call, which will be cached for subsequent calls.
+# This is reasonable, as inv(p) would do the same, and necessary in order to compute the correct input
+# type for the adjoint plan and encode it in its type.
 """
     (p::Plan)'
     adjoint(p::Plan)
@@ -659,9 +662,6 @@ Return a plan that performs the adjoint operation of the original plan.
     Adjoint plans do not currently support `LinearAlgebra.mul!`. Further, as a new addition to `AbstractFFTs`, 
     coverage of `Base.adjoint` in downstream implementations may be limited. 
 """
-# We eagerly form the plan inverse in the adjoint(p) call, which will be cached for subsequent calls.
-# This is reasonable, as inv(p) would do the same, and necessary in order to compute the correct input
-# type for the adjoint plan and encode it in its type.
 Base.adjoint(p::Plan{T}) where {T} = AdjointPlan{eltype(inv(p)), typeof(p)}(p)
 Base.adjoint(p::AdjointPlan) = p.p
 # always have AdjointPlan inside ScaledPlan.