Skip to content

Allow Preview User to download files without requiring a Guestbook Re… - #12548

Closed
stevenwinship wants to merge 6 commits into
developfrom
12535-download-without-guestbook-response-for-preview-user
Closed

Allow Preview User to download files without requiring a Guestbook Re…#12548
stevenwinship wants to merge 6 commits into
developfrom
12535-download-without-guestbook-response-for-preview-user

remove need for signed url

33244d7
Select commit
Loading
Failed to load commit list.
Refresh
SonarQubeCloud / SonarCloud Code Analysis failed Jul 31, 2026 in 1m 33s

Quality Gate failed

Failed conditions
2.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 318 in src/main/java/edu/harvard/iq/dataverse/FileDownloadServiceBean.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof PrivateUrlUser privateurluser' 

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AZ-6Eli_HtWh4JupVvYJ&open=AZ-6Eli_HtWh4JupVvYJ&pullRequest=12548

Check warning on line 318 in src/main/java/edu/harvard/iq/dataverse/FileDownloadServiceBean.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary null check; "instanceof" returns false for nulls. 

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AZ-6Eli_HtWh4JupVvYK&open=AZ-6Eli_HtWh4JupVvYK&pullRequest=12548

Check warning on line 2239 in src/main/java/edu/harvard/iq/dataverse/api/Access.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof PrivateUrlUser privateurluser' 

See more on https://sonarcloud.io/project/issues?id=IQSS_dataverse&issues=AZ-6ElgBHtWh4JupVvYI&open=AZ-6ElgBHtWh4JupVvYI&pullRequest=12548
View more details on SonarQubeCloud