From f10860954d19ecf29484b93e97fc0f51b029c413 Mon Sep 17 00:00:00 2001 From: youseihuayu-wonderful Date: Fri, 31 Jul 2026 12:22:56 -0400 Subject: [PATCH 1/6] Fix Edit Metadata to always load latest dataset version Ignore the browsed version query param in EditDatasetMetadataFactory and fetch :latest instead, matching Edit Terms and JSF. Add component regression coverage and an issue playbook with verification steps. Co-authored-by: Cursor --- .../1024-edit-metadata-latest-version.md | 598 ++++++++++++++++++ .../EditDatasetMetadataFactory.tsx | 8 +- .../EditDatasetMetadataFactory.spec.tsx | 80 +++ 3 files changed, 683 insertions(+), 3 deletions(-) create mode 100644 docs/issues/1024-edit-metadata-latest-version.md create mode 100644 tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx diff --git a/docs/issues/1024-edit-metadata-latest-version.md b/docs/issues/1024-edit-metadata-latest-version.md new file mode 100644 index 000000000..dd57caa5b --- /dev/null +++ b/docs/issues/1024-edit-metadata-latest-version.md @@ -0,0 +1,598 @@ +# Issue #1024 — Edit Metadata: should always pre-populate the latest metadata + +| Field | Value | +| --- | --- | +| Status | **Implemented on branch `fix/1024-edit-metadata-latest-version`** — awaiting PR / upstream review | +| Labels | `bug`, `SPA`, `GREI Re-arch`, `Original size: 3` | +| Reporter | `ChengShi-1` (description from `@pdurbin`) | +| Issue URL | https://github.com/IQSS/dataverse-frontend/issues/1024 | +| Diagnosis baseline commit | `922dcfc` (`develop` tip when diagnosis was written) | +| Fix branch | `fix/1024-edit-metadata-latest-version` | +| Local package path | `/Users/shihuayu/Documents/GitHub/dataverse-frontend` | +| How to implement | Follow §8 Steps 0–7; every fix must pass §10 acceptance criteria | +| How to verify | Follow §18 (commands + expected outputs). Do not merge without green AC1–AC6 | + +--- + +## 1. Executive summary + +When a dataset has multiple published versions, the **legacy JSF** “Edit Metadata” flow always pre-fills the form from the **latest** metadata (draft if one exists, otherwise latest published), regardless of which version the user is currently viewing. + +The **SPA** incorrectly pre-fills from the **version currently being browsed**. That version is written into the edit-page URL as `?version=…` and then used as the fetch target in `EditDatasetMetadataFactory`. + +### Concrete failure (from the issue + Phil’s screenshot narrative) + +| Version | Title | Subtitle | +| --- | --- | --- | +| 1.0 | Test Dataset | *(empty)* | +| 2.0 | Test Dataset | My Subtitle | + +1. User opens the dataset page for **Version 1.0**. +2. User clicks **Edit Dataset → Metadata**. +3. **JSF (correct):** form shows Subtitle = `My Subtitle` (latest). +4. **SPA (bug):** form shows Subtitle empty (version 1.0). + +### Risk + +If the user saves from a form that was initialized with older metadata, they can **overwrite newer field values** on the draft that editing creates/updates — silent data loss relative to the latest published content. + +### Root cause (one sentence) + +`EditDatasetMetadataFactory` passes the URL `version` query param into `DatasetProvider` / `getDatasetByPersistentId`, instead of forcing `DatasetNonNumericVersion.LATEST` (`:latest`) the way `EditDatasetTermsFactory` already does. + +### Recommended fix (one sentence) + +In `EditDatasetMetadataFactory.tsx`, ignore the browsed `version` search param and always load `DatasetNonNumericVersion.LATEST`, matching Edit Terms; add regression tests for “enter Edit Metadata while viewing an older published version.” + +--- + +## 2. Expected vs actual behavior + +### 2.1 Product expectation (JSF parity) + +| User context | Click “Edit Metadata” | Form must show | +| --- | --- | --- | +| Viewing published `1.0` while `2.0` exists | Edit Metadata | Metadata of **latest** (`:latest` → draft if present, else latest published) | +| Viewing published `2.0` (already latest published) | Edit Metadata | Same latest metadata (no regression) | +| Viewing / working on `DRAFT` | Edit Metadata | Draft metadata (`:latest` resolves to draft when present) | + +**Important semantic of `:latest` in Dataverse:** draft if a draft exists; otherwise the latest published version. This is exactly what the Edit Terms factory comment documents and what JSF edit-metadata behavior matches. + +### 2.2 SPA actual behavior today + +| User context | URL after menu click | Dataset fetch version | Form | +| --- | --- | --- | --- | +| Viewing `1.0` | `.../edit-metadata?persistentId=…&version=1.0` | `1.0` | Old metadata | +| Viewing `2.0` | `...&version=2.0` | `2.0` | Happens to look correct if 2.0 is latest published and no draft | +| Viewing draft | `...&version=DRAFT` → domain `:draft` | `:draft` | Draft (often OK, but still “browsed version” coupling) | + +--- + +## 3. Architecture context (where this lives) + +```text +Dataset page (browse any version) + └─ DatasetActionButtons + └─ EditDatasetMenu ──navigate──► /datasets/edit-metadata?persistentId&version + │ + ▼ + EditDatasetMetadataFactory + │ + ▼ + DatasetProvider(getDatasetByPersistentId) + │ + ▼ + DatasetJSDataverseRepository.getByPersistentId + │ + ▼ + @iqss/dataverse-client-javascript getDataset.execute + │ + ▼ + Native API: GET .../versions/{versionId} + │ + ▼ + EditDatasetMetadata + │ + ▼ + DatasetMetadataForm(mode="edit") + defaults ← dataset.metadataBlocks +``` + +The form component is **not** the bug. It faithfully displays whatever `dataset.metadataBlocks` it receives. The bug is **which version is fetched** before the form mounts. + +--- + +## 4. Verified call chain (with file:line evidence) + +All line numbers refer to local tree at commit `922dcfc` unless noted. + +### 4.1 Route + +| Item | Location | +| --- | --- | +| Path enum | `src/sections/Route.enum.ts` — `EDIT_DATASET_METADATA = '/datasets/edit-metadata'` (line 12) | +| Query keys | `QueryParamKey.VERSION = 'version'`, `PERSISTENT_ID = 'persistentId'` (lines 96–98 area) | +| Route registration | `src/router/routes.tsx` — lazy `EditDatasetMetadataFactory.create()` on `Route.EDIT_DATASET_METADATA` | + +### 4.2 Navigation (contributes browsed version into the URL) + +File: `src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx` + +```39:55:src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx + const handleOnSelect = (eventKey: EditDatasetMenuItems | string | null) => { + const searchParams = new URLSearchParams() + searchParams.set(QueryParamKey.PERSISTENT_ID, dataset.persistentId) + + if (dataset.version.publishingStatus === DatasetPublishingStatus.DRAFT) { + searchParams.set(QueryParamKey.VERSION, DatasetNonNumericVersionSearchParam.DRAFT) + } else { + searchParams.set(QueryParamKey.VERSION, dataset.version.number.toString()) + } + // ... + if (eventKey === EditDatasetMenuItems.METADATA) { + navigate(`${Route.EDIT_DATASET_METADATA}?${searchParams.toString()}`) + return + } +``` + +When the user is viewing published version `1.0`, this navigates to: + +```text +/datasets/edit-metadata?persistentId=&version=1.0 +``` + +**Note:** The same menu also sets `version` for Terms and Upload Files. Edit **Terms** already ignores URL version in its factory (see §5). Upload Files may still need a version-aware URL — do **not** globally remove version from the menu without checking upload behavior. + +### 4.3 Factory (bug site — consumes URL version) + +File: `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx` + +```18:30:src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx +function EditDatasetMetadataWithParams() { + const [searchParams] = useSearchParams() + const persistentId = searchParams.get('persistentId') ?? undefined + const searchParamVersion = searchParams.get('version') ?? undefined + const version = searchParamVersionToDomainVersion(searchParamVersion) + + return ( + + + + ) +} +``` + +`searchParamVersionToDomainVersion` (`src/router/index.tsx` lines 11–17) only special-cases `DRAFT` → `:draft`; numeric versions like `1.0` pass through unchanged. + +### 4.4 Provider → use case → repository + +| Step | File | Behavior | +| --- | --- | --- | +| Provider | `src/sections/dataset/DatasetProvider.tsx` ~28–36 | Calls `getDatasetByPersistentId(repository, persistentId, searchParams.version, undefined, true)` | +| Use case | `src/dataset/domain/useCases/getDatasetByPersistentId.ts` | Delegates to repository | +| Repository | `src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts` ~213–220 | `getDataset.execute(persistentId, version, …)` via JS client | + +Default for `getByPersistentId` when version omitted is `DatasetNonNumericVersion.LATEST_PUBLISHED` (`:latest-published`) — but the factory **does not omit** version; it passes the browsed one explicitly. + +### 4.5 Form initialization (downstream, correct given inputs) + +File: `src/sections/edit-dataset-metadata/EditDatasetMetadata.tsx` ~61–68 + +```61:68:src/sections/edit-dataset-metadata/EditDatasetMetadata.tsx + +``` + +`DatasetMetadataForm` builds defaults via `MetadataFieldsHelper.getFormDefaultValues(...)` from those blocks (`src/sections/shared/form/DatasetMetadataForm/index.tsx`). + +### 4.6 Version domain constants + +File: `src/dataset/domain/models/Dataset.ts` ~210–217 + +```210:217:src/dataset/domain/models/Dataset.ts +export enum DatasetNonNumericVersion { + LATEST = ':latest', + DRAFT = ':draft', + LATEST_PUBLISHED = ':latest-published' +} +export enum DatasetNonNumericVersionSearchParam { + DRAFT = 'DRAFT' +} +``` + +| Constant | API `versionId` | Meaning | +| --- | --- | --- | +| `LATEST` | `:latest` | Draft if exists, else latest published — **use this for Edit Metadata** | +| `DRAFT` | `:draft` | Draft only | +| `LATEST_PUBLISHED` | `:latest-published` | Latest published only (skips draft) | + +**Do not** use `:latest-published` for Edit Metadata: if a draft already exists with newer edits, editors must see the draft. + +--- + +## 5. Proven correct pattern already in this repo (Edit Terms) + +File: `src/sections/edit-dataset-terms/EditDatasetTermsFactory.tsx` + +```19:29:src/sections/edit-dataset-terms/EditDatasetTermsFactory.tsx +function EditDatasetTermsWithSearchParams() { + const [searchParams] = useSearchParams() + const defaultActiveTabKey = EditDatasetTermsHelper.defineSelectedTabKey(searchParams) + const persistentId = searchParams.get('persistentId') ?? undefined + // Always load the latest version (draft if exists, otherwise latest published) + const version = DatasetNonNumericVersion.LATEST + + return ( + +``` + +Edit Terms receives the same menu URL shape (including `version=1.0`) but **ignores** it. Edit Metadata should do the same. This is the strongest in-repo proof that the intended SPA product behavior is “always `:latest` for edit screens.” + +--- + +## 6. End-to-end bug flowchart + +```mermaid +flowchart TD + A["User browses /datasets?persistentId=…&version=1.0"] --> B["EditDatasetMenu.handleOnSelect METADATA"] + B --> C["navigate /datasets/edit-metadata?persistentId=…&version=1.0"] + C --> D["EditDatasetMetadataFactory reads version from URL"] + D --> E["DatasetProvider → getDatasetByPersistentId … '1.0'"] + E --> F["JS client getDataset.execute → API versions/1.0"] + F --> G["Form defaults = v1 metadataBlocks"] + G --> H["Bug: Subtitle empty even though v2 has My Subtitle"] + + C2["Desired"] --> D2["Factory forces DatasetNonNumericVersion.LATEST"] + D2 --> E2["getDatasetByPersistentId … ':latest'"] + E2 --> F2["API versions/:latest"] + F2 --> G2["Form defaults = latest metadataBlocks"] +``` + +--- + +## 7. Specific solution (what to change) + +### 7.1 Primary fix (required) — Factory always uses `:latest` + +**File:** `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx` +**Function:** `EditDatasetMetadataWithParams` + +**Replace** the version extraction: + +```tsx +const searchParamVersion = searchParams.get('version') ?? undefined +const version = searchParamVersionToDomainVersion(searchParamVersion) +``` + +**With** (mirror Edit Terms): + +```tsx +import { DatasetNonNumericVersion } from '@/dataset/domain/models/Dataset' +// or relative import consistent with this file's style + +// Always load the latest version (draft if exists, otherwise latest published) +const version = DatasetNonNumericVersion.LATEST +``` + +**Remove** unused imports after the change (`searchParamVersionToDomainVersion` if no longer referenced). + +**Why this is the right primary fix** + +1. Matches JSF expectation stated in #1024. +2. Matches existing SPA Edit Terms pattern. +3. Fixes **deep links** to `/edit-metadata?...&version=1.0`, not only menu clicks. +4. Does not break the dataset **browse** page (which must still load the selected version). +5. Does not change `DatasetProvider` or repository defaults globally (avoids collateral damage). + +### 7.2 Optional cleanup — Menu URL for METADATA + +Optionally stop attaching a numeric `version` when navigating to Edit Metadata (Terms already ignores it). **Optional only** after Factory fix is in place; not required for correctness once Factory forces `:latest`. + +If you change the menu, keep Upload Files behavior reviewed separately — it still sets version for a reason. + +### 7.3 Explicitly out of scope / do not change + +| Do not | Why | +| --- | --- | +| Change browse-page version loading | Users must still view historical versions | +| Change `DatasetProvider` to always latest | Shared by browse + edit | +| Change form defaulting helpers | They are correct given inputs | +| Use `:latest-published` instead of `:latest` | Misses existing draft content | +| Redesign Edit Metadata UI | Issue is data-fetching only | + +### 7.4 Save / update path (sanity) + +After submit, navigation already targets draft (see `useSubmitDataset.ts` navigating with `VERSION=DRAFT`). Prefill must therefore also be latest/draft-aware so the user edits the same lineage they will save into. No change required there for #1024 if Factory uses `:latest`. + +--- + +## 8. Implementation playbook (Steps 0–7) + +### Step 0 — Baseline (broken) + +1. Use a dataset with ≥2 published versions where a field differs (e.g. subtitle added in v2). +2. Open SPA dataset page with `version=1.0`. +3. Edit Dataset → Metadata. +4. **Observe:** form shows v1 values (subtitle empty). +5. Optionally compare same click path on JSF: subtitle present. + +Record URL query string and network call version id (`1.0` vs `:latest`). + +### Step 1 — Apply Factory fix + +Edit `EditDatasetMetadataFactory.tsx` as in §7.1. + +### Step 2 — Manual verify (happy paths) + +| Case | Steps | Expected | +| --- | --- | --- | +| A | Browse v1 → Edit Metadata | Latest fields (e.g. subtitle from v2 or draft) | +| B | Browse latest published → Edit Metadata | Same latest fields (no regression) | +| C | With an existing draft that changed a field → Edit Metadata from any published version | Draft values appear (`:latest`) | +| D | Direct URL `/edit-metadata?persistentId=…&version=1.0` | Still loads `:latest`, not `1.0` | + +### Step 3 — Automated tests + +Existing coverage gaps (verified): + +| File | Current focus | Gap | +| --- | --- | --- | +| `tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx` | Breadcrumbs / skeleton / not-found; `searchParams = { persistentId }` only | No assertion that fetch uses `:latest` when URL has old version | +| `tests/e2e-integration/e2e/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx` | Visits with `version=DRAFT` only | No multi-version “from old published version” case | +| `tests/component/.../EditDatasetMenu.spec.tsx` | Menu click | Does not assert fetch version | + +**Add at least one of:** + +1. **Component / unit (preferred minimal):** Mount or exercise `EditDatasetMetadataFactory` (or route) with + `?persistentId=…&version=1.0` + and assert the repository `getByPersistentId` was called with `DatasetNonNumericVersion.LATEST` (`:latest`), **not** `"1.0"`. + +2. **E2E (strongest product proof):** + - Create dataset, publish v1 without subtitle. + - Add subtitle, publish v2. + - Visit dataset with `version=1.0`. + - Open Edit Metadata. + - Assert subtitle input shows v2 value. + +3. **Regression:** From latest version / draft, Edit Metadata still works (existing e2e paths should remain green). + +### Step 4 — Lint / typecheck / affected tests + +Run the project’s standard checks for touched files (per `CONTRIBUTING.md` / CI). At minimum run the edit-metadata component and e2e specs you touched. + +### Step 5 — PR description checklist + +- Link #1024 +- State: “Always load `:latest` in `EditDatasetMetadataFactory`, matching `EditDatasetTermsFactory` and JSF.” +- Note: browse page version selection unchanged +- List test cases added + +### Step 6 — Definition of done + +See §10. + +### Step 7 — Evidence to attach + +- Before/after screenshots (v1 browse → Edit Metadata subtitle) +- Network panel showing `versions/:latest` (or equivalent JS client version arg) +- Test output + +--- + +## 9. Suggested patch sketch (illustrative) + +```tsx +// EditDatasetMetadataFactory.tsx — after fix +import { ReactElement } from 'react' +import { useSearchParams } from 'react-router-dom' +import { EditDatasetMetadata } from './EditDatasetMetadata' +import { DatasetProvider } from '../dataset/DatasetProvider' +import { DatasetJSDataverseRepository } from '../../dataset/infrastructure/repositories/DatasetJSDataverseRepository' +import { MetadataBlockInfoJSDataverseRepository } from '../../metadata-block-info/infrastructure/repositories/MetadataBlockInfoJSDataverseRepository' +import { DatasetNonNumericVersion } from '../../dataset/domain/models/Dataset' + +const datasetRepository = new DatasetJSDataverseRepository() +const metadataBlockInfoRepository = new MetadataBlockInfoJSDataverseRepository() + +export class EditDatasetMetadataFactory { + static create(): ReactElement { + return + } +} + +function EditDatasetMetadataWithParams() { + const [searchParams] = useSearchParams() + const persistentId = searchParams.get('persistentId') ?? undefined + // Always load the latest version (draft if exists, otherwise latest published) + // See EditDatasetTermsFactory and IQSS/dataverse-frontend#1024 + const version = DatasetNonNumericVersion.LATEST + + return ( + + + + ) +} +``` + +Import path style should match surrounding files (`@/` vs relative) — keep consistency with this module / Edit Terms. + +--- + +## 10. Acceptance criteria (verifiable) + +| # | Criterion | How to verify | +| --- | --- | --- | +| AC1 | From an older published version, Edit Metadata shows **latest** field values | Manual case A + e2e | +| AC2 | Deep link with `version=` still loads latest | Manual case D + unit spy on repository | +| AC3 | From latest published / draft, Edit Metadata unchanged / correct | Manual B/C + existing e2e | +| AC4 | Dataset **browse** of historical versions still shows that version’s metadata | Browse v1 page still empty subtitle | +| AC5 | Implementation aligns with Edit Terms (`DatasetNonNumericVersion.LATEST`) | Code review | +| AC6 | Automated regression exists for AC1 or AC2 | CI green on new test | + +--- + +## 11. API mapping (for debugging) + +The SPA uses `@iqss/dataverse-client-javascript` `getDataset.execute(persistentId, version, …)`, which maps to Dataverse Native API: + +```text +GET /api/datasets/:persistentId/versions/:versionId?persistentId=... +``` + +| Scenario | `versionId` today (bug) | `versionId` after fix | +| --- | --- | --- | +| Browsing v1, click Edit Metadata | `1.0` | `:latest` | +| Draft exists | often `:draft` via menu | `:latest` (→ draft) | +| Latest published, no draft | `N.M` | `:latest` (→ that published) | + +When debugging in DevTools, confirm the version segment or client argument — not only the form UI. + +--- + +## 12. Test plan matrix + +| ID | Type | Setup | Action | Expect | +| --- | --- | --- | --- | --- | +| T1 | Manual | v1 no subtitle, v2 has subtitle | Browse v1 → Edit Metadata | Subtitle = v2 value | +| T2 | Manual | Same | Browse v2 → Edit Metadata | Subtitle = v2 value | +| T3 | Manual | Draft edits subtitle further | Browse v1 → Edit Metadata | Subtitle = draft value | +| T4 | Manual | Open `/edit-metadata?persistentId&version=1.0` | Load page | Same as latest, not v1 | +| T5 | Unit/component | Mock repository | Mount factory with `version=1.0` | `getByPersistentId(..., ':latest')` | +| T6 | E2E | Publish two versions | Automate T1 | Pass | +| T7 | Regression | Existing draft edit e2e | Run suite | Still pass | + +--- + +## 13. Risks and edge cases + +| Risk | Mitigation | +| --- | --- | +| Confusing `:latest` vs `:latest-published` | Use `LATEST` only; document draft preference | +| Menu still puts old version in URL | Harmless after Factory fix; optional cleanup | +| Permissions / deaccessioned versions | Existing menu disable / permission checks unchanged; retest if deaccessioned latest | +| Private URL datasets | Factory path uses `persistentId`; private-URL browse uses different provider entry — confirm Edit Metadata entry points still go through this factory | +| Concurrent draft from another user | Pre-existing conflict handling via `datasetLastUpdateTime` / API; out of scope for #1024 | + +--- + +## 14. Relationship to JSF (issue text) + +Quoted expectation from #1024 / `@pdurbin`: + +> In JSF, when you click "Edit Metadata", the latest metadata is pre-populated, no matter which version you're on. In the SPA, if I click "Edit Metadata" on version 1, the metadata from that version is pre-populated. + +There is **no** separate SPA design doc required: JSF behavior + Edit Terms factory are the specifications. + +--- + +## 15. Work estimate note + +Label **Original size: 3** fits: one focused factory change (and optional menu cleanup) plus tests. Risk is low if scope stays at Factory + tests and avoids global provider changes. + +--- + +## 16. Checklist for the implementer + +- [ ] Reproduce on SPA with multi-version dataset (Step 0) +- [ ] Change `EditDatasetMetadataFactory` to `DatasetNonNumericVersion.LATEST` +- [ ] Remove unused imports +- [ ] Manual cases A–D +- [ ] Add unit/component and/or e2e regression +- [ ] Confirm browse historical version still shows historical metadata +- [ ] Open PR linking #1024 with before/after evidence + +--- + +## 17. Implementation record (this branch) + +| Change | Path | What changed | +| --- | --- | --- | +| Factory fix | `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx` | Ignore URL `version`; always pass `DatasetNonNumericVersion.LATEST` (`:latest`) into `DatasetProvider` | +| Regression tests | `tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx` | Assert `getByPersistentId` is called with `:latest` when URL has `version=1.0`, and when URL omits `version` | +| This doc | `docs/issues/1024-edit-metadata-latest-version.md` | Diagnosis + playbook + verification | + +**Not changed (intentionally):** + +- Dataset browse page version loading +- `EditDatasetMenu` URL construction (harmless after Factory fix; Terms already ignored URL version) +- `DatasetProvider` / repository defaults +- Form defaulting helpers + +--- + +## 18. Verification instructions (must pass before PR) + +Every claim below is falsifiable. Record pass/fail. + +### 18.1 Automated (required) + +From repo root, with dependencies installed (`npm ci` if needed): + +```bash +# Focused regression for #1024 +npx cypress run --component --spec \ + tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx + +# Existing edit-metadata component suite (no regressions) +npx cypress run --component --spec \ + tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx +``` + +**Pass criteria:** + +| Spec | Expect | +| --- | --- | +| `EditDatasetMetadataFactory.spec.tsx` | Both tests green: call uses `:latest` / `DatasetNonNumericVersion.LATEST`, **not** `"1.0"` | +| `EditDatasetMetadata.spec.tsx` | All existing tests still green | + +**Fail if:** `getByPersistentId` is invoked with `"1.0"` for the old-version URL case. + +### 18.2 Manual product check (required for AC1) + +Prerequisite: dataset with ≥2 published versions where a field differs (e.g. title or subtitle added in v2). + +| Step | Action | Expected (pass) | Fail if | +| --- | --- | --- | --- | +| M1 | Open SPA dataset with `?version=1.0` | Browse page shows v1 content | — | +| M2 | Edit Dataset → Metadata | Network/API version is `:latest` (or draft via `:latest`) | Request is for `1.0` | +| M3 | Inspect form field that differs in v2 | Shows **latest** value | Shows empty / v1 value | +| M4 | Open Edit Metadata from latest published | Same latest values | Regression / blank form | +| M5 | If a draft exists with further edits, open Edit Metadata from v1 | Form shows **draft** values (`:latest`) | Shows published-only / v1 | + +### 18.3 Negative control (browse must stay historical) + +| Step | Action | Expected | +| --- | --- | --- | +| N1 | Stay on browse `?version=1.0` (do not edit) | Historical metadata still shown (e.g. missing subtitle) | + +If N1 fails, the fix was applied too broadly (e.g. Provider always latest) — revert and keep the change only in `EditDatasetMetadataFactory`. + +### 18.4 Code review checklist + +- [ ] Factory uses `DatasetNonNumericVersion.LATEST` only +- [ ] No use of `:latest-published` for this page +- [ ] Comment references #1024 / Edit Terms parity +- [ ] Unused `searchParamVersionToDomainVersion` import removed from Factory +- [ ] New component spec committed + +--- + +## 19. Document history + +| Date | Commit / branch | Notes | +| --- | --- | --- | +| 2026-07-31 | `922dcfc` on `develop` | Diagnosis + solution written from source | +| 2026-07-31 | `fix/1024-edit-metadata-latest-version` | Factory fix + component regression tests + verification §18 | diff --git a/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx b/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx index 9c7bdc77e..176198b38 100644 --- a/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx +++ b/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx @@ -4,7 +4,7 @@ import { EditDatasetMetadata } from './EditDatasetMetadata' import { DatasetProvider } from '../dataset/DatasetProvider' import { DatasetJSDataverseRepository } from '../../dataset/infrastructure/repositories/DatasetJSDataverseRepository' import { MetadataBlockInfoJSDataverseRepository } from '../../metadata-block-info/infrastructure/repositories/MetadataBlockInfoJSDataverseRepository' -import { searchParamVersionToDomainVersion } from '../../router' +import { DatasetNonNumericVersion } from '../../dataset/domain/models/Dataset' const datasetRepository = new DatasetJSDataverseRepository() const metadataBlockInfoRepository = new MetadataBlockInfoJSDataverseRepository() @@ -18,8 +18,10 @@ export class EditDatasetMetadataFactory { function EditDatasetMetadataWithParams() { const [searchParams] = useSearchParams() const persistentId = searchParams.get('persistentId') ?? undefined - const searchParamVersion = searchParams.get('version') ?? undefined - const version = searchParamVersionToDomainVersion(searchParamVersion) + // Always load the latest version (draft if exists, otherwise latest published). + // Ignore the browsed `version` query param so Edit Metadata matches JSF / Edit Terms + // (IQSS/dataverse-frontend#1024). + const version = DatasetNonNumericVersion.LATEST return ( { + const persistentId = 'doi:10.5072/FK2/EDITMETA' + + beforeEach(() => { + cy.stub(DatasetJSDataverseRepository.prototype, 'getByPersistentId').resolves(dataset) + cy.stub(DatasetJSDataverseRepository.prototype, 'updateMetadata').resolves(undefined) + cy.stub(DatasetJSDataverseRepository.prototype, 'getDatasetVersionsSummaries').resolves({ + summaries: [], + totalCount: 0 + }) + cy.stub(MetadataBlockInfoJSDataverseRepository.prototype, 'getByCollectionId').resolves( + metadataBlocksInfoOnEditMode + ) + cy.stub( + MetadataBlockInfoJSDataverseRepository.prototype, + 'getDisplayedOnCreateByCollectionId' + ).resolves(metadataBlocksInfoOnCreateMode) + }) + + it('always fetches :latest when the URL carries an older published version (issue #1024)', () => { + const initialEntry = `${Route.EDIT_DATASET_METADATA}?${QueryParamKey.PERSISTENT_ID}=${encodeURIComponent( + persistentId + )}&${QueryParamKey.VERSION}=1.0` + + cy.customMount({EditDatasetMetadataFactory.create()}, [ + initialEntry + ]) + + cy.wrap(DatasetJSDataverseRepository.prototype.getByPersistentId).should( + 'have.been.calledWith', + persistentId, + DatasetNonNumericVersion.LATEST, + undefined, + true + ) + cy.wrap(DatasetJSDataverseRepository.prototype.getByPersistentId).should( + 'not.have.been.calledWith', + persistentId, + '1.0', + undefined, + true + ) + + cy.findByTestId('edit-dataset-metadata-skeleton').should('not.exist') + cy.findByText(/^Host Collection/i).should('exist') + }) + + it('still fetches :latest when the URL has no version param', () => { + const initialEntry = `${Route.EDIT_DATASET_METADATA}?${QueryParamKey.PERSISTENT_ID}=${encodeURIComponent( + persistentId + )}` + + cy.customMount({EditDatasetMetadataFactory.create()}, [ + initialEntry + ]) + + cy.wrap(DatasetJSDataverseRepository.prototype.getByPersistentId).should( + 'have.been.calledWith', + persistentId, + DatasetNonNumericVersion.LATEST, + undefined, + true + ) + }) +}) From 0b573ad3f2cffbf13d909f231f6eacc5f171c188 Mon Sep 17 00:00:00 2001 From: youseihuayu-wonderful Date: Fri, 31 Jul 2026 12:24:30 -0400 Subject: [PATCH 2/6] Add HTML verification report for Edit Metadata latest-version fix Document before/after fetch arguments, form outputs for the #1024 scenario, and the exact automated/manual checks that complete the fix. Co-authored-by: Cursor --- ...-metadata-latest-version-verification.html | 511 ++++++++++++++++++ 1 file changed, 511 insertions(+) create mode 100644 docs/issues/1024-edit-metadata-latest-version-verification.html diff --git a/docs/issues/1024-edit-metadata-latest-version-verification.html b/docs/issues/1024-edit-metadata-latest-version-verification.html new file mode 100644 index 000000000..0fb336852 --- /dev/null +++ b/docs/issues/1024-edit-metadata-latest-version-verification.html @@ -0,0 +1,511 @@ + + + + + + Issue #1024 — Edit Metadata Latest Version: Fix Verification Report + + + +
+
+

IQSS/dataverse-frontend · Issue #1024 · Verification Report

+

Edit Metadata must always pre-populate the latest metadata

+

+ This report shows the original bug (wrong version used to initialize the edit form), + the exact code fix, the expected outputs before vs after, and how to verify the fix + is complete against the issue statement. +

+
+
Issue
#1024
+
Branch
fix/1024-edit-metadata-latest-version
+
Commit
f108609
+
Primary file
EditDatasetMetadataFactory.tsx
+
+
+ +

1. Original issue (exact requirement)

+
+

Product rule (JSF parity): No matter which historical dataset version the user is viewing, clicking Edit Metadata must pre-fill the form with the latest metadata (:latest = draft if present, else latest published).

+

SPA bug: The form was pre-filled from the browsed version in the URL (?version=1.0), so older fields appeared and newer values could be overwritten on save.

+
+ +

Scenario dataset (from the issue)

+ + + + + + + + +
VersionTitleSubtitle
1.0Test Dataset(empty)
2.0 (latest published)Test DatasetMy Subtitle
+

User action: open Version 1.0 → Edit Dataset → Metadata.

+ +

2. What was parsed / loaded wrongly (BEFORE)

+
+ Bug path +
+ Browse ?version=1.0 + → + Menu writes URL version=1.0 + → + Factory reads URL version + → + Fetch API versions/1.0 + → + Form defaults = v1 blocks +
+
+ +

Wrong Factory logic (before)

+
// EditDatasetMetadataFactory.tsx — BEFORE (bug)
+const searchParamVersion = searchParams.get('version') ?? undefined
+const version = searchParamVersionToDomainVersion(searchParamVersion)
+// If URL is ...&version=1.0  →  version === "1.0"
+// DatasetProvider fetches that historical version
+ +
+
+ Before · fetch argument + 
getByPersistentId(
+  "doi:…",
+  "1.0",          // ← browsed / wrong
+  undefined,
+  true
+)
+

API equivalent: .../versions/1.0

+
+
+ Before · form output (wrong) +
+
+ +
Test Dataset
+
+
+ +
(empty — Version 1 metadata)
+
+
+

FAIL vs issue expectation

+

JSF would show Subtitle = My Subtitle. SPA showed empty.

+
+
+ +

3. What was fixed (AFTER)

+
+ Fixed path +
+ Browse ?version=1.0 + → + Menu may still pass version=1.0 in URL + → + Factory ignores URL version + → + Fetch :latest + → + Form defaults = latest blocks +
+

Same pattern as EditDatasetTermsFactory (already correct in this repo).

+
+ +

Fixed Factory logic

+
// EditDatasetMetadataFactory.tsx — AFTER (fix)
+const persistentId = searchParams.get('persistentId') ?? undefined
+// Always load the latest version (draft if exists, otherwise latest published).
+// Ignore the browsed `version` query param (IQSS/dataverse-frontend#1024).
+const version = DatasetNonNumericVersion.LATEST  // ":latest"
+
+return (
+  <DatasetProvider
+    repository={datasetRepository}
+    searchParams={{ persistentId, version }}>
+    <EditDatasetMetadata ... />
+  </DatasetProvider>
+)
+ +
+
+ After · fetch argument + 
getByPersistentId(
+  "doi:…",
+  ":latest",     // ← DatasetNonNumericVersion.LATEST
+  undefined,
+  true
+)
+

API equivalent: .../versions/:latest

+

:latest = draft if one exists, else latest published (here Version 2.0).

+
+
+ After · form output (correct) +
+
+ +
Test Dataset
+
+
+ +
My Subtitle
+
+
+

PASS vs issue expectation

+

Matches JSF: latest metadata pre-populated.

+
+
+ +

4. Side-by-side comparison

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
CheckpointBefore (bug)After (fix)Issue requirement
User viewing/datasets?persistentId=…&version=1.0
Edit Metadata URL may containversion=1.0version=1.0 (ignored)N/A — output must be latest
Factory version variable"1.0" from URL":latest" constantAlways latest
Repository callgetByPersistentId(pid, "1.0", …)getByPersistentId(pid, ":latest", …)Latest metadata source
Subtitle in formemptyMy SubtitleMy Subtitle
Browse page v1 still historical?yesyes (unchanged)Must remain historical
+ +

5. How to verify the fix is completed

+
+ Definition of done +

The fix is complete for #1024 only when all of the following pass. Code presence alone is not enough without the automated and/or manual checks.

+
+ +

A. Static code verification (already on this branch)

+
    +
  • DONE — EditDatasetMetadataFactory.tsx sets version = DatasetNonNumericVersion.LATEST
    • +
  • DONE — URL version query param is no longer passed into DatasetProvider
    • +
  • DONE — Regression spec asserts call with :latest and not "1.0"
    • +
  • DONE — Matches Edit Terms factory pattern
    • +
+ +

B. Automated verification (required)

+

From repo root (needs working npm auth for @IQSS/dataverse-client-javascript):

+
npx cypress run --component --spec \
+  tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
+
+npx cypress run --component --spec \
+  tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx
+ + + + + + + + + + + + + + + + +
TestVerified result if green
always fetches :latest when the URL carries an older published versionEven with URL version=1.0, getByPersistentId is called with DatasetNonNumericVersion.LATEST (:latest), never "1.0".
still fetches :latest when the URL has no version paramMissing version param still loads latest (no accidental undefined / published-only default).
Existing EditDatasetMetadata.spec.tsxNo regression on breadcrumbs / host collection / not-found.
+

NOTE: On this machine, npm install failed with GitHub Packages 401 for @IQSS/dataverse-client-javascript, so Cypress was not executed here. Run the commands above in an authenticated environment and record green results before merging.

+ +

C. Manual product verification (original issue scenario)

+
    +
  1. Create/publish Version 1.0 without subtitle.
    2. +
  2. Add subtitle My Subtitle, publish Version 2.0.
    3. +
  3. Open SPA: /datasets?persistentId=…&version=1.0 — browse still shows empty subtitle.
    4. +
  4. Click Edit Dataset → Metadata.
    5. +
  5. PASS if Subtitle input = My Subtitle.
    6. +
  6. FAIL if Subtitle is empty.
    7. +
  7. Optional DevTools check: dataset fetch uses version :latest, not 1.0.
    8. +
+ +

D. Negative control (must not break browse)

+

On ?version=1.0 without opening Edit Metadata, the dataset page must still show Version 1 content (empty subtitle). If browse also shows latest, the fix was applied too broadly.

+ +

6. Expected verified result summary

+ + + + + + + + + + + + + + + + + + + + + + + + + + +
LayerExpected verified result after fixStatus on branch f108609
CodeFactory hard-codes :latestVerified by source review
Unit/componentStub shows call args (pid, ":latest", undefined, true)Spec written; run Cypress locally to confirm green
UI / issue scenarioFrom v1 browse → Edit Metadata → Subtitle = My SubtitleManual / e2e after env install
ParitySame behavior as JSF + Edit TermsDesign parity verified in code
+ +

7. Files touched

+ + + + + + + + + + + + + + + + + + + + +
FileRole
src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsxProduction fix
tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsxAutomated regression
docs/issues/1024-edit-metadata-latest-version.mdFull engineering playbook
docs/issues/1024-edit-metadata-latest-version-verification.htmlThis visual verification report
+ +
+ Generated for IQSS/dataverse-frontend issue + #1024 + on branch fix/1024-edit-metadata-latest-version + (f108609). + Open this file in a browser to review before/after outputs. +
+
+ + From e81ed165a8c4f5f68c037bd1a59d5a8e41eddcde Mon Sep 17 00:00:00 2001 From: youseihuayu-wonderful Date: Fri, 31 Jul 2026 13:36:12 -0400 Subject: [PATCH 3/6] Add PR draft notes and fix Cypress stub lint for #1024 Keep draft title/body on the branch for later publishing, and avoid unbound-method lint errors in the Factory regression spec. Co-authored-by: Cursor --- ...-metadata-latest-version-verification.html | 1058 ++++++++++------- .../1024-edit-metadata-latest-version.md | 237 ++-- docs/issues/PR-1024-DRAFT-BODY.md | 17 + docs/issues/PR-1024-DRAFT.md | 54 + .../EditDatasetMetadataFactory.spec.tsx | 23 +- 5 files changed, 808 insertions(+), 581 deletions(-) create mode 100644 docs/issues/PR-1024-DRAFT-BODY.md create mode 100644 docs/issues/PR-1024-DRAFT.md diff --git a/docs/issues/1024-edit-metadata-latest-version-verification.html b/docs/issues/1024-edit-metadata-latest-version-verification.html index 0fb336852..f43d45faa 100644 --- a/docs/issues/1024-edit-metadata-latest-version-verification.html +++ b/docs/issues/1024-edit-metadata-latest-version-verification.html @@ -1,308 +1,401 @@ - - - - Issue #1024 — Edit Metadata Latest Version: Fix Verification Report - - - -
-
-

IQSS/dataverse-frontend · Issue #1024 · Verification Report

-

Edit Metadata must always pre-populate the latest metadata

-

- This report shows the original bug (wrong version used to initialize the edit form), - the exact code fix, the expected outputs before vs after, and how to verify the fix - is complete against the issue statement. -

-
-
Issue
#1024
-
Branch
fix/1024-edit-metadata-latest-version
-
Commit
f108609
-
Primary file
EditDatasetMetadataFactory.tsx
-
-
+ + + + Issue #1024 — Edit Metadata Latest Version: Fix Verification Report + + + +
+
+

IQSS/dataverse-frontend · Issue #1024 · Verification Report

+

Edit Metadata must always pre-populate the latest metadata

+

+ This report shows the original bug (wrong version used to initialize the edit form), the + exact code fix, the expected outputs before vs after, and how to verify the fix is + complete against the issue statement. +

+
+
+
Issue
+
#1024
+
+
+
Branch
+
fix/1024-edit-metadata-latest-version
+
+
+
Commit
+
f108609
+
+
+
Primary file
+
EditDatasetMetadataFactory.tsx
+
+
+
-

1. Original issue (exact requirement)

-
-

Product rule (JSF parity): No matter which historical dataset version the user is viewing, clicking Edit Metadata must pre-fill the form with the latest metadata (:latest = draft if present, else latest published).

-

SPA bug: The form was pre-filled from the browsed version in the URL (?version=1.0), so older fields appeared and newer values could be overwritten on save.

-
+

1. Original issue (exact requirement)

+
+

+ Product rule (JSF parity): No matter which historical dataset version the + user is viewing, clicking Edit Metadata must pre-fill the form with the + latest metadata (:latest = draft if present, else latest + published). +

+

+ SPA bug: The form was pre-filled from the browsed version in the + URL (?version=1.0), so older fields appeared and newer values could be + overwritten on save. +

+
-

Scenario dataset (from the issue)

- - - - - - - - -
VersionTitleSubtitle
1.0Test Dataset(empty)
2.0 (latest published)Test DatasetMy Subtitle
-

User action: open Version 1.0 → Edit Dataset → Metadata.

+

Scenario dataset (from the issue)

+ + + + + + + + + + + + + + + + + + + + +
VersionTitleSubtitle
1.0Test Dataset(empty)
2.0 (latest published)Test DatasetMy Subtitle
+

User action: open Version 1.0 → Edit Dataset → Metadata.

-

2. What was parsed / loaded wrongly (BEFORE)

-
- Bug path -
- Browse ?version=1.0 - → - Menu writes URL version=1.0 - → - Factory reads URL version - → - Fetch API versions/1.0 - → - Form defaults = v1 blocks +

2. What was parsed / loaded wrongly (BEFORE)

+
+ Bug path +
+ Browse ?version=1.0 + → + Menu writes URL version=1.0 + → + Factory reads URL version + → + Fetch API versions/1.0 + → + Form defaults = v1 blocks +
-
-

Wrong Factory logic (before)

-
// EditDatasetMetadataFactory.tsx — BEFORE (bug)
+      
Wrong Factory logic (before)

+      
// EditDatasetMetadataFactory.tsx — BEFORE (bug)
 const searchParamVersion = searchParams.get('version') ?? undefined
 const version = searchParamVersionToDomainVersion(searchParamVersion)
 // If URL is ...&version=1.0  →  version === "1.0"
 // DatasetProvider fetches that historical version

 
-    

-      

-        Before · fetch argument
-        
getByPersistentId(
+      

+        

+          Before · fetch argument
+          
getByPersistentId(
   "doi:…",
   "1.0",          // ← browsed / wrong
   undefined,
   true
 )

-        
API equivalent: .../versions/1.0

-      

-      

-        Before · form output (wrong)
-        

-          

-            
-            
Test Dataset

-          

-          

-            
-            
(empty — Version 1 metadata)

+          
API equivalent: .../versions/1.0

+        

+        

+          Before · form output (wrong)
+          

+            

+              
+              
Test Dataset

+            

+            

+              
+              
(empty — Version 1 metadata)

+            

           

+          
FAIL vs issue expectation

+          
JSF would show Subtitle = My Subtitle. SPA showed empty.

         

-        
FAIL vs issue expectation

-        
JSF would show Subtitle = My Subtitle. SPA showed empty.

       

-    

 
-    
3. What was fixed (AFTER)

-    

-      Fixed path
-      

-        Browse ?version=1.0
-        →
-        Menu may still pass version=1.0 in URL
-        →
-        Factory ignores URL version
-        →
-        Fetch :latest
-        →
-        Form defaults = latest blocks
+      
3. What was fixed (AFTER)

+      

+        Fixed path
+        

+          Browse ?version=1.0
+          →
+          Menu may still pass version=1.0 in URL
+          →
+          Factory ignores URL version
+          →
+          Fetch :latest
+          →
+          Form defaults = latest blocks
+        

+        
Same pattern as EditDatasetTermsFactory (already correct in this repo).

       

-      
Same pattern as EditDatasetTermsFactory (already correct in this repo).

-    

 
-    
Fixed Factory logic

-
// EditDatasetMetadataFactory.tsx — AFTER (fix)
+      
Fixed Factory logic

+      
// EditDatasetMetadataFactory.tsx — AFTER (fix)
 const persistentId = searchParams.get('persistentId') ?? undefined
 // Always load the latest version (draft if exists, otherwise latest published).
 // Ignore the browsed `version` query param (IQSS/dataverse-frontend#1024).
@@ -316,196 +409,255 @@ 
Fixed Factory logic

   </DatasetProvider>
 )

 
-    

-      

-        After · fetch argument
-        
getByPersistentId(
+      

+        

+          After · fetch argument
+          
getByPersistentId(
   "doi:…",
   ":latest",     // ← DatasetNonNumericVersion.LATEST
   undefined,
   true
 )

-        
API equivalent: .../versions/:latest

-        
:latest = draft if one exists, else latest published (here Version 2.0).

-      

-      

-        After · form output (correct)
-        

-          

-            
-            
Test Dataset

-          

-          

-            
-            
My Subtitle

+          
API equivalent: .../versions/:latest

+          

+            :latest = draft if one exists, else latest published (here Version 2.0).
+          

+        

+        

+          After · form output (correct)
+          

+            

+              
+              
Test Dataset

+            

+            

+              
+              
My Subtitle

+            

           

+          
PASS vs issue expectation

+          
Matches JSF: latest metadata pre-populated.

         

-        
PASS vs issue expectation

-        
Matches JSF: latest metadata pre-populated.

       

-    

 
-    
4. Side-by-side comparison

-    
-      
-        
-          
-          
-          
-          
-        
-      
-      
-        
-          
-          
-        
-        
-          
-          
-          
-          
-        
-        
-          
-          
-          
-          
-        
-        
-          
-          
-          
-          
-        
-        
-          
-          
-          
-          
-        
-        
-          
-          
-          
-          
-        
-      
-    
CheckpointBefore (bug)After (fix)Issue requirement
User viewing/datasets?persistentId=…&version=1.0
Edit Metadata URL may containversion=1.0version=1.0 (ignored)N/A — output must be latest
Factory version variable"1.0" from URL":latest" constantAlways latest
Repository callgetByPersistentId(pid, "1.0", …)getByPersistentId(pid, ":latest", …)Latest metadata source
Subtitle in formemptyMy SubtitleMy Subtitle
Browse page v1 still historical?yesyes (unchanged)Must remain historical

+      
4. Side-by-side comparison

+      
+        
+          
+            
+            
+            
+            
+          
+        
+        
+          
+            
+            
+          
+          
+            
+            
+            
+            
+          
+          
+            
+            
+            
+            
+          
+          
+            
+            
+            
+            
+          
+          
+            
+            
+            
+            
+          
+          
+            
+            
+            
+            
+          
+        
+      
CheckpointBefore (bug)After (fix)Issue requirement
User viewing/datasets?persistentId=…&version=1.0
Edit Metadata URL may containversion=1.0version=1.0 (ignored)N/A — output must be latest
Factory version variable"1.0" from URL":latest" constantAlways latest
Repository callgetByPersistentId(pid, "1.0", …)getByPersistentId(pid, ":latest", …)Latest metadata source
Subtitle in formemptyMy SubtitleMy Subtitle
Browse page v1 still historical?yesyes (unchanged)Must remain historical

 
-    
5. How to verify the fix is completed

-    

-      Definition of done
-      
The fix is complete for #1024 only when all of the following pass. Code presence alone is not enough without the automated and/or manual checks.

-    

+      
5. How to verify the fix is completed

+      

+        Definition of done
+        

+          The fix is complete for #1024 only when all of the
+          following pass. Code presence alone is not enough without the automated and/or manual
+          checks.
+        

+      

 
-    
A. Static code verification (already on this branch)

-    
    
-      
  • DONE — EditDatasetMetadataFactory.tsx sets version = DatasetNonNumericVersion.LATEST
    • 
-      
  • DONE — URL version query param is no longer passed into DatasetProvider
    • 
-      
  • DONE — Regression spec asserts call with :latest and not "1.0"
    • 
-      
  • DONE — Matches Edit Terms factory pattern
    • 
-    

+      
A. Static code verification (already on this branch)

+      
    
+        
  • 
+          DONE — EditDatasetMetadataFactory.tsx sets
+          version = DatasetNonNumericVersion.LATEST
+        
    • 
+        
  • 
+          DONE — URL version query param is no longer passed
+          into DatasetProvider
+        
    • 
+        
  • 
+          DONE — Regression spec asserts call with
+          :latest and not "1.0"
+        
    • 
+        
  • DONE — Matches Edit Terms factory pattern
    • 
+      

 
-    
B. Automated verification (required)

-    
From repo root (needs working npm auth for @IQSS/dataverse-client-javascript):

-
npx cypress run --component --spec \
+      
B. Automated verification (required)

+      

+        From repo root (needs working npm auth for
+        @IQSS/dataverse-client-javascript):
+      

+      
npx cypress run --component --spec \
   tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
 
 npx cypress run --component --spec \
   tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx

-    
-      
-      
-        
-          
-          
-        
-        
-          
-          
-        
-        
-          
-          
-        
-      
-    
TestVerified result if green
always fetches :latest when the URL carries an older published versionEven with URL version=1.0, getByPersistentId is called with DatasetNonNumericVersion.LATEST (:latest), never "1.0".
still fetches :latest when the URL has no version paramMissing version param still loads latest (no accidental undefined / published-only default).
Existing EditDatasetMetadata.spec.tsxNo regression on breadcrumbs / host collection / not-found.

-    
NOTE: On this machine, npm install failed with GitHub Packages 401 for @IQSS/dataverse-client-javascript, so Cypress was not executed here. Run the commands above in an authenticated environment and record green results before merging.

+      
+        
+          
+            
+            
+          
+        
+        
+          
+            
+            
+          
+          
+            
+            
+          
+          
+            
+            
+          
+        
+      
TestVerified result if green

+              always fetches :latest when the URL carries an older published version
+            
+              Even with URL version=1.0, getByPersistentId is called with
+              DatasetNonNumericVersion.LATEST (:latest), never
+              "1.0".
+            
still fetches :latest when the URL has no version param
+              Missing version param still loads latest (no accidental undefined /
+              published-only default).
+            
Existing EditDatasetMetadata.spec.tsxNo regression on breadcrumbs / host collection / not-found.

+      

+        NOTE: On this machine, npm install failed with
+        GitHub Packages 401 for @IQSS/dataverse-client-javascript, so
+        Cypress was not executed here. Run the commands above in an authenticated environment and
+        record green results before merging.
+      

 
-    
C. Manual product verification (original issue scenario)

-    
    
-      
  1. Create/publish Version 1.0 without subtitle.
    2. 
-      
  2. Add subtitle My Subtitle, publish Version 2.0.
    3. 
-      
  3. Open SPA: /datasets?persistentId=…&version=1.0 — browse still shows empty subtitle.
    4. 
-      
  4. Click Edit Dataset → Metadata.
    5. 
-      
  5. PASS if Subtitle input = My Subtitle.
    6. 
-      
  6. FAIL if Subtitle is empty.
    7. 
-      
  7. Optional DevTools check: dataset fetch uses version :latest, not 1.0.
    8. 
-    

+      
C. Manual product verification (original issue scenario)

+      
    
+        
  1. Create/publish Version 1.0 without subtitle.
    2. 
+        
  2. Add subtitle My Subtitle, publish Version 2.0.
    3. 
+        
  3. 
+          Open SPA: /datasets?persistentId=…&version=1.0 — browse still shows empty
+          subtitle.
+        
    4. 
+        
  4. Click Edit Dataset → Metadata.
    5. 
+        
  5. PASS if Subtitle input = My Subtitle.
    6. 
+        
  6. FAIL if Subtitle is empty.
    7. 
+        
  7. 
+          Optional DevTools check: dataset fetch uses version :latest, not
+          1.0.
+        
    8. 
+      

 
-    
D. Negative control (must not break browse)

-    
On ?version=1.0 without opening Edit Metadata, the dataset page must still show Version 1 content (empty subtitle). If browse also shows latest, the fix was applied too broadly.

+      
D. Negative control (must not break browse)

+      

+        On ?version=1.0 without opening Edit Metadata, the dataset page must
+        still show Version 1 content (empty subtitle). If browse also shows latest, the fix was
+        applied too broadly.
+      

 
-    
6. Expected verified result summary

-    
-      
-        
-      
-      
-        
-          
-          
-          
-        
-        
-          
-          
-          
-        
-        
-          
-          
-          
-        
-        
-          
-          
-          
-        
-      
-    
LayerExpected verified result after fixStatus on branch f108609
CodeFactory hard-codes :latestVerified by source review
Unit/componentStub shows call args (pid, ":latest", undefined, true)Spec written; run Cypress locally to confirm green
UI / issue scenarioFrom v1 browse → Edit Metadata → Subtitle = My SubtitleManual / e2e after env install
ParitySame behavior as JSF + Edit TermsDesign parity verified in code

+      
6. Expected verified result summary

+      
+        
+          
+            
+            
+            
+          
+        
+        
+          
+            
+            
+            
+          
+          
+            
+            
+            
+          
+          
+            
+            
+            
+          
+          
+            
+            
+            
+          
+        
+      
LayerExpected verified result after fixStatus on branch f108609
CodeFactory hard-codes :latestVerified by source review
Unit/componentStub shows call args (pid, ":latest", undefined, true)Spec written; run Cypress locally to confirm green
UI / issue scenarioFrom v1 browse → Edit Metadata → Subtitle = My SubtitleManual / e2e after env install
ParitySame behavior as JSF + Edit TermsDesign parity verified in code

 
-    
7. Files touched

-    
-      
-      
-        
-          
-          
-        
-        
-          
-          
-        
-        
-          
-          
-        
-        
-          
-          
-        
-      
-    
FileRole
src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsxProduction fix
tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsxAutomated regression
docs/issues/1024-edit-metadata-latest-version.mdFull engineering playbook
docs/issues/1024-edit-metadata-latest-version-verification.htmlThis visual verification report

+      
7. Files touched

+      
+        
+          
+            
+            
+          
+        
+        
+          
+            
+            
+          
+          
+            
+            
+          
+          
+            
+            
+          
+          
+            
+            
+          
+        
+      
FileRole
src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsxProduction fix

+              tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
+            Automated regression
docs/issues/1024-edit-metadata-latest-version.mdFull engineering playbook
docs/issues/1024-edit-metadata-latest-version-verification.htmlThis visual verification report

 
-    

-      Generated for IQSS/dataverse-frontend issue
-      #1024
-      on branch fix/1024-edit-metadata-latest-version
-      (f108609).
-      Open this file in a browser to review before/after outputs.
-    

-  

-
+      

+        Generated for IQSS/dataverse-frontend issue
+        #1024
+        on branch fix/1024-edit-metadata-latest-version (f108609). Open this file in a browser to review before/after outputs.
+      

+    

+  
 
diff --git a/docs/issues/1024-edit-metadata-latest-version.md b/docs/issues/1024-edit-metadata-latest-version.md
index dd57caa5b..29072ce38 100644
--- a/docs/issues/1024-edit-metadata-latest-version.md
+++ b/docs/issues/1024-edit-metadata-latest-version.md
@@ -1,16 +1,16 @@
 # Issue #1024 — Edit Metadata: should always pre-populate the latest metadata
 
-| Field | Value |
-| --- | --- |
-| Status | **Implemented on branch `fix/1024-edit-metadata-latest-version`** — awaiting PR / upstream review |
-| Labels | `bug`, `SPA`, `GREI Re-arch`, `Original size: 3` |
-| Reporter | `ChengShi-1` (description from `@pdurbin`) |
-| Issue URL | https://github.com/IQSS/dataverse-frontend/issues/1024 |
-| Diagnosis baseline commit | `922dcfc` (`develop` tip when diagnosis was written) |
-| Fix branch | `fix/1024-edit-metadata-latest-version` |
-| Local package path | `/Users/shihuayu/Documents/GitHub/dataverse-frontend` |
-| How to implement | Follow §8 Steps 0–7; every fix must pass §10 acceptance criteria |
-| How to verify | Follow §18 (commands + expected outputs). Do not merge without green AC1–AC6 |
+| Field                     | Value                                                                                             |
+| ------------------------- | ------------------------------------------------------------------------------------------------- |
+| Status                    | **Implemented on branch `fix/1024-edit-metadata-latest-version`** — awaiting PR / upstream review |
+| Labels                    | `bug`, `SPA`, `GREI Re-arch`, `Original size: 3`                                                  |
+| Reporter                  | `ChengShi-1` (description from `@pdurbin`)                                                        |
+| Issue URL                 | https://github.com/IQSS/dataverse-frontend/issues/1024                                            |
+| Diagnosis baseline commit | `922dcfc` (`develop` tip when diagnosis was written)                                              |
+| Fix branch                | `fix/1024-edit-metadata-latest-version`                                                           |
+| Local package path        | `/Users/shihuayu/Documents/GitHub/dataverse-frontend`                                             |
+| How to implement          | Follow §8 Steps 0–7; every fix must pass §10 acceptance criteria                                  |
+| How to verify             | Follow §18 (commands + expected outputs). Do not merge without green AC1–AC6                      |
 
 ---
 
@@ -22,10 +22,10 @@ The **SPA** incorrectly pre-fills from the **version currently being browsed**.
 
 ### Concrete failure (from the issue + Phil’s screenshot narrative)
 
-| Version | Title | Subtitle |
-| --- | --- | --- |
-| 1.0 | Test Dataset | *(empty)* |
-| 2.0 | Test Dataset | My Subtitle |
+| Version | Title        | Subtitle    |
+| ------- | ------------ | ----------- |
+| 1.0     | Test Dataset | _(empty)_   |
+| 2.0     | Test Dataset | My Subtitle |
 
 1. User opens the dataset page for **Version 1.0**.
 2. User clicks **Edit Dataset → Metadata**.
@@ -50,21 +50,21 @@ In `EditDatasetMetadataFactory.tsx`, ignore the browsed `version` search param a
 
 ### 2.1 Product expectation (JSF parity)
 
-| User context | Click “Edit Metadata” | Form must show |
-| --- | --- | --- |
-| Viewing published `1.0` while `2.0` exists | Edit Metadata | Metadata of **latest** (`:latest` → draft if present, else latest published) |
-| Viewing published `2.0` (already latest published) | Edit Metadata | Same latest metadata (no regression) |
-| Viewing / working on `DRAFT` | Edit Metadata | Draft metadata (`:latest` resolves to draft when present) |
+| User context                                       | Click “Edit Metadata” | Form must show                                                               |
+| -------------------------------------------------- | --------------------- | ---------------------------------------------------------------------------- |
+| Viewing published `1.0` while `2.0` exists         | Edit Metadata         | Metadata of **latest** (`:latest` → draft if present, else latest published) |
+| Viewing published `2.0` (already latest published) | Edit Metadata         | Same latest metadata (no regression)                                         |
+| Viewing / working on `DRAFT`                       | Edit Metadata         | Draft metadata (`:latest` resolves to draft when present)                    |
 
 **Important semantic of `:latest` in Dataverse:** draft if a draft exists; otherwise the latest published version. This is exactly what the Edit Terms factory comment documents and what JSF edit-metadata behavior matches.
 
 ### 2.2 SPA actual behavior today
 
-| User context | URL after menu click | Dataset fetch version | Form |
-| --- | --- | --- | --- |
-| Viewing `1.0` | `.../edit-metadata?persistentId=…&version=1.0` | `1.0` | Old metadata |
-| Viewing `2.0` | `...&version=2.0` | `2.0` | Happens to look correct if 2.0 is latest published and no draft |
-| Viewing draft | `...&version=DRAFT` → domain `:draft` | `:draft` | Draft (often OK, but still “browsed version” coupling) |
+| User context  | URL after menu click                           | Dataset fetch version | Form                                                            |
+| ------------- | ---------------------------------------------- | --------------------- | --------------------------------------------------------------- |
+| Viewing `1.0` | `.../edit-metadata?persistentId=…&version=1.0` | `1.0`                 | Old metadata                                                    |
+| Viewing `2.0` | `...&version=2.0`                              | `2.0`                 | Happens to look correct if 2.0 is latest published and no draft |
+| Viewing draft | `...&version=DRAFT` → domain `:draft`          | `:draft`              | Draft (often OK, but still “browsed version” coupling)          |
 
 ---
 
@@ -108,10 +108,10 @@ All line numbers refer to local tree at commit `922dcfc` unless noted.
 
 ### 4.1 Route
 
-| Item | Location |
-| --- | --- |
-| Path enum | `src/sections/Route.enum.ts` — `EDIT_DATASET_METADATA = '/datasets/edit-metadata'` (line 12) |
-| Query keys | `QueryParamKey.VERSION = 'version'`, `PERSISTENT_ID = 'persistentId'` (lines 96–98 area) |
+| Item               | Location                                                                                              |
+| ------------------ | ----------------------------------------------------------------------------------------------------- |
+| Path enum          | `src/sections/Route.enum.ts` — `EDIT_DATASET_METADATA = '/datasets/edit-metadata'` (line 12)          |
+| Query keys         | `QueryParamKey.VERSION = 'version'`, `PERSISTENT_ID = 'persistentId'` (lines 96–98 area)              |
 | Route registration | `src/router/routes.tsx` — lazy `EditDatasetMetadataFactory.create()` on `Route.EDIT_DATASET_METADATA` |
 
 ### 4.2 Navigation (contributes browsed version into the URL)
@@ -168,11 +168,11 @@ function EditDatasetMetadataWithParams() {
 
 ### 4.4 Provider → use case → repository
 
-| Step | File | Behavior |
-| --- | --- | --- |
-| Provider | `src/sections/dataset/DatasetProvider.tsx` ~28–36 | Calls `getDatasetByPersistentId(repository, persistentId, searchParams.version, undefined, true)` |
-| Use case | `src/dataset/domain/useCases/getDatasetByPersistentId.ts` | Delegates to repository |
-| Repository | `src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts` ~213–220 | `getDataset.execute(persistentId, version, …)` via JS client |
+| Step       | File                                                                               | Behavior                                                                                          |
+| ---------- | ---------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------- |
+| Provider   | `src/sections/dataset/DatasetProvider.tsx` ~28–36                                  | Calls `getDatasetByPersistentId(repository, persistentId, searchParams.version, undefined, true)` |
+| Use case   | `src/dataset/domain/useCases/getDatasetByPersistentId.ts`                          | Delegates to repository                                                                           |
+| Repository | `src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts` ~213–220 | `getDataset.execute(persistentId, version, …)` via JS client                                      |
 
 Default for `getByPersistentId` when version omitted is `DatasetNonNumericVersion.LATEST_PUBLISHED` (`:latest-published`) — but the factory **does not omit** version; it passes the browsed one explicitly.
 
@@ -208,11 +208,11 @@ export enum DatasetNonNumericVersionSearchParam {
 }
 ```
 
-| Constant | API `versionId` | Meaning |
-| --- | --- | --- |
-| `LATEST` | `:latest` | Draft if exists, else latest published — **use this for Edit Metadata** |
-| `DRAFT` | `:draft` | Draft only |
-| `LATEST_PUBLISHED` | `:latest-published` | Latest published only (skips draft) |
+| Constant           | API `versionId`     | Meaning                                                                 |
+| ------------------ | ------------------- | ----------------------------------------------------------------------- |
+| `LATEST`           | `:latest`           | Draft if exists, else latest published — **use this for Edit Metadata** |
+| `DRAFT`            | `:draft`            | Draft only                                                              |
+| `LATEST_PUBLISHED` | `:latest-published` | Latest published only (skips draft)                                     |
 
 **Do not** use `:latest-published` for Edit Metadata: if a draft already exists with newer edits, editors must see the draft.
 
@@ -302,13 +302,13 @@ If you change the menu, keep Upload Files behavior reviewed separately — it st
 
 ### 7.3 Explicitly out of scope / do not change
 
-| Do not | Why |
-| --- | --- |
-| Change browse-page version loading | Users must still view historical versions |
-| Change `DatasetProvider` to always latest | Shared by browse + edit |
-| Change form defaulting helpers | They are correct given inputs |
-| Use `:latest-published` instead of `:latest` | Misses existing draft content |
-| Redesign Edit Metadata UI | Issue is data-fetching only |
+| Do not                                       | Why                                       |
+| -------------------------------------------- | ----------------------------------------- |
+| Change browse-page version loading           | Users must still view historical versions |
+| Change `DatasetProvider` to always latest    | Shared by browse + edit                   |
+| Change form defaulting helpers               | They are correct given inputs             |
+| Use `:latest-published` instead of `:latest` | Misses existing draft content             |
+| Redesign Edit Metadata UI                    | Issue is data-fetching only               |
 
 ### 7.4 Save / update path (sanity)
 
@@ -334,22 +334,22 @@ Edit `EditDatasetMetadataFactory.tsx` as in §7.1.
 
 ### Step 2 — Manual verify (happy paths)
 
-| Case | Steps | Expected |
-| --- | --- | --- |
-| A | Browse v1 → Edit Metadata | Latest fields (e.g. subtitle from v2 or draft) |
-| B | Browse latest published → Edit Metadata | Same latest fields (no regression) |
-| C | With an existing draft that changed a field → Edit Metadata from any published version | Draft values appear (`:latest`) |
-| D | Direct URL `/edit-metadata?persistentId=…&version=1.0` | Still loads `:latest`, not `1.0` |
+| Case | Steps                                                                                  | Expected                                       |
+| ---- | -------------------------------------------------------------------------------------- | ---------------------------------------------- |
+| A    | Browse v1 → Edit Metadata                                                              | Latest fields (e.g. subtitle from v2 or draft) |
+| B    | Browse latest published → Edit Metadata                                                | Same latest fields (no regression)             |
+| C    | With an existing draft that changed a field → Edit Metadata from any published version | Draft values appear (`:latest`)                |
+| D    | Direct URL `/edit-metadata?persistentId=…&version=1.0`                                 | Still loads `:latest`, not `1.0`               |
 
 ### Step 3 — Automated tests
 
 Existing coverage gaps (verified):
 
-| File | Current focus | Gap |
-| --- | --- | --- |
-| `tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx` | Breadcrumbs / skeleton / not-found; `searchParams = { persistentId }` only | No assertion that fetch uses `:latest` when URL has old version |
-| `tests/e2e-integration/e2e/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx` | Visits with `version=DRAFT` only | No multi-version “from old published version” case |
-| `tests/component/.../EditDatasetMenu.spec.tsx` | Menu click | Does not assert fetch version |
+| File                                                                                    | Current focus                                                              | Gap                                                             |
+| --------------------------------------------------------------------------------------- | -------------------------------------------------------------------------- | --------------------------------------------------------------- |
+| `tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx`           | Breadcrumbs / skeleton / not-found; `searchParams = { persistentId }` only | No assertion that fetch uses `:latest` when URL has old version |
+| `tests/e2e-integration/e2e/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx` | Visits with `version=DRAFT` only                                           | No multi-version “from old published version” case              |
+| `tests/component/.../EditDatasetMenu.spec.tsx`                                          | Menu click                                                                 | Does not assert fetch version                                   |
 
 **Add at least one of:**
 
@@ -357,11 +357,12 @@ Existing coverage gaps (verified):
    `?persistentId=…&version=1.0`  
    and assert the repository `getByPersistentId` was called with `DatasetNonNumericVersion.LATEST` (`:latest`), **not** `"1.0"`.
 
-2. **E2E (strongest product proof):**  
-   - Create dataset, publish v1 without subtitle.  
-   - Add subtitle, publish v2.  
-   - Visit dataset with `version=1.0`.  
-   - Open Edit Metadata.  
+2. **E2E (strongest product proof):**
+
+   - Create dataset, publish v1 without subtitle.
+   - Add subtitle, publish v2.
+   - Visit dataset with `version=1.0`.
+   - Open Edit Metadata.
    - Assert subtitle input shows v2 value.
 
 3. **Regression:** From latest version / draft, Edit Metadata still works (existing e2e paths should remain green).
@@ -372,10 +373,10 @@ Run the project’s standard checks for touched files (per `CONTRIBUTING.md` / C
 
 ### Step 5 — PR description checklist
 
-- Link #1024  
-- State: “Always load `:latest` in `EditDatasetMetadataFactory`, matching `EditDatasetTermsFactory` and JSF.”  
-- Note: browse page version selection unchanged  
-- List test cases added  
+- Link #1024
+- State: “Always load `:latest` in `EditDatasetMetadataFactory`, matching `EditDatasetTermsFactory` and JSF.”
+- Note: browse page version selection unchanged
+- List test cases added
 
 ### Step 6 — Definition of done
 
@@ -383,9 +384,9 @@ See §10.
 
 ### Step 7 — Evidence to attach
 
-- Before/after screenshots (v1 browse → Edit Metadata subtitle)  
-- Network panel showing `versions/:latest` (or equivalent JS client version arg)  
-- Test output  
+- Before/after screenshots (v1 browse → Edit Metadata subtitle)
+- Network panel showing `versions/:latest` (or equivalent JS client version arg)
+- Test output
 
 ---
 
@@ -433,14 +434,14 @@ Import path style should match surrounding files (`@/` vs relative) — keep con
 
 ## 10. Acceptance criteria (verifiable)
 
-| # | Criterion | How to verify |
-| --- | --- | --- |
-| AC1 | From an older published version, Edit Metadata shows **latest** field values | Manual case A + e2e |
-| AC2 | Deep link with `version=` still loads latest | Manual case D + unit spy on repository |
-| AC3 | From latest published / draft, Edit Metadata unchanged / correct | Manual B/C + existing e2e |
-| AC4 | Dataset **browse** of historical versions still shows that version’s metadata | Browse v1 page still empty subtitle |
-| AC5 | Implementation aligns with Edit Terms (`DatasetNonNumericVersion.LATEST`) | Code review |
-| AC6 | Automated regression exists for AC1 or AC2 | CI green on new test |
+| #   | Criterion                                                                     | How to verify                          |
+| --- | ----------------------------------------------------------------------------- | -------------------------------------- |
+| AC1 | From an older published version, Edit Metadata shows **latest** field values  | Manual case A + e2e                    |
+| AC2 | Deep link with `version=` still loads latest                             | Manual case D + unit spy on repository |
+| AC3 | From latest published / draft, Edit Metadata unchanged / correct              | Manual B/C + existing e2e              |
+| AC4 | Dataset **browse** of historical versions still shows that version’s metadata | Browse v1 page still empty subtitle    |
+| AC5 | Implementation aligns with Edit Terms (`DatasetNonNumericVersion.LATEST`)     | Code review                            |
+| AC6 | Automated regression exists for AC1 or AC2                                    | CI green on new test                   |
 
 ---
 
@@ -452,11 +453,11 @@ The SPA uses `@iqss/dataverse-client-javascript` `getDataset.execute(persistentI
 GET /api/datasets/:persistentId/versions/:versionId?persistentId=...
 ```
 
-| Scenario | `versionId` today (bug) | `versionId` after fix |
-| --- | --- | --- |
-| Browsing v1, click Edit Metadata | `1.0` | `:latest` |
-| Draft exists | often `:draft` via menu | `:latest` (→ draft) |
-| Latest published, no draft | `N.M` | `:latest` (→ that published) |
+| Scenario                         | `versionId` today (bug) | `versionId` after fix        |
+| -------------------------------- | ----------------------- | ---------------------------- |
+| Browsing v1, click Edit Metadata | `1.0`                   | `:latest`                    |
+| Draft exists                     | often `:draft` via menu | `:latest` (→ draft)          |
+| Latest published, no draft       | `N.M`                   | `:latest` (→ that published) |
 
 When debugging in DevTools, confirm the version segment or client argument — not only the form UI.
 
@@ -464,27 +465,27 @@ When debugging in DevTools, confirm the version segment or client argument — n
 
 ## 12. Test plan matrix
 
-| ID | Type | Setup | Action | Expect |
-| --- | --- | --- | --- | --- |
-| T1 | Manual | v1 no subtitle, v2 has subtitle | Browse v1 → Edit Metadata | Subtitle = v2 value |
-| T2 | Manual | Same | Browse v2 → Edit Metadata | Subtitle = v2 value |
-| T3 | Manual | Draft edits subtitle further | Browse v1 → Edit Metadata | Subtitle = draft value |
-| T4 | Manual | Open `/edit-metadata?persistentId&version=1.0` | Load page | Same as latest, not v1 |
-| T5 | Unit/component | Mock repository | Mount factory with `version=1.0` | `getByPersistentId(..., ':latest')` |
-| T6 | E2E | Publish two versions | Automate T1 | Pass |
-| T7 | Regression | Existing draft edit e2e | Run suite | Still pass |
+| ID  | Type           | Setup                                          | Action                           | Expect                              |
+| --- | -------------- | ---------------------------------------------- | -------------------------------- | ----------------------------------- |
+| T1  | Manual         | v1 no subtitle, v2 has subtitle                | Browse v1 → Edit Metadata        | Subtitle = v2 value                 |
+| T2  | Manual         | Same                                           | Browse v2 → Edit Metadata        | Subtitle = v2 value                 |
+| T3  | Manual         | Draft edits subtitle further                   | Browse v1 → Edit Metadata        | Subtitle = draft value              |
+| T4  | Manual         | Open `/edit-metadata?persistentId&version=1.0` | Load page                        | Same as latest, not v1              |
+| T5  | Unit/component | Mock repository                                | Mount factory with `version=1.0` | `getByPersistentId(..., ':latest')` |
+| T6  | E2E            | Publish two versions                           | Automate T1                      | Pass                                |
+| T7  | Regression     | Existing draft edit e2e                        | Run suite                        | Still pass                          |
 
 ---
 
 ## 13. Risks and edge cases
 
-| Risk | Mitigation |
-| --- | --- |
-| Confusing `:latest` vs `:latest-published` | Use `LATEST` only; document draft preference |
-| Menu still puts old version in URL | Harmless after Factory fix; optional cleanup |
-| Permissions / deaccessioned versions | Existing menu disable / permission checks unchanged; retest if deaccessioned latest |
-| Private URL datasets | Factory path uses `persistentId`; private-URL browse uses different provider entry — confirm Edit Metadata entry points still go through this factory |
-| Concurrent draft from another user | Pre-existing conflict handling via `datasetLastUpdateTime` / API; out of scope for #1024 |
+| Risk                                       | Mitigation                                                                                                                                            |
+| ------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Confusing `:latest` vs `:latest-published` | Use `LATEST` only; document draft preference                                                                                                          |
+| Menu still puts old version in URL         | Harmless after Factory fix; optional cleanup                                                                                                          |
+| Permissions / deaccessioned versions       | Existing menu disable / permission checks unchanged; retest if deaccessioned latest                                                                   |
+| Private URL datasets                       | Factory path uses `persistentId`; private-URL browse uses different provider entry — confirm Edit Metadata entry points still go through this factory |
+| Concurrent draft from another user         | Pre-existing conflict handling via `datasetLastUpdateTime` / API; out of scope for #1024                                                              |
 
 ---
 
@@ -518,11 +519,11 @@ Label **Original size: 3** fits: one focused factory change (and optional menu c
 
 ## 17. Implementation record (this branch)
 
-| Change | Path | What changed |
-| --- | --- | --- |
-| Factory fix | `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx` | Ignore URL `version`; always pass `DatasetNonNumericVersion.LATEST` (`:latest`) into `DatasetProvider` |
+| Change           | Path                                                                                 | What changed                                                                                                 |
+| ---------------- | ------------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------ |
+| Factory fix      | `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx`                  | Ignore URL `version`; always pass `DatasetNonNumericVersion.LATEST` (`:latest`) into `DatasetProvider`       |
 | Regression tests | `tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx` | Assert `getByPersistentId` is called with `:latest` when URL has `version=1.0`, and when URL omits `version` |
-| This doc | `docs/issues/1024-edit-metadata-latest-version.md` | Diagnosis + playbook + verification |
+| This doc         | `docs/issues/1024-edit-metadata-latest-version.md`                                   | Diagnosis + playbook + verification                                                                          |
 
 **Not changed (intentionally):**
 
@@ -553,10 +554,10 @@ npx cypress run --component --spec \
 
 **Pass criteria:**
 
-| Spec | Expect |
-| --- | --- |
+| Spec                                  | Expect                                                                                     |
+| ------------------------------------- | ------------------------------------------------------------------------------------------ |
 | `EditDatasetMetadataFactory.spec.tsx` | Both tests green: call uses `:latest` / `DatasetNonNumericVersion.LATEST`, **not** `"1.0"` |
-| `EditDatasetMetadata.spec.tsx` | All existing tests still green |
+| `EditDatasetMetadata.spec.tsx`        | All existing tests still green                                                             |
 
 **Fail if:** `getByPersistentId` is invoked with `"1.0"` for the old-version URL case.
 
@@ -564,19 +565,19 @@ npx cypress run --component --spec \
 
 Prerequisite: dataset with ≥2 published versions where a field differs (e.g. title or subtitle added in v2).
 
-| Step | Action | Expected (pass) | Fail if |
-| --- | --- | --- | --- |
-| M1 | Open SPA dataset with `?version=1.0` | Browse page shows v1 content | — |
-| M2 | Edit Dataset → Metadata | Network/API version is `:latest` (or draft via `:latest`) | Request is for `1.0` |
-| M3 | Inspect form field that differs in v2 | Shows **latest** value | Shows empty / v1 value |
-| M4 | Open Edit Metadata from latest published | Same latest values | Regression / blank form |
-| M5 | If a draft exists with further edits, open Edit Metadata from v1 | Form shows **draft** values (`:latest`) | Shows published-only / v1 |
+| Step | Action                                                           | Expected (pass)                                           | Fail if                   |
+| ---- | ---------------------------------------------------------------- | --------------------------------------------------------- | ------------------------- |
+| M1   | Open SPA dataset with `?version=1.0`                             | Browse page shows v1 content                              | —                         |
+| M2   | Edit Dataset → Metadata                                          | Network/API version is `:latest` (or draft via `:latest`) | Request is for `1.0`      |
+| M3   | Inspect form field that differs in v2                            | Shows **latest** value                                    | Shows empty / v1 value    |
+| M4   | Open Edit Metadata from latest published                         | Same latest values                                        | Regression / blank form   |
+| M5   | If a draft exists with further edits, open Edit Metadata from v1 | Form shows **draft** values (`:latest`)                   | Shows published-only / v1 |
 
 ### 18.3 Negative control (browse must stay historical)
 
-| Step | Action | Expected |
-| --- | --- | --- |
-| N1 | Stay on browse `?version=1.0` (do not edit) | Historical metadata still shown (e.g. missing subtitle) |
+| Step | Action                                      | Expected                                                |
+| ---- | ------------------------------------------- | ------------------------------------------------------- |
+| N1   | Stay on browse `?version=1.0` (do not edit) | Historical metadata still shown (e.g. missing subtitle) |
 
 If N1 fails, the fix was applied too broadly (e.g. Provider always latest) — revert and keep the change only in `EditDatasetMetadataFactory`.
 
@@ -592,7 +593,7 @@ If N1 fails, the fix was applied too broadly (e.g. Provider always latest) — r
 
 ## 19. Document history
 
-| Date | Commit / branch | Notes |
-| --- | --- | --- |
-| 2026-07-31 | `922dcfc` on `develop` | Diagnosis + solution written from source |
+| Date       | Commit / branch                         | Notes                                                       |
+| ---------- | --------------------------------------- | ----------------------------------------------------------- |
+| 2026-07-31 | `922dcfc` on `develop`                  | Diagnosis + solution written from source                    |
 | 2026-07-31 | `fix/1024-edit-metadata-latest-version` | Factory fix + component regression tests + verification §18 |
diff --git a/docs/issues/PR-1024-DRAFT-BODY.md b/docs/issues/PR-1024-DRAFT-BODY.md
new file mode 100644
index 000000000..292ba2aca
--- /dev/null
+++ b/docs/issues/PR-1024-DRAFT-BODY.md
@@ -0,0 +1,17 @@
+## Summary
+
+- Fixes #1024: when opening **Edit Metadata** from an older dataset version, the SPA now pre-fills **latest** metadata (`:latest` — draft if present, otherwise latest published), matching JSF and `EditDatasetTermsFactory`.
+- Root cause: `EditDatasetMetadataFactory` used the browsed `version` query param (e.g. `1.0`). It now ignores that param and always fetches `DatasetNonNumericVersion.LATEST`.
+- Adds component regression tests asserting `getByPersistentId(..., ':latest', ...)` and not `"1.0"`.
+
+## Test plan
+
+- [x] Local: `npx cypress run --component --spec tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx` → **2 passing**
+- [ ] CI component tests
+- [ ] Manual: publish v1 without subtitle → publish v2 with subtitle → browse `?version=1.0` → Edit Metadata → subtitle shows v2 value
+- [ ] Manual: browsing `?version=1.0` without editing still shows historical v1 metadata
+
+## Notes
+
+- Browse-page version selection is unchanged.
+- Optional docs under `docs/issues/` are included for review context; happy to drop them from the PR if preferred.
diff --git a/docs/issues/PR-1024-DRAFT.md b/docs/issues/PR-1024-DRAFT.md
new file mode 100644
index 000000000..cd34e5320
--- /dev/null
+++ b/docs/issues/PR-1024-DRAFT.md
@@ -0,0 +1,54 @@
+# PR draft for #1024 — DO NOT PUBLISH until user approves
+
+**Status:** Prepared only. Do **not** run `gh pr create` until explicit approval.
+
+## Command to publish later (only when approved)
+
+```bash
+cd /Users/shihuayu/Documents/GitHub/dataverse-frontend
+gh pr create --repo IQSS/dataverse-frontend \
+  --base develop \
+  --head youseihuayu-wonderful:fix/1024-edit-metadata-latest-version \
+  --title "Fix Edit Metadata to always pre-populate latest metadata" \
+  --body-file docs/issues/PR-1024-DRAFT-BODY.md
+```
+
+## Title
+
+```
+Fix Edit Metadata to always pre-populate latest metadata
+```
+
+## Base / head
+
+|             |                                                               |
+| ----------- | ------------------------------------------------------------- |
+| Base repo   | `IQSS/dataverse-frontend`                                     |
+| Base branch | `develop`                                                     |
+| Head        | `youseihuayu-wonderful:fix/1024-edit-metadata-latest-version` |
+| Fixes       | https://github.com/IQSS/dataverse-frontend/issues/1024        |
+
+## Commits included
+
+1. `f10860954` — Fix Edit Metadata to always load latest dataset version
+2. `0b573ad3f` — Add HTML verification report for Edit Metadata latest-version fix
+
+## Files
+
+- `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx` — production fix
+- `tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx` — regression
+- `docs/issues/1024-edit-metadata-latest-version.md` — playbook (optional for upstream; can drop if reviewers prefer)
+- `docs/issues/1024-edit-metadata-latest-version-verification.html` — before/after report (optional)
+
+## Local verification already done
+
+```
+EditDatasetMetadataFactory
+  ✓ always fetches :latest when the URL carries an older published version (issue #1024)
+  ✓ still fetches :latest when the URL has no version param
+
+2 passing
+All specs passed!
+```
+
+Node: v22.23.2 · Cypress: 15.2.0
diff --git a/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx b/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
index d6b27e101..d86a2ffc4 100644
--- a/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
+++ b/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
@@ -15,9 +15,12 @@ const metadataBlocksInfoOnCreateMode =
 
 describe('EditDatasetMetadataFactory', () => {
   const persistentId = 'doi:10.5072/FK2/EDITMETA'
+  let getByPersistentIdStub: ReturnType
 
   beforeEach(() => {
-    cy.stub(DatasetJSDataverseRepository.prototype, 'getByPersistentId').resolves(dataset)
+    getByPersistentIdStub = cy
+      .stub(DatasetJSDataverseRepository.prototype, 'getByPersistentId')
+      .resolves(dataset)
     cy.stub(DatasetJSDataverseRepository.prototype, 'updateMetadata').resolves(undefined)
     cy.stub(DatasetJSDataverseRepository.prototype, 'getDatasetVersionsSummaries').resolves({
       summaries: [],
@@ -33,22 +36,22 @@ describe('EditDatasetMetadataFactory', () => {
   })
 
   it('always fetches :latest when the URL carries an older published version (issue #1024)', () => {
-    const initialEntry = `${Route.EDIT_DATASET_METADATA}?${QueryParamKey.PERSISTENT_ID}=${encodeURIComponent(
-      persistentId
-    )}&${QueryParamKey.VERSION}=1.0`
+    const initialEntry = `${Route.EDIT_DATASET_METADATA}?${
+      QueryParamKey.PERSISTENT_ID
+    }=${encodeURIComponent(persistentId)}&${QueryParamKey.VERSION}=1.0`
 
     cy.customMount({EditDatasetMetadataFactory.create()}, [
       initialEntry
     ])
 
-    cy.wrap(DatasetJSDataverseRepository.prototype.getByPersistentId).should(
+    cy.wrap(getByPersistentIdStub).should(
       'have.been.calledWith',
       persistentId,
       DatasetNonNumericVersion.LATEST,
       undefined,
       true
     )
-    cy.wrap(DatasetJSDataverseRepository.prototype.getByPersistentId).should(
+    cy.wrap(getByPersistentIdStub).should(
       'not.have.been.calledWith',
       persistentId,
       '1.0',
@@ -61,15 +64,15 @@ describe('EditDatasetMetadataFactory', () => {
   })
 
   it('still fetches :latest when the URL has no version param', () => {
-    const initialEntry = `${Route.EDIT_DATASET_METADATA}?${QueryParamKey.PERSISTENT_ID}=${encodeURIComponent(
-      persistentId
-    )}`
+    const initialEntry = `${Route.EDIT_DATASET_METADATA}?${
+      QueryParamKey.PERSISTENT_ID
+    }=${encodeURIComponent(persistentId)}`
 
     cy.customMount({EditDatasetMetadataFactory.create()}, [
       initialEntry
     ])
 
-    cy.wrap(DatasetJSDataverseRepository.prototype.getByPersistentId).should(
+    cy.wrap(getByPersistentIdStub).should(
       'have.been.calledWith',
       persistentId,
       DatasetNonNumericVersion.LATEST,

From e7b1c5abbe6d5464e1ab0fbbfd7a485cd98c9c59 Mon Sep 17 00:00:00 2001
From: youseihuayu-wonderful 
Date: Fri, 31 Jul 2026 17:15:29 -0400
Subject: [PATCH 4/6] Document Edit Metadata latest-version fix in CHANGELOG

Co-authored-by: Cursor 
---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 57dd57551..c0553a482 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -29,6 +29,7 @@ This changelog follows the principles of [Keep a Changelog](https://keepachangel
 
 - After saving on either Edit Template tab (Metadata or Terms), the user is redirected to the templates listing with a success toast instead of staying on the edit page.
 - Edit Template breadcrumb on the Terms page no longer renders the dataset's "Terms and Guestbook" label (templates have no guestbook).
+- Edit Metadata always loads the latest dataset version (draft if present, otherwise latest published), ignoring the browsed `version` query param so it matches JSF / Edit Terms. (#1024)
 
 ### Removed
 

From 24ef810b44c254c04eb83d7d907f2b23a5682821 Mon Sep 17 00:00:00 2001
From: youseihuayu-wonderful 
Date: Mon, 3 Aug 2026 15:59:02 -0400
Subject: [PATCH 5/6] Address review: remove comments and issue number from
 test title

Co-authored-by: Cursor 
---
 .../edit-dataset-metadata/EditDatasetMetadataFactory.tsx       | 3 ---
 .../edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx  | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx b/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx
index 176198b38..edbf49047 100644
--- a/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx
+++ b/src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx
@@ -18,9 +18,6 @@ export class EditDatasetMetadataFactory {
 function EditDatasetMetadataWithParams() {
   const [searchParams] = useSearchParams()
   const persistentId = searchParams.get('persistentId') ?? undefined
-  // Always load the latest version (draft if exists, otherwise latest published).
-  // Ignore the browsed `version` query param so Edit Metadata matches JSF / Edit Terms
-  // (IQSS/dataverse-frontend#1024).
   const version = DatasetNonNumericVersion.LATEST
 
   return (
diff --git a/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx b/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
index d86a2ffc4..2f83cc8fa 100644
--- a/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
+++ b/tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
@@ -35,7 +35,7 @@ describe('EditDatasetMetadataFactory', () => {
     ).resolves(metadataBlocksInfoOnCreateMode)
   })
 
-  it('always fetches :latest when the URL carries an older published version (issue #1024)', () => {
+  it('always fetches :latest when the URL carries an older published version', () => {
     const initialEntry = `${Route.EDIT_DATASET_METADATA}?${
       QueryParamKey.PERSISTENT_ID
     }=${encodeURIComponent(persistentId)}&${QueryParamKey.VERSION}=1.0`

From 1d154077cd46d172d6855ffc215a4a5068b54909 Mon Sep 17 00:00:00 2001
From: youseihuayu-wonderful 
Date: Mon, 3 Aug 2026 16:09:58 -0400
Subject: [PATCH 6/6] Remove docs/issues notes from the PR

Co-authored-by: Cursor 
---
 ...-metadata-latest-version-verification.html | 663 ------------------
 .../1024-edit-metadata-latest-version.md      | 599 ----------------
 docs/issues/PR-1024-DRAFT-BODY.md             |  17 -
 docs/issues/PR-1024-DRAFT.md                  |  54 --
 4 files changed, 1333 deletions(-)
 delete mode 100644 docs/issues/1024-edit-metadata-latest-version-verification.html
 delete mode 100644 docs/issues/1024-edit-metadata-latest-version.md
 delete mode 100644 docs/issues/PR-1024-DRAFT-BODY.md
 delete mode 100644 docs/issues/PR-1024-DRAFT.md

diff --git a/docs/issues/1024-edit-metadata-latest-version-verification.html b/docs/issues/1024-edit-metadata-latest-version-verification.html
deleted file mode 100644
index f43d45faa..000000000
--- a/docs/issues/1024-edit-metadata-latest-version-verification.html
+++ /dev/null
@@ -1,663 +0,0 @@
-
-
-  
-    
-    
-    Issue #1024 — Edit Metadata Latest Version: Fix Verification Report
-    
-  
-  
-    

-      

-        
IQSS/dataverse-frontend · Issue #1024 · Verification Report

-        
Edit Metadata must always pre-populate the latest metadata

-        

-          This report shows the original bug (wrong version used to initialize the edit form), the
-          exact code fix, the expected outputs before vs after, and how to verify the fix is
-          complete against the issue statement.
-        

-        

-          

-            
Issue

-            
#1024

-          

-          

-            
Branch

-            
fix/1024-edit-metadata-latest-version

-          

-          

-            
Commit

-            
f108609

-          

-          

-            
Primary file

-            
EditDatasetMetadataFactory.tsx

-          

-        

-      

-
-      
1. Original issue (exact requirement)

-      

-        

-          Product rule (JSF parity): No matter which historical dataset version the
-          user is viewing, clicking Edit Metadata must pre-fill the form with the
-          latest metadata (:latest = draft if present, else latest
-          published).
-        

-        

-          SPA bug: The form was pre-filled from the browsed version in the
-          URL (?version=1.0), so older fields appeared and newer values could be
-          overwritten on save.
-        

-      

-
-      
Scenario dataset (from the issue)

-      
-        
-          
-            
-            
-            
-          
-        
-        
-          
-            
-            
-            
-          
-          
-            
-            
-            
-          
-        
-      
VersionTitleSubtitle
1.0Test Dataset(empty)
2.0 (latest published)Test DatasetMy Subtitle

-      
User action: open Version 1.0 → Edit Dataset → Metadata.

-
-      
2. What was parsed / loaded wrongly (BEFORE)

-      

-        Bug path
-        

-          Browse ?version=1.0
-          →
-          Menu writes URL version=1.0
-          →
-          Factory reads URL version
-          →
-          Fetch API versions/1.0
-          →
-          Form defaults = v1 blocks
-        

-      

-
-      
Wrong Factory logic (before)

-      
// EditDatasetMetadataFactory.tsx — BEFORE (bug)
-const searchParamVersion = searchParams.get('version') ?? undefined
-const version = searchParamVersionToDomainVersion(searchParamVersion)
-// If URL is ...&version=1.0  →  version === "1.0"
-// DatasetProvider fetches that historical version

-
-      

-        

-          Before · fetch argument
-          
getByPersistentId(
-  "doi:…",
-  "1.0",          // ← browsed / wrong
-  undefined,
-  true
-)

-          
API equivalent: .../versions/1.0

-        

-        

-          Before · form output (wrong)
-          

-            

-              
-              
Test Dataset

-            

-            

-              
-              
(empty — Version 1 metadata)

-            

-          

-          
FAIL vs issue expectation

-          
JSF would show Subtitle = My Subtitle. SPA showed empty.

-        

-      

-
-      
3. What was fixed (AFTER)

-      

-        Fixed path
-        

-          Browse ?version=1.0
-          →
-          Menu may still pass version=1.0 in URL
-          →
-          Factory ignores URL version
-          →
-          Fetch :latest
-          →
-          Form defaults = latest blocks
-        

-        
Same pattern as EditDatasetTermsFactory (already correct in this repo).

-      

-
-      
Fixed Factory logic

-      
// EditDatasetMetadataFactory.tsx — AFTER (fix)
-const persistentId = searchParams.get('persistentId') ?? undefined
-// Always load the latest version (draft if exists, otherwise latest published).
-// Ignore the browsed `version` query param (IQSS/dataverse-frontend#1024).
-const version = DatasetNonNumericVersion.LATEST  // ":latest"
-
-return (
-  <DatasetProvider
-    repository={datasetRepository}
-    searchParams={{ persistentId, version }}>
-    <EditDatasetMetadata ... />
-  </DatasetProvider>
-)

-
-      

-        

-          After · fetch argument
-          
getByPersistentId(
-  "doi:…",
-  ":latest",     // ← DatasetNonNumericVersion.LATEST
-  undefined,
-  true
-)

-          
API equivalent: .../versions/:latest

-          

-            :latest = draft if one exists, else latest published (here Version 2.0).
-          

-        

-        

-          After · form output (correct)
-          

-            

-              
-              
Test Dataset

-            

-            

-              
-              
My Subtitle

-            

-          

-          
PASS vs issue expectation

-          
Matches JSF: latest metadata pre-populated.

-        

-      

-
-      
4. Side-by-side comparison

-      
-        
-          
-            
-            
-            
-            
-          
-        
-        
-          
-            
-            
-          
-          
-            
-            
-            
-            
-          
-          
-            
-            
-            
-            
-          
-          
-            
-            
-            
-            
-          
-          
-            
-            
-            
-            
-          
-          
-            
-            
-            
-            
-          
-        
-      
CheckpointBefore (bug)After (fix)Issue requirement
User viewing/datasets?persistentId=…&version=1.0
Edit Metadata URL may containversion=1.0version=1.0 (ignored)N/A — output must be latest
Factory version variable"1.0" from URL":latest" constantAlways latest
Repository callgetByPersistentId(pid, "1.0", …)getByPersistentId(pid, ":latest", …)Latest metadata source
Subtitle in formemptyMy SubtitleMy Subtitle
Browse page v1 still historical?yesyes (unchanged)Must remain historical

-
-      
5. How to verify the fix is completed

-      

-        Definition of done
-        

-          The fix is complete for #1024 only when all of the
-          following pass. Code presence alone is not enough without the automated and/or manual
-          checks.
-        

-      

-
-      
A. Static code verification (already on this branch)

-      
    
-        
  • 
-          DONE — EditDatasetMetadataFactory.tsx sets
-          version = DatasetNonNumericVersion.LATEST
-        
    • 
-        
  • 
-          DONE — URL version query param is no longer passed
-          into DatasetProvider
-        
    • 
-        
  • 
-          DONE — Regression spec asserts call with
-          :latest and not "1.0"
-        
    • 
-        
  • DONE — Matches Edit Terms factory pattern
    • 
-      

-
-      
B. Automated verification (required)

-      

-        From repo root (needs working npm auth for
-        @IQSS/dataverse-client-javascript):
-      

-      
npx cypress run --component --spec \
-  tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
-
-npx cypress run --component --spec \
-  tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx

-      
-        
-          
-            
-            
-          
-        
-        
-          
-            
-            
-          
-          
-            
-            
-          
-          
-            
-            
-          
-        
-      
TestVerified result if green

-              always fetches :latest when the URL carries an older published version
-            
-              Even with URL version=1.0, getByPersistentId is called with
-              DatasetNonNumericVersion.LATEST (:latest), never
-              "1.0".
-            
still fetches :latest when the URL has no version param
-              Missing version param still loads latest (no accidental undefined /
-              published-only default).
-            
Existing EditDatasetMetadata.spec.tsxNo regression on breadcrumbs / host collection / not-found.

-      

-        NOTE: On this machine, npm install failed with
-        GitHub Packages 401 for @IQSS/dataverse-client-javascript, so
-        Cypress was not executed here. Run the commands above in an authenticated environment and
-        record green results before merging.
-      

-
-      
C. Manual product verification (original issue scenario)

-      
    
-        
  1. Create/publish Version 1.0 without subtitle.
    2. 
-        
  2. Add subtitle My Subtitle, publish Version 2.0.
    3. 
-        
  3. 
-          Open SPA: /datasets?persistentId=…&version=1.0 — browse still shows empty
-          subtitle.
-        
    4. 
-        
  4. Click Edit Dataset → Metadata.
    5. 
-        
  5. PASS if Subtitle input = My Subtitle.
    6. 
-        
  6. FAIL if Subtitle is empty.
    7. 
-        
  7. 
-          Optional DevTools check: dataset fetch uses version :latest, not
-          1.0.
-        
    8. 
-      

-
-      
D. Negative control (must not break browse)

-      

-        On ?version=1.0 without opening Edit Metadata, the dataset page must
-        still show Version 1 content (empty subtitle). If browse also shows latest, the fix was
-        applied too broadly.
-      

-
-      
6. Expected verified result summary

-      
-        
-          
-            
-            
-            
-          
-        
-        
-          
-            
-            
-            
-          
-          
-            
-            
-            
-          
-          
-            
-            
-            
-          
-          
-            
-            
-            
-          
-        
-      
LayerExpected verified result after fixStatus on branch f108609
CodeFactory hard-codes :latestVerified by source review
Unit/componentStub shows call args (pid, ":latest", undefined, true)Spec written; run Cypress locally to confirm green
UI / issue scenarioFrom v1 browse → Edit Metadata → Subtitle = My SubtitleManual / e2e after env install
ParitySame behavior as JSF + Edit TermsDesign parity verified in code

-
-      
7. Files touched

-      
-        
-          
-            
-            
-          
-        
-        
-          
-            
-            
-          
-          
-            
-            
-          
-          
-            
-            
-          
-          
-            
-            
-          
-        
-      
FileRole
src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsxProduction fix

-              tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
-            Automated regression
docs/issues/1024-edit-metadata-latest-version.mdFull engineering playbook
docs/issues/1024-edit-metadata-latest-version-verification.htmlThis visual verification report

-
-      

-        Generated for IQSS/dataverse-frontend issue
-        #1024
-        on branch fix/1024-edit-metadata-latest-version (f108609). Open this file in a browser to review before/after outputs.
-      

-    

-  
-
diff --git a/docs/issues/1024-edit-metadata-latest-version.md b/docs/issues/1024-edit-metadata-latest-version.md
deleted file mode 100644
index 29072ce38..000000000
--- a/docs/issues/1024-edit-metadata-latest-version.md
+++ /dev/null
@@ -1,599 +0,0 @@
-# Issue #1024 — Edit Metadata: should always pre-populate the latest metadata
-
-| Field                     | Value                                                                                             |
-| ------------------------- | ------------------------------------------------------------------------------------------------- |
-| Status                    | **Implemented on branch `fix/1024-edit-metadata-latest-version`** — awaiting PR / upstream review |
-| Labels                    | `bug`, `SPA`, `GREI Re-arch`, `Original size: 3`                                                  |
-| Reporter                  | `ChengShi-1` (description from `@pdurbin`)                                                        |
-| Issue URL                 | https://github.com/IQSS/dataverse-frontend/issues/1024                                            |
-| Diagnosis baseline commit | `922dcfc` (`develop` tip when diagnosis was written)                                              |
-| Fix branch                | `fix/1024-edit-metadata-latest-version`                                                           |
-| Local package path        | `/Users/shihuayu/Documents/GitHub/dataverse-frontend`                                             |
-| How to implement          | Follow §8 Steps 0–7; every fix must pass §10 acceptance criteria                                  |
-| How to verify             | Follow §18 (commands + expected outputs). Do not merge without green AC1–AC6                      |
-
----
-
-## 1. Executive summary
-
-When a dataset has multiple published versions, the **legacy JSF** “Edit Metadata” flow always pre-fills the form from the **latest** metadata (draft if one exists, otherwise latest published), regardless of which version the user is currently viewing.
-
-The **SPA** incorrectly pre-fills from the **version currently being browsed**. That version is written into the edit-page URL as `?version=…` and then used as the fetch target in `EditDatasetMetadataFactory`.
-
-### Concrete failure (from the issue + Phil’s screenshot narrative)
-
-| Version | Title        | Subtitle    |
-| ------- | ------------ | ----------- |
-| 1.0     | Test Dataset | _(empty)_   |
-| 2.0     | Test Dataset | My Subtitle |
-
-1. User opens the dataset page for **Version 1.0**.
-2. User clicks **Edit Dataset → Metadata**.
-3. **JSF (correct):** form shows Subtitle = `My Subtitle` (latest).
-4. **SPA (bug):** form shows Subtitle empty (version 1.0).
-
-### Risk
-
-If the user saves from a form that was initialized with older metadata, they can **overwrite newer field values** on the draft that editing creates/updates — silent data loss relative to the latest published content.
-
-### Root cause (one sentence)
-
-`EditDatasetMetadataFactory` passes the URL `version` query param into `DatasetProvider` / `getDatasetByPersistentId`, instead of forcing `DatasetNonNumericVersion.LATEST` (`:latest`) the way `EditDatasetTermsFactory` already does.
-
-### Recommended fix (one sentence)
-
-In `EditDatasetMetadataFactory.tsx`, ignore the browsed `version` search param and always load `DatasetNonNumericVersion.LATEST`, matching Edit Terms; add regression tests for “enter Edit Metadata while viewing an older published version.”
-
----
-
-## 2. Expected vs actual behavior
-
-### 2.1 Product expectation (JSF parity)
-
-| User context                                       | Click “Edit Metadata” | Form must show                                                               |
-| -------------------------------------------------- | --------------------- | ---------------------------------------------------------------------------- |
-| Viewing published `1.0` while `2.0` exists         | Edit Metadata         | Metadata of **latest** (`:latest` → draft if present, else latest published) |
-| Viewing published `2.0` (already latest published) | Edit Metadata         | Same latest metadata (no regression)                                         |
-| Viewing / working on `DRAFT`                       | Edit Metadata         | Draft metadata (`:latest` resolves to draft when present)                    |
-
-**Important semantic of `:latest` in Dataverse:** draft if a draft exists; otherwise the latest published version. This is exactly what the Edit Terms factory comment documents and what JSF edit-metadata behavior matches.
-
-### 2.2 SPA actual behavior today
-
-| User context  | URL after menu click                           | Dataset fetch version | Form                                                            |
-| ------------- | ---------------------------------------------- | --------------------- | --------------------------------------------------------------- |
-| Viewing `1.0` | `.../edit-metadata?persistentId=…&version=1.0` | `1.0`                 | Old metadata                                                    |
-| Viewing `2.0` | `...&version=2.0`                              | `2.0`                 | Happens to look correct if 2.0 is latest published and no draft |
-| Viewing draft | `...&version=DRAFT` → domain `:draft`          | `:draft`              | Draft (often OK, but still “browsed version” coupling)          |
-
----
-
-## 3. Architecture context (where this lives)
-
-```text
-Dataset page (browse any version)
-  └─ DatasetActionButtons
-       └─ EditDatasetMenu  ──navigate──►  /datasets/edit-metadata?persistentId&version
-                                              │
-                                              ▼
-                                    EditDatasetMetadataFactory
-                                              │
-                                              ▼
-                                    DatasetProvider(getDatasetByPersistentId)
-                                              │
-                                              ▼
-                                    DatasetJSDataverseRepository.getByPersistentId
-                                              │
-                                              ▼
-                                    @iqss/dataverse-client-javascript getDataset.execute
-                                              │
-                                              ▼
-                                    Native API: GET .../versions/{versionId}
-                                              │
-                                              ▼
-                                    EditDatasetMetadata
-                                              │
-                                              ▼
-                                    DatasetMetadataForm(mode="edit")
-                                         defaults ← dataset.metadataBlocks
-```
-
-The form component is **not** the bug. It faithfully displays whatever `dataset.metadataBlocks` it receives. The bug is **which version is fetched** before the form mounts.
-
----
-
-## 4. Verified call chain (with file:line evidence)
-
-All line numbers refer to local tree at commit `922dcfc` unless noted.
-
-### 4.1 Route
-
-| Item               | Location                                                                                              |
-| ------------------ | ----------------------------------------------------------------------------------------------------- |
-| Path enum          | `src/sections/Route.enum.ts` — `EDIT_DATASET_METADATA = '/datasets/edit-metadata'` (line 12)          |
-| Query keys         | `QueryParamKey.VERSION = 'version'`, `PERSISTENT_ID = 'persistentId'` (lines 96–98 area)              |
-| Route registration | `src/router/routes.tsx` — lazy `EditDatasetMetadataFactory.create()` on `Route.EDIT_DATASET_METADATA` |
-
-### 4.2 Navigation (contributes browsed version into the URL)
-
-File: `src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx`
-
-```39:55:src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx
-  const handleOnSelect = (eventKey: EditDatasetMenuItems | string | null) => {
-    const searchParams = new URLSearchParams()
-    searchParams.set(QueryParamKey.PERSISTENT_ID, dataset.persistentId)
-
-    if (dataset.version.publishingStatus === DatasetPublishingStatus.DRAFT) {
-      searchParams.set(QueryParamKey.VERSION, DatasetNonNumericVersionSearchParam.DRAFT)
-    } else {
-      searchParams.set(QueryParamKey.VERSION, dataset.version.number.toString())
-    }
-    // ...
-    if (eventKey === EditDatasetMenuItems.METADATA) {
-      navigate(`${Route.EDIT_DATASET_METADATA}?${searchParams.toString()}`)
-      return
-    }
-```
-
-When the user is viewing published version `1.0`, this navigates to:
-
-```text
-/datasets/edit-metadata?persistentId=&version=1.0
-```
-
-**Note:** The same menu also sets `version` for Terms and Upload Files. Edit **Terms** already ignores URL version in its factory (see §5). Upload Files may still need a version-aware URL — do **not** globally remove version from the menu without checking upload behavior.
-
-### 4.3 Factory (bug site — consumes URL version)
-
-File: `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx`
-
-```18:30:src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx
-function EditDatasetMetadataWithParams() {
-  const [searchParams] = useSearchParams()
-  const persistentId = searchParams.get('persistentId') ?? undefined
-  const searchParamVersion = searchParams.get('version') ?? undefined
-  const version = searchParamVersionToDomainVersion(searchParamVersion)
-
-  return (
-    
-      
-    
-  )
-}
-```
-
-`searchParamVersionToDomainVersion` (`src/router/index.tsx` lines 11–17) only special-cases `DRAFT` → `:draft`; numeric versions like `1.0` pass through unchanged.
-
-### 4.4 Provider → use case → repository
-
-| Step       | File                                                                               | Behavior                                                                                          |
-| ---------- | ---------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------- |
-| Provider   | `src/sections/dataset/DatasetProvider.tsx` ~28–36                                  | Calls `getDatasetByPersistentId(repository, persistentId, searchParams.version, undefined, true)` |
-| Use case   | `src/dataset/domain/useCases/getDatasetByPersistentId.ts`                          | Delegates to repository                                                                           |
-| Repository | `src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts` ~213–220 | `getDataset.execute(persistentId, version, …)` via JS client                                      |
-
-Default for `getByPersistentId` when version omitted is `DatasetNonNumericVersion.LATEST_PUBLISHED` (`:latest-published`) — but the factory **does not omit** version; it passes the browsed one explicitly.
-
-### 4.5 Form initialization (downstream, correct given inputs)
-
-File: `src/sections/edit-dataset-metadata/EditDatasetMetadata.tsx` ~61–68
-
-```61:68:src/sections/edit-dataset-metadata/EditDatasetMetadata.tsx
-            
-```
-
-`DatasetMetadataForm` builds defaults via `MetadataFieldsHelper.getFormDefaultValues(...)` from those blocks (`src/sections/shared/form/DatasetMetadataForm/index.tsx`).
-
-### 4.6 Version domain constants
-
-File: `src/dataset/domain/models/Dataset.ts` ~210–217
-
-```210:217:src/dataset/domain/models/Dataset.ts
-export enum DatasetNonNumericVersion {
-  LATEST = ':latest',
-  DRAFT = ':draft',
-  LATEST_PUBLISHED = ':latest-published'
-}
-export enum DatasetNonNumericVersionSearchParam {
-  DRAFT = 'DRAFT'
-}
-```
-
-| Constant           | API `versionId`     | Meaning                                                                 |
-| ------------------ | ------------------- | ----------------------------------------------------------------------- |
-| `LATEST`           | `:latest`           | Draft if exists, else latest published — **use this for Edit Metadata** |
-| `DRAFT`            | `:draft`            | Draft only                                                              |
-| `LATEST_PUBLISHED` | `:latest-published` | Latest published only (skips draft)                                     |
-
-**Do not** use `:latest-published` for Edit Metadata: if a draft already exists with newer edits, editors must see the draft.
-
----
-
-## 5. Proven correct pattern already in this repo (Edit Terms)
-
-File: `src/sections/edit-dataset-terms/EditDatasetTermsFactory.tsx`
-
-```19:29:src/sections/edit-dataset-terms/EditDatasetTermsFactory.tsx
-function EditDatasetTermsWithSearchParams() {
-  const [searchParams] = useSearchParams()
-  const defaultActiveTabKey = EditDatasetTermsHelper.defineSelectedTabKey(searchParams)
-  const persistentId = searchParams.get('persistentId') ?? undefined
-  // Always load the latest version (draft if exists, otherwise latest published)
-  const version = DatasetNonNumericVersion.LATEST
-
-  return (
-    
-```
-
-Edit Terms receives the same menu URL shape (including `version=1.0`) but **ignores** it. Edit Metadata should do the same. This is the strongest in-repo proof that the intended SPA product behavior is “always `:latest` for edit screens.”
-
----
-
-## 6. End-to-end bug flowchart
-
-```mermaid
-flowchart TD
-  A["User browses /datasets?persistentId=…&version=1.0"] --> B["EditDatasetMenu.handleOnSelect METADATA"]
-  B --> C["navigate /datasets/edit-metadata?persistentId=…&version=1.0"]
-  C --> D["EditDatasetMetadataFactory reads version from URL"]
-  D --> E["DatasetProvider → getDatasetByPersistentId … '1.0'"]
-  E --> F["JS client getDataset.execute → API versions/1.0"]
-  F --> G["Form defaults = v1 metadataBlocks"]
-  G --> H["Bug: Subtitle empty even though v2 has My Subtitle"]
-
-  C2["Desired"] --> D2["Factory forces DatasetNonNumericVersion.LATEST"]
-  D2 --> E2["getDatasetByPersistentId … ':latest'"]
-  E2 --> F2["API versions/:latest"]
-  F2 --> G2["Form defaults = latest metadataBlocks"]
-```
-
----
-
-## 7. Specific solution (what to change)
-
-### 7.1 Primary fix (required) — Factory always uses `:latest`
-
-**File:** `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx`  
-**Function:** `EditDatasetMetadataWithParams`
-
-**Replace** the version extraction:
-
-```tsx
-const searchParamVersion = searchParams.get('version') ?? undefined
-const version = searchParamVersionToDomainVersion(searchParamVersion)
-```
-
-**With** (mirror Edit Terms):
-
-```tsx
-import { DatasetNonNumericVersion } from '@/dataset/domain/models/Dataset'
-// or relative import consistent with this file's style
-
-// Always load the latest version (draft if exists, otherwise latest published)
-const version = DatasetNonNumericVersion.LATEST
-```
-
-**Remove** unused imports after the change (`searchParamVersionToDomainVersion` if no longer referenced).
-
-**Why this is the right primary fix**
-
-1. Matches JSF expectation stated in #1024.
-2. Matches existing SPA Edit Terms pattern.
-3. Fixes **deep links** to `/edit-metadata?...&version=1.0`, not only menu clicks.
-4. Does not break the dataset **browse** page (which must still load the selected version).
-5. Does not change `DatasetProvider` or repository defaults globally (avoids collateral damage).
-
-### 7.2 Optional cleanup — Menu URL for METADATA
-
-Optionally stop attaching a numeric `version` when navigating to Edit Metadata (Terms already ignores it). **Optional only** after Factory fix is in place; not required for correctness once Factory forces `:latest`.
-
-If you change the menu, keep Upload Files behavior reviewed separately — it still sets version for a reason.
-
-### 7.3 Explicitly out of scope / do not change
-
-| Do not                                       | Why                                       |
-| -------------------------------------------- | ----------------------------------------- |
-| Change browse-page version loading           | Users must still view historical versions |
-| Change `DatasetProvider` to always latest    | Shared by browse + edit                   |
-| Change form defaulting helpers               | They are correct given inputs             |
-| Use `:latest-published` instead of `:latest` | Misses existing draft content             |
-| Redesign Edit Metadata UI                    | Issue is data-fetching only               |
-
-### 7.4 Save / update path (sanity)
-
-After submit, navigation already targets draft (see `useSubmitDataset.ts` navigating with `VERSION=DRAFT`). Prefill must therefore also be latest/draft-aware so the user edits the same lineage they will save into. No change required there for #1024 if Factory uses `:latest`.
-
----
-
-## 8. Implementation playbook (Steps 0–7)
-
-### Step 0 — Baseline (broken)
-
-1. Use a dataset with ≥2 published versions where a field differs (e.g. subtitle added in v2).
-2. Open SPA dataset page with `version=1.0`.
-3. Edit Dataset → Metadata.
-4. **Observe:** form shows v1 values (subtitle empty).
-5. Optionally compare same click path on JSF: subtitle present.
-
-Record URL query string and network call version id (`1.0` vs `:latest`).
-
-### Step 1 — Apply Factory fix
-
-Edit `EditDatasetMetadataFactory.tsx` as in §7.1.
-
-### Step 2 — Manual verify (happy paths)
-
-| Case | Steps                                                                                  | Expected                                       |
-| ---- | -------------------------------------------------------------------------------------- | ---------------------------------------------- |
-| A    | Browse v1 → Edit Metadata                                                              | Latest fields (e.g. subtitle from v2 or draft) |
-| B    | Browse latest published → Edit Metadata                                                | Same latest fields (no regression)             |
-| C    | With an existing draft that changed a field → Edit Metadata from any published version | Draft values appear (`:latest`)                |
-| D    | Direct URL `/edit-metadata?persistentId=…&version=1.0`                                 | Still loads `:latest`, not `1.0`               |
-
-### Step 3 — Automated tests
-
-Existing coverage gaps (verified):
-
-| File                                                                                    | Current focus                                                              | Gap                                                             |
-| --------------------------------------------------------------------------------------- | -------------------------------------------------------------------------- | --------------------------------------------------------------- |
-| `tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx`           | Breadcrumbs / skeleton / not-found; `searchParams = { persistentId }` only | No assertion that fetch uses `:latest` when URL has old version |
-| `tests/e2e-integration/e2e/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx` | Visits with `version=DRAFT` only                                           | No multi-version “from old published version” case              |
-| `tests/component/.../EditDatasetMenu.spec.tsx`                                          | Menu click                                                                 | Does not assert fetch version                                   |
-
-**Add at least one of:**
-
-1. **Component / unit (preferred minimal):** Mount or exercise `EditDatasetMetadataFactory` (or route) with  
-   `?persistentId=…&version=1.0`  
-   and assert the repository `getByPersistentId` was called with `DatasetNonNumericVersion.LATEST` (`:latest`), **not** `"1.0"`.
-
-2. **E2E (strongest product proof):**
-
-   - Create dataset, publish v1 without subtitle.
-   - Add subtitle, publish v2.
-   - Visit dataset with `version=1.0`.
-   - Open Edit Metadata.
-   - Assert subtitle input shows v2 value.
-
-3. **Regression:** From latest version / draft, Edit Metadata still works (existing e2e paths should remain green).
-
-### Step 4 — Lint / typecheck / affected tests
-
-Run the project’s standard checks for touched files (per `CONTRIBUTING.md` / CI). At minimum run the edit-metadata component and e2e specs you touched.
-
-### Step 5 — PR description checklist
-
-- Link #1024
-- State: “Always load `:latest` in `EditDatasetMetadataFactory`, matching `EditDatasetTermsFactory` and JSF.”
-- Note: browse page version selection unchanged
-- List test cases added
-
-### Step 6 — Definition of done
-
-See §10.
-
-### Step 7 — Evidence to attach
-
-- Before/after screenshots (v1 browse → Edit Metadata subtitle)
-- Network panel showing `versions/:latest` (or equivalent JS client version arg)
-- Test output
-
----
-
-## 9. Suggested patch sketch (illustrative)
-
-```tsx
-// EditDatasetMetadataFactory.tsx — after fix
-import { ReactElement } from 'react'
-import { useSearchParams } from 'react-router-dom'
-import { EditDatasetMetadata } from './EditDatasetMetadata'
-import { DatasetProvider } from '../dataset/DatasetProvider'
-import { DatasetJSDataverseRepository } from '../../dataset/infrastructure/repositories/DatasetJSDataverseRepository'
-import { MetadataBlockInfoJSDataverseRepository } from '../../metadata-block-info/infrastructure/repositories/MetadataBlockInfoJSDataverseRepository'
-import { DatasetNonNumericVersion } from '../../dataset/domain/models/Dataset'
-
-const datasetRepository = new DatasetJSDataverseRepository()
-const metadataBlockInfoRepository = new MetadataBlockInfoJSDataverseRepository()
-
-export class EditDatasetMetadataFactory {
-  static create(): ReactElement {
-    return 
-  }
-}
-
-function EditDatasetMetadataWithParams() {
-  const [searchParams] = useSearchParams()
-  const persistentId = searchParams.get('persistentId') ?? undefined
-  // Always load the latest version (draft if exists, otherwise latest published)
-  // See EditDatasetTermsFactory and IQSS/dataverse-frontend#1024
-  const version = DatasetNonNumericVersion.LATEST
-
-  return (
-    
-      
-    
-  )
-}
-```
-
-Import path style should match surrounding files (`@/` vs relative) — keep consistency with this module / Edit Terms.
-
----
-
-## 10. Acceptance criteria (verifiable)
-
-| #   | Criterion                                                                     | How to verify                          |
-| --- | ----------------------------------------------------------------------------- | -------------------------------------- |
-| AC1 | From an older published version, Edit Metadata shows **latest** field values  | Manual case A + e2e                    |
-| AC2 | Deep link with `version=` still loads latest                             | Manual case D + unit spy on repository |
-| AC3 | From latest published / draft, Edit Metadata unchanged / correct              | Manual B/C + existing e2e              |
-| AC4 | Dataset **browse** of historical versions still shows that version’s metadata | Browse v1 page still empty subtitle    |
-| AC5 | Implementation aligns with Edit Terms (`DatasetNonNumericVersion.LATEST`)     | Code review                            |
-| AC6 | Automated regression exists for AC1 or AC2                                    | CI green on new test                   |
-
----
-
-## 11. API mapping (for debugging)
-
-The SPA uses `@iqss/dataverse-client-javascript` `getDataset.execute(persistentId, version, …)`, which maps to Dataverse Native API:
-
-```text
-GET /api/datasets/:persistentId/versions/:versionId?persistentId=...
-```
-
-| Scenario                         | `versionId` today (bug) | `versionId` after fix        |
-| -------------------------------- | ----------------------- | ---------------------------- |
-| Browsing v1, click Edit Metadata | `1.0`                   | `:latest`                    |
-| Draft exists                     | often `:draft` via menu | `:latest` (→ draft)          |
-| Latest published, no draft       | `N.M`                   | `:latest` (→ that published) |
-
-When debugging in DevTools, confirm the version segment or client argument — not only the form UI.
-
----
-
-## 12. Test plan matrix
-
-| ID  | Type           | Setup                                          | Action                           | Expect                              |
-| --- | -------------- | ---------------------------------------------- | -------------------------------- | ----------------------------------- |
-| T1  | Manual         | v1 no subtitle, v2 has subtitle                | Browse v1 → Edit Metadata        | Subtitle = v2 value                 |
-| T2  | Manual         | Same                                           | Browse v2 → Edit Metadata        | Subtitle = v2 value                 |
-| T3  | Manual         | Draft edits subtitle further                   | Browse v1 → Edit Metadata        | Subtitle = draft value              |
-| T4  | Manual         | Open `/edit-metadata?persistentId&version=1.0` | Load page                        | Same as latest, not v1              |
-| T5  | Unit/component | Mock repository                                | Mount factory with `version=1.0` | `getByPersistentId(..., ':latest')` |
-| T6  | E2E            | Publish two versions                           | Automate T1                      | Pass                                |
-| T7  | Regression     | Existing draft edit e2e                        | Run suite                        | Still pass                          |
-
----
-
-## 13. Risks and edge cases
-
-| Risk                                       | Mitigation                                                                                                                                            |
-| ------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------- |
-| Confusing `:latest` vs `:latest-published` | Use `LATEST` only; document draft preference                                                                                                          |
-| Menu still puts old version in URL         | Harmless after Factory fix; optional cleanup                                                                                                          |
-| Permissions / deaccessioned versions       | Existing menu disable / permission checks unchanged; retest if deaccessioned latest                                                                   |
-| Private URL datasets                       | Factory path uses `persistentId`; private-URL browse uses different provider entry — confirm Edit Metadata entry points still go through this factory |
-| Concurrent draft from another user         | Pre-existing conflict handling via `datasetLastUpdateTime` / API; out of scope for #1024                                                              |
-
----
-
-## 14. Relationship to JSF (issue text)
-
-Quoted expectation from #1024 / `@pdurbin`:
-
-> In JSF, when you click "Edit Metadata", the latest metadata is pre-populated, no matter which version you're on. In the SPA, if I click "Edit Metadata" on version 1, the metadata from that version is pre-populated.
-
-There is **no** separate SPA design doc required: JSF behavior + Edit Terms factory are the specifications.
-
----
-
-## 15. Work estimate note
-
-Label **Original size: 3** fits: one focused factory change (and optional menu cleanup) plus tests. Risk is low if scope stays at Factory + tests and avoids global provider changes.
-
----
-
-## 16. Checklist for the implementer
-
-- [ ] Reproduce on SPA with multi-version dataset (Step 0)
-- [ ] Change `EditDatasetMetadataFactory` to `DatasetNonNumericVersion.LATEST`
-- [ ] Remove unused imports
-- [ ] Manual cases A–D
-- [ ] Add unit/component and/or e2e regression
-- [ ] Confirm browse historical version still shows historical metadata
-- [ ] Open PR linking #1024 with before/after evidence
-
----
-
-## 17. Implementation record (this branch)
-
-| Change           | Path                                                                                 | What changed                                                                                                 |
-| ---------------- | ------------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------ |
-| Factory fix      | `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx`                  | Ignore URL `version`; always pass `DatasetNonNumericVersion.LATEST` (`:latest`) into `DatasetProvider`       |
-| Regression tests | `tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx` | Assert `getByPersistentId` is called with `:latest` when URL has `version=1.0`, and when URL omits `version` |
-| This doc         | `docs/issues/1024-edit-metadata-latest-version.md`                                   | Diagnosis + playbook + verification                                                                          |
-
-**Not changed (intentionally):**
-
-- Dataset browse page version loading
-- `EditDatasetMenu` URL construction (harmless after Factory fix; Terms already ignored URL version)
-- `DatasetProvider` / repository defaults
-- Form defaulting helpers
-
----
-
-## 18. Verification instructions (must pass before PR)
-
-Every claim below is falsifiable. Record pass/fail.
-
-### 18.1 Automated (required)
-
-From repo root, with dependencies installed (`npm ci` if needed):
-
-```bash
-# Focused regression for #1024
-npx cypress run --component --spec \
-  tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx
-
-# Existing edit-metadata component suite (no regressions)
-npx cypress run --component --spec \
-  tests/component/sections/edit-dataset-metadata/EditDatasetMetadata.spec.tsx
-```
-
-**Pass criteria:**
-
-| Spec                                  | Expect                                                                                     |
-| ------------------------------------- | ------------------------------------------------------------------------------------------ |
-| `EditDatasetMetadataFactory.spec.tsx` | Both tests green: call uses `:latest` / `DatasetNonNumericVersion.LATEST`, **not** `"1.0"` |
-| `EditDatasetMetadata.spec.tsx`        | All existing tests still green                                                             |
-
-**Fail if:** `getByPersistentId` is invoked with `"1.0"` for the old-version URL case.
-
-### 18.2 Manual product check (required for AC1)
-
-Prerequisite: dataset with ≥2 published versions where a field differs (e.g. title or subtitle added in v2).
-
-| Step | Action                                                           | Expected (pass)                                           | Fail if                   |
-| ---- | ---------------------------------------------------------------- | --------------------------------------------------------- | ------------------------- |
-| M1   | Open SPA dataset with `?version=1.0`                             | Browse page shows v1 content                              | —                         |
-| M2   | Edit Dataset → Metadata                                          | Network/API version is `:latest` (or draft via `:latest`) | Request is for `1.0`      |
-| M3   | Inspect form field that differs in v2                            | Shows **latest** value                                    | Shows empty / v1 value    |
-| M4   | Open Edit Metadata from latest published                         | Same latest values                                        | Regression / blank form   |
-| M5   | If a draft exists with further edits, open Edit Metadata from v1 | Form shows **draft** values (`:latest`)                   | Shows published-only / v1 |
-
-### 18.3 Negative control (browse must stay historical)
-
-| Step | Action                                      | Expected                                                |
-| ---- | ------------------------------------------- | ------------------------------------------------------- |
-| N1   | Stay on browse `?version=1.0` (do not edit) | Historical metadata still shown (e.g. missing subtitle) |
-
-If N1 fails, the fix was applied too broadly (e.g. Provider always latest) — revert and keep the change only in `EditDatasetMetadataFactory`.
-
-### 18.4 Code review checklist
-
-- [ ] Factory uses `DatasetNonNumericVersion.LATEST` only
-- [ ] No use of `:latest-published` for this page
-- [ ] Comment references #1024 / Edit Terms parity
-- [ ] Unused `searchParamVersionToDomainVersion` import removed from Factory
-- [ ] New component spec committed
-
----
-
-## 19. Document history
-
-| Date       | Commit / branch                         | Notes                                                       |
-| ---------- | --------------------------------------- | ----------------------------------------------------------- |
-| 2026-07-31 | `922dcfc` on `develop`                  | Diagnosis + solution written from source                    |
-| 2026-07-31 | `fix/1024-edit-metadata-latest-version` | Factory fix + component regression tests + verification §18 |
diff --git a/docs/issues/PR-1024-DRAFT-BODY.md b/docs/issues/PR-1024-DRAFT-BODY.md
deleted file mode 100644
index 292ba2aca..000000000
--- a/docs/issues/PR-1024-DRAFT-BODY.md
+++ /dev/null
@@ -1,17 +0,0 @@
-## Summary
-
-- Fixes #1024: when opening **Edit Metadata** from an older dataset version, the SPA now pre-fills **latest** metadata (`:latest` — draft if present, otherwise latest published), matching JSF and `EditDatasetTermsFactory`.
-- Root cause: `EditDatasetMetadataFactory` used the browsed `version` query param (e.g. `1.0`). It now ignores that param and always fetches `DatasetNonNumericVersion.LATEST`.
-- Adds component regression tests asserting `getByPersistentId(..., ':latest', ...)` and not `"1.0"`.
-
-## Test plan
-
-- [x] Local: `npx cypress run --component --spec tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx` → **2 passing**
-- [ ] CI component tests
-- [ ] Manual: publish v1 without subtitle → publish v2 with subtitle → browse `?version=1.0` → Edit Metadata → subtitle shows v2 value
-- [ ] Manual: browsing `?version=1.0` without editing still shows historical v1 metadata
-
-## Notes
-
-- Browse-page version selection is unchanged.
-- Optional docs under `docs/issues/` are included for review context; happy to drop them from the PR if preferred.
diff --git a/docs/issues/PR-1024-DRAFT.md b/docs/issues/PR-1024-DRAFT.md
deleted file mode 100644
index cd34e5320..000000000
--- a/docs/issues/PR-1024-DRAFT.md
+++ /dev/null
@@ -1,54 +0,0 @@
-# PR draft for #1024 — DO NOT PUBLISH until user approves
-
-**Status:** Prepared only. Do **not** run `gh pr create` until explicit approval.
-
-## Command to publish later (only when approved)
-
-```bash
-cd /Users/shihuayu/Documents/GitHub/dataverse-frontend
-gh pr create --repo IQSS/dataverse-frontend \
-  --base develop \
-  --head youseihuayu-wonderful:fix/1024-edit-metadata-latest-version \
-  --title "Fix Edit Metadata to always pre-populate latest metadata" \
-  --body-file docs/issues/PR-1024-DRAFT-BODY.md
-```
-
-## Title
-
-```
-Fix Edit Metadata to always pre-populate latest metadata
-```
-
-## Base / head
-
-|             |                                                               |
-| ----------- | ------------------------------------------------------------- |
-| Base repo   | `IQSS/dataverse-frontend`                                     |
-| Base branch | `develop`                                                     |
-| Head        | `youseihuayu-wonderful:fix/1024-edit-metadata-latest-version` |
-| Fixes       | https://github.com/IQSS/dataverse-frontend/issues/1024        |
-
-## Commits included
-
-1. `f10860954` — Fix Edit Metadata to always load latest dataset version
-2. `0b573ad3f` — Add HTML verification report for Edit Metadata latest-version fix
-
-## Files
-
-- `src/sections/edit-dataset-metadata/EditDatasetMetadataFactory.tsx` — production fix
-- `tests/component/sections/edit-dataset-metadata/EditDatasetMetadataFactory.spec.tsx` — regression
-- `docs/issues/1024-edit-metadata-latest-version.md` — playbook (optional for upstream; can drop if reviewers prefer)
-- `docs/issues/1024-edit-metadata-latest-version-verification.html` — before/after report (optional)
-
-## Local verification already done
-
-```
-EditDatasetMetadataFactory
-  ✓ always fetches :latest when the URL carries an older published version (issue #1024)
-  ✓ still fetches :latest when the URL has no version param
-
-2 passing
-All specs passed!
-```
-
-Node: v22.23.2 · Cypress: 15.2.0