[codex] fix(tui): tolerate unsupported bracketed paste#3548
Merged
Hmbown merged 2 commits intoJun 24, 2026
Conversation
Legacy Windows console hosts can report bracketed paste as unsupported through crossterm, which made older Win10/LTSC shells a fragile startup and terminal-mode path. Disable bracketed paste automatically for unmarked legacy Windows console hosts, and make bracketed-paste enable/disable best-effort in terminal recovery, pause, cleanup, and emergency restore paths. Closes Hmbown#1102. Verification: - cargo fmt -- --check - cargo test -p codewhale-tui --bin codewhale-tui --locked unmarked_windows_console_forces_calm_rendering - cargo test -p codewhale-tui --bin codewhale-tui --locked recover_terminal_modes_runs_without_panic_on_windows - cargo test -p codewhale-tui --bin codewhale-tui --locked paste_burst_detection_is_configurable_independent_of_bracketed_paste - cargo test -p codewhale-tui --bin codewhale-tui --locked - cargo test --workspace --locked - cargo build --release -p codewhale-cli -p codewhale-tui --locked
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0a0bb1412
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review caught that mutating Settings::bracketed_paste inside apply_env_overrides could persist the legacy conhost fallback when unrelated settings are saved. Keep the stored setting unchanged, expose an effective_bracketed_paste runtime helper, and use that helper when building TuiOptions for startup. Verification: - cargo fmt -- --check - cargo test -p codewhale-tui --bin codewhale-tui --locked unmarked_windows_console_forces_calm_rendering - cargo test -p codewhale-tui --bin codewhale-tui --locked recover_terminal_modes_runs_without_panic_on_windows - cargo test -p codewhale-tui --bin codewhale-tui --locked paste_burst_detection_is_configurable_independent_of_bracketed_paste - cargo test -p codewhale-tui --bin codewhale-tui --locked
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Win10/LTSC legacy console hosts can report crossterm bracketed paste as unsupported (
Bracketed paste not implemented in the legacy Windows API). CodeWhale already recovered some terminal modes best-effort, but bracketed paste still had strict paths and the legacy-host settings fallback did not disable it by default.Closes #1102.
Testing
cargo fmt -- --checkcargo test -p codewhale-tui --bin codewhale-tui --locked unmarked_windows_console_forces_calm_renderingcargo test -p codewhale-tui --bin codewhale-tui --locked recover_terminal_modes_runs_without_panic_on_windowscargo test -p codewhale-tui --bin codewhale-tui --locked paste_burst_detection_is_configurable_independent_of_bracketed_pastecargo test -p codewhale-tui --bin codewhale-tui --lockedcargo test --workspace --lockedcargo build --release -p codewhale-cli -p codewhale-tui --lockedAdditional local check:
cargo clippy --workspace --all-targets --locked -- -D warningscurrently fails on unrelated current-main warnings inclient/chat.rs,core/engine.rs,client.rs,tools/js_execution.rs,tools/pandoc.rs,tui/session_picker.rs, andtui/widgets/mod.rs; none are in this PR's changed files.