Skip to content

Commit 55115d8

Browse files
committed
Fix several cases of errors appearing in the console
One appeared on load (a deprecated meta tag). One appeared when adding an Identity (Passthrough) node. One appeared when exposing the the Weight parameter of the Stroke node. This also fixes the intended behavior of the bisect script, which was involved when finding the prevenance of these errors.
1 parent 5edb00b commit 55115d8

4 files changed

Lines changed: 13 additions & 8 deletions

File tree

editor/src/messages/portfolio/document/utility_types/network_interface.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3994,10 +3994,12 @@ impl NodeNetworkInterface {
39943994
self.unload_upstream_node_click_targets(vec![*node_id], network_path);
39953995
self.unload_all_nodes_bounding_box(network_path);
39963996

3997-
// Unload the interior imports ports
3998-
let nested_path = [network_path, &[*node_id]].concat();
3999-
self.unload_import_export_ports(&nested_path);
4000-
self.unload_modify_import_export(&nested_path);
3997+
// Unload the interior import/export ports if this node has a nested network
3998+
if matches!(self.implementation(node_id, network_path), Some(DocumentNodeImplementation::Network(_))) {
3999+
let nested_path = [network_path, &[*node_id]].concat();
4000+
self.unload_import_export_ports(&nested_path);
4001+
self.unload_modify_import_export(&nested_path);
4002+
}
40014003
}
40024004
} else {
40034005
self.unload_import_export_ports(network_path);

editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,10 @@ impl NodeNetworkInterface {
242242
}
243243
DocumentNodeImplementation::ProtoNode(proto_node_identifier) => {
244244
let Some(implementations) = NODE_REGISTRY.get(proto_node_identifier) else {
245-
log::error!("Protonode {proto_node_identifier:?} not found in registry in potential_valid_input_types");
245+
// The compiler removes the identity node, so it's expected to be absent from the registry
246+
if proto_node_identifier != &graphene_std::ops::identity::IDENTIFIER {
247+
log::error!("Proto node `{proto_node_identifier:?}` not found in the node registry, in potential_valid_input_types");
248+
}
246249
return Vec::new();
247250
};
248251
let number_of_inputs = self.number_of_inputs(node_id, network_path);

frontend/index.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
<meta name="color-scheme" content="dark only" />
1717
<meta name="darkreader-lock" />
1818
<meta name="description" content="Graphite is an open source vector graphics editor and procedural design engine. Create and animate with a nondestructive editing workflow that combines layer-based compositing with node-based generative design." />
19-
<meta name="apple-mobile-web-app-capable" content="yes" />
20-
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" />
19+
<meta name="mobile-web-app-capable" content="yes">
2120
<!-- INDEX_HTML_HEAD_REPLACEMENT -->
2221
</head>
2322
<body>

website/static/js/page/contributor-guide/bisect-tool.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,7 @@ document.addEventListener("DOMContentLoaded", () => {
369369
// Exists at starting commit, so it was introduced earlier. Search backward (doubling).
370370
badIndex = currentIndex;
371371
boundarySearching = true;
372+
boundaryOffset = Math.max(1, commits.length - 1 - startIndex);
372373
} else {
373374
// Absent at starting commit, so the issue was introduced more recently. Extend the commit list forward (towards HEAD) before narrowing.
374375
goodIndex = currentIndex;
@@ -558,7 +559,7 @@ document.addEventListener("DOMContentLoaded", () => {
558559
stepCount = 0;
559560
history = [];
560561
bisectPhase = "boundary";
561-
boundaryOffset = 1;
562+
boundaryOffset = 0;
562563
boundarySearching = false;
563564
elements.goBackButton?.classList.remove("hidden");
564565
if (elements.testBuildButton instanceof HTMLElement) elements.testBuildButton.style.display = "";

0 commit comments

Comments
 (0)