You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3a765bc
Browse filesBrowse the repository at this point in the historyBrowse files
fix(#403): No way to clear a selection: no Esc, no clear button, no select-all; Upload stay
Esc on a row or the list clears a non-empty selection (onActionKey in itemActions.ts); the selection bar (desktop and phone sheet) gets a borderless 'Clear selection' icon button; the shortcuts dialog lists Esc; i18n added in all three locales. The #403 E2E test now deletes its folder afterwards so the shared home root stays under the list's 200-entry render limit, which had made the collision spec time out on mobile.
Refs #403
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: DECISIONS.md
+8Lines changed: 8 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1388,3 +1388,11 @@ Question: a password-protected link answered `info` with the item's name and typ
1388
1388
Decision: while locked, `GET /s/<token>/info` is `{ locked: true }` and nothing else; `name` and `type` are optional in `PublicLinkInfo` and come only once the link is unlocked, as before. The page keeps the header with the app's name, as on every visitor page; the kind line says "Shared link" instead of "Shared file"/"Shared folder", the heading is "Protected link" (`link.page.lockedTitle`), and the existing line "This link is protected by a password." stands above the password field. A link without a password is unlocked at once and is unchanged.
1389
1389
1390
1390
Why: the owner set the password to keep the item private, and what it is called and whether it is a file or a folder is part of that; file requests already answer only the owner-written label while locked. The link's label stays owner-only: it was written for the owner's list ("For the accountant"), not for visitors, and showing it would be a new disclosure nobody asked for (YAGNI).
1391
+
1392
+
## 2026-10-20: One step clears a selection: Esc and a clear button (#403)
1393
+
1394
+
Question: after Ctrl+A (or "New folder", which selects what it creates) nothing cleared the selection but unticking every row, and on the desktop the bar keeps Upload hidden meanwhile. Which ways out, and do a select-all checkbox in the list header or Ctrl+A as a toggle come with them?
1395
+
1396
+
Decision: Esc on a row or tile clears a non-empty selection (`onActionKey`; open menus and dialogs stop the key first), and the selection bar has a borderless icon button "Clear selection" (`icon-close`, aria-label) right after the count, on the desktop bar and on the phone's bottom bar alike. The shortcuts dialog lists "Esc: clear the selection". No header checkbox, Ctrl+A stays select-all, and a click on the empty area does not clear.
1397
+
1398
+
Why: the issue's expected behaviour asks for exactly these two ways; the clear button sits beside the count it resets, where both a mouse and a finger look for it. A header checkbox and a toggling Ctrl+A would be a second and third way to the same state (YAGNI), and clearing on an empty-area click would fight the empty area's own menu (#340).
0 commit comments