From 5a7a3d4397b9f76a92c85b88e46b84556156e171 Mon Sep 17 00:00:00 2001 From: Kody Stribrny Date: Thu, 4 Jun 2026 10:05:58 -0700 Subject: [PATCH 1/2] Add comment explaining ACL permissions revocation Adds a simple comment mentioning the requirement for the privileged task to revoke permissions before deleting an object. --- include/mpu_wrappers.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/mpu_wrappers.h b/include/mpu_wrappers.h index 3b4738e962c..5e775f8fae1 100644 --- a/include/mpu_wrappers.h +++ b/include/mpu_wrappers.h @@ -249,6 +249,8 @@ #if ( ( configUSE_MPU_WRAPPERS_V1 == 0 ) && ( configENABLE_ACCESS_CONTROL_LIST == 1 ) ) #define vGrantAccessToTask( xTask, xTaskToGrantAccess ) vGrantAccessToKernelObject( ( xTask ), ( int32_t ) ( xTaskToGrantAccess ) ) + /* A privileged task must revoke access to the object before deletion, + * otherwise index reuse may result in accidental permissions. */ #define vRevokeAccessToTask( xTask, xTaskToRevokeAccess ) vRevokeAccessToKernelObject( ( xTask ), ( int32_t ) ( xTaskToRevokeAccess ) ) #define vGrantAccessToSemaphore( xTask, xSemaphoreToGrantAccess ) vGrantAccessToKernelObject( ( xTask ), ( int32_t ) ( xSemaphoreToGrantAccess ) ) From 4319a7147029fe5fcb6a2f7a8ae2a5f48b71b688 Mon Sep 17 00:00:00 2001 From: Kody Stribrny Date: Thu, 4 Jun 2026 13:31:49 -0700 Subject: [PATCH 2/2] Update formatting --- include/mpu_wrappers.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/mpu_wrappers.h b/include/mpu_wrappers.h index 5e775f8fae1..b1b35d2ba83 100644 --- a/include/mpu_wrappers.h +++ b/include/mpu_wrappers.h @@ -249,8 +249,9 @@ #if ( ( configUSE_MPU_WRAPPERS_V1 == 0 ) && ( configENABLE_ACCESS_CONTROL_LIST == 1 ) ) #define vGrantAccessToTask( xTask, xTaskToGrantAccess ) vGrantAccessToKernelObject( ( xTask ), ( int32_t ) ( xTaskToGrantAccess ) ) - /* A privileged task must revoke access to the object before deletion, - * otherwise index reuse may result in accidental permissions. */ + +/* A privileged task must revoke access to the object before deletion, + * otherwise index reuse may result in accidental permissions. */ #define vRevokeAccessToTask( xTask, xTaskToRevokeAccess ) vRevokeAccessToKernelObject( ( xTask ), ( int32_t ) ( xTaskToRevokeAccess ) ) #define vGrantAccessToSemaphore( xTask, xSemaphoreToGrantAccess ) vGrantAccessToKernelObject( ( xTask ), ( int32_t ) ( xSemaphoreToGrantAccess ) )