bgpd: Don't mark nexthop as changed if a set next-hop unchanged is applied (backport #21445) #346
Annotations
1 error and 2 warnings
|
Check Commit
You have commit messages with errors
⧗ input: bgpd: Don't mark nexthop as changed if a set next-hop unchanged is applied
An inbound policy preserving the received nexthop into the RIB shouldn't
prevent the outbound decision to set next-hop-self or reset the nexthop
for EBGP. Those are independent decisions. If an operator wants the nexthop
preserved on outbound, they configure neighbor X next-hop-unchanged
or an outbound route-map with set ip next-hop unchanged (which would
set the flag in out_rmap_flags).
Fixes: a725bf4bbb ("bgpd:Fixing a conflict issue between rmap_in_change_flag and rmap_out_change_flag.")
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit e14d1bd9b1f0ce4a84b90156676de45654256c48)
✖ header must not be longer than 72 characters, current length is 74 [header-max-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: tests: Check if route-map with set nexthop unchanged does not prevent outgoing
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit 8de3f049fcd80d705e1e717866f626e731b24451)
✖ header must not be longer than 72 characters, current length is 78 [header-max-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
|
|
.github/workflows/commitlint.yml#L14
.github/workflows/commitlint.yml (Line: 14, Col: 9): Conditional expression contains literal text outside replacement tokens. This will cause the expression to always evaluate to truthy. Did you mean to put the entire expression inside ${{ }}?
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
Loading