Add Zcash buy/sell support with Banxa

Add ZEC to CURRENCY_PLUGINID_MAP in the Banxa ramp plugin to enable
Zcash buy/sell when supported by Banxa's API.

Author: samholmes

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased (develop)
 
+- added: Zcash buy/sell support with Banxa
+
 ## 4.41.0 (staging)
 
 - changed: Replace `currencyCode` usage with `EdgeTokenId` throughout the app

src/plugins/ramps/banxa/banxaRampPlugin.ts

@@ -307,7 +307,8 @@ const CURRENCY_PLUGINID_MAP: Record<string, string> = {
   TON: 'ton',
   XLM: 'stellar',
   XRP: 'ripple',
-  XTZ: 'tezos'
+  XTZ: 'tezos',
+  ZEC: 'zcash'
 }
 
 const COIN_TO_CURRENCY_CODE_MAP: StringMap = { BTC: 'BTC' }
@@ -1206,16 +1207,24 @@ export const banxaRampPlugin: RampPluginFactory = (
                 )
                 return
               }
-              // Prefer segwit where available; fallback to default public address
+              // Prefer transparent or segwit address where available; fallback to default
               const addresses = await coreWallet.getAddresses({ tokenId: null })
-              const [defaultAddress] = addresses
-              if (defaultAddress == null)
-                throw new Error('Banxa missing receive address')
-              const segwitAddress = addresses.find(
-                row => row.addressType === 'segwitAddress'
+              const getAddressTypePriority = (
+                type: string | undefined
+              ): number => {
+                if (type === 'transparentAddress') return 1
+                if (type === 'segwitAddress') return 1
+                return 2
+              }
+              // Sort addresses by priority
+              addresses.sort(
+                (a, b) =>
+                  getAddressTypePriority(a.addressType) -
+                  getAddressTypePriority(b.addressType)
               )
-              const receivePublicAddress =
-                segwitAddress?.publicAddress ?? defaultAddress.publicAddress
+              const [receiveAddress] = addresses
+              if (receiveAddress == null)
+                throw new Error('Banxa missing receive address')
 
               const bodyParams: any = {
                 payment_method_id: paymentObj?.id ?? '',
@@ -1240,13 +1249,13 @@ export const banxaRampPlugin: RampPluginFactory = (
                 if (testnet && banxaChain === 'BTC') {
                   bodyParams.wallet_address = TESTNET_ADDRESS
                 } else {
-                  bodyParams.wallet_address = receivePublicAddress
+                  bodyParams.wallet_address = receiveAddress.publicAddress
                 }
               } else {
                 if (testnet && banxaChain === 'BTC') {
                   bodyParams.refund_address = TESTNET_ADDRESS
                 } else {
-                  bodyParams.refund_address = receivePublicAddress
+                  bodyParams.refund_address = receiveAddress.publicAddress
                 }
               }
 
@@ -1482,7 +1491,7 @@ export const banxaRampPlugin: RampPluginFactory = (
                             // Post the txid back to Banxa
                             const bodyParams = {
                               tx_hash: txid,
-                              source_address: receivePublicAddress,
+                              source_address: receiveAddress.publicAddress,
                               destination_address: publicAddress
                             }
                             await banxaFetch({