Skip to content

EXP 7.10#220

Merged
The9Cat merged 146 commits into
mainfrom
devel
Jun 2, 2026
Merged

EXP 7.10#220
The9Cat merged 146 commits into
mainfrom
devel

Conversation

@michael-petersen

@michael-petersen michael-petersen commented May 26, 2026

Copy link
Copy Markdown
Member

This PR bumps EXP to 7.10, with new features and small API changes.

The9Cat and others added 30 commits March 12, 2026 10:00
@The9Cat
Added a Toomre-type disk for deprojection primarily
494c619
@The9Cat
Added an enum and reflector for deprojection disk types and included …
c7bf5ee 
…the Toomre model in the updated list of valid types
Addded a test routine for Abel deprojection; updated EmpCylSL for der…
6efc024 
…ivative form, which is more accurate near the center
Missing source driver file
22adb60
Missing test class
b12a1f8
@The9Cat
Potential fix for pull request finding
3cf4d6c 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
a03bbe6 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
4042544 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
db0e02d 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
dfc99f9 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
2e6fee4 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add a test routine from EmpDeproj alone; fix parsing error in testEmp…
204d43d 
…Deproj for method variables
@The9Cat
Updated parsing in BiorthBasis::Cylindrical for deprojection
0e82cb6
@The9Cat
Potential fix for pull request finding
cb5e150 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
5f151bc 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
b761050 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
25f893d 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
f9a6ae2 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
5a66623 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
4175b1e 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
31dad72 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
9c2f36f 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Use new sech^2 scaling
22b6493
Merge branch 'Toomre' of github.com:EXP-code/EXP into Toomre
84bef8f
Python deprojection test routine; add possibility of a separate Pytho…
9439daa 
…n functor for deprojection in EmpCylSL
@The9Cat
Fix typo in parameter assignment
1d50ae5
Remove the initial test function; add doc strings to the help stanza …
eb1f9eb 
…on the standalone tests
Only print deprojection info from one node
6402d49
@The9Cat
Merge branch 'devel' into Toomre
5b0aa7d
@The9Cat
Potential fix for pull request finding
c934a79 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
The9Cat and others added 10 commits May 28, 2026 17:49
@The9Cat
Potential fix for pull request finding
bb96362 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
219ac1a 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
43c919f 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
3f1bd24 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Fix Cube valid_keys entries for samplesz suggestion
20e3ec2
chore: finalize targeted review-comment handling
5cffe13
@michael-petersen
Merge pull request #221 from EXP-code/copilot/wip-address-feedback-ap…
3aa536b 
…ply-coefficient-rotation-ch

Address feedback to apply coefficient rotation change in computeAccel() calls
@michael-petersen
remove some build files along for the ride
be2cd3a
@michael-petersen
Merge pull request #208 from EXP-code/Toomre
13be92a 
BiorthBasis::Cylinder deprojection improvements
@michael-petersen
Merge branch 'devel' into covarianceParameterConfusion
ad182a3
@michael-petersen michael-petersen requested a review from Copilot May 29, 2026 09:26
Copilot AI reviewed May 29, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 39 changed files in this pull request and generated 7 comments.

Comment thread utils/Test/testDeproject.cc Outdated
Comment thread utils/Test/testDeproject.cc
Comment thread utils/Test/testEmpDeproj.cc
Comment thread utils/Test/testEmp.cc Outdated
Comment thread utils/Test/testmd5.cc Outdated
Comment thread utils/Test/testmd5.cc
Comment thread utils/Test/testmd5.cc
Martin D. Weinberg and others added 14 commits May 29, 2026 08:30
Add explicit version number to deprecation warning
f8e8c48
@The9Cat
Potential fix for pull request finding
3b07ea6 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
5e753a5 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
eb52943 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
2452b03 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
9b56ca1 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
2b21274 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Potential fix for pull request finding
256a55c 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@The9Cat
Merge pull request #222 from EXP-code/covarianceParameterConfusion
cb83303 
`BiorthBasis` parameter 'subsamp' and 'samplesz' are duplicates!
Add missing global key
6485d51
@The9Cat
Potential fix for pull request finding
0f837d1 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@michael-petersen
Merge pull request #223 from EXP-code/missingGlobalKey
761f303 
Missing global key
@michael-petersen
reset bug counter at minor version to 0
1a780bc
@michael-petersen
Merge branch 'devel' of github.com:EXP-code/EXP into devel
a8a97d2
@The9Cat

The9Cat commented Jun 2, 2026

Copy link
Copy Markdown
Member

@michael-petersen reports that the notebook suite ran successfully. The Toomre target with inner tapers ('doughnut' basis) builds and reads successfully as well.

Let's call it done.

The9Cat
The9Cat approved these changes Jun 2, 2026
View reviewed changes

@The9Cat The9Cat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks okay. Let's merge.

@The9Cat The9Cat merged commit e913730 into main Jun 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@The9Cat The9Cat The9Cat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michael-petersen @The9Cat