Add snapshots plan#41
Merged
Merged
Conversation
DominicOram
approved these changes
May 26, 2026
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Great, thanks, just the one comment.
|
|
||
|
|
||
| def test_take_snapshot_plan(run_engine: RunEngine, camera: ContAcqDetector): | ||
| run_engine(take_snapshot(camera)) |
Contributor
There was a problem hiding this comment.
Should: Can you assert something here? Or maybe also have a test that runs with the sim run engine?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 53.09% 55.82% +2.73%
==========================================
Files 8 9 +1
Lines 194 206 +12
==========================================
+ Hits 103 115 +12
Misses 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
Requires DiamondLightSource/dodal#2032, possibly bluesky/ophyd-async#1258