docs: document okta_saml configuration and auth flow - #260
Conversation
Document the okta_saml context format, runtime flow, and v1 limitations across README (config example, usage section, env-var automation), architecture docs (EN/KO auth model), and project overview docs. v1 limitations are stated explicitly: TOTP and Okta Verify push factors only, deterministic role selection via role_arn, and credentials-only caching with no persisted secrets. Closes #88 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFhLrnpVxivu62cC3k9NZB
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This documentation PR comprehensively documents the Okta SAML authentication feature across all relevant documentation files. The changes correctly update authentication mode counts, add detailed usage examples, describe the runtime flow, explain configuration options, and document v1 limitations including MFA factor support and security practices.
The documentation is consistent across English and Korean versions, follows existing patterns, and provides clear guidance for both interactive and non-interactive (CI/automation) usage scenarios. All sections properly integrate the new okta_saml authentication type alongside existing credential, assume-role, SSO, and console_login options.
No blocking issues identified. The documentation is ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
youngjinjung-linq
left a comment
youngjinjung-linq
left a comment
There was a problem hiding this comment.
냉정 리뷰 완료. stacked #257–#259의 실제 필드명과 인증/MFA/cache 동작을 문서와 대조했으며 이 docs-only diff의 새 오류는 찾지 못했습니다.
…-88-okta-saml-docs
1d204db
into
feature/issue-85-okta-saml-exchange
2 participants
Summary
Implements #88, the final slice of the Okta SAML track (#26). Stacked on the #87 MFA PR (base branch:
feature/issue-87-okta-mfa-challenge); merge the earlier Okta slices first.okta_samlcontext in the config example, a dedicated Okta SAML Contexts usage section (interactive +UNIC_OKTA_USERNAME/UNIC_OKTA_PASSWORDautomation), how to deriveokta_app_idfrom the app embed link, and explicit v1 limitations (factor set, deterministic role selection, credentials-only caching).docs/architecture.en.md/docs/architecture.ko.md:okta_samladded to the auth model with the runtime flow and cache behavior; auth mode counts corrected.docs/project-overview.en.md/docs/project-overview.ko.md: auth coverage updated.With this, all five delivery slices of #26 are complete (#84 schema, #85 exchange, #86 cache, #87 MFA, #88 docs) — #26 can be closed once the stack merges.
Closes #88
Part of #26