feat: add okta_saml auth type and context schema - #244
Conversation
Introduce the okta_saml auth type so Okta-backed contexts can be defined ahead of runtime credential exchange (DevopsArtFactory#85). Config gains okta_org_url and okta_app_id fields in both the flat and structured auth forms, the context add wizard offers okta_saml with non-secret fields only (passwords and MFA secrets never touch config.yaml), and the repository/env flows reject okta_saml contexts with a clear not-implemented-yet error instead of misbehaving. Closes DevopsArtFactory#84 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFhLrnpVxivu62cC3k9NZB
|
Warning Review limit reached
Next review available in: 23 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Recreated as #257 from an in-repo branch under the maintainer account; this PR is superseded. |
Summary
Implements #84, the first slice of the Okta SAML federation track (#26): okta_saml contexts can now be defined in config and the context add wizard, ahead of the runtime credential exchange provider (#85).
okta_samlauth type constant plus normalization (okta_saml/okta-saml).okta_org_urlandokta_app_id, supported in both the flat form and the structuredauthsection, and surfaced throughConfig,ContextInfo, and named-context loading. The existingrole_arnfield doubles as an optional preferred role.okta_samlwith org URL and app ID as required fields; passwords, one-time codes, and MFA secrets are never collected or persisted.NewAwsRepositoryandunic envreject okta_saml contexts with a clear "runtime credential exchange is not implemented yet" error instead of silently falling through to profile-based auth.Testing
go test ./...passes: config parsing (flat/structured/ContextInfo), auth type normalization, wizard field selection incl. a no-secrets assertion, and the repository rejection path.make buildpasses.Docs
okta_samlas config-schema-only for now. Full auth-flow documentation lands with docs: Document okta_saml configuration and auth flow #88 once feat: Add Okta SAML credential exchange provider #85–feat: Add Okta MFA challenge flow for okta_saml #87 ship.Closes #84
Part of #26