Skip to content

feat: add okta_saml auth type and context schema - #244

Closed
youngjinjung-linq wants to merge 1 commit into
DevopsArtFactory:mainfrom
youngjinjung-linq:feature/issue-84-okta-saml-schema
Closed

feat: add okta_saml auth type and context schema#244
youngjinjung-linq wants to merge 1 commit into
DevopsArtFactory:mainfrom
youngjinjung-linq:feature/issue-84-okta-saml-schema

Conversation

@youngjinjung-linq

Copy link
Copy Markdown

Summary

Implements #84, the first slice of the Okta SAML federation track (#26): okta_saml contexts can now be defined in config and the context add wizard, ahead of the runtime credential exchange provider (#85).

  • okta_saml auth type constant plus normalization (okta_saml / okta-saml).
  • New non-secret context fields okta_org_url and okta_app_id, supported in both the flat form and the structured auth section, and surfaced through Config, ContextInfo, and named-context loading. The existing role_arn field doubles as an optional preferred role.
  • Context add wizard offers okta_saml with org URL and app ID as required fields; passwords, one-time codes, and MFA secrets are never collected or persisted.
  • Runtime guard: NewAwsRepository and unic env reject okta_saml contexts with a clear "runtime credential exchange is not implemented yet" error instead of silently falling through to profile-based auth.

Testing

  • go test ./... passes: config parsing (flat/structured/ContextInfo), auth type normalization, wizard field selection incl. a no-secrets assertion, and the repository rejection path.
  • make build passes.

Docs

Closes #84

Part of #26

Introduce the okta_saml auth type so Okta-backed contexts can be
defined ahead of runtime credential exchange (DevopsArtFactory#85). Config gains
okta_org_url and okta_app_id fields in both the flat and structured
auth forms, the context add wizard offers okta_saml with non-secret
fields only (passwords and MFA secrets never touch config.yaml), and
the repository/env flows reject okta_saml contexts with a clear
not-implemented-yet error instead of misbehaving.

Closes DevopsArtFactory#84

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BFhLrnpVxivu62cC3k9NZB
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@youngjinjung-linq, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e7a54811-1aad-400e-a507-316f123d9b99

📥 Commits

Reviewing files that changed from the base of the PR and between 744b139 and dbd5773.

📒 Files selected for processing (8)
  • README.md
  • internal/app/context_add.go
  • internal/app/context_add_test.go
  • internal/auth/env.go
  • internal/config/config.go
  • internal/config/config_test.go
  • internal/services/aws/repository.go
  • internal/services/aws/repository_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@YoungJinJung

Copy link
Copy Markdown
Contributor

Recreated as #257 from an in-repo branch under the maintainer account; this PR is superseded.

@youngjinjung-linq
youngjinjung-linq deleted the feature/issue-84-okta-saml-schema branch August 13, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add okta_saml auth type and context schema

2 participants