From d6f204643f6a6dbb9327418417a23671fa7a20fd Mon Sep 17 00:00:00 2001 From: Danny Ben Shitrit Date: Mon, 23 Mar 2026 20:12:42 +0200 Subject: [PATCH 1/2] update github action --- .github/workflows/test.yml | 40 ++++++++++++++++++++++++++++---------- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d8656c6..59c728b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,25 +4,19 @@ on: push: { branches: master } jobs: - test: - name: Approvals on Ubuntu + ubuntu_approval: + name: Approval on Ubuntu runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v4 - name: Install fzf run: sudo apt install -y fzf - - name: Install Shellkin - run: curl -Ls get.dannyb.co/shellkin/setup | bash - - name: Run shellcheck tests - run: shellcheck fuzzycd setup - name: Run approval tests run: test/approve - - name: Run acceptance tests - run: shellkin - test_mac: - name: Approvals on macOS + macos_approval: + name: Approval on macOS runs-on: macos-latest steps: - name: Checkout code @@ -32,6 +26,32 @@ jobs: - name: Run approval tests run: test/approve + ubuntu_acceptance: + name: Acceptance on Ubuntu + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + - name: Install fzf + run: sudo apt install -y fzf + - name: Install Shellkin + run: curl -Ls get.dannyb.co/shellkin/setup | bash + - name: Run acceptance tests + run: shellkin + + macos_acceptance: + name: Acceptance on macOS + runs-on: macos-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + - name: Install fzf + run: brew install fzf + - name: Install Shellkin + run: curl -Ls get.dannyb.co/shellkin/setup | bash + - name: Run acceptance tests + run: shellkin + ubuntu_setup: name: Setup on Ubuntu runs-on: ubuntu-latest From 1b1f4ea8cfa7a871af47f3b347f7cd3224d896d5 Mon Sep 17 00:00:00 2001 From: Danny Ben Shitrit Date: Mon, 23 Mar 2026 20:15:17 +0200 Subject: [PATCH 2/2] fix mac acceptance --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 59c728b..b1002e2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -47,6 +47,8 @@ jobs: uses: actions/checkout@v4 - name: Install fzf run: brew install fzf + - name: Upgrade the outdated bash + run: brew install bash - name: Install Shellkin run: curl -Ls get.dannyb.co/shellkin/setup | bash - name: Run acceptance tests