Feature: add neighbor subface helper#2216
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
==========================================
- Coverage 82.57% 82.50% -0.07%
==========================================
Files 116 116
Lines 18553 18568 +15
==========================================
Hits 15320 15320
- Misses 3233 3248 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
spenke91
left a comment
There was a problem hiding this comment.
Thank you very much @dutkalex for another great contribution! :-) I am sorry it took us so long to reply...
I mostly have suggestions regarding variable names and code comments (which, I know, not everybody loves as much as I do 🤓 ). Aside from that, I only have a question regarding the hard-coded 4.
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
Add assertion to ensure the face was found before destruction.
No worries @spenke91. Thank you for taking the time, I know you guys have a lot on your plate.
I get it, I often say that getting the compiler to understand the code is the easy part and that the real challenge it to write code that humans can comprehend 😉. I have either committed your suggestions directly, or answered your comments/questions to get your opinion. Let me know what you think and I'll revise the code accordingly. |
spenke91
left a comment
There was a problem hiding this comment.
Thanks a lot for your comments and replies!
spenke91
left a comment
There was a problem hiding this comment.
The doxygen workflow is failing due to a minor typo...
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
Head branch was pushed to by a user without write access
Describe your changes here:
Implements #2215
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).