-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: [performance improvement] Optimize PDF Forge icon imports for tree-shaking #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cukurikik
wants to merge
1
commit into
main
Choose a base branch
from
bolt-optimize-pdf-icons-tree-shaking-12979008199779249146
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| ## 2024-03-19 - React Icons Import Tree-Shaking Bottleneck | ||
| **Learning:** Using `import * as Icons from "lucide-react"` combined with dynamic property lookups completely defeats Next.js and Webpack tree-shaking mechanisms. In this specific Next.js codebase, it pulled in the entire `lucide-react` library (~160 KB extra JavaScript) into the `/audio` route's client bundle, rather than just the ~30 icons actually needed. | ||
| **Action:** Always import icons explicitly by name (e.g., `import { Scissors } from "lucide-react"`) and store the component reference itself when mapping configurations, rather than relying on string keys and wildcard imports. This drastically reduces First Load JS size. | ||
|
|
||
| ## 2024-03-29 - PDF Forge Icons Import Tree-Shaking Bottleneck | ||
| **Learning:** Found another instance where `import * as Icons from "lucide-react"` was used in `src/modules/pdf-forge/components/PdfForgeDashboard.tsx` to dynamically render icons based on string names from the `PDF_TOOLS` constants file. This causes the same tree-shaking failure, bloating the `/pdf` route bundle. | ||
| **Action:** Applied the explicit import pattern to `src/modules/pdf-forge/constants/tools.ts`, importing only the 30 necessary icons and assigning them to the `icon` property as component references, rather than string keys. This ensures only used icons are bundled. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the entry date to match the actual PR date.
Line 5 uses
2024-03-29, but this PR is dated2026-03-29. This can mislead future timeline/audit reads of this learning log.Suggested patch
📝 Committable suggestion
🤖 Prompt for AI Agents