🧪 [testing improvement] Add unit tests for usePdfStore toBlob helper

[Cukurikik]

🎯 What: The testing gap in src/modules/pdf-forge/store/usePdfStore.ts regarding the toBlob pure function was addressed.
📊 Coverage: Added tests to cover the happy path (correct conversion, correct blob type, correct size) and an edge condition (empty Uint8Array) in usePdfStore.test.ts.
✨ Result: Improved test coverage and reliability for the PDF store utility functions. The toBlob function was exported to be testable.

---

PR created automatically by Jules for task 4187336579000509184 started by @Cukurikik

Summary by CodeRabbit

• Refactor

  • Converted a blob conversion utility from an internal helper to a publicly exported function

• Tests

  • Added test cases validating blob conversion functionality, ensuring correct MIME type assignment and accurate size handling across various input scenarios

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

📝 Walkthrough

Walkthrough

The toBlob utility function in usePdfStore.ts is exported to make it accessible for external testing. Corresponding test cases validate that this function correctly converts Uint8Array inputs into Blob objects with the proper application/pdf type and expected sizes.

Changes

Cohort / File(s)	Summary
Export utility function and add test coverage src/modules/pdf-forge/store/usePdfStore.ts, src/modules/pdf-forge/store/usePdfStore.test.ts	Exported toBlob function from usePdfStore.ts and added test suite validating conversion of Uint8Array to Blob with correct MIME type and size for both non-empty and empty input cases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hooray! A function steps to light,
From hidden helper to export bright,
Blobs dance from bytes with careful test,
Our PDF utilities are truly blessed! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding unit tests for the toBlob helper in usePdfStore. It is specific, concise, and directly reflects the primary purpose of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/usePdfStore-toBlob-4187336579000509184

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

src/modules/pdf-forge/store/usePdfStore.ts (1)

33-35: Using data.buffer can include unintended bytes when Uint8Array is a subarray view.

Uint8Array.buffer returns the entire underlying ArrayBuffer, which may be larger than the view if the Uint8Array was created with an offset or as a subarray. Pass data directly to the Blob constructor instead—it accepts TypedArray natively.

Proposed fix

 export function toBlob(data: Uint8Array): Blob {
-  return new Blob([data.buffer as ArrayBuffer], { type: 'application/pdf' });
+  return new Blob([data], { type: 'application/pdf' });
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/modules/pdf-forge/store/usePdfStore.ts` around lines 33 - 35, The toBlob
function uses data.buffer which can include extra bytes when the Uint8Array is a
subarray; change the Blob construction to pass the Uint8Array itself (the data
variable) instead of data.buffer so the Blob contains only the view's bytes and
keep the MIME type 'application/pdf'; update the implementation in the toBlob
function accordingly.

src/modules/pdf-forge/store/usePdfStore.test.ts (1)

55-73: LGTM — consider adding a subarray edge-case test.

The current tests cover basic conversion and empty input well. To guard against the data.buffer issue noted in the implementation, consider adding a test with a Uint8Array subarray view:

Optional additional test

it('should handle Uint8Array subarray views correctly', () => {
  const buffer = new ArrayBuffer(10);
  const fullView = new Uint8Array(buffer);
  fullView.set([0, 0, 1, 2, 3, 0, 0, 0, 0, 0]);
  const subarray = fullView.subarray(2, 5); // [1, 2, 3]

  const blob = toBlob(subarray);

  expect(blob.size).toBe(3); // Should be 3, not 10
  expect(blob.type).toBe('application/pdf');
});

This test would fail with the current implementation (which uses data.buffer) and pass once fixed to use data directly.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/modules/pdf-forge/store/usePdfStore.test.ts` around lines 55 - 73, The
test needs to cover the Uint8Array subarray edge case and the implementation of
toBlob must be updated to avoid using the whole data.buffer; modify tests to add
a case that passes a subarray view (as suggested) and update the toBlob
implementation (function toBlob) to construct the Blob from the actual
Uint8Array slice/bytes (use the Uint8Array itself or new Uint8Array(data.buffer,
data.byteOffset, data.byteLength)) so the Blob size equals data.byteLength
rather than the full ArrayBuffer length.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/modules/pdf-forge/store/usePdfStore.test.ts`:
- Around line 55-73: The test needs to cover the Uint8Array subarray edge case
and the implementation of toBlob must be updated to avoid using the whole
data.buffer; modify tests to add a case that passes a subarray view (as
suggested) and update the toBlob implementation (function toBlob) to construct
the Blob from the actual Uint8Array slice/bytes (use the Uint8Array itself or
new Uint8Array(data.buffer, data.byteOffset, data.byteLength)) so the Blob size
equals data.byteLength rather than the full ArrayBuffer length.

In `@src/modules/pdf-forge/store/usePdfStore.ts`:
- Around line 33-35: The toBlob function uses data.buffer which can include
extra bytes when the Uint8Array is a subarray; change the Blob construction to
pass the Uint8Array itself (the data variable) instead of data.buffer so the
Blob contains only the view's bytes and keep the MIME type 'application/pdf';
update the implementation in the toBlob function accordingly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d82ecda-f903-4995-a4dd-1c8866a9005f

📥 Commits

Reviewing files that changed from the base of the PR and between 8aebcab and d3e6f50.

📒 Files selected for processing (2)

• src/modules/pdf-forge/store/usePdfStore.test.ts
• src/modules/pdf-forge/store/usePdfStore.ts