⚡ perf: optimize PDF image processing with Promise.all#124
Conversation
Refactor the `from-image` PDF generation block in `usePdfStore.ts` to process arrayBuffer decoding and PDF image embedding concurrently using `Promise.all`. The pages are subsequently added sequentially to maintain the original file order. Measured Performance Improvement (Synthetic 50 Images with 10ms I/O latency): - Sequential: ~623.36ms - Parallel: ~57.48ms Resulting in an approximate 10.8x speedup for I/O bound processing while maintaining original progress bar reporting behavior. Co-authored-by: Cukurikik <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
💡 What:
Refactored the
from-imageblock insrc/modules/pdf-forge/store/usePdfStore.tsto process filearrayBuffer()decoding anddoc.embedJpg/doc.embedPngconcurrently viaPromise.all().🎯 Why:
The original implementation looped through the user-provided files array sequentially. Because reading the files and decoding the image bytes is heavily I/O bound, iterating sequentially drastically increased execution time. By parallelizing these operations and then inserting the loaded images synchronously via a sequential loop, we eliminate I/O blocking bottlenecks.
📊 Measured Improvement:
Using an isolated synthetic benchmark mimicking 50 image files with simulated 10ms read/decode latency:
~623.36ms~57.48msPR created automatically by Jules for task 4507277603377056526 started by @Cukurikik