Skip to content

Support enable date on non-PV node in alarm config #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shroffk merged 7 commits into from
Jun 9, 2026

Documentation update

c3496cc
Select commit
Loading
Failed to load commit list.
Merged

Support enable date on non-PV node in alarm config #3809

Documentation update
c3496cc
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 27, 2026 in 2m 44s

Quality Gate passed

Issues
38 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 21 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make delayTooltip2 a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2p&open=AZ5pWHlQoTWlItriCU2p&pullRequest=3809

Check warning on line 91 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change the visibility of this constructor to "protected". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHkgoTWlItriCU2i&open=AZ5pWHkgoTWlItriCU2i&pullRequest=3809

Check warning on line 20 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make delayTooltip1 a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2o&open=AZ5pWHlQoTWlItriCU2o&pullRequest=3809

Check warning on line 184 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/LeafConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHj7oTWlItriCU2g&open=AZ5pWHj7oTWlItriCU2g&pullRequest=3809

Check warning on line 86 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/ComponentActionHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof AlarmClientLeaf pv' 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHkqoTWlItriCU2l&open=AZ5pWHkqoTWlItriCU2l&pullRequest=3809

Check warning on line 35 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make promptTitle a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2x&open=AZ5pWHlQoTWlItriCU2x&pullRequest=3809

Check warning on line 31 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static headerConfirmDisableWithEnableDate" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU28&open=AZ5pWHlQoTWlItriCU28&pullRequest=3809

Check warning on line 32 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static headerConfirmEnable" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU29&open=AZ5pWHlQoTWlItriCU29&pullRequest=3809

Check warning on line 18 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static configure" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2z&open=AZ5pWHlQoTWlItriCU2z&pullRequest=3809

Check warning on line 19 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make delayTooltip0 a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2n&open=AZ5pWHlQoTWlItriCU2n&pullRequest=3809

Check warning on line 29 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make headerAlreadyEnabled a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2t&open=AZ5pWHlQoTWlItriCU2t&pullRequest=3809

Check warning on line 28 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static headerAlreadyDisabled" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU25&open=AZ5pWHlQoTWlItriCU25&pullRequest=3809

Check warning on line 36 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make promptContent a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2y&open=AZ5pWHlQoTWlItriCU2y&pullRequest=3809

Check warning on line 21 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static delayTooltip2" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU22&open=AZ5pWHlQoTWlItriCU22&pullRequest=3809

Check failure on line 35 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/ComponentActionHelper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHkqoTWlItriCU2k&open=AZ5pWHkqoTWlItriCU2k&pullRequest=3809

Check warning on line 18 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make configure a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2m&open=AZ5pWHlQoTWlItriCU2m&pullRequest=3809

Check warning on line 27 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make enableAlarms a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2r&open=AZ5pWHlQoTWlItriCU2r&pullRequest=3809

Check warning on line 36 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static promptContent" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2_&open=AZ5pWHlQoTWlItriCU2_&pullRequest=3809

Check failure on line 69 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"enabled" is the name of a field in "ConfigDialogController". 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHgyoTWlItriCU2a&open=AZ5pWHgyoTWlItriCU2a&pullRequest=3809

Check warning on line 23 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make disableAlarms a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2q&open=AZ5pWHlQoTWlItriCU2q&pullRequest=3809

Check warning on line 27 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static enableAlarms" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU24&open=AZ5pWHlQoTWlItriCU24&pullRequest=3809

Check warning on line 35 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static promptTitle" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU2-&open=AZ5pWHlQoTWlItriCU2-&pullRequest=3809

Check warning on line 94 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/config/ComponentConfigDialogController.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHgyoTWlItriCU2d&open=AZ5pWHgyoTWlItriCU2d&pullRequest=3809

Check warning on line 19 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static delayTooltip0" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU20&open=AZ5pWHlQoTWlItriCU20&pullRequest=3809

Check warning on line 23 in app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this "public static disableAlarms" field final 

See more on https://sonarcloud.io/project/issues?id=ControlSystemStudio_phoebus&issues=AZ5pWHlQoTWlItriCU23&open=AZ5pWHlQoTWlItriCU23&pullRequest=3809
View more details on SonarQubeCloud