Replace CallSite file+line with position

Author: sciapanCA

skills/codealive-context-engine/scripts/lib/api_client.py

@@ -628,10 +628,10 @@ def get_artifact_relationships(
             (identifier, filePath, startLine, shortSummary).
 
             Call items additionally carry ``callSites`` — where the call is
-            written (filePath, 1-based line, and a ``confidence`` only when the
-            position is approximate) — and ``callSiteCount``, the pre-cap total.
-            Their ABSENCE means the position is not indexed yet, never that the
-            call does not happen.
+            written (``position`` as ``path:line``, plus a ``confidence`` only
+            when the position is approximate) — and ``callSiteCount``, the
+            pre-cap total. Their ABSENCE means the position is not indexed yet,
+            never that the call does not happen.
         """
         profile_map = {
             "callsOnly": "calls_only",

skills/codealive-context-engine/scripts/relationships.py

@@ -159,15 +159,16 @@ def _format_call_sites(item: dict) -> list:
 
     lines = []
     for site in call_sites:
-        file_path = (site or {}).get("filePath")
-        line_number = (site or {}).get("line")
-        if not file_path or not line_number:
+        # The backend already spells a position as "path:line" — the form this line renders — so it is
+        # printed verbatim rather than reassembled from parts.
+        position = (site or {}).get("position")
+        if not position:
             continue
 
         # Confidence is shown only when the backend sent one; its absence means the position is exact.
         confidence = (site or {}).get("confidence")
         approximate = f"  (~{confidence:.0%} confident)" if confidence is not None else ""
-        lines.append(f"      ↪ called at {file_path}:{line_number}{approximate}")
+        lines.append(f"      ↪ called at {position}{approximate}")
 
     total = item.get("callSiteCount")
     if isinstance(total, int) and total > len(lines) > 0:

tests/test_relationship_call_sites.py

@@ -41,7 +41,7 @@ def _item(**overrides):
 def test_known_positions_are_rendered_as_call_sites() -> None:
     # Arrange
     item = _item(
-        callSites=[{"filePath": "src/svc.py", "line": 17}],
+        callSites=[{"position": "src/svc.py:17"}],
         callSiteCount=1,
     )
 
@@ -56,8 +56,8 @@ def test_confidence_is_shown_only_when_the_position_is_approximate() -> None:
     # Arrange
     item = _item(
         callSites=[
-            {"filePath": "src/svc.py", "line": 17},
-            {"filePath": "src/svc.py", "line": 88, "confidence": 0.6},
+            {"position": "src/svc.py:17"},
+            {"position": "src/svc.py:88", "confidence": 0.6},
         ],
         callSiteCount=2,
     )
@@ -73,7 +73,7 @@ def test_confidence_is_shown_only_when_the_position_is_approximate() -> None:
 def test_a_capped_list_says_how_many_were_withheld() -> None:
     # Arrange
     item = _item(
-        callSites=[{"filePath": "src/svc.py", "line": 17}],
+        callSites=[{"position": "src/svc.py:17"}],
         callSiteCount=4,
     )
 
@@ -98,3 +98,20 @@ def test_an_unindexed_position_renders_nothing_at_all() -> None:
     # Assert
     assert from_missing == []
     assert from_empty == []
+
+
+def test_a_site_without_a_position_is_skipped_rather_than_rendered_blank() -> None:
+    # Defensive: a malformed site from an older or partially rolled-back backend must not produce a
+    # "called at" line pointing nowhere, which an agent would try to read.
+    # Arrange
+    item = _item(
+        # The count is the pre-cap total of KNOWN positions, so a malformed entry does not raise it.
+        callSites=[{"confidence": 0.6}, {"position": "src/svc.py:17"}],
+        callSiteCount=1,
+    )
+
+    # Act
+    lines = relationships._format_call_sites(item)
+
+    # Assert
+    assert lines == ["      ↪ called at src/svc.py:17"]