delivery_router: redundant reliable-wake notify (channel full) logs at WARN, flooding healthy-engine logs

[loning]

Evidence

On a healthy trureturing host engine (substrate a8029a9, platform 8e82f4bc, uptime ~40min, deliveries flowing, DLQ drained), the supervise log accumulated 233×:

LEVEL=WARN dept=github-devloop-intake.admission error=no available capacity MSG=reliable wake notify failed

Analysis

crates/fkst-framework/src/supervise/delivery_router.rs:271 — notify_reliable does wake.try_send(()) on the bounded wake channel and logs every failure at WARN. When the channel is full the consumer already has a pending wake: the notify is redundant coalescing, the wake will happen anyway, and nothing is lost. Under event bursts (intake admission fan-in) this floods the log and poisons downstream monitor signals (our health snapshot counts warn/error lines; 620 of the instance's lines were dominated by this one benign path — a bad-raw-material generator for every log-reading harness).

Suggested fix

Distinguish TrySendError::Full (wake already pending → debug/trace, or drop silently) from TrySendError::Closed / registry errors (real faults → keep WARN). One-line match on the error variant.

Environment

• host: trureturing legacy-layout engine, macOS
• substrate: a8029a9 (dev), platform: 8e82f4bc8bcc

[loning]

github-devloop intake decision: enable
Service class: standard

Reason:
Established bounded-channel practice treats TrySendError::Full as successful wake coalescing, so this actionable implementation request should narrow WARN logging; the digest shows no two sibling issues requiring recurrence escalation. ⟦AI:FKST⟧

[loning]

github-devloop thinking: consensus started

[loning]

github-devloop decision: approve
Verdicts: teleology=approve parsimony=approve fidelity=approve natural-ownership=approve proportional-containment=approve

teleology:
The issue is sound, bounded, actionable, and code-verifiable: split TrySendError::Full from TrySendError::Closed, suppress or demote only the already-pending wake case, and preserve warnings for genuine receiver or registry faults. PR review should require variant-specific logging tests so the severity contract cannot regress; this is advisory, not a blocker.

parsimony:
The proposal is sound, bounded, and code-verifiable: match TrySendError::Full as benign coalescence and preserve WARN for TrySendError::Closed. During implementation, prefer silent handling over DEBUG unless that signal has demonstrated diagnostic value, and add a focused variant-level test; making the wake channel explicitly one-slot would further clarify its coalescing purpose but is advisory rather than required scope. ⟦AI:FKST⟧

fidelity:
The issue identifies a real, bounded, source-verifiable observability defect: notify_reliable currently warns on every try_send failure even though a full unit-wake channel already contains a sufficient wake and durable dispatch has a periodic fallback. Development should preserve WARN for Closed and registry failures and include variant-specific tests; treating Full as silent or trace-level is faithful to the underlying truth.

natural-ownership:
The invariant belongs in DeliveryRouter::notify_reliable, where the engine can distinguish TrySendError::Full from TrySendError::Closed; the proposal is bounded, consistent with established coalescing-notification practice, and code-verifiable. Development should preserve WARN for Closed and add log-capture tests for both variants so the fix cannot silently suppress genuine receiver loss.

proportional-containment:
This is a sound, actionable, and proportionally contained correction at the notification owner layer. Full means at least one wake is already pending, while the durable store remains authoritative; Closed remains a genuine fault. The supplied recurrence history does not establish a third same-class instance requiring a broader logging abstraction. During PR review, require focused coverage for both variants and prefer silent or trace-level handling of Full without changing channel capacity or introducing global policy.

⟦AI:FKST⟧

[loning]

github-devloop dependency hold: unresolvable

Reason: gh-failed

[loning]

github-devloop dependency gate blocked

Reason:
gh-failed

[fkst-loning-s-macbook-m5]

github-devloop thinking: consensus started