Skip to content

Bug: low/normal trigger command environments are built from trigger_cmd_high #760

@somethingwithproof

Description

@somethingwithproof

Summary

In thold_command_execution(), the environment for trigger_cmd_low and trigger_cmd_norm branches is built using trigger_cmd_high.

Impact

  • Variable extraction/context can be inconsistent with the command actually executed.
  • Low and normal-restoral command paths may receive incorrect environment substitutions.

Location

  • thold_functions.php, function thold_command_execution()
    • breach-down path uses thold_set_environ($thold_data['trigger_cmd_high'], ...)
    • breach-normal path uses thold_set_environ($thold_data['trigger_cmd_high'], ...)

Expected

  • breach-up uses trigger_cmd_high
  • breach-down uses trigger_cmd_low
  • breach-normal uses trigger_cmd_norm

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions