From d69b778c874a2e265a50dac60abf0eaa116a7de2 Mon Sep 17 00:00:00 2001 From: Jonathan Colon Date: Mon, 27 Jul 2026 13:58:30 -0400 Subject: [PATCH 1/3] Fix Cannot process argument transformation on parameter 'Domain'. Cannot convert value to type System.String. Fixes #264 --- .github/workflows/Release.yml | 36 ++++++------------- .../AsBuiltReport.Microsoft.AD.psd1 | 4 +-- .../Invoke-AsBuiltReport.Microsoft.AD.ps1 | 6 ++-- CHANGELOG.md | 12 +++++++ 4 files changed, 28 insertions(+), 30 deletions(-) diff --git a/.github/workflows/Release.yml b/.github/workflows/Release.yml index 3f46982..b1143bd 100644 --- a/.github/workflows/Release.yml +++ b/.github/workflows/Release.yml @@ -33,29 +33,13 @@ jobs: shell: pwsh run: | Publish-Module -Path ./AsBuiltReport.Microsoft.AD -NuGetApiKey ${{ secrets.PSGALLERY_API_KEY }} -Verbose - # tweet: - # needs: publish-to-gallery - # runs-on: ubuntu-latest - # steps: - # - uses: Eomm/why-don-t-you-tweet@v2 - # # We don't want to tweet if the repository is not a public one - # if: ${{ !github.event.repository.private }} - # with: - # # GitHub event payload - # # https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#release - # tweet-message: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #Microsoft #ActiveDirectory #AsBuiltReport #PowerShell #MicrosoftMVP #MVPBuzz #cybersecurity #infosec" - # env: - # TWITTER_CONSUMER_API_KEY: ${{ secrets.TWITTER_CONSUMER_API_KEY }} - # TWITTER_CONSUMER_API_SECRET: ${{ secrets.TWITTER_CONSUMER_API_SECRET }} - # TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }} - # TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }} - # bsky-post: - # needs: publish-to-gallery - # runs-on: ubuntu-latest - # steps: - # - uses: zentered/bluesky-post-action@v0.4.0 - # with: - # post: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #Microsoft #ActiveDirectory #AsBuiltReport #PowerShell #MicrosoftMVP #MVPBuzz #cybersecurity #infosec" - # env: - # BSKY_IDENTIFIER: ${{ secrets.BSKY_IDENTIFIER }} - # BSKY_PASSWORD: ${{ secrets.BSKY_PASSWORD }} + bsky-post: + needs: publish-to-gallery + runs-on: ubuntu-latest + steps: + - uses: zentered/bluesky-post-action@v0.4.0 + with: + post: "[New Release] ${{ github.event.repository.name }} ${{ github.event.release.tag_name }}! Check out what's new! ${{ github.event.release.html_url }} #Microsoft #ActiveDirectory #AsBuiltReport #PowerShell #MicrosoftMVP #MVPBuzz #cybersecurity #infosec" + env: + BSKY_IDENTIFIER: ${{ secrets.BSKY_IDENTIFIER }} + BSKY_PASSWORD: ${{ secrets.BSKY_PASSWORD }} diff --git a/AsBuiltReport.Microsoft.AD/AsBuiltReport.Microsoft.AD.psd1 b/AsBuiltReport.Microsoft.AD/AsBuiltReport.Microsoft.AD.psd1 index 1716b19..042bd00 100644 --- a/AsBuiltReport.Microsoft.AD/AsBuiltReport.Microsoft.AD.psd1 +++ b/AsBuiltReport.Microsoft.AD/AsBuiltReport.Microsoft.AD.psd1 @@ -12,7 +12,7 @@ RootModule = 'AsBuiltReport.Microsoft.AD.psm1' # Version number of this module. - ModuleVersion = '1.0.1' + ModuleVersion = '1.0.2' # Supported PSEditions CompatiblePSEditions = @('Core') @@ -58,7 +58,7 @@ }, @{ ModuleName = 'AsBuiltReport.Chart'; - ModuleVersion = '0.3.3' + ModuleVersion = '0.3.4' }, @{ ModuleName = 'AsBuiltReport.Diagram'; diff --git a/AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 b/AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 index 3a7ce20..f8095df 100644 --- a/AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 +++ b/AsBuiltReport.Microsoft.AD/Src/Public/Invoke-AsBuiltReport.Microsoft.AD.ps1 @@ -5,7 +5,7 @@ function Invoke-AsBuiltReport.Microsoft.AD { .DESCRIPTION Documents the configuration of Microsoft AD in Word/HTML/Text formats using PScribo. .NOTES - Version: 1.0.1 + Version: 1.0.2 Author: Jonathan Colon Twitter: @jcolonfzenpr Github: rebelinux @@ -172,7 +172,9 @@ function Invoke-AsBuiltReport.Microsoft.AD { Write-Host ($reportTranslate.InvokeAsBuiltReportMicrosoftAD.GettingForestInfo -f $RootDomains) if ($ChildDomains) { - $OrderedDomains.Add($ChildDomains) + foreach ($ChildDomain in $ChildDomains) { + $OrderedDomains.Add($ChildDomain) + } Write-Host (" $($reportTranslate.InvokeAsBuiltReportMicrosoftAD.DiscoveringChildDomains)" -f $RootDomains, ($OrderedDomains -join ', ')) } diff --git a/CHANGELOG.md b/CHANGELOG.md index e31e52b..e3e6128 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ##### This project is community maintained and has no sponsorship from Microsoft, its employees or any of its affiliates. +## [1.0.2] - Unreleased + +### Changed + +- Bump module version to `1.0.2` +- Upgrade AsBuiltReport.Chart module to version `0.3.4` + +### Fixed + +- Fix [#264](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/264) +- Fix [#260](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/260) + ## [1.0.1] - 2026-06-22 ### Added From 2f29a5e8bdb35e7015b205994f3a33e58590a53d Mon Sep 17 00:00:00 2001 From: Jonathan Colon Date: Mon, 27 Jul 2026 20:32:47 -0400 Subject: [PATCH 2/3] Fix cmdlet ConvertTo-TextYN to correctly translate boolean values to "Yes" or "No" in the report output, ensuring accurate representation of true/false states in the generated documentation. --- AsBuiltReport.Microsoft.AD/Language/en-US/MicrosoftAD.psd1 | 1 + CHANGELOG.md | 2 ++ 2 files changed, 3 insertions(+) diff --git a/AsBuiltReport.Microsoft.AD/Language/en-US/MicrosoftAD.psd1 b/AsBuiltReport.Microsoft.AD/Language/en-US/MicrosoftAD.psd1 index 76408e9..97cef21 100644 --- a/AsBuiltReport.Microsoft.AD/Language/en-US/MicrosoftAD.psd1 +++ b/AsBuiltReport.Microsoft.AD/Language/en-US/MicrosoftAD.psd1 @@ -43,6 +43,7 @@ Domains = Domains NoData = No data returned (Get-ADForest returned $null) RunAsAdministrator = Please run the report with Run As Administrator priviledges. +'@ # InvokeAsBuiltReportMicrosoftAD ConvertToTextYN = ConvertFrom-StringData @' diff --git a/CHANGELOG.md b/CHANGELOG.md index e3e6128..0e03ac5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix [#264](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/264) - Fix [#260](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/260) +- Fix critical issue preventing report execution. +- Fix cmdlet ConvertTo-TextYN to correctly translate boolean values to "Yes" or "No" in the report output, ensuring accurate representation of true/false states in the generated documentation. ## [1.0.1] - 2026-06-22 From eadf592b64f1d15cc3fe7f5c49cca111e2cfdd3d Mon Sep 17 00:00:00 2001 From: Jonathan Colon Date: Mon, 27 Jul 2026 20:45:46 -0400 Subject: [PATCH 3/3] update date --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0e03ac5..a164a2a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ##### This project is community maintained and has no sponsorship from Microsoft, its employees or any of its affiliates. -## [1.0.2] - Unreleased +## [1.0.2] - 2026-07-27 ### Changed @@ -19,7 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix [#264](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/264) - Fix [#260](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/260) - Fix critical issue preventing report execution. -- Fix cmdlet ConvertTo-TextYN to correctly translate boolean values to "Yes" or "No" in the report output, ensuring accurate representation of true/false states in the generated documentation. +- Fix cmdlet ConvertTo-TextYN to correctly translate boolean values to "Yes" or "No" in the report output ## [1.0.1] - 2026-06-22