Skip to content

Commit 5385d7e

Browse files
The cross-repo gate could never fail the job
`... | tee report.txt` ran under the default shell, which is `bash -e` with no pipefail, so the step reported tee's exit code. steps.audit.outcome was success whatever the audit found, the "Fail the job" step never fired, and the scheduled drift issue could never open. Proof rather than reasoning: run 30208588762 printed six vocabulary errors and concluded success. That run is also what surfaced the bug, because it is the first time this checker had anything to report. `shell: bash` runs with -eo pipefail, which is the whole fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent faa9a00 commit 5385d7e

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎.github/workflows/cross-repo-consistency.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ jobs:
3333

3434
- name: Run cross-repo audit
3535
id: audit
36+
# `shell: bash` is load-bearing: it runs with -o pipefail. The default
37+
# shell does not, so `... | tee report.txt` reported tee's exit code and
38+
# the audit could never fail the job. Run 30208588762 is the proof: six
39+
# vocabulary errors, conclusion success.
40+
shell: bash
3641
run: |
3742
python3 scripts/arithmon-consistency-check.py \
3843
--json findings.json | tee report.txt

0 commit comments

Comments
 (0)