Skip to content

Commit 19a802f

Browse files
committed
remove redundant codes from writing_analysis.py
1 parent ca13755 commit 19a802f

1 file changed

Lines changed: 3 additions & 17 deletions

File tree

‎modules/writing_observer/writing_observer/writing_analysis.py‎

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -191,19 +191,6 @@ async def reconstruct(event, internal_state):
191191
Google's deltas into a document. It also adds a bit of metadata e.g. for
192192
Deane plots.
193193
'''
194-
def _extract_tab_id(client, root_event):
195-
tab_id = client.get("tab_id") or root_event.get("tab_id")
196-
if tab_id:
197-
return tab_id
198-
url = (
199-
client.get("url")
200-
or client.get("object", {}).get("url")
201-
or root_event.get("url", "")
202-
)
203-
if not url:
204-
return None
205-
return gdoc_reconstruct_doc.parse_tab_from_url(url)
206-
207194
def _extract_tab_title(client):
208195
mouseclick = client.get("mouseclick", {})
209196
class_name = mouseclick.get("target.className", "") or ""
@@ -215,7 +202,7 @@ def _extract_tab_title(client):
215202

216203
client = event.get("client", {}) or {}
217204
event_type = client.get("event") or event.get("event")
218-
tab_id = _extract_tab_id(client, event)
205+
tab_id = client.get("tab_id") or event.get("tab_id")
219206
tab_title = _extract_tab_title(client)
220207

221208
# If it's not a relevant event and we have no tab metadata to update, ignore it
@@ -246,7 +233,7 @@ def _extract_tab_title(client):
246233
or client.get("object", {}).get("url")
247234
or event.get("url", "")
248235
)
249-
default_tab = tab_id or gdoc_reconstruct_doc.parse_tab_from_url(url)
236+
default_tab = tab_id or "t.0"
250237

251238
ts = event.get("client", {}).get("timestamp")
252239
if ts is None:
@@ -298,7 +285,6 @@ def _extract_tab_title(client):
298285
tabs.append({
299286
"tab_id": tab_id,
300287
"title": tab.name or tab_id,
301-
"last_accessed": tab.last_timestamp or tab.first_timestamp,
302288
"text": gdoc_reconstruct_doc.render_tab_text(tab),
303289
})
304290

@@ -544,4 +530,4 @@ def document_link_to_doc_id(event):
544530
event['doc_id'] = doc_id
545531
return event
546532

547-
learning_observer.adapters.adapter.add_common_migrator(document_link_to_doc_id, __file__)
533+
learning_observer.adapters.adapter.add_common_migrator(document_link_to_doc_id, __file__)

0 commit comments

Comments
 (0)